)]}'
{"doc/source/rest.rst":[{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"43832dba02bc1b5618bb33c9069b15948104f791","unresolved":false,"context_lines":[{"line_number":89,"context_line":"      [\"2014-10-06T14:34:00\", 60.0, 7]"},{"line_number":90,"context_line":"    ]"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"The list of points returned is composed of tuples with (timestamp, offset,"},{"line_number":93,"context_line":"value) sorted by timestamp. The offset is the timespan covered by aggregation"},{"line_number":94,"context_line":"for this point."},{"line_number":95,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a890539_2b27a313","line":92,"updated":"2014-11-13 13:42:24.000000000","message":"Would it be clearer to call this \"granularity\" instead of \"offset\", given that this is the terminology used for the equivalent concept in the archive policy?","commit_id":"6e92c3ac5412358f9cd90d620ce4f16d1f183283"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"ca40737830261a6fe5dd998c5cceece14901e25d","unresolved":false,"context_lines":[{"line_number":89,"context_line":"      [\"2014-10-06T14:34:00\", 60.0, 7]"},{"line_number":90,"context_line":"    ]"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"The list of points returned is composed of tuples with (timestamp, offset,"},{"line_number":93,"context_line":"value) sorted by timestamp. The offset is the timespan covered by aggregation"},{"line_number":94,"context_line":"for this point."},{"line_number":95,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a890539_06bbbe72","line":92,"in_reply_to":"5a890539_2b27a313","updated":"2014-11-13 14:07:36.000000000","message":"Good idea.","commit_id":"6e92c3ac5412358f9cd90d620ce4f16d1f183283"}],"gnocchi/carbonara.py":[{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"43832dba02bc1b5618bb33c9069b15948104f791","unresolved":false,"context_lines":[{"line_number":274,"context_line":"        result \u003d []"},{"line_number":275,"context_line":"        for ts in self.agg_timeseries:"},{"line_number":276,"context_line":"            if result:"},{"line_number":277,"context_line":"                # Change to_timestamp not to override more precised points we"},{"line_number":278,"context_line":"                # already have"},{"line_number":279,"context_line":"                to_timestamp \u003d result[0][0]"},{"line_number":280,"context_line":"            offset \u003d ts.sampling.nanos / 1000000000.0"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_eb591bff","line":277,"updated":"2014-11-13 13:42:24.000000000","message":"Non-blocking nitpick:\n\n  s/precised/precise/","commit_id":"6e92c3ac5412358f9cd90d620ce4f16d1f183283"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"ca40737830261a6fe5dd998c5cceece14901e25d","unresolved":false,"context_lines":[{"line_number":274,"context_line":"        result \u003d []"},{"line_number":275,"context_line":"        for ts in self.agg_timeseries:"},{"line_number":276,"context_line":"            if result:"},{"line_number":277,"context_line":"                # Change to_timestamp not to override more precised points we"},{"line_number":278,"context_line":"                # already have"},{"line_number":279,"context_line":"                to_timestamp \u003d result[0][0]"},{"line_number":280,"context_line":"            offset \u003d ts.sampling.nanos / 1000000000.0"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_a64bca85","line":277,"in_reply_to":"5a890539_eb591bff","updated":"2014-11-13 14:07:36.000000000","message":"Done","commit_id":"6e92c3ac5412358f9cd90d620ce4f16d1f183283"}],"gnocchi/tests/test_carbonara.py":[{"author":{"_account_id":10683,"name":"Ana Malagon","email":"atmalagon@gmail.com","username":"atmalagon"},"change_message_id":"67f071a958862183ed9cd94c796034012f15cb50","unresolved":false,"context_lines":[{"line_number":204,"context_line":"            (pandas.Timestamp(\u00272014-01-01 12:05:00\u0027), 60.0, 8.0),"},{"line_number":205,"context_line":"            (pandas.Timestamp(\u00272014-01-01 12:06:00\u0027), 60.0, 3.0),"},{"line_number":206,"context_line":"        ], tsc.fetch())"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"        self.assertEqual(["},{"line_number":209,"context_line":"            (pandas.Timestamp(\u00272014-01-01 12:00:00\u0027),"},{"line_number":210,"context_line":"             300.0, 6.166666666666667),"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_accdd688","line":207,"updated":"2014-11-09 20:00:14.000000000","message":"Why isn\u0027t any data returned with 300 second granularity at 11:55, 12:00, and 12:05?\n\nWhy isn\u0027t there any 0 sec granularity data anymore?","commit_id":"8c1c0f8f74975d147c5a9927371f55419ffb39a4"},{"author":{"_account_id":10683,"name":"Ana Malagon","email":"atmalagon@gmail.com","username":"atmalagon"},"change_message_id":"7f6c8a36e7e22cca4412e53b6bc7a3f124c4f583","unresolved":false,"context_lines":[{"line_number":204,"context_line":"            (pandas.Timestamp(\u00272014-01-01 12:05:00\u0027), 60.0, 8.0),"},{"line_number":205,"context_line":"            (pandas.Timestamp(\u00272014-01-01 12:06:00\u0027), 60.0, 3.0),"},{"line_number":206,"context_line":"        ], tsc.fetch())"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"        self.assertEqual(["},{"line_number":209,"context_line":"            (pandas.Timestamp(\u00272014-01-01 12:00:00\u0027),"},{"line_number":210,"context_line":"             300.0, 6.166666666666667),"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_cf73f4e5","line":207,"in_reply_to":"5a890539_2c8f2625","updated":"2014-11-10 08:36:11.000000000","message":"I\u0027m not sure...maybe? In general it\u0027s probably not worth it to keep coarse data once finer resolution data becomes available, but if it is kept that makes things easier for the current implementation of the custom aggregation. Also, keeping the 0sec data would make the custom aggregation more accurate...these are reasons more for changing the custom aggregate implementation than for keeping additional data around but, if nothing would break by keeping the 0sec data and all 300sec values, would it be possible to return them as well?","commit_id":"8c1c0f8f74975d147c5a9927371f55419ffb39a4"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"3874ff6cfb6ed786a03164f697116eb9eb1cc4f9","unresolved":false,"context_lines":[{"line_number":204,"context_line":"            (pandas.Timestamp(\u00272014-01-01 12:05:00\u0027), 60.0, 8.0),"},{"line_number":205,"context_line":"            (pandas.Timestamp(\u00272014-01-01 12:06:00\u0027), 60.0, 3.0),"},{"line_number":206,"context_line":"        ], tsc.fetch())"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"        self.assertEqual(["},{"line_number":209,"context_line":"            (pandas.Timestamp(\u00272014-01-01 12:00:00\u0027),"},{"line_number":210,"context_line":"             300.0, 6.166666666666667),"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_2c8f2625","line":207,"in_reply_to":"5a890539_accdd688","updated":"2014-11-09 20:28:03.000000000","message":"Good question. I changed that since I talked to you, because the 0 sec data granularity does not work correctly AFAIU with aggregation method like standard deviation. Since there\u0027s no aggregation the data for a 0 sec agg make no sense. So I changed that.\n\nHowever I could easily add points for 300 sec granularity for 11:55 12:00 and 12:05, do you think it\u0027d be worth it?","commit_id":"8c1c0f8f74975d147c5a9927371f55419ffb39a4"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"cea33f7a14c5630ff1a1484fb98b705bb3232883","unresolved":false,"context_lines":[{"line_number":204,"context_line":"            (pandas.Timestamp(\u00272014-01-01 12:05:00\u0027), 60.0, 8.0),"},{"line_number":205,"context_line":"            (pandas.Timestamp(\u00272014-01-01 12:06:00\u0027), 60.0, 3.0),"},{"line_number":206,"context_line":"        ], tsc.fetch())"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"        self.assertEqual(["},{"line_number":209,"context_line":"            (pandas.Timestamp(\u00272014-01-01 12:00:00\u0027),"},{"line_number":210,"context_line":"             300.0, 6.166666666666667),"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_5b526614","line":207,"in_reply_to":"5a890539_cf73f4e5","updated":"2014-11-10 09:56:24.000000000","message":"Sure, I can do that. I\u0027ll add a flag to the fetch() function so that it returns everything.","commit_id":"8c1c0f8f74975d147c5a9927371f55419ffb39a4"}],"gnocchi/tests/test_rest.py":[{"author":{"_account_id":10683,"name":"Ana Malagon","email":"atmalagon@gmail.com","username":"atmalagon"},"change_message_id":"67f071a958862183ed9cd94c796034012f15cb50","unresolved":false,"context_lines":[{"line_number":485,"context_line":"             [u\u00272013-01-01T12:00:00.000000\u0027, 60.0, 845.1],"},{"line_number":486,"context_line":"             [u\u00272013-01-01T12:00:00.000000\u0027, 1.0, 1234.2]],"},{"line_number":487,"context_line":"            result)"},{"line_number":488,"context_line":""},{"line_number":489,"context_line":"    def test_get_measure_aggregation(self):"},{"line_number":490,"context_line":"        result \u003d self.app.post_json(\"/v1/entity\","},{"line_number":491,"context_line":"                                    params\u003d{\"archive_policy\": \"medium\"})"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_6c268e6a","line":488,"updated":"2014-11-09 20:00:14.000000000","message":"Huh, so even if you specify \u0027stop\u0027, the returned data will still include values from after the stop point if the sampling is too coarse - I hadn\u0027t understood this before. Might be good to add a note in the documentation otherwise people might misinterpret the returned data?","commit_id":"8c1c0f8f74975d147c5a9927371f55419ffb39a4"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"cea33f7a14c5630ff1a1484fb98b705bb3232883","unresolved":false,"context_lines":[{"line_number":485,"context_line":"             [u\u00272013-01-01T12:00:00.000000\u0027, 60.0, 845.1],"},{"line_number":486,"context_line":"             [u\u00272013-01-01T12:00:00.000000\u0027, 1.0, 1234.2]],"},{"line_number":487,"context_line":"            result)"},{"line_number":488,"context_line":""},{"line_number":489,"context_line":"    def test_get_measure_aggregation(self):"},{"line_number":490,"context_line":"        result \u003d self.app.post_json(\"/v1/entity\","},{"line_number":491,"context_line":"                                    params\u003d{\"archive_policy\": \"medium\"})"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_5b798692","line":488,"in_reply_to":"5a890539_4a2612bc","updated":"2014-11-10 09:56:24.000000000","message":"Ok, I\u0027ll fix that in a following patch.","commit_id":"8c1c0f8f74975d147c5a9927371f55419ffb39a4"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"3874ff6cfb6ed786a03164f697116eb9eb1cc4f9","unresolved":false,"context_lines":[{"line_number":485,"context_line":"             [u\u00272013-01-01T12:00:00.000000\u0027, 60.0, 845.1],"},{"line_number":486,"context_line":"             [u\u00272013-01-01T12:00:00.000000\u0027, 1.0, 1234.2]],"},{"line_number":487,"context_line":"            result)"},{"line_number":488,"context_line":""},{"line_number":489,"context_line":"    def test_get_measure_aggregation(self):"},{"line_number":490,"context_line":"        result \u003d self.app.post_json(\"/v1/entity\","},{"line_number":491,"context_line":"                                    params\u003d{\"archive_policy\": \"medium\"})"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_6c992e6e","line":488,"in_reply_to":"5a890539_6c268e6a","updated":"2014-11-09 20:28:03.000000000","message":"That or maybe we should change that behaviour?","commit_id":"8c1c0f8f74975d147c5a9927371f55419ffb39a4"},{"author":{"_account_id":10683,"name":"Ana Malagon","email":"atmalagon@gmail.com","username":"atmalagon"},"change_message_id":"7f6c8a36e7e22cca4412e53b6bc7a3f124c4f583","unresolved":false,"context_lines":[{"line_number":485,"context_line":"             [u\u00272013-01-01T12:00:00.000000\u0027, 60.0, 845.1],"},{"line_number":486,"context_line":"             [u\u00272013-01-01T12:00:00.000000\u0027, 1.0, 1234.2]],"},{"line_number":487,"context_line":"            result)"},{"line_number":488,"context_line":""},{"line_number":489,"context_line":"    def test_get_measure_aggregation(self):"},{"line_number":490,"context_line":"        result \u003d self.app.post_json(\"/v1/entity\","},{"line_number":491,"context_line":"                                    params\u003d{\"archive_policy\": \"medium\"})"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_4a2612bc","line":488,"in_reply_to":"5a890539_6c992e6e","updated":"2014-11-10 08:36:11.000000000","message":"yeah, I would be in favor of changing the behavior, I guess. The only thing that could be modified would be no longer returning aggregated values if their index timestamp plus their granularity size ended up being past the stop point?","commit_id":"8c1c0f8f74975d147c5a9927371f55419ffb39a4"}]}