)]}'
{"doc/source/rest.j2":[{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"7f4f07aa742a1fdfb6bbdb20d64dc0466a3ff6b8","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"{{ scenarios[\u0027get-metric-details-in-accept\u0027][\u0027doc\u0027] }}"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"To retrieve the list of all the metric created, use the following request:"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"{{ scenarios[\u0027list-metric\u0027][\u0027doc\u0027] }}"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"3a961159_0ab685dc","line":40,"updated":"2014-12-17 19:51:52.000000000","message":"Nitpick:\n\n  s/all the metric/all the metrics/","commit_id":"9afcdc05c74a63ab097ccb9fe59769964fdbc962"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"52009fee5d1b998267532b0922e9553c2e84c740","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"{{ scenarios[\u0027get-metric-details-in-accept\u0027][\u0027doc\u0027] }}"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"To retrieve the list of all the metric created, use the following request:"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"{{ scenarios[\u0027list-metric\u0027][\u0027doc\u0027] }}"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"3a961159_c8ee308b","line":40,"in_reply_to":"3a961159_0ab685dc","updated":"2014-12-18 10:53:44.000000000","message":"Done","commit_id":"9afcdc05c74a63ab097ccb9fe59769964fdbc962"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"7f4f07aa742a1fdfb6bbdb20d64dc0466a3ff6b8","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"{{ scenarios[\u0027list-metric\u0027][\u0027doc\u0027] }}"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"It is possible to send metrics to the metric:"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"{{ scenarios[\u0027post-measures\u0027][\u0027doc\u0027] }}"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"3a961159_8ac9955c","line":44,"updated":"2014-12-17 19:51:52.000000000","message":"Not related to the current patch, but this caught my eye .. perhaps less circular as:\n\n  s/send metrics to the metric/send measures to the metric/\n\nor:\n\n  s/send metrics to the metric/send datapoints to the metric/","commit_id":"9afcdc05c74a63ab097ccb9fe59769964fdbc962"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"52009fee5d1b998267532b0922e9553c2e84c740","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"{{ scenarios[\u0027list-metric\u0027][\u0027doc\u0027] }}"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"It is possible to send metrics to the metric:"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"{{ scenarios[\u0027post-measures\u0027][\u0027doc\u0027] }}"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"3a961159_28ec148f","line":44,"in_reply_to":"3a961159_8ac9955c","updated":"2014-12-18 10:53:44.000000000","message":"Done","commit_id":"9afcdc05c74a63ab097ccb9fe59769964fdbc962"}],"gnocchi/rest/__init__.py":[{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"7f4f07aa742a1fdfb6bbdb20d64dc0466a3ff6b8","unresolved":false,"context_lines":[{"line_number":442,"context_line":"                \"archive_policy\": str(body[\u0027archive_policy\u0027])}"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"    @pecan.expose(\u0027json\u0027)"},{"line_number":445,"context_line":"    def get_all(self):"},{"line_number":446,"context_line":"        attrfilter \u003d {}"},{"line_number":447,"context_line":"        try:"},{"line_number":448,"context_line":"            enforce(\"list all metric\", {})"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_4a0c0d95","line":445,"updated":"2014-12-17 19:51:52.000000000","message":"For an admin user, is this going to list all the metrics ever created?\n\nWould it make more sense to allow MetricsController.get_all be constrained by kwargs in the style of the GenericResourcesController.get_all, recognize some standard time-constraints, and include the remaining kwargs in the attributes_filter passed into indexer.list_resources?","commit_id":"9afcdc05c74a63ab097ccb9fe59769964fdbc962"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"52009fee5d1b998267532b0922e9553c2e84c740","unresolved":false,"context_lines":[{"line_number":442,"context_line":"                \"archive_policy\": str(body[\u0027archive_policy\u0027])}"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"    @pecan.expose(\u0027json\u0027)"},{"line_number":445,"context_line":"    def get_all(self):"},{"line_number":446,"context_line":"        attrfilter \u003d {}"},{"line_number":447,"context_line":"        try:"},{"line_number":448,"context_line":"            enforce(\"list all metric\", {})"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_c89550e5","line":445,"in_reply_to":"3a961159_4a0c0d95","updated":"2014-12-18 10:53:44.000000000","message":"Yes an admin will see every metric.\n\nAgreed with the kwargs suggestion. I\u0027ll add that in a later patch. :)","commit_id":"9afcdc05c74a63ab097ccb9fe59769964fdbc962"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"9d77dd8800f453c15446004ed75592ede076ad60","unresolved":false,"context_lines":[{"line_number":442,"context_line":"                \"archive_policy\": str(body[\u0027archive_policy\u0027])}"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"    @pecan.expose(\u0027json\u0027)"},{"line_number":445,"context_line":"    def get_all(self):"},{"line_number":446,"context_line":"        attrfilter \u003d {}"},{"line_number":447,"context_line":"        try:"},{"line_number":448,"context_line":"            enforce(\"list all metric\", {})"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_8391699c","line":445,"in_reply_to":"3a961159_c89550e5","updated":"2014-12-18 11:07:04.000000000","message":"Cool, thanks!","commit_id":"9afcdc05c74a63ab097ccb9fe59769964fdbc962"}]}