)]}'
{"gnocchi/archive_policy.py":[{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"715d1ea63a4163434027678b223df7838aed0848","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    #               methods, where there is no longer just a single aggregate"},{"line_number":28,"context_line":"    #               value to be stored per-period (e.g. ohlc)"},{"line_number":29,"context_line":"    VALID_AGGREGATION_METHODS \u003d set((\u0027mean\u0027, \u0027sum\u0027, \u0027last\u0027, \u0027max\u0027, \u0027min\u0027,"},{"line_number":30,"context_line":"                                     \u0027std\u0027, \u0027median\u0027, \u0027first\u0027))"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def __init__(self, name, back_window, definition,"},{"line_number":33,"context_line":"                 aggregation_methods\u003dset((\"*\",))):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_a6902143","line":30,"updated":"2015-01-14 13:32:39.000000000","message":"Unrelated to the current patch, but should we also include \u0027count\u0027 in the list of valid aggregation methods?\n\n... assuning timeseries.resample(..., how\u003d\u0027count\u0027) is valid, which I haven\u0027t checked TBH.","commit_id":"429ca1fa4b6442132ee8f9cede7cca305fbf18a8"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"ed78851a0930b2ea17fa24055ac10cd71d78536c","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    #               methods, where there is no longer just a single aggregate"},{"line_number":28,"context_line":"    #               value to be stored per-period (e.g. ohlc)"},{"line_number":29,"context_line":"    VALID_AGGREGATION_METHODS \u003d set((\u0027mean\u0027, \u0027sum\u0027, \u0027last\u0027, \u0027max\u0027, \u0027min\u0027,"},{"line_number":30,"context_line":"                                     \u0027std\u0027, \u0027median\u0027, \u0027first\u0027))"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def __init__(self, name, back_window, definition,"},{"line_number":33,"context_line":"                 aggregation_methods\u003dset((\"*\",))):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_bc1671a5","line":30,"in_reply_to":"3a961159_a6902143","updated":"2015-01-14 13:54:05.000000000","message":"I had no idea we missed it, adding it right now.","commit_id":"429ca1fa4b6442132ee8f9cede7cca305fbf18a8"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"715d1ea63a4163434027678b223df7838aed0848","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        self.name \u003d name"},{"line_number":35,"context_line":"        self.back_window \u003d back_window"},{"line_number":36,"context_line":"        self.definition \u003d definition"},{"line_number":37,"context_line":"        self.aggregation_methods \u003d set(aggregation_methods)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    @property"},{"line_number":40,"context_line":"    def aggregation_methods(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_a6b741d6","line":37,"updated":"2015-01-14 13:32:39.000000000","message":"I don\u0027t think we need the set creation on lines 37 and 33, as this is done again anyhow in the setter.","commit_id":"429ca1fa4b6442132ee8f9cede7cca305fbf18a8"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"ed78851a0930b2ea17fa24055ac10cd71d78536c","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        self.name \u003d name"},{"line_number":35,"context_line":"        self.back_window \u003d back_window"},{"line_number":36,"context_line":"        self.definition \u003d definition"},{"line_number":37,"context_line":"        self.aggregation_methods \u003d set(aggregation_methods)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    @property"},{"line_number":40,"context_line":"    def aggregation_methods(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_7c1889cd","line":37,"in_reply_to":"3a961159_a6b741d6","updated":"2015-01-14 13:54:05.000000000","message":"Done","commit_id":"429ca1fa4b6442132ee8f9cede7cca305fbf18a8"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"715d1ea63a4163434027678b223df7838aed0848","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        if rest:"},{"line_number":62,"context_line":"            raise ValueError(\"Invalid value for aggregation_methods: %s\" %"},{"line_number":63,"context_line":"                             rest)"},{"line_number":64,"context_line":"        self._aggregation_methods \u003d value"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    @classmethod"},{"line_number":67,"context_line":"    def from_dict(cls, d):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_a67ae1ed","line":64,"updated":"2015-01-14 13:32:39.000000000","message":"Would it make more sense to do the parsing of the \u0027*\u0027 wildcard and the -function syntax here in the setter, instead of doing it when the property is accessed on lines 41-50?","commit_id":"429ca1fa4b6442132ee8f9cede7cca305fbf18a8"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"34d0151e5b83dcdd2a47f2006854d4df8159c366","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        if rest:"},{"line_number":62,"context_line":"            raise ValueError(\"Invalid value for aggregation_methods: %s\" %"},{"line_number":63,"context_line":"                             rest)"},{"line_number":64,"context_line":"        self._aggregation_methods \u003d value"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    @classmethod"},{"line_number":67,"context_line":"    def from_dict(cls, d):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_f51b8619","line":64,"in_reply_to":"3a961159_5c490db7","updated":"2015-01-15 10:49:41.000000000","message":"Fair enough, agreed it doesn\u0027t make a huge difference.","commit_id":"429ca1fa4b6442132ee8f9cede7cca305fbf18a8"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"ed78851a0930b2ea17fa24055ac10cd71d78536c","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        if rest:"},{"line_number":62,"context_line":"            raise ValueError(\"Invalid value for aggregation_methods: %s\" %"},{"line_number":63,"context_line":"                             rest)"},{"line_number":64,"context_line":"        self._aggregation_methods \u003d value"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    @classmethod"},{"line_number":67,"context_line":"    def from_dict(cls, d):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_5c490db7","line":64,"in_reply_to":"3a961159_a67ae1ed","updated":"2015-01-14 13:54:05.000000000","message":"Good question. I don\u0027t think it changes a lot, but I like the idea to be able to have access to the real set value (e.g. [\u0027*\u0027]) in _aggregation_methods if ever needed. :)","commit_id":"429ca1fa4b6442132ee8f9cede7cca305fbf18a8"}]}