)]}'
{"gnocchi/rest/__init__.py":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"108edb28e5dbdac3f58d02ac447e990080583697","unresolved":false,"context_lines":[{"line_number":674,"context_line":"        for metric in metrics:"},{"line_number":675,"context_line":"            try:"},{"line_number":676,"context_line":"                pecan.request.storage.delete_metric(str(metric[\u0027id\u0027]))"},{"line_number":677,"context_line":"            except Exception:"},{"line_number":678,"context_line":"                LOG.error("},{"line_number":679,"context_line":"                    \"Unable to delete metric `%s\u0027 from storage, \""},{"line_number":680,"context_line":"                    \"you will need to delete it manually\" % metric,"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_92e56baa","line":677,"updated":"2015-02-02 16:25:56.000000000","message":"Will the caller (the person deleting the resource over the api) ever know this exception happened, or just the log?\n\nIs it possible to use a more focused exception?","commit_id":"cd9e2b20f44b7f5d77473f29d04ced1f8eb71522"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"017c69b9bbd45ecb79c2e45dab3bcfa29bdecb84","unresolved":false,"context_lines":[{"line_number":674,"context_line":"        for metric in metrics:"},{"line_number":675,"context_line":"            try:"},{"line_number":676,"context_line":"                pecan.request.storage.delete_metric(str(metric[\u0027id\u0027]))"},{"line_number":677,"context_line":"            except Exception:"},{"line_number":678,"context_line":"                LOG.error("},{"line_number":679,"context_line":"                    \"Unable to delete metric `%s\u0027 from storage, \""},{"line_number":680,"context_line":"                    \"you will need to delete it manually\" % metric,"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_0bb78287","line":677,"in_reply_to":"da86d52c_92e56baa","updated":"2015-02-02 17:06:06.000000000","message":"No the caller won\u0027t, because from its point of view it will succeed and there\u0027s no point in letting them know of that.\n\nThe point is to log if any exception occurs, i.e. the storage is not-available or something and succeed.\n\n\nThe thing is that we can\u0027t do a delete on all the metrics in a transactional matters, so we do a best effort to delete the maximum amount and that\u0027s it.","commit_id":"cd9e2b20f44b7f5d77473f29d04ced1f8eb71522"}]}