)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"fb2c555a83357f4ca11213f5ef04bf9f7bc0d2c3","unresolved":false,"context_lines":[{"line_number":9,"context_line":"There were two problems with the startup of the statsd service:"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"* In cli.py the name of the function and module were colliding."},{"line_number":12,"context_line":"* In statsd.py the statsd related options were listed is \"required\"."},{"line_number":13,"context_line":"  If this is done it means that any installation that wants to use"},{"line_number":14,"context_line":"  gnocchi.conf must configure for statsd. This is not desired."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da86d52c_026672bb","line":12,"updated":"2015-02-16 16:14:39.000000000","message":"If you don\u0027t set required\u003dTrue and start gnocchi-statsd with the value unset it will fail.\n\nSo yes this is required. I think the option should just be registered elseswhere maybe?","commit_id":"944f78cb6b82b5b7f7264c4a10feafb5a2d112b8"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"a22b3b93a6d67724f903300d5df3af87c4285eff","unresolved":false,"context_lines":[{"line_number":9,"context_line":"There were two problems with the startup of the statsd service:"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"* In cli.py the name of the function and module were colliding."},{"line_number":12,"context_line":"* In statsd.py the statsd related options were listed is \"required\"."},{"line_number":13,"context_line":"  If this is done it means that any installation that wants to use"},{"line_number":14,"context_line":"  gnocchi.conf must configure for statsd. This is not desired."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da86d52c_e21ebeba","line":12,"in_reply_to":"da86d52c_026672bb","updated":"2015-02-16 16:25:33.000000000","message":"It\u0027s wrong as is: If you try to test something without statsd settings set, it will barf.\n\nThere are plenty of other settings which are required in order for things to not fail (for example database.connection) but they are not listed as Required. Instead they fail with an error.\n\nThis is what I would expect in this case too because running the statsd service is optional.\n\nI assume that it can probably be moved inside some method, but then that method would need to be called from gnocchi/tests/base.py, which seems wrong too.\n\nThere seem to be too many interconnecting things here and required misstates the desired outcome. Its semantics are \"must be in the configuration file\" not \"required for this service\". We want the latter, but that\u0027s not what it means.","commit_id":"944f78cb6b82b5b7f7264c4a10feafb5a2d112b8"}]}