)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"00b0c03f0dc9d416c1e1fbb3dd012a2bae1e7355","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"tests: stop generating scenarios for all indexer"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We know test only one indexer at a time, as we already rely on tox to"},{"line_number":10,"context_line":"configure correctly one indexer at a time."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This reduces the number of generated+skipped tests and speeds up the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a80dd14_36b1c147","line":9,"updated":"2015-03-06 13:44:11.000000000","message":"s/know/now/","commit_id":"e2d36faf754c8fb197d99d7e637dd66118cf0603"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"a39b0dfbf6a6ae55c75c0d12a3c17a9d1ab591b7","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"tests: stop generating scenarios for all indexer"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We know test only one indexer at a time, as we already rely on tox to"},{"line_number":10,"context_line":"configure correctly one indexer at a time."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This reduces the number of generated+skipped tests and speeds up the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a80dd14_a9046f18","line":9,"in_reply_to":"9a80dd14_36b1c147","updated":"2015-03-06 15:44:57.000000000","message":"Done","commit_id":"e2d36faf754c8fb197d99d7e637dd66118cf0603"}],"gnocchi/indexer/__init__.py":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"203064e5602859934888f1f84236e8acee1a1c30","unresolved":false,"context_lines":[{"line_number":32,"context_line":"def get_driver(conf):"},{"line_number":33,"context_line":"    \"\"\"Return the configured driver.\"\"\""},{"line_number":34,"context_line":"    split \u003d netutils.urlsplit(conf.indexer.url)"},{"line_number":35,"context_line":"    d \u003d driver.DriverManager(\u0027gnocchi.indexer\u0027,"},{"line_number":36,"context_line":"                             split.scheme).driver"},{"line_number":37,"context_line":"    return d(conf)"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_7ac9d8ab","line":35,"updated":"2015-03-10 18:11:52.000000000","message":"Are you happy with single letter variable names?\n\nwhy not return driver.DriverManager(\u0027gnocchi.indexer\u0027, split.scheme).driver(conf)?","commit_id":"0620d8415a7a6de86c9636345006bf4692c28994"}],"gnocchi/indexer/sqlalchemy.py":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"00b0c03f0dc9d416c1e1fbb3dd012a2bae1e7355","unresolved":false,"context_lines":[{"line_number":230,"context_line":""},{"line_number":231,"context_line":"    def __init__(self, conf):"},{"line_number":232,"context_line":"        options.set_defaults(conf)"},{"line_number":233,"context_line":"        conf.set_override(\"connection\", conf.indexer.url, \"database\")"},{"line_number":234,"context_line":"        self.conf \u003d conf"},{"line_number":235,"context_line":"        self.qt \u003d QueryTransformer()"},{"line_number":236,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_76e5f936","line":233,"updated":"2015-03-06 13:44:11.000000000","message":"Doing a set_override this deep in the core code seems a bit weird an unexpected?","commit_id":"e2d36faf754c8fb197d99d7e637dd66118cf0603"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"a39b0dfbf6a6ae55c75c0d12a3c17a9d1ab591b7","unresolved":false,"context_lines":[{"line_number":230,"context_line":""},{"line_number":231,"context_line":"    def __init__(self, conf):"},{"line_number":232,"context_line":"        options.set_defaults(conf)"},{"line_number":233,"context_line":"        conf.set_override(\"connection\", conf.indexer.url, \"database\")"},{"line_number":234,"context_line":"        self.conf \u003d conf"},{"line_number":235,"context_line":"        self.qt \u003d QueryTransformer()"},{"line_number":236,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_690ef73c","line":233,"in_reply_to":"9a80dd14_76e5f936","updated":"2015-03-06 15:44:57.000000000","message":"That\u0027s allow the user not to have to duplicate the config option.\n\nWe don\u0027t have much choice since we are using EngineFacade.from_config().","commit_id":"e2d36faf754c8fb197d99d7e637dd66118cf0603"}]}