)]}'
{"gnocchi/tests/base.py":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"5a836c0a9ecc3e038f92d830768c8a8694cdb330","unresolved":false,"context_lines":[{"line_number":76,"context_line":"            # Locking a not existing object create an empty one"},{"line_number":77,"context_line":"            # so, do the same in test"},{"line_number":78,"context_line":"            if not isinstance(name, str):"},{"line_number":79,"context_line":"                raise TypeError(\"name in not a \u0027str\u0027 object\")"},{"line_number":80,"context_line":"            if not isinstance(lock, str):"},{"line_number":81,"context_line":"                raise TypeError(\"lock in not a \u0027str\u0027 object\")"},{"line_number":82,"context_line":"            key \u003d name.value.decode(\u0027ascii\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_c9301feb","line":79,"updated":"2015-03-11 12:47:26.000000000","message":"Do you want \"is\" instead of \"in\" here?","commit_id":"0e626cbc1fa028c837453a673185ff9b73f41dbe"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"7d1f82fad263c1ab48d36a9ef749782f6c9036f7","unresolved":false,"context_lines":[{"line_number":76,"context_line":"            # Locking a not existing object create an empty one"},{"line_number":77,"context_line":"            # so, do the same in test"},{"line_number":78,"context_line":"            if not isinstance(name, str):"},{"line_number":79,"context_line":"                raise TypeError(\"name in not a \u0027str\u0027 object\")"},{"line_number":80,"context_line":"            if not isinstance(lock, str):"},{"line_number":81,"context_line":"                raise TypeError(\"lock in not a \u0027str\u0027 object\")"},{"line_number":82,"context_line":"            key \u003d name.value.decode(\u0027ascii\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_fad47abe","line":79,"in_reply_to":"9a80dd14_c9301feb","updated":"2015-03-12 17:20:31.000000000","message":"Done","commit_id":"0e626cbc1fa028c837453a673185ff9b73f41dbe"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"5a836c0a9ecc3e038f92d830768c8a8694cdb330","unresolved":false,"context_lines":[{"line_number":78,"context_line":"            if not isinstance(name, str):"},{"line_number":79,"context_line":"                raise TypeError(\"name in not a \u0027str\u0027 object\")"},{"line_number":80,"context_line":"            if not isinstance(lock, str):"},{"line_number":81,"context_line":"                raise TypeError(\"lock in not a \u0027str\u0027 object\")"},{"line_number":82,"context_line":"            key \u003d name.value.decode(\u0027ascii\u0027)"},{"line_number":83,"context_line":"            if key not in self.kvs:"},{"line_number":84,"context_line":"                self.kvs[key] \u003d \"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_e94c0379","line":81,"updated":"2015-03-11 12:47:26.000000000","message":"Ditto","commit_id":"0e626cbc1fa028c837453a673185ff9b73f41dbe"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"7d1f82fad263c1ab48d36a9ef749782f6c9036f7","unresolved":false,"context_lines":[{"line_number":78,"context_line":"            if not isinstance(name, str):"},{"line_number":79,"context_line":"                raise TypeError(\"name in not a \u0027str\u0027 object\")"},{"line_number":80,"context_line":"            if not isinstance(lock, str):"},{"line_number":81,"context_line":"                raise TypeError(\"lock in not a \u0027str\u0027 object\")"},{"line_number":82,"context_line":"            key \u003d name.value.decode(\u0027ascii\u0027)"},{"line_number":83,"context_line":"            if key not in self.kvs:"},{"line_number":84,"context_line":"                self.kvs[key] \u003d \"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_1adb0eee","line":81,"in_reply_to":"9a80dd14_e94c0379","updated":"2015-03-12 17:20:31.000000000","message":"Done","commit_id":"0e626cbc1fa028c837453a673185ff9b73f41dbe"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"5a836c0a9ecc3e038f92d830768c8a8694cdb330","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        def rados_unlock(self, ctx, name, lock, locker):"},{"line_number":88,"context_line":"            if not isinstance(name, str):"},{"line_number":89,"context_line":"                raise TypeError(\"name in not a \u0027str\u0027 object\")"},{"line_number":90,"context_line":"            if not isinstance(lock, str):"},{"line_number":91,"context_line":"                raise TypeError(\"lock in not a \u0027str\u0027 object\")"},{"line_number":92,"context_line":"            # Locking a not existing object create an empty one"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_a94a0b53","line":89,"updated":"2015-03-11 12:47:26.000000000","message":"ditto","commit_id":"0e626cbc1fa028c837453a673185ff9b73f41dbe"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"7d1f82fad263c1ab48d36a9ef749782f6c9036f7","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        def rados_unlock(self, ctx, name, lock, locker):"},{"line_number":88,"context_line":"            if not isinstance(name, str):"},{"line_number":89,"context_line":"                raise TypeError(\"name in not a \u0027str\u0027 object\")"},{"line_number":90,"context_line":"            if not isinstance(lock, str):"},{"line_number":91,"context_line":"                raise TypeError(\"lock in not a \u0027str\u0027 object\")"},{"line_number":92,"context_line":"            # Locking a not existing object create an empty one"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_3ad612c4","line":89,"in_reply_to":"9a80dd14_a94a0b53","updated":"2015-03-12 17:20:31.000000000","message":"Done","commit_id":"0e626cbc1fa028c837453a673185ff9b73f41dbe"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"5a836c0a9ecc3e038f92d830768c8a8694cdb330","unresolved":false,"context_lines":[{"line_number":88,"context_line":"            if not isinstance(name, str):"},{"line_number":89,"context_line":"                raise TypeError(\"name in not a \u0027str\u0027 object\")"},{"line_number":90,"context_line":"            if not isinstance(lock, str):"},{"line_number":91,"context_line":"                raise TypeError(\"lock in not a \u0027str\u0027 object\")"},{"line_number":92,"context_line":"            # Locking a not existing object create an empty one"},{"line_number":93,"context_line":"            # so, do the same in test"},{"line_number":94,"context_line":"            key \u003d name.value.decode(\u0027ascii\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_09795793","line":91,"updated":"2015-03-11 12:47:26.000000000","message":"ditto","commit_id":"0e626cbc1fa028c837453a673185ff9b73f41dbe"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"7d1f82fad263c1ab48d36a9ef749782f6c9036f7","unresolved":false,"context_lines":[{"line_number":88,"context_line":"            if not isinstance(name, str):"},{"line_number":89,"context_line":"                raise TypeError(\"name in not a \u0027str\u0027 object\")"},{"line_number":90,"context_line":"            if not isinstance(lock, str):"},{"line_number":91,"context_line":"                raise TypeError(\"lock in not a \u0027str\u0027 object\")"},{"line_number":92,"context_line":"            # Locking a not existing object create an empty one"},{"line_number":93,"context_line":"            # so, do the same in test"},{"line_number":94,"context_line":"            key \u003d name.value.decode(\u0027ascii\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_5ae586a6","line":91,"in_reply_to":"9a80dd14_09795793","updated":"2015-03-12 17:20:31.000000000","message":"Done","commit_id":"0e626cbc1fa028c837453a673185ff9b73f41dbe"}],"gnocchi/tests/gabbi/gabbits/resource.yaml":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"83c78ee09c3d25af30aa73b461c340ad0dfcf2dd","unresolved":false,"context_lines":[{"line_number":412,"context_line":"          host: compute3"},{"line_number":413,"context_line":"          display_name: myvm2"},{"line_number":414,"context_line":"          metrics:"},{"line_number":415,"context_line":"              \u0027∞.unicode\u0027: $RESPONSE[\u0027id\u0027]"},{"line_number":416,"context_line":"      status: 201"},{"line_number":417,"context_line":"      response_json_paths:"},{"line_number":418,"context_line":"          created_by_user_id: 0fbb2314-8461-4b1a-8013-1fc22f6afc9c"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9a80dd14_f41693a6","line":415,"updated":"2015-03-11 14:39:45.000000000","message":"Wait, I\u0027m lost somwhere. The id is an UUID so it\u0027s not unicode. And that\u0027s what is passed down to Ceph.\n\nThe name of the metric in the indexer is never passed to the storage drivers.","commit_id":"18c1ea0822fc04d0eaec72b6c0a5c50bab1c44cc"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"50ca7daf132aeeb37d1dd0b4b492d95cebcd9362","unresolved":false,"context_lines":[{"line_number":412,"context_line":"          host: compute3"},{"line_number":413,"context_line":"          display_name: myvm2"},{"line_number":414,"context_line":"          metrics:"},{"line_number":415,"context_line":"              \u0027∞.unicode\u0027: $RESPONSE[\u0027id\u0027]"},{"line_number":416,"context_line":"      status: 201"},{"line_number":417,"context_line":"      response_json_paths:"},{"line_number":418,"context_line":"          created_by_user_id: 0fbb2314-8461-4b1a-8013-1fc22f6afc9c"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9a80dd14_12825700","line":415,"in_reply_to":"9a80dd14_72c0f37c","updated":"2015-03-11 15:09:48.000000000","message":"I have removed the tests have added, if this is a UUID the improvement in the mock is sufficient.","commit_id":"18c1ea0822fc04d0eaec72b6c0a5c50bab1c44cc"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"052d6f7edbf98034e5b16d94d7ea4b1af8598d86","unresolved":false,"context_lines":[{"line_number":412,"context_line":"          host: compute3"},{"line_number":413,"context_line":"          display_name: myvm2"},{"line_number":414,"context_line":"          metrics:"},{"line_number":415,"context_line":"              \u0027∞.unicode\u0027: $RESPONSE[\u0027id\u0027]"},{"line_number":416,"context_line":"      status: 201"},{"line_number":417,"context_line":"      response_json_paths:"},{"line_number":418,"context_line":"          created_by_user_id: 0fbb2314-8461-4b1a-8013-1fc22f6afc9c"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9a80dd14_72c0f37c","line":415,"in_reply_to":"9a80dd14_f41693a6","updated":"2015-03-11 15:07:18.000000000","message":"That explains why the issue I try to figure out is not triggered :(","commit_id":"18c1ea0822fc04d0eaec72b6c0a5c50bab1c44cc"}]}