)]}'
{"gnocchi/tests/test_storage.py":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"7c56cbf7a1ed42a5e311fddc93e00ad2074818e4","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                          self.storage.create_metric,"},{"line_number":63,"context_line":"                          self.metric)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def test_delete_inexistent_metric(self):"},{"line_number":66,"context_line":"        self.assertRaises(storage.MetricDoesNotExist,"},{"line_number":67,"context_line":"                          self.storage.delete_metric,"},{"line_number":68,"context_line":"                          self.metric)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_735414c6","line":65,"updated":"2015-03-19 13:02:51.000000000","message":"It\u0027s not very obvious here how or why self.metric will not exist here.","commit_id":"d3fb349b6e87dd32689674d11b73690c12241e56"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"0fb95f80045a5592a9608d36a65a5645a18cbea2","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                          self.storage.create_metric,"},{"line_number":63,"context_line":"                          self.metric)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def test_delete_inexistent_metric(self):"},{"line_number":66,"context_line":"        self.assertRaises(storage.MetricDoesNotExist,"},{"line_number":67,"context_line":"                          self.storage.delete_metric,"},{"line_number":68,"context_line":"                          self.metric)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_760b22d5","line":65,"in_reply_to":"9a80dd14_735414c6","updated":"2015-03-19 13:18:46.000000000","message":"self.storage.create_metric is never called in setUp() :)\nI guess you missed that?","commit_id":"d3fb349b6e87dd32689674d11b73690c12241e56"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"114c162ae180d6d5ca689454e5339e3972c6bb42","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                          self.storage.create_metric,"},{"line_number":63,"context_line":"                          self.metric)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def test_delete_inexistent_metric(self):"},{"line_number":66,"context_line":"        self.assertRaises(storage.MetricDoesNotExist,"},{"line_number":67,"context_line":"                          self.storage.delete_metric,"},{"line_number":68,"context_line":"                          self.metric)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_f9c38355","line":65,"in_reply_to":"9a80dd14_760b22d5","updated":"2015-03-19 13:35:47.000000000","message":"I know that, but in isolation, it\u0027s not very obvious.\n\nIt\u0027s not that big of a deal. I just hate OO :)","commit_id":"d3fb349b6e87dd32689674d11b73690c12241e56"}]}