)]}'
{"gnocchi/indexer/sqlalchemy.py":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"11a8b0c91cf2fdd9714eba6d95c4a71efe19683c","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        session \u003d self.engine_facade.get_session()"},{"line_number":101,"context_line":"        query \u003d session.query(Metric)"},{"line_number":102,"context_line":"        # Avoid sqlalchemy getting upset about performance and"},{"line_number":103,"context_line":"        # making warnings when uuids is empty."},{"line_number":104,"context_line":"        if uuids:"},{"line_number":105,"context_line":"            query \u003d query.filter(Metric.id.in_(uuids))"},{"line_number":106,"context_line":"        if details:"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9b358b_4b231fbe","line":103,"updated":"2015-03-30 17:00:51.000000000","message":"If the UUID list is empty we should return the empty list directly.\n\nI don\u0027t think we ever call get_metrics([])? That sounds like a bug.\nMaybe we need indexer tests too.","commit_id":"4cccb824767516c85e4c1a6209e1ba2dc8e437c1"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"d5e10e7d3ca45b5ccd114cc99e2e7c266ddc373e","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        session \u003d self.engine_facade.get_session()"},{"line_number":101,"context_line":"        query \u003d session.query(Metric)"},{"line_number":102,"context_line":"        # Avoid sqlalchemy getting upset about performance and"},{"line_number":103,"context_line":"        # making warnings when uuids is empty."},{"line_number":104,"context_line":"        if uuids:"},{"line_number":105,"context_line":"            query \u003d query.filter(Metric.id.in_(uuids))"},{"line_number":106,"context_line":"        if details:"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9b358b_6e271113","line":103,"in_reply_to":"da9b358b_4b231fbe","updated":"2015-03-30 17:15:51.000000000","message":"My read of the code was that if no uuids were provided we\u0027d return all metrics, but that\u0027s no good.\n\nget_metrics([]) is being called by delete_resource, which is called with a function for delete_metrics from the delete method of the GenericResourceController in the rest api.\n\nI\u0027ll update this to return an empty list when uuids is empty.","commit_id":"4cccb824767516c85e4c1a6209e1ba2dc8e437c1"}]}