)]}'
{"devstack/plugin.sh":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"0bf794b91eccd6e28f6c65883f271d6f85af9877","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"# Gnocchi connection info."},{"line_number":61,"context_line":"GNOCCHI_SERVICE_PROTOCOL\u003dhttp"},{"line_number":62,"context_line":"GNOCCHI_SERVICE_PORT\u003d${GNOCCHI_SERVICE_PORT:-\u0027\u0027}"},{"line_number":63,"context_line":"GNOCCHI_SERVICE_PREFIX\u003d${GNOCCHI_SERVICE_PREFIX:-\u0027/metric\u0027}"},{"line_number":64,"context_line":"GNOCCHI_SERVICE_HOST\u003d$SERVICE_HOST"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-sh","patch_set":3,"id":"fa32b979_7b8e1f7a","line":62,"updated":"2015-06-25 09:59:37.000000000","message":"Maybe set 8041 here?","commit_id":"01fb5ba846dbe269282be78cf5496e5785c74e9b"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"d5a2d4bf501de2931da6662268f78bbc8ebbf19e","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"# Gnocchi connection info."},{"line_number":61,"context_line":"GNOCCHI_SERVICE_PROTOCOL\u003dhttp"},{"line_number":62,"context_line":"GNOCCHI_SERVICE_PORT\u003d${GNOCCHI_SERVICE_PORT:-\u0027\u0027}"},{"line_number":63,"context_line":"GNOCCHI_SERVICE_PREFIX\u003d${GNOCCHI_SERVICE_PREFIX:-\u0027/metric\u0027}"},{"line_number":64,"context_line":"GNOCCHI_SERVICE_HOST\u003d$SERVICE_HOST"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-sh","patch_set":3,"id":"fa32b979_a1fa3173","line":62,"in_reply_to":"fa32b979_7b8e1f7a","updated":"2015-06-25 11:43:35.000000000","message":"At the moment the empty value on port signals that the prefixed service is going to be used, and the prefixed service is the default (which is what QA would prefer, as well as only running on one location at time).\n\nWhat would you want setting 8041 here to do or signal? Or is it just a matter of recording that 8041 is the port gnocchi has eked out for itself?","commit_id":"01fb5ba846dbe269282be78cf5496e5785c74e9b"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"c762c59d802867618668d0a4d9b2ab23088e0b88","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"# Gnocchi connection info."},{"line_number":61,"context_line":"GNOCCHI_SERVICE_PROTOCOL\u003dhttp"},{"line_number":62,"context_line":"GNOCCHI_SERVICE_PORT\u003d${GNOCCHI_SERVICE_PORT:-\u0027\u0027}"},{"line_number":63,"context_line":"GNOCCHI_SERVICE_PREFIX\u003d${GNOCCHI_SERVICE_PREFIX:-\u0027/metric\u0027}"},{"line_number":64,"context_line":"GNOCCHI_SERVICE_HOST\u003d$SERVICE_HOST"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-sh","patch_set":3,"id":"fa32b979_521e95bb","line":62,"in_reply_to":"fa32b979_a1fa3173","updated":"2015-06-25 12:48:41.000000000","message":"No that\u0027s good, it was more a proposal regarding the gabbi live testing port being set to None if metric was used, but this is now OK :)","commit_id":"01fb5ba846dbe269282be78cf5496e5785c74e9b"}],"gnocchi/tests/gabbi/test_gabbi_live.py":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"0bf794b91eccd6e28f6c65883f271d6f85af9877","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        port \u003d os.getenv(\u0027GNOCCHI_SERVICE_PORT\u0027, 8041)"},{"line_number":32,"context_line":"        prefix \u003d os.getenv(\u0027GNOCCHI_SERVICE_PREFIX\u0027)"},{"line_number":33,"context_line":"        if prefix:"},{"line_number":34,"context_line":"            port \u003d None"},{"line_number":35,"context_line":"        return driver.build_tests(test_dir, loader,"},{"line_number":36,"context_line":"                                  host\u003dhost, prefix\u003dprefix, port\u003dport)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_9be0c327","line":34,"updated":"2015-06-25 09:59:37.000000000","message":"I\u0027m not a fan of that :(","commit_id":"01fb5ba846dbe269282be78cf5496e5785c74e9b"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"d5a2d4bf501de2931da6662268f78bbc8ebbf19e","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        port \u003d os.getenv(\u0027GNOCCHI_SERVICE_PORT\u0027, 8041)"},{"line_number":32,"context_line":"        prefix \u003d os.getenv(\u0027GNOCCHI_SERVICE_PREFIX\u0027)"},{"line_number":33,"context_line":"        if prefix:"},{"line_number":34,"context_line":"            port \u003d None"},{"line_number":35,"context_line":"        return driver.build_tests(test_dir, loader,"},{"line_number":36,"context_line":"                                  host\u003dhost, prefix\u003dprefix, port\u003dport)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_c16ad519","line":34,"in_reply_to":"fa32b979_9be0c327","updated":"2015-06-25 11:43:35.000000000","message":"passing in the url is a good idea, I\u0027ll make that happen.","commit_id":"01fb5ba846dbe269282be78cf5496e5785c74e9b"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"b447fc0098fffc37df89a3a24b409e2ff3245ca5","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        host \u003d parsed_url[1]"},{"line_number":33,"context_line":"        port \u003d 443 if parsed_url[0] \u003d\u003d \u0027https\u0027 else 80"},{"line_number":34,"context_line":"        if \u0027:\u0027 in host:"},{"line_number":35,"context_line":"            host, port \u003d host.split(\u0027:\u0027)"},{"line_number":36,"context_line":"        prefix \u003d parsed_url[2].rstrip(\u0027/\u0027)  # turn it into a prefix"},{"line_number":37,"context_line":"        test_dir \u003d os.path.join(os.path.dirname(__file__), TESTS_DIR)"},{"line_number":38,"context_line":"        return driver.build_tests(test_dir, loader,"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa32b979_5218d51d","line":35,"updated":"2015-06-25 12:42:14.000000000","message":"You know there are libs to parse that correctly? ;)","commit_id":"5d1978a19f2f8a5049bfc36434fddc8eb3bc06a1"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"6909b6c779eaa411e4370060896607af9ce65865","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        host \u003d parsed_url[1]"},{"line_number":33,"context_line":"        port \u003d 443 if parsed_url[0] \u003d\u003d \u0027https\u0027 else 80"},{"line_number":34,"context_line":"        if \u0027:\u0027 in host:"},{"line_number":35,"context_line":"            host, port \u003d host.split(\u0027:\u0027)"},{"line_number":36,"context_line":"        prefix \u003d parsed_url[2].rstrip(\u0027/\u0027)  # turn it into a prefix"},{"line_number":37,"context_line":"        test_dir \u003d os.path.join(os.path.dirname(__file__), TESTS_DIR)"},{"line_number":38,"context_line":"        return driver.build_tests(test_dir, loader,"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa32b979_12b80dc7","line":35,"in_reply_to":"fa32b979_5218d51d","updated":"2015-06-25 12:46:16.000000000","message":"Fine, fine\n\nPlease answer my question on the other comment.","commit_id":"5d1978a19f2f8a5049bfc36434fddc8eb3bc06a1"}]}