)]}'
{"gnocchi/indexer/sqlalchemy.py":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"aff13450f7a1fe5ab24a12ef6e2e6e8547409b1a","unresolved":false,"context_lines":[{"line_number":129,"context_line":"            # TODO(jd) Add an exception in oslo.db to match foreign key"},{"line_number":130,"context_line":"            # violations"},{"line_number":131,"context_line":"            if isinstance(e.inner_exception, sqlalchemy.exc.IntegrityError):"},{"line_number":132,"context_line":"                raise indexer.ArchivePolicyInUse(name)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    def get_metrics(self, uuids):"},{"line_number":135,"context_line":"        if not uuids:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_05064820","side":"PARENT","line":132,"updated":"2015-08-10 09:52:15.000000000","message":"If you need the safety of checking e.constraint here then doesn\u0027t that mean you need to `raise` when the if doesn\u0027t match?\n\nOtherwise you are swallowing the exception.","commit_id":"39ff4c8ac8876336b61d4f4683ca3f08964f6ef8"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"2d2536cc4ad5f6903ed587ba439d6d24c556a800","unresolved":false,"context_lines":[{"line_number":129,"context_line":"            # TODO(jd) Add an exception in oslo.db to match foreign key"},{"line_number":130,"context_line":"            # violations"},{"line_number":131,"context_line":"            if isinstance(e.inner_exception, sqlalchemy.exc.IntegrityError):"},{"line_number":132,"context_line":"                raise indexer.ArchivePolicyInUse(name)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    def get_metrics(self, uuids):"},{"line_number":135,"context_line":"        if not uuids:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_cbe86f19","side":"PARENT","line":132,"in_reply_to":"1a4dcd0f_05064820","updated":"2015-08-10 10:14:37.000000000","message":"Good catch!","commit_id":"39ff4c8ac8876336b61d4f4683ca3f08964f6ef8"}]}