)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"91a29ae9c68ca2a27f8b97910e41114497820a76","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Mehdi Abaakouk \u003csileht@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-09-01 09:04:56 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add two new resources"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change adds instance_disk and instance_network_interface resources."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"da20952f_a037204c","line":7,"updated":"2015-09-10 08:24:19.000000000","message":"Could you name them here :)","commit_id":"d16b47d7e0891fa991a688c55ce7f743e41ea2f3"}],"gnocchi/indexer/sqlalchemy_extension.py":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"4d9ee315bea76be3ada9f13bdb66d63aa1b0e9c7","unresolved":false,"context_lines":[{"line_number":39,"context_line":"                                    nullable\u003dFalse)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"class InstanceNetwork(object):"},{"line_number":43,"context_line":"    name \u003d sqlalchemy.Column(sqlalchemy.String(255), nullable\u003dFalse)"},{"line_number":44,"context_line":"    instance_id \u003d sqlalchemy.Column(sqlalchemy_utils.UUIDType(),"},{"line_number":45,"context_line":"                                    nullable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_b40994df","line":42,"updated":"2015-08-28 13:01:05.000000000","message":"So my raw thinking about that.\n\n\nThe instance_network is not actually a network for an instance. It\u0027s a network where you can have multiple instances. So I *think* it should be just one resource called \"network\".\n\nWhat you measure is the interaction between the network and the instance. That meter could be attached to the network or the instance, whatever.\n\nShould, can we do something smarter than that here?","commit_id":"07585881e983bf63bbc89259a89dc0980322286d"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"6ca6c29ec8b528b6579cbae8560859cedf7e6ce5","unresolved":false,"context_lines":[{"line_number":39,"context_line":"                                    nullable\u003dFalse)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"class InstanceNetwork(object):"},{"line_number":43,"context_line":"    name \u003d sqlalchemy.Column(sqlalchemy.String(255), nullable\u003dFalse)"},{"line_number":44,"context_line":"    instance_id \u003d sqlalchemy.Column(sqlalchemy_utils.UUIDType(),"},{"line_number":45,"context_line":"                                    nullable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_bfdcc873","line":42,"in_reply_to":"da20952f_7c671eb7","updated":"2015-08-31 09:12:36.000000000","message":"Yeah I think it\u0027d be a better name.","commit_id":"07585881e983bf63bbc89259a89dc0980322286d"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"a2ebf4680d3f14d35be30a47d244cb1cb7455026","unresolved":false,"context_lines":[{"line_number":39,"context_line":"                                    nullable\u003dFalse)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"class InstanceNetwork(object):"},{"line_number":43,"context_line":"    name \u003d sqlalchemy.Column(sqlalchemy.String(255), nullable\u003dFalse)"},{"line_number":44,"context_line":"    instance_id \u003d sqlalchemy.Column(sqlalchemy_utils.UUIDType(),"},{"line_number":45,"context_line":"                                    nullable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_7c671eb7","line":42,"in_reply_to":"da20952f_b40994df","updated":"2015-08-31 08:50:43.000000000","message":"Perhaps this class is badly named. \n\nThis is a tap interface where a instance is connected on.  This is used to measure the network packets number and the bandwith of each network interfaces of an instance.\n\n(counter_name: network.incoming/outgoing.bytes/packets*)\n\nWDYT of \u0027InstanceNetworkInterface\u0027 instead ?\n\nIt could be cool to have the subnet/network where we are attached too, but we don\u0027t have this information in samples/notifications that generates the metric.","commit_id":"07585881e983bf63bbc89259a89dc0980322286d"}]}