)]}'
{"devstack/plugin.sh":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"1aaaaf30ce570e99f90f30ad081976ef6bd24936","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        echo \"$GNOCCHI_SERVICE_PROTOCOL://$GNOCCHI_SERVICE_HOST:$GNOCCHI_SERVICE_PORT\""},{"line_number":84,"context_line":"    else"},{"line_number":85,"context_line":"        echo \"$GNOCCHI_SERVICE_PROTOCOL://$GNOCCHI_SERVICE_HOST$GNOCCHI_SERVICE_PREFIX\""},{"line_number":86,"context_line":"    fi"},{"line_number":87,"context_line":"}"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"# install redis"}],"source_content_type":"text/x-sh","patch_set":2,"id":"ba15a1d1_7f6d2703","side":"PARENT","line":86,"updated":"2015-09-22 13:20:36.000000000","message":"You need an else clause so that when LIBS_FROM_GIT is not set a pip_install python-gnocchiclient happens.","commit_id":"8befab055f74ee9e701e333585defcc022ee32cf"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"352c38bad94ed7f162b68ce19ba0a5dcdc71d33c","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        echo \"$GNOCCHI_SERVICE_PROTOCOL://$GNOCCHI_SERVICE_HOST:$GNOCCHI_SERVICE_PORT\""},{"line_number":84,"context_line":"    else"},{"line_number":85,"context_line":"        echo \"$GNOCCHI_SERVICE_PROTOCOL://$GNOCCHI_SERVICE_HOST$GNOCCHI_SERVICE_PREFIX\""},{"line_number":86,"context_line":"    fi"},{"line_number":87,"context_line":"}"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"# install redis"}],"source_content_type":"text/x-sh","patch_set":2,"id":"ba15a1d1_a25ba6f5","side":"PARENT","line":86,"in_reply_to":"ba15a1d1_7f6d2703","updated":"2015-09-22 13:30:08.000000000","message":"I wondered. None of the other projects do that, and it will fail (for now) since we never pushed to PyPI.","commit_id":"8befab055f74ee9e701e333585defcc022ee32cf"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"1aaaaf30ce570e99f90f30ad081976ef6bd24936","unresolved":false,"context_lines":[{"line_number":89,"context_line":"}"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"function install_gnocchiclient {"},{"line_number":92,"context_line":"    if use_library_from_git python-gnocchiclient; then"},{"line_number":93,"context_line":"        git_clone_by_name python-gnocchiclient"},{"line_number":94,"context_line":"        setup_dev_lib python-gnocchiclient"},{"line_number":95,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":2,"id":"ba15a1d1_bf95ffe4","line":92,"updated":"2015-09-22 13:20:36.000000000","message":"use_library_from_git is a conditional that checks for the library in the LIBS_FROM_GIT variable. You need to add python-gnocchiclient there if you want it to be installed in this function.","commit_id":"c4ccdeb1ec8919ce8dac8abd48944b8f865e006d"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"123e2ce021d42f1f5e3bc49bf13a3dba95a1ec78","unresolved":false,"context_lines":[{"line_number":89,"context_line":"}"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"function install_gnocchiclient {"},{"line_number":92,"context_line":"    if use_library_from_git python-gnocchiclient; then"},{"line_number":93,"context_line":"        git_clone_by_name python-gnocchiclient"},{"line_number":94,"context_line":"        setup_dev_lib python-gnocchiclient"},{"line_number":95,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":2,"id":"ba15a1d1_e27c3eed","line":92,"in_reply_to":"ba15a1d1_02c93278","updated":"2015-09-22 13:38:12.000000000","message":"Ok, I\u0027ll add that for now and we\u0027ll revert to pip install when it\u0027s available!","commit_id":"c4ccdeb1ec8919ce8dac8abd48944b8f865e006d"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"352c38bad94ed7f162b68ce19ba0a5dcdc71d33c","unresolved":false,"context_lines":[{"line_number":89,"context_line":"}"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"function install_gnocchiclient {"},{"line_number":92,"context_line":"    if use_library_from_git python-gnocchiclient; then"},{"line_number":93,"context_line":"        git_clone_by_name python-gnocchiclient"},{"line_number":94,"context_line":"        setup_dev_lib python-gnocchiclient"},{"line_number":95,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":2,"id":"ba15a1d1_e2619ea9","line":92,"in_reply_to":"ba15a1d1_bf95ffe4","updated":"2015-09-22 13:30:08.000000000","message":"LIBS_FROM_GIT is supposed to be set in your local.conf AFAIU","commit_id":"c4ccdeb1ec8919ce8dac8abd48944b8f865e006d"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"84ed9eb7a19283dd2d729e48dcbb31fba5716f53","unresolved":false,"context_lines":[{"line_number":89,"context_line":"}"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"function install_gnocchiclient {"},{"line_number":92,"context_line":"    if use_library_from_git python-gnocchiclient; then"},{"line_number":93,"context_line":"        git_clone_by_name python-gnocchiclient"},{"line_number":94,"context_line":"        setup_dev_lib python-gnocchiclient"},{"line_number":95,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":2,"id":"ba15a1d1_02c93278","line":92,"in_reply_to":"ba15a1d1_e2619ea9","updated":"2015-09-22 13:32:26.000000000","message":"Maybe put a reasonable default in devstack/settings?\n\nThe point of the settings file is to make it easy for someone to have just \u0027enable_plugin gnocchi ...\u0027 and get a reasonable default install. In this case I think we do want people to install the gnocchiclient by default, yeah?","commit_id":"c4ccdeb1ec8919ce8dac8abd48944b8f865e006d"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"2e77ae48310250cf137f5cdab1bd60876932fa9e","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"function install_gnocchiclient {"},{"line_number":92,"context_line":"    if use_library_from_git python-gnocchiclient; then"},{"line_number":93,"context_line":"        mkdir $GITDIR[\"python-gnocchiclient\"]"},{"line_number":94,"context_line":"        git_clone_by_name python-gnocchiclient"},{"line_number":95,"context_line":"        setup_dev_lib python-gnocchiclient"},{"line_number":96,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":4,"id":"ba15a1d1_ebd3b95d","line":93,"updated":"2015-09-22 14:22:16.000000000","message":"This shouldn\u0027t be necessary should it?\n\nIf https://github.com/openstack-dev/devstack/blob/master/functions-common#L544 calls git_clone somewhere in git_clone git itself ought to create the directory?","commit_id":"0f6b7120d9a9eac5ae9b11f7e776c48ecbd4e532"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"40ed303fb1cdb6f1e73797d4efbb75084dee670e","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"function install_gnocchiclient {"},{"line_number":92,"context_line":"    if use_library_from_git python-gnocchiclient; then"},{"line_number":93,"context_line":"        mkdir $GITDIR[\"python-gnocchiclient\"]"},{"line_number":94,"context_line":"        git_clone_by_name python-gnocchiclient"},{"line_number":95,"context_line":"        setup_dev_lib python-gnocchiclient"},{"line_number":96,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":4,"id":"ba15a1d1_6bd7a9bf","line":93,"in_reply_to":"ba15a1d1_ebd3b95d","updated":"2015-09-22 14:31:12.000000000","message":"If you read the devstack-gate log of the previous run, you\u0027ll see the gate sets ERROR_ON_CLONE to True so clone fails if the target directory does not exist :(","commit_id":"0f6b7120d9a9eac5ae9b11f7e776c48ecbd4e532"}]}