)]}'
{"gnocchi/rest/__init__.py":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"0e88a741cbb9d40abd2c07619ed078e4a2b88327","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        return [value]"},{"line_number":45,"context_line":"    return []"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"def abort(status_code\u003dNone, detail\u003d\u0027\u0027, headers\u003dNone, comment\u003dNone, **kw):"},{"line_number":49,"context_line":"    \"\"\"Like pecan.abort, but make sure detail is a string.\"\"\""},{"line_number":50,"context_line":"    return pecan.abort(status_code, six.text_type(detail),"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_4b3a17cf","line":47,"updated":"2015-10-02 11:37:27.000000000","message":"What about changing that proto to\n\nabort(status_code, detail, headers\u003dNone…)\n\nSo we\u0027re sure we don\u0027t forget in the future.","commit_id":"71e30a02fc7873a4b356d77cbddb7b87cbf0757d"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"6b7edbed72c5b46da167ba386b49bc812d864708","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        return [value]"},{"line_number":45,"context_line":"    return []"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"def abort(status_code\u003dNone, detail\u003d\u0027\u0027, headers\u003dNone, comment\u003dNone, **kw):"},{"line_number":49,"context_line":"    \"\"\"Like pecan.abort, but make sure detail is a string.\"\"\""},{"line_number":50,"context_line":"    return pecan.abort(status_code, six.text_type(detail),"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_99a965e2","line":47,"in_reply_to":"9a1a9d01_4b3a17cf","updated":"2015-10-02 12:30:03.000000000","message":"This is only needed for 404, I have wrote something to ensure that.","commit_id":"71e30a02fc7873a4b356d77cbddb7b87cbf0757d"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"3224b19fe519cbe055ee0934cc68acff37a3018d","unresolved":false,"context_lines":[{"line_number":48,"context_line":"def abort(status_code, detail\u003d\u0027\u0027, headers\u003dNone, comment\u003dNone, **kw):"},{"line_number":49,"context_line":"    \"\"\"Like pecan.abort, but make sure detail is a string.\"\"\""},{"line_number":50,"context_line":"    if status_code \u003d\u003d 404 and not detail:"},{"line_number":51,"context_line":"        raise RuntimeError(\"http code 404 must have \u0027detail\u0027 set\")"},{"line_number":52,"context_line":"    return pecan.abort(status_code, six.text_type(detail),"},{"line_number":53,"context_line":"                       headers, comment, **kw)"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a2fa921_c6bb830d","line":51,"updated":"2015-10-06 13:04:53.000000000","message":"this is kind of strange. this seems only useful to developers but we\u0027re raising this like it\u0027s a data error or understandable to a user.\n\nthis is probably better as a docstring or we have another abort404 function.","commit_id":"b0373dde82cb2ba88910fcaccd345b9d2350fe8c"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"49e1ba7d544b92b027c636324209d7c55ef18f4d","unresolved":false,"context_lines":[{"line_number":48,"context_line":"def abort(status_code, detail\u003d\u0027\u0027, headers\u003dNone, comment\u003dNone, **kw):"},{"line_number":49,"context_line":"    \"\"\"Like pecan.abort, but make sure detail is a string.\"\"\""},{"line_number":50,"context_line":"    if status_code \u003d\u003d 404 and not detail:"},{"line_number":51,"context_line":"        raise RuntimeError(\"http code 404 must have \u0027detail\u0027 set\")"},{"line_number":52,"context_line":"    return pecan.abort(status_code, six.text_type(detail),"},{"line_number":53,"context_line":"                       headers, comment, **kw)"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a2fa921_261b301d","line":51,"in_reply_to":"7a2fa921_c6bb830d","updated":"2015-10-07 07:44:09.000000000","message":"I have chossen to raise RuntimeError to return a 500, that strongly ensure that we didn\u0027t miss it. And even we miss it (because we didn\u0027t write the test correctly), this will enforce us to fix it quickly :p\n\nabort404 is a bit less strong, but this is a good alternative and will help us for reviewing.","commit_id":"b0373dde82cb2ba88910fcaccd345b9d2350fe8c"}]}