)]}'
{"gnocchi/archive_policy.py":[{"author":{"_account_id":5164,"name":"jsimms","email":"justin.simms@gmail.com","username":"jsimms"},"change_message_id":"663d2bade3cf6291408db8e978ea3fdaed3149a0","unresolved":false,"context_lines":[{"line_number":60,"context_line":"                raise ValueError("},{"line_number":61,"context_line":"                    \"Unable to understand policy definition %s\" % d)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        granularities \u003d set(d.granularity for d in self.definition)"},{"line_number":64,"context_line":"        if len(granularities) !\u003d len(self.definition):"},{"line_number":65,"context_line":"            raise ValueError("},{"line_number":66,"context_line":"                \"Several archive policies have the same granularity\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a29b11f_dce6e5e7","line":63,"updated":"2015-10-27 05:19:10.000000000","message":"Should a check be done to ensure that the granularity for a definition has a valid value, since 0 seems to be a possible value due to the calculation of the granularity when no value is supplied during construction of an ArchivePolicyItem. I am thinking specifically of line 151 with a supplied timespan of 0.","commit_id":"92703cfb2fd117b2eb66da4291903d37b8e0b910"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"f10c21b604dfbddf50554aca08d31710c5f3cc44","unresolved":false,"context_lines":[{"line_number":60,"context_line":"                raise ValueError("},{"line_number":61,"context_line":"                    \"Unable to understand policy definition %s\" % d)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        granularities \u003d set(d.granularity for d in self.definition)"},{"line_number":64,"context_line":"        if len(granularities) !\u003d len(self.definition):"},{"line_number":65,"context_line":"            raise ValueError("},{"line_number":66,"context_line":"                \"Several archive policies have the same granularity\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a26ad4f_a273e94c","line":63,"in_reply_to":"3a29b11f_dce6e5e7","updated":"2015-10-28 01:49:44.000000000","message":"That\u0027s a good point, I\u0027ll add that in a subsequent patch.","commit_id":"92703cfb2fd117b2eb66da4291903d37b8e0b910"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"e99ed65f932cd21a6fa332a37f5dd76b45a2068d","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        granularities \u003d set(d.granularity for d in self.definition)"},{"line_number":64,"context_line":"        if len(granularities) !\u003d len(self.definition):"},{"line_number":65,"context_line":"            raise ValueError("},{"line_number":66,"context_line":"                \"Several archive policies have the same granularity\")"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        if aggregation_methods is None:"},{"line_number":69,"context_line":"            self.aggregation_methods \u003d self.DEFAULT_AGGREGATION_METHODS"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a26ad4f_0dbda9b6","line":66,"updated":"2015-11-02 14:53:28.000000000","message":"I\u0027m not sure how much it matters (I wouldn\u0027t block on it) but \"several\" is a bit misleading here. I think perhaps you want \"More than one archive policy uses granularity %s\"?","commit_id":"92703cfb2fd117b2eb66da4291903d37b8e0b910"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"8496032ab7b55c8457f7d13eae6b698eda0a38e9","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        granularities \u003d set(d.granularity for d in self.definition)"},{"line_number":64,"context_line":"        if len(granularities) !\u003d len(self.definition):"},{"line_number":65,"context_line":"            raise ValueError("},{"line_number":66,"context_line":"                \"Several archive policies have the same granularity\")"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        if aggregation_methods is None:"},{"line_number":69,"context_line":"            self.aggregation_methods \u003d self.DEFAULT_AGGREGATION_METHODS"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a26ad4f_70d0b21f","line":66,"in_reply_to":"1a26ad4f_0dbda9b6","updated":"2015-11-02 15:10:50.000000000","message":"Done","commit_id":"92703cfb2fd117b2eb66da4291903d37b8e0b910"}]}
