)]}'
{"gnocchi/service.py":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"5ade2d6a84ab466be016be48f37fc3aca33e0d10","unresolved":false,"context_lines":[{"line_number":28,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"def prepare_service(args\u003dNone, conf\u003dNone, test_opts\u003dNone):"},{"line_number":32,"context_line":"    if conf is None:"},{"line_number":33,"context_line":"        conf \u003d cfg.ConfigOpts()"},{"line_number":34,"context_line":"    # FIXME(jd) Use the pkg_entry info to register the options of these libs"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_6a6ba2b7","line":31,"updated":"2015-12-22 11:15:35.000000000","message":"I don\u0027t like the name test_opts TBH. I was fine with default_opts, just add default_config_files too, or load_default_config_files\u003dTrue.","commit_id":"a0c608cf48034418487101ab283e82f567d4371c"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"0d557bce4461f24385977d282708d90bdee1ad63","unresolved":false,"context_lines":[{"line_number":28,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"def prepare_service(args\u003dNone, conf\u003dNone, test_opts\u003dNone):"},{"line_number":32,"context_line":"    if conf is None:"},{"line_number":33,"context_line":"        conf \u003d cfg.ConfigOpts()"},{"line_number":34,"context_line":"    # FIXME(jd) Use the pkg_entry info to register the options of these libs"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_7b24d20b","line":31,"in_reply_to":"3a7e1126_6a6ba2b7","updated":"2015-12-22 12:36:53.000000000","message":"sure. default_opts is kind of misleading because it\u0027s not something that would ever play out in real life but not a big deal.","commit_id":"a0c608cf48034418487101ab283e82f567d4371c"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"007e436f7ff30e61e76dd7897375f0a1a72bb49b","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        conf.set_default(opt, value, group)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    conf(args, project\u003d\u0027gnocchi\u0027, validate_default_values\u003dTrue,"},{"line_number":61,"context_line":"         default_config_files\u003dNone if default_opts is None else [])"},{"line_number":62,"context_line":"    log.setup(conf, \u0027gnocchi\u0027)"},{"line_number":63,"context_line":"    conf.log_opt_values(LOG, logging.DEBUG)"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a7e1126_9624f35f","line":61,"updated":"2015-12-22 12:50:09.000000000","message":"Actually my suggestion was to just keep the name, but having another option to control file; setting default options does not imply you don\u0027t want to not load the default config files.\n\nI\u0027m just not ecstatic about having \"test code\" in the source code of the project. It\u0027s ok to use the API provided by the project to set-up things, but having some kind of \"test mode\" in the main source code is a terrible practice IMHO. That\u0027s why I didn\u0027t want to have that \"test_opts\"in the first place.","commit_id":"43052f0f3ae6723ee5922fdc6310ee25a689495d"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"2be271e8331d56510708ec82778bd1e306465af4","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        conf.set_default(opt, value, group)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    conf(args, project\u003d\u0027gnocchi\u0027, validate_default_values\u003dTrue,"},{"line_number":61,"context_line":"         default_config_files\u003dNone if default_opts is None else [])"},{"line_number":62,"context_line":"    log.setup(conf, \u0027gnocchi\u0027)"},{"line_number":63,"context_line":"    conf.log_opt_values(LOG, logging.DEBUG)"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a7e1126_16056312","line":61,"in_reply_to":"3a7e1126_9624f35f","updated":"2015-12-22 13:04:24.000000000","message":"default_opts is already test code... the fact that you\u0027re overriding default means it\u0027s not a default anymore which is why i changed the variable name to begin with.\n\ni\u0027ll come up with a bigger change.","commit_id":"43052f0f3ae6723ee5922fdc6310ee25a689495d"}],"gnocchi/tests/base.py":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"589713cb2d0097e0e41a7b9cf9dde9be26fcd919","unresolved":false,"context_lines":[{"line_number":339,"context_line":"    def setUp(self):"},{"line_number":340,"context_line":"        super(TestCase, self).setUp()"},{"line_number":341,"context_line":"        conf \u003d cfg.ConfigOpts()"},{"line_number":342,"context_line":"        conf.register_opts(indexer.OPTS, \u0027indexer\u0027)"},{"line_number":343,"context_line":"        conf.set_default(\u0027url\u0027,"},{"line_number":344,"context_line":"                         os.environ.get(\"GNOCCHI_TEST_INDEXER_URL\", \"null://\"),"},{"line_number":345,"context_line":"                         \u0027indexer\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a7b0d38_ee99df20","line":342,"updated":"2015-12-22 15:16:08.000000000","message":"This is exactly the kind of thing the code was trying to avoid :[","commit_id":"72f5156fa29c9d5d4894f99a2b2ff32bbc513b12"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"75760c5f11018eb97e2b2574147260d82d5cc299","unresolved":false,"context_lines":[{"line_number":339,"context_line":"    def setUp(self):"},{"line_number":340,"context_line":"        super(TestCase, self).setUp()"},{"line_number":341,"context_line":"        conf \u003d cfg.ConfigOpts()"},{"line_number":342,"context_line":"        conf.register_opts(indexer.OPTS, \u0027indexer\u0027)"},{"line_number":343,"context_line":"        conf.set_default(\u0027url\u0027,"},{"line_number":344,"context_line":"                         os.environ.get(\"GNOCCHI_TEST_INDEXER_URL\", \"null://\"),"},{"line_number":345,"context_line":"                         \u0027indexer\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a7b0d38_51dd346f","line":342,"in_reply_to":"1a7b0d38_ee99df20","updated":"2015-12-22 15:20:41.000000000","message":"this keeps all the test stuff in the test code. i don\u0027t understand what the issue is.","commit_id":"72f5156fa29c9d5d4894f99a2b2ff32bbc513b12"}]}