)]}'
{"gnocchi/tests/test_indexer.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"d05f627ed6ae7b96859e7c11524422ba2ab0efb0","unresolved":false,"context_lines":[{"line_number":520,"context_line":"        # It can be called twice"},{"line_number":521,"context_line":"        try:"},{"line_number":522,"context_line":"            self.index.delete_metric(e1)"},{"line_number":523,"context_line":"        except indexer.NoSuchMetric:"},{"line_number":524,"context_line":"            # It\u0027s possible that the metric has been expunged by another"},{"line_number":525,"context_line":"            # parallel test. No worry."},{"line_number":526,"context_line":"            pass"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_a15fbb3f","line":523,"updated":"2016-01-11 17:53:45.000000000","message":"i don\u0027t get it. it doesn\u0027t fail when we delete it twice, why would it fail if we delete it more than twice?","commit_id":"5af5f7acd19d2df5c7d38df81b838583ae9e77e0"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"7b02cd855da2bef946f0c43954510afa85d1ebbe","unresolved":false,"context_lines":[{"line_number":520,"context_line":"        # It can be called twice"},{"line_number":521,"context_line":"        try:"},{"line_number":522,"context_line":"            self.index.delete_metric(e1)"},{"line_number":523,"context_line":"        except indexer.NoSuchMetric:"},{"line_number":524,"context_line":"            # It\u0027s possible that the metric has been expunged by another"},{"line_number":525,"context_line":"            # parallel test. No worry."},{"line_number":526,"context_line":"            pass"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_9f2692cc","line":523,"in_reply_to":"fa69d971_0437b54d","updated":"2016-01-11 18:35:40.000000000","message":"doesn\u0027t it make this delete_metric twice test less useful then? whether delete_metric allows us to delete multiple times (before expunge) or not, error will be caught and hidden.","commit_id":"5af5f7acd19d2df5c7d38df81b838583ae9e77e0"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"382343cf763db8aa32f4379521c0a39f46c5c99a","unresolved":false,"context_lines":[{"line_number":520,"context_line":"        # It can be called twice"},{"line_number":521,"context_line":"        try:"},{"line_number":522,"context_line":"            self.index.delete_metric(e1)"},{"line_number":523,"context_line":"        except indexer.NoSuchMetric:"},{"line_number":524,"context_line":"            # It\u0027s possible that the metric has been expunged by another"},{"line_number":525,"context_line":"            # parallel test. No worry."},{"line_number":526,"context_line":"            pass"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_1d0575c1","line":523,"in_reply_to":"fa69d971_9f2692cc","updated":"2016-01-12 08:23:42.000000000","message":"Good question. I could delete it for sure, but I like the fact that we just test for it to have one behaviour (ok) or the other (raise a particular exception). It does not bother me per say in this context. But I could live with this line deleted if it bothers you.","commit_id":"5af5f7acd19d2df5c7d38df81b838583ae9e77e0"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"3f19d517bd4a1a97784fb3fd48aadefd3fa0656e","unresolved":false,"context_lines":[{"line_number":520,"context_line":"        # It can be called twice"},{"line_number":521,"context_line":"        try:"},{"line_number":522,"context_line":"            self.index.delete_metric(e1)"},{"line_number":523,"context_line":"        except indexer.NoSuchMetric:"},{"line_number":524,"context_line":"            # It\u0027s possible that the metric has been expunged by another"},{"line_number":525,"context_line":"            # parallel test. No worry."},{"line_number":526,"context_line":"            pass"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_0437b54d","line":523,"in_reply_to":"fa69d971_a15fbb3f","updated":"2016-01-11 18:07:34.000000000","message":"it fails when we delete twice, sometimes, because it\u0027s possible it has been expunged. That\u0027s what is written. What is unclear? :(","commit_id":"5af5f7acd19d2df5c7d38df81b838583ae9e77e0"}]}
