)]}'
{"gnocchi/storage/file.py":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"b57af3c4771ca88fa93290a811756a7ef95d2079","unresolved":false,"context_lines":[{"line_number":132,"context_line":"                    if e.errno !\u003d errno.EEXIST:"},{"line_number":133,"context_line":"                        raise"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    def _build_report(self, details):"},{"line_number":136,"context_line":"        metric_details \u003d {}"},{"line_number":137,"context_line":"        for metric in os.listdir(self.measure_path):"},{"line_number":138,"context_line":"            metric_details[metric] \u003d ("}],"source_content_type":"text/x-python","patch_set":1,"id":"1a54edaf_fd3bc79a","line":135,"updated":"2016-02-13 10:40:59.000000000","message":"no need to check details?","commit_id":"d723ea44d2c5a1e89f11853df959f3e024b2b062"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"ea68074b4da0a9839e07c50d99f56dd5e913073e","unresolved":false,"context_lines":[{"line_number":132,"context_line":"                    if e.errno !\u003d errno.EEXIST:"},{"line_number":133,"context_line":"                        raise"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    def _build_report(self, details):"},{"line_number":136,"context_line":"        metric_details \u003d {}"},{"line_number":137,"context_line":"        for metric in os.listdir(self.measure_path):"},{"line_number":138,"context_line":"            metric_details[metric] \u003d ("}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_86e3f532","line":135,"in_reply_to":"1a54edaf_fd3bc79a","updated":"2016-02-16 13:02:41.000000000","message":"i didn\u0027t check it because i think the only way to actually get summary is to build entire details.\n\ni do check it below and return empty if not enabled.","commit_id":"d723ea44d2c5a1e89f11853df959f3e024b2b062"}],"gnocchi/storage/swift.py":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"5b8299a44a21e60cd789a0010d84310c08a5b018","unresolved":false,"context_lines":[{"line_number":110,"context_line":"                                                  full_listing\u003dTrue)"},{"line_number":111,"context_line":"        metrics \u003d len(files)"},{"line_number":112,"context_line":"        measures \u003d headers.get(\u0027x-container-object-count\u0027)"},{"line_number":113,"context_line":"        metric_details \u003d {}"},{"line_number":114,"context_line":"        if details:"},{"line_number":115,"context_line":"            headers, files \u003d self.swift.get_container(self.MEASURE_PREFIX,"},{"line_number":116,"context_line":"                                                      full_listing\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_2a3c5fc7","line":113,"updated":"2016-02-16 16:14:38.000000000","message":"defaultdict","commit_id":"d723ea44d2c5a1e89f11853df959f3e024b2b062"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"04388e4814c3a83b127fe38af329c5f251e56bd7","unresolved":false,"context_lines":[{"line_number":110,"context_line":"                                                  full_listing\u003dTrue)"},{"line_number":111,"context_line":"        metrics \u003d len(files)"},{"line_number":112,"context_line":"        measures \u003d headers.get(\u0027x-container-object-count\u0027)"},{"line_number":113,"context_line":"        metric_details \u003d {}"},{"line_number":114,"context_line":"        if details:"},{"line_number":115,"context_line":"            headers, files \u003d self.swift.get_container(self.MEASURE_PREFIX,"},{"line_number":116,"context_line":"                                                      full_listing\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_582c0f02","line":113,"in_reply_to":"dae33548_2a3c5fc7","updated":"2016-02-16 21:37:33.000000000","message":"Done","commit_id":"d723ea44d2c5a1e89f11853df959f3e024b2b062"}],"gnocchi/tests/test_storage.py":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"b57af3c4771ca88fa93290a811756a7ef95d2079","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        self.assertIn(\u0027summary\u0027, report)"},{"line_number":100,"context_line":"        self.assertIn(\u0027metrics\u0027, report[\u0027summary\u0027])"},{"line_number":101,"context_line":"        self.assertIn(\u0027measures\u0027, report[\u0027summary\u0027])"},{"line_number":102,"context_line":"        self.assertIn(\u0027details\u0027, report)"},{"line_number":103,"context_line":"        self.assertEqual({}, report[\u0027details\u0027])"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    def test_add_measures_big(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a54edaf_7d48372e","line":102,"updated":"2016-02-13 10:40:59.000000000","message":"weird to have details if you don\u0027t want details. And I think the test does not cover it well since in the file driver you fill details unconditionnaly…","commit_id":"d723ea44d2c5a1e89f11853df959f3e024b2b062"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"ea68074b4da0a9839e07c50d99f56dd5e913073e","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        self.assertIn(\u0027summary\u0027, report)"},{"line_number":100,"context_line":"        self.assertIn(\u0027metrics\u0027, report[\u0027summary\u0027])"},{"line_number":101,"context_line":"        self.assertIn(\u0027measures\u0027, report[\u0027summary\u0027])"},{"line_number":102,"context_line":"        self.assertIn(\u0027details\u0027, report)"},{"line_number":103,"context_line":"        self.assertEqual({}, report[\u0027details\u0027])"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    def test_add_measures_big(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_a66d599a","line":102,"in_reply_to":"1a54edaf_7d48372e","updated":"2016-02-16 13:02:41.000000000","message":"i do actually check in file driver that if details is not True, we return empty dict.\n\ni kept details in to have consistent schema. i can remove if we want.\n\nthe main question is, are we ok with changing default to just include summary and disable details?","commit_id":"d723ea44d2c5a1e89f11853df959f3e024b2b062"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"5b8299a44a21e60cd789a0010d84310c08a5b018","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        self.assertIn(\u0027summary\u0027, report)"},{"line_number":100,"context_line":"        self.assertIn(\u0027metrics\u0027, report[\u0027summary\u0027])"},{"line_number":101,"context_line":"        self.assertIn(\u0027measures\u0027, report[\u0027summary\u0027])"},{"line_number":102,"context_line":"        self.assertIn(\u0027details\u0027, report)"},{"line_number":103,"context_line":"        self.assertEqual({}, report[\u0027details\u0027])"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    def test_add_measures_big(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_ea6f17c3","line":102,"in_reply_to":"dae33548_a66d599a","updated":"2016-02-16 16:14:38.000000000","message":"Yeah I don\u0027t like the empty dict approach. You can\u0027t make the difference between a bug in the implementation or if it\u0027s what you requested.","commit_id":"d723ea44d2c5a1e89f11853df959f3e024b2b062"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"04388e4814c3a83b127fe38af329c5f251e56bd7","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        self.assertIn(\u0027summary\u0027, report)"},{"line_number":100,"context_line":"        self.assertIn(\u0027metrics\u0027, report[\u0027summary\u0027])"},{"line_number":101,"context_line":"        self.assertIn(\u0027measures\u0027, report[\u0027summary\u0027])"},{"line_number":102,"context_line":"        self.assertIn(\u0027details\u0027, report)"},{"line_number":103,"context_line":"        self.assertEqual({}, report[\u0027details\u0027])"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    def test_add_measures_big(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_d8f93f82","line":102,"in_reply_to":"dae33548_ea6f17c3","updated":"2016-02-16 21:37:33.000000000","message":"Done","commit_id":"d723ea44d2c5a1e89f11853df959f3e024b2b062"}]}