)]}'
{"devstack/plugin.sh":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"64cce425ee64238269d3975e75af519aa642e267","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    if is_service_enabled ceph; then"},{"line_number":72,"context_line":"        # Old ceph setup"},{"line_number":73,"context_line":"        return 0"},{"line_number":74,"context_line":"    elif type is_ceph_enabled_for_service \u003e/dev/null 2\u003e\u00261; then"},{"line_number":75,"context_line":"        # New devstack-plugin-ceph"},{"line_number":76,"context_line":"        return 0"},{"line_number":77,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":1,"id":"9a061dce_06d104ce","line":74,"range":{"start_line":74,"start_character":9,"end_line":74,"end_character":41},"updated":"2016-04-04 09:42:10.000000000","message":"Are not you supposed to also call it? Just asking.","commit_id":"5153164ade5a1197dd77c2cddeea409cf438194b"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"cae995f3b36d92ad3eb24531c9fc536bcbc39465","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    if is_service_enabled ceph; then"},{"line_number":72,"context_line":"        # Old ceph setup"},{"line_number":73,"context_line":"        return 0"},{"line_number":74,"context_line":"    elif type is_ceph_enabled_for_service \u003e/dev/null 2\u003e\u00261; then"},{"line_number":75,"context_line":"        # New devstack-plugin-ceph"},{"line_number":76,"context_line":"        return 0"},{"line_number":77,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":1,"id":"9a061dce_4f82e301","line":74,"range":{"start_line":74,"start_character":9,"end_line":74,"end_character":41},"in_reply_to":"9a061dce_06d104ce","updated":"2016-04-04 13:27:46.000000000","message":"We don\u0027t really need to call it. Nova/Cinder/Glance/... are configured by the Ceph plugin when ENABLE_CEPH_\u003cPROJECT\u003e\u003dTrue is set.\n\n\"is_ceph_enabled_for_service nova\" is a helper to check that ENABLE_CEPH_NOVA\u003dTrue\n\nBut for us we already have GNOCCHI_STORAGE_DRIVER\u003dceph to use Ceph.\nSo I just check that function is_ceph_enabled_for_service exists, that means that user have enable the devstack plugin and we can use Ceph.\n\nI have make the choice to continue to configure Gnocchi ourself instead of having the Ceph devstack plugin that changes the Gnocchi configuration file, like other project does.","commit_id":"5153164ade5a1197dd77c2cddeea409cf438194b"}]}