)]}'
{"gnocchi/indexer/alembic/versions/ed9c6ddc5c35_fix_host_foreign_key.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"79aed1b721092dc7d1128a069196cad99358716b","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                       \"host_history\", type_\u003d\"foreignkey\")"},{"line_number":49,"context_line":"    op.create_foreign_key(\"fk_host_id_resource_id\", \"host\", \"resource\","},{"line_number":50,"context_line":"                          [\"id\"], [\"id\"], ondelete\u003d\"CASCADE\")"},{"line_number":51,"context_line":"    op.create_foreign_key(\"fk_host_history_resource_history_revision\","},{"line_number":52,"context_line":"                          \"host_history\", \"resource_history\","},{"line_number":53,"context_line":"                          [\"revision\"], [\"revision\"], ondelete\u003d\"CASCADE\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_02b522ed","line":51,"updated":"2016-04-18 15:11:40.000000000","message":"this is different than other FK.\n\nshould be fk_host_history_revision_resource_history_revision","commit_id":"255abf3489475c7e815b802d580af1f1c8596c15"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"f18102e0fbdc35cafba47892a6e8e736adfe6753","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                       \"host_history\", type_\u003d\"foreignkey\")"},{"line_number":49,"context_line":"    op.create_foreign_key(\"fk_host_id_resource_id\", \"host\", \"resource\","},{"line_number":50,"context_line":"                          [\"id\"], [\"id\"], ondelete\u003d\"CASCADE\")"},{"line_number":51,"context_line":"    op.create_foreign_key(\"fk_host_history_resource_history_revision\","},{"line_number":52,"context_line":"                          \"host_history\", \"resource_history\","},{"line_number":53,"context_line":"                          [\"revision\"], [\"revision\"], ondelete\u003d\"CASCADE\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_ec0578c2","line":51,"in_reply_to":"1a122d0e_02b522ed","updated":"2016-04-18 16:16:58.000000000","message":"You put your thumb on another bug :( \n\nThe one in sqlalchemy_base.py have \u0027_revision_\u0027 in while the one in the initial mysql migration script doesn\u0027t have.\n\nWe put a big trust into the oslo.db migration tests, but it doesn\u0027t catch foreignkey issue :(\n\nSo I keep them here with the same bug as other, I fix the name for all tables in next review:","commit_id":"255abf3489475c7e815b802d580af1f1c8596c15"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"d6094327e07a5068990cf7039b834d0122a9a6a9","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                       \"host_history\", type_\u003d\"foreignkey\")"},{"line_number":49,"context_line":"    op.create_foreign_key(\"fk_host_id_resource_id\", \"host\", \"resource\","},{"line_number":50,"context_line":"                          [\"id\"], [\"id\"], ondelete\u003d\"CASCADE\")"},{"line_number":51,"context_line":"    op.create_foreign_key(\"fk_host_history_resource_history_revision\","},{"line_number":52,"context_line":"                          \"host_history\", \"resource_history\","},{"line_number":53,"context_line":"                          [\"revision\"], [\"revision\"], ondelete\u003d\"CASCADE\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_4acd6c5c","line":51,"in_reply_to":"1a122d0e_4a0f2c2e","updated":"2016-04-18 16:51:23.000000000","message":"That because your database have not been created with alembic. The bug occurs only if the database is created by alembic. (But perhaps this was never possible to create the database with alembic, the first alembic script is perhaps just a dump script for testing).\n\nI hope my grenade jobs will be merged soon, that will help to not reproduce this in the future.","commit_id":"255abf3489475c7e815b802d580af1f1c8596c15"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"38cfca93478b720ecea8f88f4596b554492fac7b","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                       \"host_history\", type_\u003d\"foreignkey\")"},{"line_number":49,"context_line":"    op.create_foreign_key(\"fk_host_id_resource_id\", \"host\", \"resource\","},{"line_number":50,"context_line":"                          [\"id\"], [\"id\"], ondelete\u003d\"CASCADE\")"},{"line_number":51,"context_line":"    op.create_foreign_key(\"fk_host_history_resource_history_revision\","},{"line_number":52,"context_line":"                          \"host_history\", \"resource_history\","},{"line_number":53,"context_line":"                          [\"revision\"], [\"revision\"], ondelete\u003d\"CASCADE\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_4a0f2c2e","line":51,"in_reply_to":"1a122d0e_ec0578c2","updated":"2016-04-18 16:36:36.000000000","message":"i have \"fk_\u003ctype\u003e_history_revision_resource_history_revision\" for all tables currently... except for host table. if we don\u0027t sync this up with the others, i believe the next patch will not patch this key or all the other keys","commit_id":"255abf3489475c7e815b802d580af1f1c8596c15"}]}