)]}'
{"gnocchi/indexer/alembic/versions/c62df18bf4ee_add_unit_column_for_metric.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"6d8fc08cf1554c40bf1376d44f168884acae9e3d","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"def upgrade():"},{"line_number":36,"context_line":"    op.add_column(\u0027metric\u0027, sa.Column(\u0027unit\u0027,"},{"line_number":37,"context_line":"                                      sa.String(length\u003d255),"},{"line_number":38,"context_line":"                                      nullable\u003dTrue))"}],"source_content_type":"text/x-python","patch_set":6,"id":"dab17558_a4e661ad","line":37,"updated":"2016-05-17 13:00:05.000000000","message":"can we shrink this. to be honest, 255 seems ridiculously long for a unit... maybe 32?","commit_id":"134fa1bad577e3c764b7fa7a4d5e49528a331cf9"},{"author":{"_account_id":8358,"name":"zhangguoqing","email":"zhang.guoqing@99cloud.net","username":"zhangguoqing"},"change_message_id":"dead8602dd7cbc4fb02dc2543ea427de688ef248","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"def upgrade():"},{"line_number":36,"context_line":"    op.add_column(\u0027metric\u0027, sa.Column(\u0027unit\u0027,"},{"line_number":37,"context_line":"                                      sa.String(length\u003d255),"},{"line_number":38,"context_line":"                                      nullable\u003dTrue))"}],"source_content_type":"text/x-python","patch_set":6,"id":"bab6814e_4fb8c9c8","line":37,"in_reply_to":"dab17558_a4e661ad","updated":"2016-05-20 01:37:54.000000000","message":"FYI. unit \u003d Column(String(255))\nhttps://github.com/openstack/ceilometer/blob/master/ceilometer/storage/sqlalchemy/models.py#L161","commit_id":"134fa1bad577e3c764b7fa7a4d5e49528a331cf9"}],"gnocchi/indexer/sqlalchemy.py":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"7c072ca712b8d53abb7942977400648e2449b575","unresolved":false,"context_lines":[{"line_number":536,"context_line":"                if update \u003d\u003d 0:"},{"line_number":537,"context_line":"                    raise indexer.NoSuchMetric(value)"},{"line_number":538,"context_line":"            else:"},{"line_number":539,"context_line":"                unit \u003d value.get(\u0027unit\u0027, None)"},{"line_number":540,"context_line":"                ap_name \u003d value[\u0027archive_policy_name\u0027]"},{"line_number":541,"context_line":"                m \u003d Metric(id\u003duuid.uuid4(),"},{"line_number":542,"context_line":"                           created_by_user_id\u003dr.created_by_user_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_e1f2919a","line":539,"updated":"2016-05-04 13:25:36.000000000","message":"nit, no need for \", None\", it\u0027s the default.","commit_id":"2e2c438d3c8a4e9f5a8c629a918b540699e59f4f"},{"author":{"_account_id":8358,"name":"zhangguoqing","email":"zhang.guoqing@99cloud.net","username":"zhangguoqing"},"change_message_id":"3118f7d55c31ccf5d9708a0a69bce7f6b973989c","unresolved":false,"context_lines":[{"line_number":370,"context_line":""},{"line_number":371,"context_line":"    def create_metric(self, id, created_by_user_id, created_by_project_id,"},{"line_number":372,"context_line":"                      archive_policy_name,"},{"line_number":373,"context_line":"                      name\u003dNone, unit\u003d\u0027\u0027, resource_id\u003dNone):"},{"line_number":374,"context_line":"        m \u003d Metric(id\u003did,"},{"line_number":375,"context_line":"                   created_by_user_id\u003dcreated_by_user_id,"},{"line_number":376,"context_line":"                   created_by_project_id\u003dcreated_by_project_id,"}],"source_content_type":"text/x-python","patch_set":5,"id":"dab17558_e19a766d","line":373,"range":{"start_line":373,"start_character":33,"end_line":373,"end_character":40},"updated":"2016-05-10 05:38:42.000000000","message":"mark!","commit_id":"f20c67305fe4fa5550a3a5f5fc2cf3a8cf27332b"},{"author":{"_account_id":8358,"name":"zhangguoqing","email":"zhang.guoqing@99cloud.net","username":"zhangguoqing"},"change_message_id":"3118f7d55c31ccf5d9708a0a69bce7f6b973989c","unresolved":false,"context_lines":[{"line_number":536,"context_line":"                if update \u003d\u003d 0:"},{"line_number":537,"context_line":"                    raise indexer.NoSuchMetric(value)"},{"line_number":538,"context_line":"            else:"},{"line_number":539,"context_line":"                unit \u003d value.get(\u0027unit\u0027, \u0027\u0027)"},{"line_number":540,"context_line":"                ap_name \u003d value[\u0027archive_policy_name\u0027]"},{"line_number":541,"context_line":"                m \u003d Metric(id\u003duuid.uuid4(),"},{"line_number":542,"context_line":"                           created_by_user_id\u003dr.created_by_user_id,"}],"source_content_type":"text/x-python","patch_set":5,"id":"dab17558_0175fa30","line":539,"range":{"start_line":539,"start_character":16,"end_line":539,"end_character":44},"updated":"2016-05-10 05:38:42.000000000","message":"mark!","commit_id":"f20c67305fe4fa5550a3a5f5fc2cf3a8cf27332b"}],"gnocchi/rest/__init__.py":[{"author":{"_account_id":8358,"name":"zhangguoqing","email":"zhang.guoqing@99cloud.net","username":"zhangguoqing"},"change_message_id":"3118f7d55c31ccf5d9708a0a69bce7f6b973989c","unresolved":false,"context_lines":[{"line_number":622,"context_line":"            \"project_id\": definition.get(\u0027project_id\u0027),"},{"line_number":623,"context_line":"            \"archive_policy_name\": archive_policy_name,"},{"line_number":624,"context_line":"            \"name\": name,"},{"line_number":625,"context_line":"            \"unit\": definition.get(\u0027unit\u0027),"},{"line_number":626,"context_line":"        })"},{"line_number":627,"context_line":""},{"line_number":628,"context_line":"        return definition"}],"source_content_type":"text/x-python","patch_set":5,"id":"dab17558_6185e605","line":625,"range":{"start_line":625,"start_character":12,"end_line":625,"end_character":43},"updated":"2016-05-10 05:38:42.000000000","message":"mark!\n\"unit\": definition.get(\u0027unit\u0027, \u0027\u0027)","commit_id":"f20c67305fe4fa5550a3a5f5fc2cf3a8cf27332b"}],"gnocchi/tests/test_rest.py":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"32acbdc4c5d06fda405fdb21331a093c44f8d880","unresolved":false,"context_lines":[{"line_number":253,"context_line":""},{"line_number":254,"context_line":"class MetricTest(RestTest):"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"    def test_post_metric_with_over_length_unit(self):"},{"line_number":257,"context_line":"        result \u003d self.app.post_json("},{"line_number":258,"context_line":"            \"/v1/metric\","},{"line_number":259,"context_line":"            params\u003d{\"archive_policy_name\": \"medium\","}],"source_content_type":"text/x-python","patch_set":15,"id":"bab6814e_f3b8e32c","line":256,"updated":"2016-05-24 12:54:04.000000000","message":"You can remove this one, Gabbi is enough","commit_id":"68e1895d71c7861952e39d63c848cbe5e06121f8"}]}