)]}'
{"gnocchi/cli.py":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"d8912955dd4de57673a4c2bdc4d321a86878d398","unresolved":false,"context_lines":[{"line_number":163,"context_line":"        try:"},{"line_number":164,"context_line":"            # TODO(gordc): add support to detect other agents to enable"},{"line_number":165,"context_line":"            #              partitioning"},{"line_number":166,"context_line":"            metrics \u003d self.store._list_metric_with_measures_to_process(500, 0)"},{"line_number":167,"context_line":"            if not self.queue.empty():"},{"line_number":168,"context_line":"                # NOTE(gordc): drop metrics we previously process to avoid"},{"line_number":169,"context_line":"                #              handling twice"}],"source_content_type":"text/x-python","patch_set":7,"id":"dada55a8_252160fd","line":166,"range":{"start_line":166,"start_character":12,"end_line":166,"end_character":78},"updated":"2016-07-25 09:12:05.000000000","message":"So this is a layer violation: this is a private method from _carbonara, because it\u0027s tied on how Carbonara based driver work under the hood.\n\nNot saying it\u0027s bad per say – I do like your design – but you need to take that into account… probably unprefix this method (remove the _) and says it\u0027s public… and driver not base on Carbonara (one day maybe) will be able to just return [] always. :) Take also that into account, so this process would just do nothing.","commit_id":"8b22a91fe1a0ab87aa029ca322ccb042cc238f88"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"917f1cf421f206dd01e520209b496aaff26ee301","unresolved":false,"context_lines":[{"line_number":163,"context_line":"        try:"},{"line_number":164,"context_line":"            # TODO(gordc): add support to detect other agents to enable"},{"line_number":165,"context_line":"            #              partitioning"},{"line_number":166,"context_line":"            metrics \u003d self.store._list_metric_with_measures_to_process(500, 0)"},{"line_number":167,"context_line":"            if not self.queue.empty():"},{"line_number":168,"context_line":"                # NOTE(gordc): drop metrics we previously process to avoid"},{"line_number":169,"context_line":"                #              handling twice"}],"source_content_type":"text/x-python","patch_set":7,"id":"dada55a8_cb2e8e41","line":166,"range":{"start_line":166,"start_character":12,"end_line":166,"end_character":78},"in_reply_to":"dada55a8_252160fd","updated":"2016-07-25 12:01:18.000000000","message":"sure, will make it public. is the idea that we would still have metricd running even if we have non-carbonara based driver. i was thinking this entire metricd service would be exclusive to carbonara?","commit_id":"8b22a91fe1a0ab87aa029ca322ccb042cc238f88"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"018ca09fb1d3f57ec60b1f649399dcaeccdc12f4","unresolved":false,"context_lines":[{"line_number":163,"context_line":"        try:"},{"line_number":164,"context_line":"            # TODO(gordc): add support to detect other agents to enable"},{"line_number":165,"context_line":"            #              partitioning"},{"line_number":166,"context_line":"            metrics \u003d self.store._list_metric_with_measures_to_process(500, 0)"},{"line_number":167,"context_line":"            if not self.queue.empty():"},{"line_number":168,"context_line":"                # NOTE(gordc): drop metrics we previously process to avoid"},{"line_number":169,"context_line":"                #              handling twice"}],"source_content_type":"text/x-python","patch_set":7,"id":"dada55a8_0b154648","line":166,"range":{"start_line":166,"start_character":12,"end_line":166,"end_character":78},"in_reply_to":"dada55a8_cb2e8e41","updated":"2016-07-25 12:16:51.000000000","message":"honestly, we don\u0027t know. metricd has nothing carbonara specific (or maybe everything is).\n\nso I assume it\u0027s not carbonara specific until proven otherwise (if it is proven one day)","commit_id":"8b22a91fe1a0ab87aa029ca322ccb042cc238f88"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"d8912955dd4de57673a4c2bdc4d321a86878d398","unresolved":false,"context_lines":[{"line_number":167,"context_line":"            if not self.queue.empty():"},{"line_number":168,"context_line":"                # NOTE(gordc): drop metrics we previously process to avoid"},{"line_number":169,"context_line":"                #              handling twice"},{"line_number":170,"context_line":"                orig \u003d len(metrics)"},{"line_number":171,"context_line":"                metrics \u003d metrics - self.prev_set"},{"line_number":172,"context_line":"                if 500 - (orig - len(metrics)) \u003e 150:"},{"line_number":173,"context_line":"                    LOG.warning(\u0027Large overlap between processing intervals. \u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"dada55a8_65feb8af","line":170,"range":{"start_line":170,"start_character":16,"end_line":170,"end_character":20},"updated":"2016-07-25 09:12:05.000000000","message":"number_of_metrics_to_schedule","commit_id":"8b22a91fe1a0ab87aa029ca322ccb042cc238f88"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"917f1cf421f206dd01e520209b496aaff26ee301","unresolved":false,"context_lines":[{"line_number":167,"context_line":"            if not self.queue.empty():"},{"line_number":168,"context_line":"                # NOTE(gordc): drop metrics we previously process to avoid"},{"line_number":169,"context_line":"                #              handling twice"},{"line_number":170,"context_line":"                orig \u003d len(metrics)"},{"line_number":171,"context_line":"                metrics \u003d metrics - self.prev_set"},{"line_number":172,"context_line":"                if 500 - (orig - len(metrics)) \u003e 150:"},{"line_number":173,"context_line":"                    LOG.warning(\u0027Large overlap between processing intervals. \u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"dada55a8_8bb93618","line":170,"range":{"start_line":170,"start_character":16,"end_line":170,"end_character":20},"in_reply_to":"dada55a8_65feb8af","updated":"2016-07-25 12:01:18.000000000","message":"Done","commit_id":"8b22a91fe1a0ab87aa029ca322ccb042cc238f88"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"d8912955dd4de57673a4c2bdc4d321a86878d398","unresolved":false,"context_lines":[{"line_number":168,"context_line":"                # NOTE(gordc): drop metrics we previously process to avoid"},{"line_number":169,"context_line":"                #              handling twice"},{"line_number":170,"context_line":"                orig \u003d len(metrics)"},{"line_number":171,"context_line":"                metrics \u003d metrics - self.prev_set"},{"line_number":172,"context_line":"                if 500 - (orig - len(metrics)) \u003e 150:"},{"line_number":173,"context_line":"                    LOG.warning(\u0027Large overlap between processing intervals. \u0027"},{"line_number":174,"context_line":"                                \u0027It is recommended to increase the number of \u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"dada55a8_8503ecb7","line":171,"range":{"start_line":171,"start_character":41,"end_line":171,"end_character":49},"updated":"2016-07-25 09:12:05.000000000","message":"previously_scheduled_metrics","commit_id":"8b22a91fe1a0ab87aa029ca322ccb042cc238f88"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"917f1cf421f206dd01e520209b496aaff26ee301","unresolved":false,"context_lines":[{"line_number":168,"context_line":"                # NOTE(gordc): drop metrics we previously process to avoid"},{"line_number":169,"context_line":"                #              handling twice"},{"line_number":170,"context_line":"                orig \u003d len(metrics)"},{"line_number":171,"context_line":"                metrics \u003d metrics - self.prev_set"},{"line_number":172,"context_line":"                if 500 - (orig - len(metrics)) \u003e 150:"},{"line_number":173,"context_line":"                    LOG.warning(\u0027Large overlap between processing intervals. \u0027"},{"line_number":174,"context_line":"                                \u0027It is recommended to increase the number of \u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"dada55a8_abbebafc","line":171,"range":{"start_line":171,"start_character":41,"end_line":171,"end_character":49},"in_reply_to":"dada55a8_8503ecb7","updated":"2016-07-25 12:01:18.000000000","message":"Done","commit_id":"8b22a91fe1a0ab87aa029ca322ccb042cc238f88"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"d8912955dd4de57673a4c2bdc4d321a86878d398","unresolved":false,"context_lines":[{"line_number":169,"context_line":"                #              handling twice"},{"line_number":170,"context_line":"                orig \u003d len(metrics)"},{"line_number":171,"context_line":"                metrics \u003d metrics - self.prev_set"},{"line_number":172,"context_line":"                if 500 - (orig - len(metrics)) \u003e 150:"},{"line_number":173,"context_line":"                    LOG.warning(\u0027Large overlap between processing intervals. \u0027"},{"line_number":174,"context_line":"                                \u0027It is recommended to increase the number of \u0027"},{"line_number":175,"context_line":"                                \u0027workers or to increase processing interval.\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"dada55a8_4541f438","line":172,"range":{"start_line":172,"start_character":16,"end_line":172,"end_character":53},"updated":"2016-07-25 09:12:05.000000000","message":"nit but i\u0027d rather use percentage","commit_id":"8b22a91fe1a0ab87aa029ca322ccb042cc238f88"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"917f1cf421f206dd01e520209b496aaff26ee301","unresolved":false,"context_lines":[{"line_number":169,"context_line":"                #              handling twice"},{"line_number":170,"context_line":"                orig \u003d len(metrics)"},{"line_number":171,"context_line":"                metrics \u003d metrics - self.prev_set"},{"line_number":172,"context_line":"                if 500 - (orig - len(metrics)) \u003e 150:"},{"line_number":173,"context_line":"                    LOG.warning(\u0027Large overlap between processing intervals. \u0027"},{"line_number":174,"context_line":"                                \u0027It is recommended to increase the number of \u0027"},{"line_number":175,"context_line":"                                \u0027workers or to increase processing interval.\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"dada55a8_4bbf3efc","line":172,"range":{"start_line":172,"start_character":16,"end_line":172,"end_character":53},"in_reply_to":"dada55a8_4541f438","updated":"2016-07-25 12:01:18.000000000","message":"Done","commit_id":"8b22a91fe1a0ab87aa029ca322ccb042cc238f88"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"d8912955dd4de57673a4c2bdc4d321a86878d398","unresolved":false,"context_lines":[{"line_number":170,"context_line":"                orig \u003d len(metrics)"},{"line_number":171,"context_line":"                metrics \u003d metrics - self.prev_set"},{"line_number":172,"context_line":"                if 500 - (orig - len(metrics)) \u003e 150:"},{"line_number":173,"context_line":"                    LOG.warning(\u0027Large overlap between processing intervals. \u0027"},{"line_number":174,"context_line":"                                \u0027It is recommended to increase the number of \u0027"},{"line_number":175,"context_line":"                                \u0027workers or to increase processing interval.\u0027)"},{"line_number":176,"context_line":"            for m_id in metrics:"}],"source_content_type":"text/x-python","patch_set":7,"id":"dada55a8_05a53c03","line":173,"range":{"start_line":173,"start_character":33,"end_line":173,"end_character":75},"updated":"2016-07-25 09:12:05.000000000","message":"i don\u0027t think this is very clear\n\ni\u0027m a developer and i did not understand it at first read","commit_id":"8b22a91fe1a0ab87aa029ca322ccb042cc238f88"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"917f1cf421f206dd01e520209b496aaff26ee301","unresolved":false,"context_lines":[{"line_number":170,"context_line":"                orig \u003d len(metrics)"},{"line_number":171,"context_line":"                metrics \u003d metrics - self.prev_set"},{"line_number":172,"context_line":"                if 500 - (orig - len(metrics)) \u003e 150:"},{"line_number":173,"context_line":"                    LOG.warning(\u0027Large overlap between processing intervals. \u0027"},{"line_number":174,"context_line":"                                \u0027It is recommended to increase the number of \u0027"},{"line_number":175,"context_line":"                                \u0027workers or to increase processing interval.\u0027)"},{"line_number":176,"context_line":"            for m_id in metrics:"}],"source_content_type":"text/x-python","patch_set":7,"id":"dada55a8_0bcd46b7","line":173,"range":{"start_line":173,"start_character":33,"end_line":173,"end_character":75},"in_reply_to":"dada55a8_05a53c03","updated":"2016-07-25 12:01:18.000000000","message":"Done","commit_id":"8b22a91fe1a0ab87aa029ca322ccb042cc238f88"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"d8912955dd4de57673a4c2bdc4d321a86878d398","unresolved":false,"context_lines":[{"line_number":176,"context_line":"            for m_id in metrics:"},{"line_number":177,"context_line":"                self.queue.put(m_id)"},{"line_number":178,"context_line":"            self.prev_set \u003d metrics"},{"line_number":179,"context_line":"            LOG.debug(\"Metricd distribution: %d metrics queued.\", len(metrics))"},{"line_number":180,"context_line":"        except Exception:"},{"line_number":181,"context_line":"            LOG.error(\"Unexpected error scheduling metrics for processing\","},{"line_number":182,"context_line":"                      exc_info\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":7,"id":"dada55a8_e57e2869","line":179,"range":{"start_line":179,"start_character":23,"end_line":179,"end_character":44},"updated":"2016-07-25 09:12:05.000000000","message":"we stopped using prefix ;)","commit_id":"8b22a91fe1a0ab87aa029ca322ccb042cc238f88"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"917f1cf421f206dd01e520209b496aaff26ee301","unresolved":false,"context_lines":[{"line_number":176,"context_line":"            for m_id in metrics:"},{"line_number":177,"context_line":"                self.queue.put(m_id)"},{"line_number":178,"context_line":"            self.prev_set \u003d metrics"},{"line_number":179,"context_line":"            LOG.debug(\"Metricd distribution: %d metrics queued.\", len(metrics))"},{"line_number":180,"context_line":"        except Exception:"},{"line_number":181,"context_line":"            LOG.error(\"Unexpected error scheduling metrics for processing\","},{"line_number":182,"context_line":"                      exc_info\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":7,"id":"dada55a8_cbd20e5b","line":179,"range":{"start_line":179,"start_character":23,"end_line":179,"end_character":44},"in_reply_to":"dada55a8_e57e2869","updated":"2016-07-25 12:01:18.000000000","message":"Done","commit_id":"8b22a91fe1a0ab87aa029ca322ccb042cc238f88"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"d8912955dd4de57673a4c2bdc4d321a86878d398","unresolved":false,"context_lines":[{"line_number":211,"context_line":"    def _run_job(self):"},{"line_number":212,"context_line":"        try:"},{"line_number":213,"context_line":"            metrics \u003d []"},{"line_number":214,"context_line":"            while not self.queue.empty() and len(metrics) \u003c self.BLOCK_SIZE:"},{"line_number":215,"context_line":"                metrics.append(self.queue.get())"},{"line_number":216,"context_line":"            if metrics:"},{"line_number":217,"context_line":"                self.store.process_background_tasks(self.index, metrics)"},{"line_number":218,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":7,"id":"dada55a8_659a3870","line":215,"range":{"start_line":214,"start_character":11,"end_line":215,"end_character":48},"updated":"2016-07-25 09:12:05.000000000","message":"There\u0027s a race here: if the queue becomes empty between empty() and get(), then get() will block, possibly for a long time… which will do a huge delay processing the first grabbed metrics.\n\nYou need to call get(block\u003dFalse) up to BLOCK_SIZE time and handle the queue.Empty exception has \"let\u0027s go and process anyway\"","commit_id":"8b22a91fe1a0ab87aa029ca322ccb042cc238f88"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"917f1cf421f206dd01e520209b496aaff26ee301","unresolved":false,"context_lines":[{"line_number":211,"context_line":"    def _run_job(self):"},{"line_number":212,"context_line":"        try:"},{"line_number":213,"context_line":"            metrics \u003d []"},{"line_number":214,"context_line":"            while not self.queue.empty() and len(metrics) \u003c self.BLOCK_SIZE:"},{"line_number":215,"context_line":"                metrics.append(self.queue.get())"},{"line_number":216,"context_line":"            if metrics:"},{"line_number":217,"context_line":"                self.store.process_background_tasks(self.index, metrics)"},{"line_number":218,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":7,"id":"dada55a8_6b72027e","line":215,"range":{"start_line":214,"start_character":11,"end_line":215,"end_character":48},"in_reply_to":"dada55a8_659a3870","updated":"2016-07-25 12:01:18.000000000","message":"Done","commit_id":"8b22a91fe1a0ab87aa029ca322ccb042cc238f88"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"ef2082902a42a748d84b006523e59c22d335a392","unresolved":false,"context_lines":[{"line_number":163,"context_line":"        try:"},{"line_number":164,"context_line":"            # TODO(gordc): add support to detect other agents to enable"},{"line_number":165,"context_line":"            #              partitioning"},{"line_number":166,"context_line":"            metrics \u003d self.store.list_metric_with_measures_to_process(500, 0)"},{"line_number":167,"context_line":"            if metrics and not self.queue.empty():"},{"line_number":168,"context_line":"                # NOTE(gordc): drop metrics we previously process to avoid"},{"line_number":169,"context_line":"                #              handling twice"}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_506054cf","line":166,"range":{"start_line":166,"start_character":70,"end_line":166,"end_character":73},"updated":"2016-07-26 10:32:46.000000000","message":"put that into a class variable","commit_id":"7dc3e09cddbfbbfbee34090e62fc57ad8bf5503f"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"2e22c88313d07fc861b0cdf92675380f4aed454f","unresolved":false,"context_lines":[{"line_number":163,"context_line":"        try:"},{"line_number":164,"context_line":"            # TODO(gordc): add support to detect other agents to enable"},{"line_number":165,"context_line":"            #              partitioning"},{"line_number":166,"context_line":"            metrics \u003d self.store.list_metric_with_measures_to_process(500, 0)"},{"line_number":167,"context_line":"            if metrics and not self.queue.empty():"},{"line_number":168,"context_line":"                # NOTE(gordc): drop metrics we previously process to avoid"},{"line_number":169,"context_line":"                #              handling twice"}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_53533939","line":166,"range":{"start_line":166,"start_character":70,"end_line":166,"end_character":73},"in_reply_to":"dada55a8_506054cf","updated":"2016-07-26 12:29:27.000000000","message":"Done","commit_id":"7dc3e09cddbfbbfbee34090e62fc57ad8bf5503f"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"ef2082902a42a748d84b006523e59c22d335a392","unresolved":false,"context_lines":[{"line_number":169,"context_line":"                #              handling twice"},{"line_number":170,"context_line":"                number_of_scheduled_metrics \u003d len(metrics)"},{"line_number":171,"context_line":"                metrics \u003d metrics - self.previously_scheduled_metrics"},{"line_number":172,"context_line":"                if (number_of_scheduled_metrics - len(metrics)) / 500.0 \u003e 0.3:"},{"line_number":173,"context_line":"                    LOG.warning(\u0027Metric processing lagging scheduling rate. \u0027"},{"line_number":174,"context_line":"                                \u0027It is recommended to increase the number of \u0027"},{"line_number":175,"context_line":"                                \u0027workers or to lengthen processing interval.\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_b07ef067","line":172,"range":{"start_line":172,"start_character":73,"end_line":172,"end_character":77},"updated":"2016-07-26 10:32:46.000000000","message":"class variable too plz","commit_id":"7dc3e09cddbfbbfbee34090e62fc57ad8bf5503f"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"ef2082902a42a748d84b006523e59c22d335a392","unresolved":false,"context_lines":[{"line_number":169,"context_line":"                #              handling twice"},{"line_number":170,"context_line":"                number_of_scheduled_metrics \u003d len(metrics)"},{"line_number":171,"context_line":"                metrics \u003d metrics - self.previously_scheduled_metrics"},{"line_number":172,"context_line":"                if (number_of_scheduled_metrics - len(metrics)) / 500.0 \u003e 0.3:"},{"line_number":173,"context_line":"                    LOG.warning(\u0027Metric processing lagging scheduling rate. \u0027"},{"line_number":174,"context_line":"                                \u0027It is recommended to increase the number of \u0027"},{"line_number":175,"context_line":"                                \u0027workers or to lengthen processing interval.\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_50b7b439","line":172,"range":{"start_line":172,"start_character":66,"end_line":172,"end_character":69},"updated":"2016-07-26 10:32:46.000000000","message":"so you can use is here","commit_id":"7dc3e09cddbfbbfbee34090e62fc57ad8bf5503f"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"2e22c88313d07fc861b0cdf92675380f4aed454f","unresolved":false,"context_lines":[{"line_number":169,"context_line":"                #              handling twice"},{"line_number":170,"context_line":"                number_of_scheduled_metrics \u003d len(metrics)"},{"line_number":171,"context_line":"                metrics \u003d metrics - self.previously_scheduled_metrics"},{"line_number":172,"context_line":"                if (number_of_scheduled_metrics - len(metrics)) / 500.0 \u003e 0.3:"},{"line_number":173,"context_line":"                    LOG.warning(\u0027Metric processing lagging scheduling rate. \u0027"},{"line_number":174,"context_line":"                                \u0027It is recommended to increase the number of \u0027"},{"line_number":175,"context_line":"                                \u0027workers or to lengthen processing interval.\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_135d4147","line":172,"range":{"start_line":172,"start_character":73,"end_line":172,"end_character":77},"in_reply_to":"dada55a8_b07ef067","updated":"2016-07-26 12:29:27.000000000","message":"Done","commit_id":"7dc3e09cddbfbbfbee34090e62fc57ad8bf5503f"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"a7f4bc0432bcd94eaeb59ac17882d74abc107ca6","unresolved":false,"context_lines":[{"line_number":211,"context_line":"    def _run_job(self):"},{"line_number":212,"context_line":"        try:"},{"line_number":213,"context_line":"            metrics \u003d []"},{"line_number":214,"context_line":"            while not self.queue.empty() and len(metrics) \u003c self.BLOCK_SIZE:"},{"line_number":215,"context_line":"                try:"},{"line_number":216,"context_line":"                    metrics.append(self.queue.get(block\u003dFalse))"},{"line_number":217,"context_line":"                except six.moves.queue.Empty:"}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_6d0adf8b","line":214,"range":{"start_line":214,"start_character":18,"end_line":214,"end_character":40},"updated":"2016-07-26 10:28:56.000000000","message":"Remove this check, this is useless now.","commit_id":"7dc3e09cddbfbbfbee34090e62fc57ad8bf5503f"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"2e22c88313d07fc861b0cdf92675380f4aed454f","unresolved":false,"context_lines":[{"line_number":211,"context_line":"    def _run_job(self):"},{"line_number":212,"context_line":"        try:"},{"line_number":213,"context_line":"            metrics \u003d []"},{"line_number":214,"context_line":"            while not self.queue.empty() and len(metrics) \u003c self.BLOCK_SIZE:"},{"line_number":215,"context_line":"                try:"},{"line_number":216,"context_line":"                    metrics.append(self.queue.get(block\u003dFalse))"},{"line_number":217,"context_line":"                except six.moves.queue.Empty:"}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_93501134","line":214,"range":{"start_line":214,"start_character":18,"end_line":214,"end_character":40},"in_reply_to":"dada55a8_6d0adf8b","updated":"2016-07-26 12:29:27.000000000","message":"Done","commit_id":"7dc3e09cddbfbbfbee34090e62fc57ad8bf5503f"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"a7f4bc0432bcd94eaeb59ac17882d74abc107ca6","unresolved":false,"context_lines":[{"line_number":215,"context_line":"                try:"},{"line_number":216,"context_line":"                    metrics.append(self.queue.get(block\u003dFalse))"},{"line_number":217,"context_line":"                except six.moves.queue.Empty:"},{"line_number":218,"context_line":"                    # queue might be empty by other workers, continue on."},{"line_number":219,"context_line":"                    break"},{"line_number":220,"context_line":"            if metrics:"},{"line_number":221,"context_line":"                self.store.process_background_tasks(self.index, metrics)"}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_2da8e776","line":218,"range":{"start_line":218,"start_character":37,"end_line":218,"end_character":42},"updated":"2016-07-26 10:28:56.000000000","message":"emptied?","commit_id":"7dc3e09cddbfbbfbee34090e62fc57ad8bf5503f"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"2e22c88313d07fc861b0cdf92675380f4aed454f","unresolved":false,"context_lines":[{"line_number":215,"context_line":"                try:"},{"line_number":216,"context_line":"                    metrics.append(self.queue.get(block\u003dFalse))"},{"line_number":217,"context_line":"                except six.moves.queue.Empty:"},{"line_number":218,"context_line":"                    # queue might be empty by other workers, continue on."},{"line_number":219,"context_line":"                    break"},{"line_number":220,"context_line":"            if metrics:"},{"line_number":221,"context_line":"                self.store.process_background_tasks(self.index, metrics)"}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_f3418d64","line":218,"range":{"start_line":218,"start_character":37,"end_line":218,"end_character":42},"in_reply_to":"dada55a8_2da8e776","updated":"2016-07-26 12:29:27.000000000","message":"Done","commit_id":"7dc3e09cddbfbbfbee34090e62fc57ad8bf5503f"}],"gnocchi/storage/__init__.py":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"d8912955dd4de57673a4c2bdc4d321a86878d398","unresolved":false,"context_lines":[{"line_number":228,"context_line":"        raise exceptions.NotImplementedError"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"    @staticmethod"},{"line_number":231,"context_line":"    def process_new_measures(indexer\u003dNone, metrics\u003dNone, sync\u003dFalse):"},{"line_number":232,"context_line":"        \"\"\"Process added measures in background."},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"        Some drivers might need to have a background task running that process"}],"source_content_type":"text/x-python","patch_set":7,"id":"dada55a8_854e4cbf","line":231,"range":{"start_line":231,"start_character":29,"end_line":231,"end_character":55},"updated":"2016-07-25 09:12:05.000000000","message":"none of those can be equal to None according to other signature and… common sense :)","commit_id":"8b22a91fe1a0ab87aa029ca322ccb042cc238f88"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"917f1cf421f206dd01e520209b496aaff26ee301","unresolved":false,"context_lines":[{"line_number":228,"context_line":"        raise exceptions.NotImplementedError"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"    @staticmethod"},{"line_number":231,"context_line":"    def process_new_measures(indexer\u003dNone, metrics\u003dNone, sync\u003dFalse):"},{"line_number":232,"context_line":"        \"\"\"Process added measures in background."},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"        Some drivers might need to have a background task running that process"}],"source_content_type":"text/x-python","patch_set":7,"id":"dada55a8_ab1a3a15","line":231,"range":{"start_line":231,"start_character":29,"end_line":231,"end_character":55},"in_reply_to":"dada55a8_854e4cbf","updated":"2016-07-25 12:01:18.000000000","message":"i laugh in the face of common sense :)","commit_id":"8b22a91fe1a0ab87aa029ca322ccb042cc238f88"}]}