)]}'
{"gnocchi/storage/_carbonara.py":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"a3d5c404f8914af6109a929d101b9ac250fb06a8","unresolved":false,"context_lines":[{"line_number":304,"context_line":"            metrics \u003d [metric for metric in"},{"line_number":305,"context_line":"                       index.list_metrics(limit\u003dself.UPGRADE_LIMIT,"},{"line_number":306,"context_line":"                                          marker\u003dmarker)]"},{"line_number":307,"context_line":"            map(self._check_for_metric_upgrade, metrics)"},{"line_number":308,"context_line":"            if len(metrics) \u003c self.UPGRADE_LIMIT:"},{"line_number":309,"context_line":"                break"},{"line_number":310,"context_line":"            marker \u003d metrics[-1].id"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_bee75b3f","line":307,"updated":"2016-08-19 14:29:46.000000000","message":"This should do nothing on Python 3, as it\u0027s a lazy generator :(","commit_id":"7ffac79881e23632c208996e9c1cd6ead5513718"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"fe194db86abb60743d89c974aec49d6784816536","unresolved":false,"context_lines":[{"line_number":304,"context_line":"            metrics \u003d [metric for metric in"},{"line_number":305,"context_line":"                       index.list_metrics(limit\u003dself.UPGRADE_LIMIT,"},{"line_number":306,"context_line":"                                          marker\u003dmarker)]"},{"line_number":307,"context_line":"            map(self._check_for_metric_upgrade, metrics)"},{"line_number":308,"context_line":"            if len(metrics) \u003c self.UPGRADE_LIMIT:"},{"line_number":309,"context_line":"                break"},{"line_number":310,"context_line":"            marker \u003d metrics[-1].id"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_afc44740","line":307,"in_reply_to":"1ac06dbe_bee75b3f","updated":"2016-08-19 15:10:56.000000000","message":"should i wrap this in a list() then? or apply it in list comprehension?","commit_id":"7ffac79881e23632c208996e9c1cd6ead5513718"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"65bc71354730925788e31e6bb0442f3addf9845a","unresolved":false,"context_lines":[{"line_number":302,"context_line":"    def upgrade(self, index):"},{"line_number":303,"context_line":"        marker \u003d None"},{"line_number":304,"context_line":"        while True:"},{"line_number":305,"context_line":"            metrics \u003d [self._check_for_metric_upgrade(metric) for metric in"},{"line_number":306,"context_line":"                       index.list_metrics(limit\u003dself.UPGRADE_BATCH_SIZE,"},{"line_number":307,"context_line":"                                          marker\u003dmarker)]"},{"line_number":308,"context_line":"            if len(metrics) \u003d\u003d 0:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ac06dbe_37a42956","line":305,"updated":"2016-08-19 16:25:57.000000000","message":"not sure building 2 lists in memory is worth it.\nrather I\u0027d do:\n\nmetrics \u003d list_metrics()\nfor m in metrics: check_for_metric_upgrade(m)\nif len(metrics \u003d\u003d 0:\n    break","commit_id":"0e600e4561a2f3c73536f7533d7ee70579d670bf"}]}