)]}'
{"gnocchi/carbonara.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"77644a4a9854086bc42037de3943127f99763d46","unresolved":false,"context_lines":[{"line_number":493,"context_line":"                timestamps.append(int((v - start) // offset_div))"},{"line_number":494,"context_line":"                start \u003d v"},{"line_number":495,"context_line":"            values \u003d self.ts.values.tolist()"},{"line_number":496,"context_line":"            return None, b\"c\" + lz4.dumps(struct.pack("},{"line_number":497,"context_line":"                \u0027\u003c\u0027 + \u0027H\u0027 * len(timestamps) + \u0027d\u0027 * len(values),"},{"line_number":498,"context_line":"                *(timestamps + values)))"},{"line_number":499,"context_line":"        # NOTE(gordc): this binary serializes series based on the split"}],"source_content_type":"text/x-python","patch_set":16,"id":"fa7ab95a_ecb0f08d","line":496,"range":{"start_line":496,"start_character":19,"end_line":496,"end_character":23},"updated":"2016-09-01 12:33:08.000000000","message":"this doesn\u0027t seem like the right fix. i think this will explode since librados actually expects offset to be a number and not None\n\nhttps://github.com/ceph/ceph/blob/ef9e8dc37dcf32f6fd15a8deff7dc162960b7bf3/src/pybind/rados/rados.pyx#L2315\n\nthis is weird the tests are passing since i feel like None doesn\u0027t really make sense in our mock either:\n\nhttps://github.com/openstack/gnocchi/blob/master/gnocchi/tests/base.py#L145-L147","commit_id":"922341068bac62b085a650fa3d35a4333f1d8476"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"36420a6117e9b0a34e98cf4b7e4a222b1695d3c7","unresolved":false,"context_lines":[{"line_number":493,"context_line":"                timestamps.append(int((v - start) // offset_div))"},{"line_number":494,"context_line":"                start \u003d v"},{"line_number":495,"context_line":"            values \u003d self.ts.values.tolist()"},{"line_number":496,"context_line":"            return None, b\"c\" + lz4.dumps(struct.pack("},{"line_number":497,"context_line":"                \u0027\u003c\u0027 + \u0027H\u0027 * len(timestamps) + \u0027d\u0027 * len(values),"},{"line_number":498,"context_line":"                *(timestamps + values)))"},{"line_number":499,"context_line":"        # NOTE(gordc): this binary serializes series based on the split"}],"source_content_type":"text/x-python","patch_set":16,"id":"fa7ab95a_c4db00ec","line":496,"range":{"start_line":496,"start_character":19,"end_line":496,"end_character":23},"in_reply_to":"fa7ab95a_02087b2c","updated":"2016-09-01 12:55:02.000000000","message":"dammit. you\u0027re making changes everywhere :P","commit_id":"922341068bac62b085a650fa3d35a4333f1d8476"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"1df2010aa02f614f8ef52c20a0c10a24d76cbd37","unresolved":false,"context_lines":[{"line_number":493,"context_line":"                timestamps.append(int((v - start) // offset_div))"},{"line_number":494,"context_line":"                start \u003d v"},{"line_number":495,"context_line":"            values \u003d self.ts.values.tolist()"},{"line_number":496,"context_line":"            return None, b\"c\" + lz4.dumps(struct.pack("},{"line_number":497,"context_line":"                \u0027\u003c\u0027 + \u0027H\u0027 * len(timestamps) + \u0027d\u0027 * len(values),"},{"line_number":498,"context_line":"                *(timestamps + values)))"},{"line_number":499,"context_line":"        # NOTE(gordc): this binary serializes series based on the split"}],"source_content_type":"text/x-python","patch_set":16,"id":"fa7ab95a_02087b2c","line":496,"range":{"start_line":496,"start_character":19,"end_line":496,"end_character":23},"in_reply_to":"fa7ab95a_ecb0f08d","updated":"2016-09-01 12:46:04.000000000","message":"You need a coffee. ;-)\n\nLook at one of the previous patch, Ceph understand None for offset as write_full()","commit_id":"922341068bac62b085a650fa3d35a4333f1d8476"}],"gnocchi/storage/_carbonara.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"882c836b312a7b63d494bd03a796bc42ceca3674","unresolved":false,"context_lines":[{"line_number":250,"context_line":""},{"line_number":251,"context_line":"        return self._store_metric_measures("},{"line_number":252,"context_line":"            metric, key_as_str, aggregation, archive_policy_def.granularity,"},{"line_number":253,"context_line":"            data, offset\u003doffset)"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"    def _add_measures(self, aggregation, archive_policy_def,"},{"line_number":256,"context_line":"                      metric, timeserie,"}],"source_content_type":"text/x-python","patch_set":15,"id":"fa7ab95a_7dbe7ed5","line":253,"updated":"2016-08-31 18:16:22.000000000","message":"ah, yes. i think i see it now. we can\u0027t share write_full and with offset since ceph actually has to call write_full method rather than write to properly clear trailing data.","commit_id":"4cb0efa0dc72f8b608801091055ee0f8fe75ec61"}]}