)]}'
{"gnocchi/indexer/alembic/versions/ed214f6c33d6_add_volume_type.py":[{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"0ce21496e0681c0c5c0b226e8913ecf514a4dba1","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"def upgrade():"},{"line_number":36,"context_line":"    op.add_column(\u0027volume\u0027, sa.Column(\u0027volume_type\u0027,"},{"line_number":37,"context_line":"                                      sa.String(length\u003d255),"},{"line_number":38,"context_line":"                                      nullable\u003dTrue))"},{"line_number":39,"context_line":"    op.add_column(\u0027volume_history\u0027, sa.Column(\u0027volume_type\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_2bac8033","line":36,"updated":"2016-09-06 15:10:31.000000000","message":"We need to check that table volume exists. Because if the DB have been created with Gnocchi 2.2 without ceilometer resource types, this is going to fail.","commit_id":"9f4e6b700dc365e5da5e273a751add6529be8ad1"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"c73beeb00273a9204d9b2dc5deedd4a8b608cdd6","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    engine \u003d op.get_bind().engine"},{"line_number":38,"context_line":"    inspector \u003d Inspector.from_engine(engine)"},{"line_number":39,"context_line":"    table_names \u003d inspector.get_table_names()"},{"line_number":40,"context_line":"    for table_name in table_names:"},{"line_number":41,"context_line":"        if table_name \u003d\u003d \u0027volume\u0027:"},{"line_number":42,"context_line":"            op.add_column(\u0027volume\u0027, sa.Column(\u0027volume_type\u0027,"},{"line_number":43,"context_line":"                                              sa.String(length\u003d255),"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_27ac908b","line":40,"updated":"2016-09-07 08:02:38.000000000","message":"just do:\n\nif \u0027volume\u0027 in table_names:\n   op.add_column()","commit_id":"af69b49cf7e8a48e4782f281f33aa881c62548bf"},{"author":{"_account_id":8358,"name":"zhangguoqing","email":"zhang.guoqing@99cloud.net","username":"zhangguoqing"},"change_message_id":"ae46870863d9b15aa790ea3e1829e3a0a6607356","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    engine \u003d op.get_bind().engine"},{"line_number":38,"context_line":"    inspector \u003d Inspector.from_engine(engine)"},{"line_number":39,"context_line":"    table_names \u003d inspector.get_table_names()"},{"line_number":40,"context_line":"    for table_name in table_names:"},{"line_number":41,"context_line":"        if table_name \u003d\u003d \u0027volume\u0027:"},{"line_number":42,"context_line":"            op.add_column(\u0027volume\u0027, sa.Column(\u0027volume_type\u0027,"},{"line_number":43,"context_line":"                                              sa.String(length\u003d255),"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_10198022","line":40,"in_reply_to":"9a89bdaa_27ac908b","updated":"2016-09-07 08:45:42.000000000","message":"Yes, I have written like this, then I change to current. I think current code always right, just \u0027volume in table_names\u0027 is not precise.","commit_id":"af69b49cf7e8a48e4782f281f33aa881c62548bf"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"3ff5e53b638e8c83e3edcb8ecacaa09bcc49547d","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        op.add_column(\u0027volume_history\u0027, sa.Column(\u0027volume_type\u0027,"},{"line_number":47,"context_line":"                                                  sa.String(length\u003d255),"},{"line_number":48,"context_line":"                                                  nullable\u003dTrue))"},{"line_number":49,"context_line":"    except sa.exc.NoSuchTableError:"},{"line_number":50,"context_line":"        return"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    # Update attributes of volume in resource_type table"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a8ec9b2_dae13100","line":49,"updated":"2016-09-15 06:42:31.000000000","message":"I have tested this on top on my upgrade testing works and I got:\nhttp://paste.openstack.org/show/577223/","commit_id":"c1457880d62892e63faf19580b2e04dd8aeda7b1"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"b33e1f127ad6a760580f105f5d80f43140bc778e","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        op.add_column(\u0027volume_history\u0027, sa.Column(\u0027volume_type\u0027,"},{"line_number":47,"context_line":"                                                  sa.String(length\u003d255),"},{"line_number":48,"context_line":"                                                  nullable\u003dTrue))"},{"line_number":49,"context_line":"    except sa.exc.NoSuchTableError:"},{"line_number":50,"context_line":"        return"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    # Update attributes of volume in resource_type table"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a8ec9b2_5a9e8f07","line":49,"in_reply_to":"7a8ec9b2_921e416e","updated":"2016-09-17 07:55:41.000000000","message":"I saw nothing on IRC, so it\u0027d be better to paste your investigation here :)","commit_id":"c1457880d62892e63faf19580b2e04dd8aeda7b1"},{"author":{"_account_id":8358,"name":"zhangguoqing","email":"zhang.guoqing@99cloud.net","username":"zhangguoqing"},"change_message_id":"aee011eb975ee426eb09c9bfe628b596ad20b8f8","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        op.add_column(\u0027volume_history\u0027, sa.Column(\u0027volume_type\u0027,"},{"line_number":47,"context_line":"                                                  sa.String(length\u003d255),"},{"line_number":48,"context_line":"                                                  nullable\u003dTrue))"},{"line_number":49,"context_line":"    except sa.exc.NoSuchTableError:"},{"line_number":50,"context_line":"        return"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    # Update attributes of volume in resource_type table"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a8ec9b2_921e416e","line":49,"in_reply_to":"7a8ec9b2_dae13100","updated":"2016-09-17 02:48:23.000000000","message":"It seems that there are some transaction difference between postgresql and mysql. I have try several ways and talked it in IRC, but I remain have no idea how to fix it. Could you give me some suggestions? thank you. :)","commit_id":"c1457880d62892e63faf19580b2e04dd8aeda7b1"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"3ff5e53b638e8c83e3edcb8ecacaa09bcc49547d","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        op.execute(resource_type.update().where("},{"line_number":65,"context_line":"            resource_type.c.name \u003d\u003d \u0027volume\u0027"},{"line_number":66,"context_line":"        ).values({resource_type.c.attributes: text_attributes}))"},{"line_number":67,"context_line":"    except Exception:"},{"line_number":68,"context_line":"        raise"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a8ec9b2_b0180786","line":67,"updated":"2016-09-15 06:42:31.000000000","message":"Looks useless to catch and reraise.","commit_id":"c1457880d62892e63faf19580b2e04dd8aeda7b1"}]}