)]}'
{"gnocchi/carbonara.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"6461eb7067be0975ee7c6b03adac42f65108b09d","unresolved":false,"context_lines":[{"line_number":561,"context_line":"                           max_size\u003dNone):"},{"line_number":562,"context_line":"        agg_name, q \u003d cls._get_agg_method(aggregation_method)"},{"line_number":563,"context_line":"        return cls(sampling, aggregation_method,"},{"line_number":564,"context_line":"                   ts\u003dcls._resample_grouped(grouped_serie, agg_name, q),"},{"line_number":565,"context_line":"                   max_size\u003dmax_size)"},{"line_number":566,"context_line":""},{"line_number":567,"context_line":"    def fetch(self, from_timestamp\u003dNone, to_timestamp\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_4cbf39fc","line":564,"updated":"2016-09-10 20:39:56.000000000","message":"i verified this but i don\u0027t believe we need dropna() here because the groupby only returns groups with points and doesn\u0027t fill in NaN","commit_id":"5fc9648bfa3c4289b1ceef565b5cc6678b9b9587"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"764b5314dedf3a51186c20f0525acb897e1df689","unresolved":false,"context_lines":[{"line_number":595,"context_line":"        self.ts \u003d self.ts.combine_first(ts.ts)"},{"line_number":596,"context_line":""},{"line_number":597,"context_line":"    def update(self, ts):"},{"line_number":598,"context_line":"        # FIXME(gordc): this might not actually be used anywhere?"},{"line_number":599,"context_line":"        if ts.ts.empty:"},{"line_number":600,"context_line":"            return"},{"line_number":601,"context_line":"        ts.ts \u003d self.clean_ts(ts.ts)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_4b8f04cc","line":598,"updated":"2016-09-12 10:00:16.000000000","message":"The method? Try to delete it in another patch and you\u0027ll see :)","commit_id":"30ec0e287d87cf89f0df3ed4c9cd5c2167e6e8b0"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"f6dadacb8bbce53f2d0babf17d3fbb458fea8c27","unresolved":false,"context_lines":[{"line_number":184,"context_line":"        return msgpack.dumps(self.to_dict())"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    @staticmethod"},{"line_number":187,"context_line":"    def group_serie(ts, granularity):"},{"line_number":188,"context_line":"        return ts.groupby(functools.partial(round_timestamp,"},{"line_number":189,"context_line":"                                            freq\u003dgranularity * 10e8))"},{"line_number":190,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a89bdaa_0fb7b5d8","line":187,"updated":"2016-09-12 14:37:54.000000000","message":"not staticmethod, this should use self.ts","commit_id":"79277150ed7358cc3941408bdca3d0b71f9be120"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"05dddaebf3016f11d1a35c7d6afa59d7096ff5e9","unresolved":false,"context_lines":[{"line_number":593,"context_line":"        self.ts \u003d self.ts.combine_first(ts.ts)"},{"line_number":594,"context_line":""},{"line_number":595,"context_line":"    def update(self, ts):"},{"line_number":596,"context_line":"        # TODO(gordc): remove this since it\u0027s not used"},{"line_number":597,"context_line":"        if ts.ts.empty:"},{"line_number":598,"context_line":"            return"},{"line_number":599,"context_line":"        ts.ts \u003d self.clean_ts(ts.ts)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a89bdaa_fd8dda7c","line":596,"updated":"2016-09-12 18:26:03.000000000","message":"so what about that?","commit_id":"67240de074224cfcfad27af128619410283462ae"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"fe20ad7a2453a0006aa5935379bc77cb53c5ea90","unresolved":false,"context_lines":[{"line_number":593,"context_line":"        self.ts \u003d self.ts.combine_first(ts.ts)"},{"line_number":594,"context_line":""},{"line_number":595,"context_line":"    def update(self, ts):"},{"line_number":596,"context_line":"        # TODO(gordc): remove this since it\u0027s not used"},{"line_number":597,"context_line":"        if ts.ts.empty:"},{"line_number":598,"context_line":"            return"},{"line_number":599,"context_line":"        ts.ts \u003d self.clean_ts(ts.ts)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a89bdaa_5bea4910","line":596,"in_reply_to":"9a89bdaa_fd8dda7c","updated":"2016-09-12 21:37:01.000000000","message":"see next patch... it\u0027s a rather large change.","commit_id":"67240de074224cfcfad27af128619410283462ae"}],"gnocchi/storage/_carbonara.py":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"764b5314dedf3a51186c20f0525acb897e1df689","unresolved":false,"context_lines":[{"line_number":257,"context_line":"                      metric, timeserie,"},{"line_number":258,"context_line":"                      previous_oldest_mutable_timestamp,"},{"line_number":259,"context_line":"                      oldest_mutable_timestamp):"},{"line_number":260,"context_line":"        ts \u003d timeserie.aggregate("},{"line_number":261,"context_line":"            archive_policy_def.granularity,"},{"line_number":262,"context_line":"            aggregation,"},{"line_number":263,"context_line":"            archive_policy_def.points)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_cb15d449","side":"PARENT","line":260,"range":{"start_line":260,"start_character":23,"end_line":260,"end_character":32},"updated":"2016-09-12 10:00:16.000000000","message":"I think aggregate() was only used there so you might be able to remove it","commit_id":"a4b12efa21b5ba533e2da5081bd2382169c28414"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"9844aeb008737fbbce542d84bbee3154eb9322a2","unresolved":false,"context_lines":[{"line_number":257,"context_line":"                      metric, timeserie,"},{"line_number":258,"context_line":"                      previous_oldest_mutable_timestamp,"},{"line_number":259,"context_line":"                      oldest_mutable_timestamp):"},{"line_number":260,"context_line":"        ts \u003d timeserie.aggregate("},{"line_number":261,"context_line":"            archive_policy_def.granularity,"},{"line_number":262,"context_line":"            aggregation,"},{"line_number":263,"context_line":"            archive_policy_def.points)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_9485a408","side":"PARENT","line":260,"range":{"start_line":260,"start_character":23,"end_line":260,"end_character":32},"in_reply_to":"9a89bdaa_cb15d449","updated":"2016-09-12 11:55:22.000000000","message":"k","commit_id":"a4b12efa21b5ba533e2da5081bd2382169c28414"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"764b5314dedf3a51186c20f0525acb897e1df689","unresolved":false,"context_lines":[{"line_number":505,"context_line":"                                ts \u003d bound_timeserie.ts["},{"line_number":506,"context_line":"                                    carbonara.round_timestamp("},{"line_number":507,"context_line":"                                        tstamp,"},{"line_number":508,"context_line":"                                        d.granularity * 10e8):].groupby("},{"line_number":509,"context_line":"                                            functools.partial("},{"line_number":510,"context_line":"                                                carbonara.round_timestamp,"},{"line_number":511,"context_line":"                                                freq\u003dd.granularity * 10e8))"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_261e7763","line":508,"updated":"2016-09-12 10:00:16.000000000","message":"so, yes to that, but there\u0027s a bit too much of Pandas leaking here, so might be we could hide that in carbonara.py?","commit_id":"30ec0e287d87cf89f0df3ed4c9cd5c2167e6e8b0"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"9844aeb008737fbbce542d84bbee3154eb9322a2","unresolved":false,"context_lines":[{"line_number":505,"context_line":"                                ts \u003d bound_timeserie.ts["},{"line_number":506,"context_line":"                                    carbonara.round_timestamp("},{"line_number":507,"context_line":"                                        tstamp,"},{"line_number":508,"context_line":"                                        d.granularity * 10e8):].groupby("},{"line_number":509,"context_line":"                                            functools.partial("},{"line_number":510,"context_line":"                                                carbonara.round_timestamp,"},{"line_number":511,"context_line":"                                                freq\u003dd.granularity * 10e8))"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_7482e001","line":508,"in_reply_to":"9a89bdaa_261e7763","updated":"2016-09-12 11:55:22.000000000","message":"sure","commit_id":"30ec0e287d87cf89f0df3ed4c9cd5c2167e6e8b0"}]}
