)]}'
{"gnocchi/carbonara.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"a1c5b8a8dedbf4b377e5e0d6371ea28183c556b0","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        return (), ()"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    @classmethod"},{"line_number":136,"context_line":"    def from_dict(cls, d):"},{"line_number":137,"context_line":"        \"\"\"Build a time series from a dict."},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        The dict format must be datetime as key and values as values."}],"source_content_type":"text/x-python","patch_set":7,"id":"7a8ec9b2_310f3d89","line":136,"updated":"2016-09-16 16:27:15.000000000","message":"this is empty method.","commit_id":"39559ccd420b9fca556d3b6c456f80a3b06081ce"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"26afd91e20dfb12abcb6bf5075621a122e4752b7","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        return (), ()"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    @classmethod"},{"line_number":136,"context_line":"    def from_dict(cls, d):"},{"line_number":137,"context_line":"        \"\"\"Build a time series from a dict."},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        The dict format must be datetime as key and values as values."}],"source_content_type":"text/x-python","patch_set":7,"id":"7a8ec9b2_6c05670f","line":136,"in_reply_to":"7a8ec9b2_310f3d89","updated":"2016-09-16 17:28:10.000000000","message":"Done","commit_id":"39559ccd420b9fca556d3b6c456f80a3b06081ce"}],"gnocchi/storage/_carbonara.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"a1c5b8a8dedbf4b377e5e0d6371ea28183c556b0","unresolved":false,"context_lines":[{"line_number":430,"context_line":"                        self._delete_metric_measures("},{"line_number":431,"context_line":"                            metric, key, agg_method,"},{"line_number":432,"context_line":"                            d.granularity, version\u003dNone)"},{"line_number":433,"context_line":"            self._delete_unaggregated_timeserie(metric, version\u003dNone)"},{"line_number":434,"context_line":"            LOG.info(\"Migrated metric %s to new format\" % metric)"},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"    def upgrade(self, index):"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a8ec9b2_717b8528","line":433,"updated":"2016-09-16 16:27:15.000000000","message":"why do we delete this at the end?","commit_id":"39559ccd420b9fca556d3b6c456f80a3b06081ce"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"26afd91e20dfb12abcb6bf5075621a122e4752b7","unresolved":false,"context_lines":[{"line_number":430,"context_line":"                        self._delete_metric_measures("},{"line_number":431,"context_line":"                            metric, key, agg_method,"},{"line_number":432,"context_line":"                            d.granularity, version\u003dNone)"},{"line_number":433,"context_line":"            self._delete_unaggregated_timeserie(metric, version\u003dNone)"},{"line_number":434,"context_line":"            LOG.info(\"Migrated metric %s to new format\" % metric)"},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"    def upgrade(self, index):"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a8ec9b2_cc167b4b","line":433,"in_reply_to":"7a8ec9b2_717b8528","updated":"2016-09-16 17:28:10.000000000","message":"In case of failure in the middle of the upgrade, we can redo the migration: if we delete earlier, the line 377 will fail","commit_id":"39559ccd420b9fca556d3b6c456f80a3b06081ce"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"a1c5b8a8dedbf4b377e5e0d6371ea28183c556b0","unresolved":false,"context_lines":[{"line_number":499,"context_line":"                        if ts is None:"},{"line_number":500,"context_line":"                            # This is the first time we treat measures for this"},{"line_number":501,"context_line":"                            # metric, or data are corrupted, create a new one"},{"line_number":502,"context_line":"                            mbs \u003d metric.archive_policy.max_block_size"},{"line_number":503,"context_line":"                            ts \u003d carbonara.BoundTimeSerie("},{"line_number":504,"context_line":"                                block_size\u003dmbs,"},{"line_number":505,"context_line":"                                back_window\u003dmetric.archive_policy.back_window)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a8ec9b2_71d0e5f6","line":502,"updated":"2016-09-16 16:27:15.000000000","message":"reuse this from above?","commit_id":"39559ccd420b9fca556d3b6c456f80a3b06081ce"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"26afd91e20dfb12abcb6bf5075621a122e4752b7","unresolved":false,"context_lines":[{"line_number":499,"context_line":"                        if ts is None:"},{"line_number":500,"context_line":"                            # This is the first time we treat measures for this"},{"line_number":501,"context_line":"                            # metric, or data are corrupted, create a new one"},{"line_number":502,"context_line":"                            mbs \u003d metric.archive_policy.max_block_size"},{"line_number":503,"context_line":"                            ts \u003d carbonara.BoundTimeSerie("},{"line_number":504,"context_line":"                                block_size\u003dmbs,"},{"line_number":505,"context_line":"                                back_window\u003dmetric.archive_policy.back_window)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a8ec9b2_2c18bf74","line":502,"in_reply_to":"7a8ec9b2_71d0e5f6","updated":"2016-09-16 17:28:10.000000000","message":"Done","commit_id":"39559ccd420b9fca556d3b6c456f80a3b06081ce"}],"gnocchi/tests/storage/test_carbonara.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"a1c5b8a8dedbf4b377e5e0d6371ea28183c556b0","unresolved":false,"context_lines":[{"line_number":166,"context_line":"        self.upgrade()"},{"line_number":167,"context_line":"        self.upgrade()"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    def test_get_measures_upgrade_limit(self):"},{"line_number":170,"context_line":"        self.metric2 \u003d storage.Metric(uuid.uuid4(),"},{"line_number":171,"context_line":"                                      self.archive_policies[\u0027low\u0027])"},{"line_number":172,"context_line":"        self.storage._create_metric(self.metric2)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a8ec9b2_313e5dda","side":"PARENT","line":169,"updated":"2016-09-16 16:27:15.000000000","message":"why you straight drop my test. not that i have a concern.","commit_id":"36b3352cb678a2b3f65e37e465592e02a5816dc3"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"26afd91e20dfb12abcb6bf5075621a122e4752b7","unresolved":false,"context_lines":[{"line_number":166,"context_line":"        self.upgrade()"},{"line_number":167,"context_line":"        self.upgrade()"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    def test_get_measures_upgrade_limit(self):"},{"line_number":170,"context_line":"        self.metric2 \u003d storage.Metric(uuid.uuid4(),"},{"line_number":171,"context_line":"                                      self.archive_policies[\u0027low\u0027])"},{"line_number":172,"context_line":"        self.storage._create_metric(self.metric2)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a8ec9b2_0c34e3db","side":"PARENT","line":169,"in_reply_to":"7a8ec9b2_313e5dda","updated":"2016-09-16 17:28:10.000000000","message":"just because it was too painful to port it lol and I was lazy\n\nsince I don\u0027t think it has much value in its testing, I preferred to drop it.","commit_id":"36b3352cb678a2b3f65e37e465592e02a5816dc3"}]}