)]}'
{"gnocchi/storage/_carbonara.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"908b003c4c1d245bb824413bdd48f9ff841a9f90","unresolved":false,"context_lines":[{"line_number":542,"context_line":"                              (metric.id, locksw.elapsed()))"},{"line_number":543,"context_line":"                except Exception:"},{"line_number":544,"context_line":"                    LOG.debug(\"Metric %s locked during %.2f seconds\" %"},{"line_number":545,"context_line":"                              (metric.id, locksw.elapsed()))"},{"line_number":546,"context_line":"                    if sync:"},{"line_number":547,"context_line":"                        raise"},{"line_number":548,"context_line":"                    LOG.error(\"Error processing new measures\", exc_info\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_a325ce09","line":545,"updated":"2016-09-16 12:54:48.000000000","message":"just put these in finally no?","commit_id":"376edf32b3c5b195f97964c3c2f6439498737ea6"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"a9597cf980878ff1638ea81052629d7451a9dc3c","unresolved":false,"context_lines":[{"line_number":542,"context_line":"                              (metric.id, locksw.elapsed()))"},{"line_number":543,"context_line":"                except Exception:"},{"line_number":544,"context_line":"                    LOG.debug(\"Metric %s locked during %.2f seconds\" %"},{"line_number":545,"context_line":"                              (metric.id, locksw.elapsed()))"},{"line_number":546,"context_line":"                    if sync:"},{"line_number":547,"context_line":"                        raise"},{"line_number":548,"context_line":"                    LOG.error(\"Error processing new measures\", exc_info\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_56fbad78","line":545,"in_reply_to":"7a8ec9b2_a325ce09","updated":"2016-09-19 08:14:36.000000000","message":"I prefer not, because:\n\n* if I put it before release() in finally and it fails, the lock is not released.\n* if I put it just after release(), the time to release to lock will be added to what I want to measure.","commit_id":"376edf32b3c5b195f97964c3c2f6439498737ea6"}]}