)]}'
{"gnocchi/archive_policy.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"59b94b4ce3e3faf63c46393116f7bdc5494cfbb3","unresolved":false,"context_lines":[{"line_number":163,"context_line":"            raise ValueError(\"Number of points should be \u003e 0\")"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"        if granularity is None:"},{"line_number":166,"context_line":"            if points is None or timespan is None:"},{"line_number":167,"context_line":"                raise ValueError("},{"line_number":168,"context_line":"                    \"At least two of granularity/points/timespan \""},{"line_number":169,"context_line":"                    \"must be provided\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_e8b0a645","side":"PARENT","line":166,"updated":"2016-09-21 16:33:40.000000000","message":"i feel like we should keep this regardless.","commit_id":"252e7bf1aef7638a59f2359627069302b602bd60"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"8158e7877651a6be42bd5c8dc6d81f8f2d23f995","unresolved":false,"context_lines":[{"line_number":163,"context_line":"            raise ValueError(\"Number of points should be \u003e 0\")"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"        if granularity is None:"},{"line_number":166,"context_line":"            if points is None or timespan is None:"},{"line_number":167,"context_line":"                raise ValueError("},{"line_number":168,"context_line":"                    \"At least two of granularity/points/timespan \""},{"line_number":169,"context_line":"                    \"must be provided\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a8bc5a2_9f17eeec","side":"PARENT","line":166,"in_reply_to":"7a8ec9b2_740d3e3d","updated":"2016-09-22 09:23:08.000000000","message":"Because there\u0027s no obligation to use voluptuous before using this class. It\u0027s true that right now we do it this way, but that might not be the case in the future.","commit_id":"252e7bf1aef7638a59f2359627069302b602bd60"},{"author":{"_account_id":22514,"name":"fengchaoyang","email":"fengchaoyang@unitedstack.com","username":"fengchaoyang"},"change_message_id":"848780af41b087cf698a73fbab20ee5fdda2f440","unresolved":false,"context_lines":[{"line_number":163,"context_line":"            raise ValueError(\"Number of points should be \u003e 0\")"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"        if granularity is None:"},{"line_number":166,"context_line":"            if points is None or timespan is None:"},{"line_number":167,"context_line":"                raise ValueError("},{"line_number":168,"context_line":"                    \"At least two of granularity/points/timespan \""},{"line_number":169,"context_line":"                    \"must be provided\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_740d3e3d","side":"PARENT","line":166,"in_reply_to":"7a8ec9b2_e8b0a645","updated":"2016-09-22 01:44:51.000000000","message":"Sorry, I do not quite understand why we should keep this? If granularity points and timespan schema min is 2, granulairty is None, points and timespan definitely not to None, so we can delete this.","commit_id":"252e7bf1aef7638a59f2359627069302b602bd60"},{"author":{"_account_id":22514,"name":"fengchaoyang","email":"fengchaoyang@unitedstack.com","username":"fengchaoyang"},"change_message_id":"848780af41b087cf698a73fbab20ee5fdda2f440","unresolved":false,"context_lines":[{"line_number":172,"context_line":"            granularity \u003d float(granularity)"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"        if points is None:"},{"line_number":175,"context_line":"            if timespan is None:"},{"line_number":176,"context_line":"                self[\u0027timespan\u0027] \u003d None"},{"line_number":177,"context_line":"            else:"},{"line_number":178,"context_line":"                points \u003d int(timespan / granularity)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_0f530318","side":"PARENT","line":175,"range":{"start_line":175,"start_character":0,"end_line":175,"end_character":32},"updated":"2016-09-22 01:44:51.000000000","message":"I think we seem to be able to delete this","commit_id":"252e7bf1aef7638a59f2359627069302b602bd60"}],"gnocchi/rest/__init__.py":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"bc817bfdc8bca7447de9c52528e06bd4d3c8bd83","unresolved":false,"context_lines":[{"line_number":328,"context_line":"                \"granularity\": Timespan,"},{"line_number":329,"context_line":"                \"points\": PositiveNotNullInt,"},{"line_number":330,"context_line":"                \"timespan\": Timespan,"},{"line_number":331,"context_line":"                }], voluptuous.Length(min\u003d2)),"},{"line_number":332,"context_line":"            })"},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"        body \u003d deserialize_and_validate(ArchivePolicySchema)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a8bc5a2_7f76a23f","line":331,"updated":"2016-09-22 09:23:51.000000000","message":"Also this chagne is wrong, because you can have only granularity with no limit (no timespan and no points).","commit_id":"024efe7359f92a8e83aedef4d9d0d73bc6073673"}]}