)]}'
{"gnocchi/indexer/sqlalchemy.py":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"3d03761ba44d5a8c3cdccc45405bc1d4ecc6015f","unresolved":false,"context_lines":[{"line_number":283,"context_line":"        self.conf \u003d conf"},{"line_number":284,"context_line":"        self.facade \u003d PerInstanceFacade(conf)"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"    def _check_dbms(self, connection):"},{"line_number":287,"context_line":"        dialect \u003d connection.dialect.dialect_description"},{"line_number":288,"context_line":"        version \u003d connection.dialect.server_version_info"},{"line_number":289,"context_line":"        if dialect.startswith(\u0027mysql\u0027) and version \u003c (5, 6, 4):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_f9fb9745","line":286,"updated":"2016-10-18 08:04:22.000000000","message":"@staticmethod","commit_id":"22a36853fec5f180bb4686126d99fc75a50f3881"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"3d03761ba44d5a8c3cdccc45405bc1d4ecc6015f","unresolved":false,"context_lines":[{"line_number":312,"context_line":"        cfg \u003d self._get_alembic_config()"},{"line_number":313,"context_line":"        cfg.conf \u003d self.conf"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"        with self.facade.writer_connection() as connection:"},{"line_number":316,"context_line":"            if not self._check_dbms(connection):"},{"line_number":317,"context_line":"                raise RuntimeError(\"mysql minimum required version is \""},{"line_number":318,"context_line":"                                   \"5.6.4\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_5999e31e","line":315,"updated":"2016-10-18 08:04:22.000000000","message":"This should be done on __init__ not just on upgrade IMHO.","commit_id":"22a36853fec5f180bb4686126d99fc75a50f3881"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"3d03761ba44d5a8c3cdccc45405bc1d4ecc6015f","unresolved":false,"context_lines":[{"line_number":314,"context_line":""},{"line_number":315,"context_line":"        with self.facade.writer_connection() as connection:"},{"line_number":316,"context_line":"            if not self._check_dbms(connection):"},{"line_number":317,"context_line":"                raise RuntimeError(\"mysql minimum required version is \""},{"line_number":318,"context_line":"                                   \"5.6.4\")"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"        if nocreate:"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_19f92b4e","line":317,"updated":"2016-10-18 08:04:22.000000000","message":"MySQL","commit_id":"22a36853fec5f180bb4686126d99fc75a50f3881"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"6258db05c88a54b25827d9059910a7a167bd4a37","unresolved":false,"context_lines":[{"line_number":268,"context_line":"        return new_url"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"    @staticmethod"},{"line_number":271,"context_line":"    def _check_dbms(connection):"},{"line_number":272,"context_line":"        dialect \u003d connection.dialect.dialect_description"},{"line_number":273,"context_line":"        version \u003d connection.dialect.server_version_info"},{"line_number":274,"context_line":"        if dialect.startswith(\u0027mysql\u0027) and version \u003c (5, 6, 4):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5da102_55f53b81","line":271,"updated":"2016-10-26 12:22:59.000000000","message":"That does not really explain what/why there\u0027s a check.\n\nmaybe rename\n\n_is_rdbms_compatible()\n\nthat\u0027ll make it more clear","commit_id":"b4cea3e9fe56e29839645fb316fb007aeab28a4c"},{"author":{"_account_id":22752,"name":"Hanxi Liu","email":"apolloliuhx@gmail.com","username":"Hanxi_Liu"},"change_message_id":"fa42cab5c3c41af9b07a7f3452e4d7626e3648a5","unresolved":false,"context_lines":[{"line_number":268,"context_line":"        return new_url"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"    @staticmethod"},{"line_number":271,"context_line":"    def _check_dbms(connection):"},{"line_number":272,"context_line":"        dialect \u003d connection.dialect.dialect_description"},{"line_number":273,"context_line":"        version \u003d connection.dialect.server_version_info"},{"line_number":274,"context_line":"        if dialect.startswith(\u0027mysql\u0027) and version \u003c (5, 6, 4):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6eadb0_b55a8e28","line":271,"in_reply_to":"ba5da102_55f53b81","updated":"2016-12-15 02:30:25.000000000","message":"Done","commit_id":"b4cea3e9fe56e29839645fb316fb007aeab28a4c"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"6258db05c88a54b25827d9059910a7a167bd4a37","unresolved":false,"context_lines":[{"line_number":271,"context_line":"    def _check_dbms(connection):"},{"line_number":272,"context_line":"        dialect \u003d connection.dialect.dialect_description"},{"line_number":273,"context_line":"        version \u003d connection.dialect.server_version_info"},{"line_number":274,"context_line":"        if dialect.startswith(\u0027mysql\u0027) and version \u003c (5, 6, 4):"},{"line_number":275,"context_line":"            return False"},{"line_number":276,"context_line":"        return True"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"    @staticmethod"},{"line_number":279,"context_line":"    def dress_url(url):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5da102_f5e64fe7","line":276,"range":{"start_line":274,"start_character":8,"end_line":276,"end_character":19},"updated":"2016-10-26 12:22:59.000000000","message":"return dialect.startswith(\u0027mysql\u0027) and version \u003c (5, 6, 4)","commit_id":"b4cea3e9fe56e29839645fb316fb007aeab28a4c"},{"author":{"_account_id":22752,"name":"Hanxi Liu","email":"apolloliuhx@gmail.com","username":"Hanxi_Liu"},"change_message_id":"fa42cab5c3c41af9b07a7f3452e4d7626e3648a5","unresolved":false,"context_lines":[{"line_number":271,"context_line":"    def _check_dbms(connection):"},{"line_number":272,"context_line":"        dialect \u003d connection.dialect.dialect_description"},{"line_number":273,"context_line":"        version \u003d connection.dialect.server_version_info"},{"line_number":274,"context_line":"        if dialect.startswith(\u0027mysql\u0027) and version \u003c (5, 6, 4):"},{"line_number":275,"context_line":"            return False"},{"line_number":276,"context_line":"        return True"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"    @staticmethod"},{"line_number":279,"context_line":"    def dress_url(url):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6eadb0_d56aaab2","line":276,"range":{"start_line":274,"start_character":8,"end_line":276,"end_character":19},"in_reply_to":"ba5da102_f5e64fe7","updated":"2016-12-15 02:30:25.000000000","message":"should be \"not (dialect.startswith(\u0027mysql\u0027) and version \u003c (5, 6, 4))\"","commit_id":"b4cea3e9fe56e29839645fb316fb007aeab28a4c"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"3d1afe4a50f3030b3f614d64b6fd7fab1c16891d","unresolved":false,"context_lines":[{"line_number":291,"context_line":"        self.conf \u003d conf"},{"line_number":292,"context_line":"        self.facade \u003d PerInstanceFacade(conf)"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"        with self.facade.writer_connection() as connection:"},{"line_number":295,"context_line":"            if not self._check_dbms(connection):"},{"line_number":296,"context_line":"                raise RuntimeError(\"MySQL minimum required version is \""},{"line_number":297,"context_line":"                                   \"5.6.4\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5da102_cc51cf10","line":294,"updated":"2016-10-26 08:47:17.000000000","message":"I think a reader_connection() should be better here but this is not a big deal for version checking.","commit_id":"b4cea3e9fe56e29839645fb316fb007aeab28a4c"},{"author":{"_account_id":22752,"name":"Hanxi Liu","email":"apolloliuhx@gmail.com","username":"Hanxi_Liu"},"change_message_id":"fa42cab5c3c41af9b07a7f3452e4d7626e3648a5","unresolved":false,"context_lines":[{"line_number":291,"context_line":"        self.conf \u003d conf"},{"line_number":292,"context_line":"        self.facade \u003d PerInstanceFacade(conf)"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"        with self.facade.writer_connection() as connection:"},{"line_number":295,"context_line":"            if not self._check_dbms(connection):"},{"line_number":296,"context_line":"                raise RuntimeError(\"MySQL minimum required version is \""},{"line_number":297,"context_line":"                                   \"5.6.4\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6eadb0_753396ab","line":294,"in_reply_to":"ba5da102_cc51cf10","updated":"2016-12-15 02:30:25.000000000","message":"Done","commit_id":"b4cea3e9fe56e29839645fb316fb007aeab28a4c"}]}