)]}'
{"gnocchi/utils.py":[{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"e2f13c3bff2a7946534ec8cc9e4f4e2ad429458e","unresolved":false,"context_lines":[{"line_number":63,"context_line":"# Retry with exponential backoff for up to 1 minute"},{"line_number":64,"context_line":"retry \u003d tenacity.retry("},{"line_number":65,"context_line":"    wait\u003dtenacity.wait_exponential(multiplier\u003d0.5, max\u003d60),"},{"line_number":66,"context_line":"    retry\u003dtenacity.retry_never,"},{"line_number":67,"context_line":"    reraise\u003dTrue)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_0132fb5e","line":66,"updated":"2016-11-10 15:53:20.000000000","message":"The argument name looks wierd, this looks retry will never retry ever.","commit_id":"223eca1887676d5a41346488ae560be5bc864197"},{"author":{"_account_id":19594,"name":"Yarko Tymciurak","email":"yarko.tymciurak@intel.com","username":"yarkot"},"change_message_id":"aea5c787c70bc70368c46aa228050e4cb842e97c","unresolved":false,"context_lines":[{"line_number":63,"context_line":"# Retry with exponential backoff for up to 1 minute"},{"line_number":64,"context_line":"retry \u003d tenacity.retry("},{"line_number":65,"context_line":"    wait\u003dtenacity.wait_exponential(multiplier\u003d0.5, max\u003d60),"},{"line_number":66,"context_line":"    retry\u003dtenacity.retry_never,"},{"line_number":67,"context_line":"    reraise\u003dTrue)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_ead5ae42","line":66,"in_reply_to":"9a629dbe_0132fb5e","updated":"2016-11-11 17:49:47.000000000","message":"I agree... I had to dig into tenacity code just to see what this intends, and wonder why (in tenacity) this isn\u0027t called more simply:\n\n    tenacity.retry_accept_results\nor\n    tenacity.retry_accepts\n\nand\n\n    tenacity.retry_reject_results\nor\n    tenacity.retry_rejects\n\n\nIn that same file (retry.py),\n\n    class retry_if_exception_type(...)\n\nI assume is not camel cased for legacy reasons (which is also a little confusing when reading the code).\n\nAnyway, it would be nice to make the intent clear here - either with an equivalent definition somewhere, e.g.\n\n    ALWAYS_ACCEPT_RESULTS \u003d tenacity.retry_never\n\nor at least a comment.","commit_id":"223eca1887676d5a41346488ae560be5bc864197"},{"author":{"_account_id":19594,"name":"Yarko Tymciurak","email":"yarko.tymciurak@intel.com","username":"yarkot"},"change_message_id":"e44a3fa78bcc8a52d4b59ca4316ca0ae66cbd618","unresolved":false,"context_lines":[{"line_number":63,"context_line":"# Retry with exponential backoff for up to 1 minute"},{"line_number":64,"context_line":"retry \u003d tenacity.retry("},{"line_number":65,"context_line":"    wait\u003dtenacity.wait_exponential(multiplier\u003d0.5, max\u003d60),"},{"line_number":66,"context_line":"    retry\u003dtenacity.retry_never,"},{"line_number":67,"context_line":"    reraise\u003dTrue)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_3c0974de","line":66,"in_reply_to":"9a629dbe_42a008a6","updated":"2016-11-14 16:55:35.000000000","message":"Ok.   This is beginning to make sense.  (_and_ it would be nice if the docstring in retry_never added this, your comment ;-))","commit_id":"223eca1887676d5a41346488ae560be5bc864197"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"d27c6f53093699e50eae8f5a5ffac6928ccdf67a","unresolved":false,"context_lines":[{"line_number":63,"context_line":"# Retry with exponential backoff for up to 1 minute"},{"line_number":64,"context_line":"retry \u003d tenacity.retry("},{"line_number":65,"context_line":"    wait\u003dtenacity.wait_exponential(multiplier\u003d0.5, max\u003d60),"},{"line_number":66,"context_line":"    retry\u003dtenacity.retry_never,"},{"line_number":67,"context_line":"    reraise\u003dTrue)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_42a008a6","line":66,"in_reply_to":"9a629dbe_ead5ae42","updated":"2016-11-14 15:56:15.000000000","message":"It will actually never retry on any condition. Except when TryAgain is raised. :)","commit_id":"223eca1887676d5a41346488ae560be5bc864197"}]}