)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"deb1d3e44818af8314592498e601ebc8425bacfc","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     fengchaoyang \u003cfengchaoyang@unitedstack.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-11-15 10:14:21 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"All to pass search filter in the query metric value"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Follow patch https://review.openstack.org/#/c/370629/"},{"line_number":10,"context_line":"You can use the filter to query metric values on server side."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a77a97e_f5bb9973","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":3},"updated":"2016-11-15 09:56:09.000000000","message":"Allow?","commit_id":"5b1cd77127ad5d27dc7264877cd0bb5964ac86de"}],"doc/source/rest.j2":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"40e2ef9e7963b2e696cc3538ea5bf89968243b3f","unresolved":false,"context_lines":[{"line_number":466,"context_line":""},{"line_number":467,"context_line":"{{ scenarios[\u0027search-value-in-metrics-by-granularity\u0027][\u0027doc\u0027] }}"},{"line_number":468,"context_line":""},{"line_number":469,"context_line":"And it is possible to search for values in metrics by search filter, but"},{"line_number":470,"context_line":"now only support simple binary operators."},{"line_number":471,"context_line":""},{"line_number":472,"context_line":"{{ scenarios[\u0027search-value-in-metrics-by-search-filter\u0027][\u0027doc\u0027] }}"},{"line_number":473,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"7a77a97e_04be02d4","line":470,"range":{"start_line":469,"start_character":68,"end_line":470,"end_character":40},"updated":"2016-11-15 23:49:44.000000000","message":"s/but now only support simple binary operators/but currently only simple binary operators are supported/","commit_id":"fa13eb8f71b18197a7fd35d0f191d78a7d389c6a"}],"doc/source/rest.yaml":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"40e2ef9e7963b2e696cc3538ea5bf89968243b3f","unresolved":false,"context_lines":[{"line_number":256,"context_line":""},{"line_number":257,"context_line":"- name: search-value-in-metrics-by-search-filter"},{"line_number":258,"context_line":"  request: |"},{"line_number":259,"context_line":"    POST /v1/search/metric?metric_id\u003d{{ scenarios[\u0027create-metric-a\u0027][\u0027response\u0027].json[\u0027id\u0027] }}\u0026granularity\u003d1second\u0026granularity\u003d1800s\u0026filter\u003d\u003d%2012 HTTP/1.1"},{"line_number":260,"context_line":"    Content-Type: application/json"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"- name: get-measures"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7a77a97e_84c69247","line":259,"range":{"start_line":259,"start_character":133,"end_line":259,"end_character":146},"updated":"2016-11-15 23:49:44.000000000","message":"sorry, i don\u0027t really understand what is %2012?","commit_id":"fa13eb8f71b18197a7fd35d0f191d78a7d389c6a"},{"author":{"_account_id":22514,"name":"fengchaoyang","email":"fengchaoyang@unitedstack.com","username":"fengchaoyang"},"change_message_id":"c5dab91a4dd4be75c4fd882315d3b1f6e61c5592","unresolved":false,"context_lines":[{"line_number":256,"context_line":""},{"line_number":257,"context_line":"- name: search-value-in-metrics-by-search-filter"},{"line_number":258,"context_line":"  request: |"},{"line_number":259,"context_line":"    POST /v1/search/metric?metric_id\u003d{{ scenarios[\u0027create-metric-a\u0027][\u0027response\u0027].json[\u0027id\u0027] }}\u0026granularity\u003d1second\u0026granularity\u003d1800s\u0026filter\u003d\u003d%2012 HTTP/1.1"},{"line_number":260,"context_line":"    Content-Type: application/json"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"- name: get-measures"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7a77a97e_133ba69d","line":259,"range":{"start_line":259,"start_character":133,"end_line":259,"end_character":146},"in_reply_to":"7a77a97e_84c69247","updated":"2016-11-16 03:41:07.000000000","message":"This line of code we want is \u0027\u003d 12\u0027, but spaces in the url is a special character,can encode space to plus(+) or %20, It seems controversial to use plus(+) or %20. http://stackoverflow.com/questions/2678551/when-to-encode-space-to-plus-or-20\nhttp://stackoverflow.com/questions/1634271/url-encoding-the-space-character-or-20\nI choose the same as sileht, here should be %20(see https://review.openstack.org/#/c/370629/1/gnocchi/tests/gabbi/gabbits/search.yaml)","commit_id":"fa13eb8f71b18197a7fd35d0f191d78a7d389c6a"}],"gnocchi/rest/__init__.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"40e2ef9e7963b2e696cc3538ea5bf89968243b3f","unresolved":false,"context_lines":[{"line_number":1134,"context_line":"    comparison_term \u003c\u003c (null | boolean | uuid_string | identifier | number |"},{"line_number":1135,"context_line":"                        quoted_string | in_list)"},{"line_number":1136,"context_line":"    condition \u003d pyparsing.Group(comparison_term + operator + comparison_term)"},{"line_number":1137,"context_line":""},{"line_number":1138,"context_line":"    expr \u003d pyparsing.infixNotation(condition, ["},{"line_number":1139,"context_line":"        (\"not\", 1, pyparsing.opAssoc.RIGHT, ),"},{"line_number":1140,"context_line":"        (\"and\", 2, pyparsing.opAssoc.LEFT, ),"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a77a97e_048c4234","side":"PARENT","line":1137,"range":{"start_line":1137,"start_character":0,"end_line":1137,"end_character":0},"updated":"2016-11-15 23:49:44.000000000","message":"not related","commit_id":"c5779e4dc26c3b059adb2743bbf4384e5d2a52b6"},{"author":{"_account_id":22514,"name":"fengchaoyang","email":"fengchaoyang@unitedstack.com","username":"fengchaoyang"},"change_message_id":"c5dab91a4dd4be75c4fd882315d3b1f6e61c5592","unresolved":false,"context_lines":[{"line_number":1134,"context_line":"    comparison_term \u003c\u003c (null | boolean | uuid_string | identifier | number |"},{"line_number":1135,"context_line":"                        quoted_string | in_list)"},{"line_number":1136,"context_line":"    condition \u003d pyparsing.Group(comparison_term + operator + comparison_term)"},{"line_number":1137,"context_line":""},{"line_number":1138,"context_line":"    expr \u003d pyparsing.infixNotation(condition, ["},{"line_number":1139,"context_line":"        (\"not\", 1, pyparsing.opAssoc.RIGHT, ),"},{"line_number":1140,"context_line":"        (\"and\", 2, pyparsing.opAssoc.LEFT, ),"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a77a97e_53451e15","side":"PARENT","line":1137,"range":{"start_line":1137,"start_character":0,"end_line":1137,"end_character":0},"in_reply_to":"7a77a97e_048c4234","updated":"2016-11-16 03:41:07.000000000","message":"Done","commit_id":"c5779e4dc26c3b059adb2743bbf4384e5d2a52b6"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"40e2ef9e7963b2e696cc3538ea5bf89968243b3f","unresolved":false,"context_lines":[{"line_number":1279,"context_line":""},{"line_number":1280,"context_line":""},{"line_number":1281,"context_line":"class SearchMetricValueFilter(QueryStringSearchAttrFilter):"},{"line_number":1282,"context_line":"    binary_operator \u003d (u\"\u003e\u003d\", u\"\u003c\u003d\", u\"!\u003d\", u\"\u003e\", u\"\u003c\", u\"\u003d\", u\"\u003d\u003d\", u\"eq\","},{"line_number":1283,"context_line":"                       u\"ne\", u\"lt\", u\"gt\", u\"ge\", u\"le\", u\"in\", u\"like\", u\"≠\","},{"line_number":1284,"context_line":"                       u\"≥\", u\"≤\")"},{"line_number":1285,"context_line":"    operator \u003d pyparsing.Regex(u\"|\".join(binary_operator))"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a77a97e_c4a96a7d","line":1282,"updated":"2016-11-15 23:49:44.000000000","message":"don\u0027t need to redefine this.","commit_id":"fa13eb8f71b18197a7fd35d0f191d78a7d389c6a"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"874e6e01d803f768e955359b7ccb266b8cbf8814","unresolved":false,"context_lines":[{"line_number":1279,"context_line":""},{"line_number":1280,"context_line":""},{"line_number":1281,"context_line":"class SearchMetricValueFilter(QueryStringSearchAttrFilter):"},{"line_number":1282,"context_line":"    binary_operator \u003d (u\"\u003e\u003d\", u\"\u003c\u003d\", u\"!\u003d\", u\"\u003e\", u\"\u003c\", u\"\u003d\", u\"\u003d\u003d\", u\"eq\","},{"line_number":1283,"context_line":"                       u\"ne\", u\"lt\", u\"gt\", u\"ge\", u\"le\", u\"in\", u\"like\", u\"≠\","},{"line_number":1284,"context_line":"                       u\"≥\", u\"≤\")"},{"line_number":1285,"context_line":"    operator \u003d pyparsing.Regex(u\"|\".join(binary_operator))"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a77a97e_283e53b8","line":1282,"in_reply_to":"7a77a97e_73213a4d","updated":"2016-11-16 14:06:54.000000000","message":"you still have \u0027in\u0027 and \u0027like\u0027 in this list","commit_id":"fa13eb8f71b18197a7fd35d0f191d78a7d389c6a"},{"author":{"_account_id":22514,"name":"fengchaoyang","email":"fengchaoyang@unitedstack.com","username":"fengchaoyang"},"change_message_id":"c5dab91a4dd4be75c4fd882315d3b1f6e61c5592","unresolved":false,"context_lines":[{"line_number":1279,"context_line":""},{"line_number":1280,"context_line":""},{"line_number":1281,"context_line":"class SearchMetricValueFilter(QueryStringSearchAttrFilter):"},{"line_number":1282,"context_line":"    binary_operator \u003d (u\"\u003e\u003d\", u\"\u003c\u003d\", u\"!\u003d\", u\"\u003e\", u\"\u003c\", u\"\u003d\", u\"\u003d\u003d\", u\"eq\","},{"line_number":1283,"context_line":"                       u\"ne\", u\"lt\", u\"gt\", u\"ge\", u\"le\", u\"in\", u\"like\", u\"≠\","},{"line_number":1284,"context_line":"                       u\"≥\", u\"≤\")"},{"line_number":1285,"context_line":"    operator \u003d pyparsing.Regex(u\"|\".join(binary_operator))"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a77a97e_73213a4d","line":1282,"in_reply_to":"7a77a97e_c4a96a7d","updated":"2016-11-16 03:41:07.000000000","message":"QueryStringSearchAttrFilter binary_operator support \"like\" and \"in\", but SearchMetricValueFilter not support. so I think need to redefine this.","commit_id":"fa13eb8f71b18197a7fd35d0f191d78a7d389c6a"}],"gnocchi/tests/gabbi/gabbits/search-metric.yaml":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"40e2ef9e7963b2e696cc3538ea5bf89968243b3f","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        $[0].archive_policy.name: high"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    - name: search metric value filter"},{"line_number":89,"context_line":"      POST: /v1/search/metric?metric_id\u003d$RESPONSE[\u0027$[0].id\u0027]\u0026filter\u003deq%2012"},{"line_number":90,"context_line":"      request_headers:"},{"line_number":91,"context_line":"        content-type: application/json"},{"line_number":92,"context_line":"      status: 200"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7a77a97e_04e1a2d0","line":89,"range":{"start_line":89,"start_character":61,"end_line":89,"end_character":75},"updated":"2016-11-15 23:49:44.000000000","message":"i\u0027m probably not understanding patch but what is eq%2012?","commit_id":"fa13eb8f71b18197a7fd35d0f191d78a7d389c6a"},{"author":{"_account_id":22514,"name":"fengchaoyang","email":"fengchaoyang@unitedstack.com","username":"fengchaoyang"},"change_message_id":"c5dab91a4dd4be75c4fd882315d3b1f6e61c5592","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        $[0].archive_policy.name: high"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    - name: search metric value filter"},{"line_number":89,"context_line":"      POST: /v1/search/metric?metric_id\u003d$RESPONSE[\u0027$[0].id\u0027]\u0026filter\u003deq%2012"},{"line_number":90,"context_line":"      request_headers:"},{"line_number":91,"context_line":"        content-type: application/json"},{"line_number":92,"context_line":"      status: 200"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7a77a97e_253bf59d","line":89,"range":{"start_line":89,"start_character":61,"end_line":89,"end_character":75},"in_reply_to":"7a77a97e_04e1a2d0","updated":"2016-11-16 03:41:07.000000000","message":"URL encode space to %20","commit_id":"fa13eb8f71b18197a7fd35d0f191d78a7d389c6a"}]}