)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"450a6fed2283112855e8777a5a249bd5e207e7a0","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Don\u0027t sleep if we have stuff to do"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"On each _run_job() iteration we sleep the interval delay but for"},{"line_number":10,"context_line":"the MetricProcessor if we have metric to process we should"},{"line_number":11,"context_line":"continue to do the work."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I38fefe81bd6b2eadbfa6aa9ffdd5c23e76c24bf9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5a74a57a_33e52437","line":10,"updated":"2016-11-23 15:46:33.000000000","message":"i don\u0027t get it, this is talking about metricprocessor but you are modifying the metricscheduler.","commit_id":"74cff907e396ded3450528f02582d1f3f3f87c1f"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"11f110c2b13f93661ddc0a13b8ca2921f9ddb816","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Don\u0027t sleep if we have stuff to do"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"On each _run_job() iteration we sleep the interval delay but for"},{"line_number":10,"context_line":"the MetricProcessor if we have metric to process we should"},{"line_number":11,"context_line":"continue to do the work."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I38fefe81bd6b2eadbfa6aa9ffdd5c23e76c24bf9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5a74a57a_13dca811","line":10,"in_reply_to":"5a74a57a_33e52437","updated":"2016-11-23 15:54:50.000000000","message":"Done, the commitmsg is wrong :)","commit_id":"74cff907e396ded3450528f02582d1f3f3f87c1f"}],"gnocchi/cli.py":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"5c4b4e0a83aef486d341cc87a91ab7bf7c690f6b","unresolved":false,"context_lines":[{"line_number":217,"context_line":"            while not self._shutdown.is_set():"},{"line_number":218,"context_line":"                metrics \u003d set(self.store.list_metric_with_measures_to_process("},{"line_number":219,"context_line":"                    self.block_size, self.block_index))"},{"line_number":220,"context_line":"                if metrics and not self.queue.empty():"},{"line_number":221,"context_line":"                    # NOTE(gordc): drop metrics we previously process to avoid"},{"line_number":222,"context_line":"                    #              handling twice"},{"line_number":223,"context_line":"                    number_of_scheduled_metrics \u003d len(metrics)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a74a57a_6287c861","line":220,"updated":"2016-11-23 14:52:01.000000000","message":"I think it\u0027d be more readable with:\n\nif not metrics:\n  # Nothing to do, sleep and retry later\n  return\n\nand then just the current code…","commit_id":"f99e1e04cdfe050a05ecadc1e634e6811639bf95"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"5c4b4e0a83aef486d341cc87a91ab7bf7c690f6b","unresolved":false,"context_lines":[{"line_number":227,"context_line":"                        LOG.warning("},{"line_number":228,"context_line":"                            \u0027Metric processing lagging scheduling rate. \u0027"},{"line_number":229,"context_line":"                            \u0027It is recommended to increase the number of \u0027"},{"line_number":230,"context_line":"                            \u0027workers or to lengthen processing interval.\u0027)"},{"line_number":231,"context_line":"                elif metrics:"},{"line_number":232,"context_line":"                    metrics \u003d list(metrics)"},{"line_number":233,"context_line":"                    for i in six.moves.range(0, len(metrics), self.BLOCK_SIZE):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a74a57a_e26598e1","line":230,"updated":"2016-11-23 14:52:01.000000000","message":"Since this does not return anymore, I imagine we can end up with over-flowing the log with this warning very fast until the queue is not empty anymore.","commit_id":"f99e1e04cdfe050a05ecadc1e634e6811639bf95"}]}