)]}'
{"gnocchi/opts.py":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"b10f0818d907d94dd90734ad9fefd50ce75ca51d","unresolved":false,"context_lines":[{"line_number":27,"context_line":"import gnocchi.storage.swift"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"def set_storage_default(opts):"},{"line_number":31,"context_line":"    # Don\u0027t change the orignals"},{"line_number":32,"context_line":"    opts \u003d copy.deepcopy(list(opts))"},{"line_number":33,"context_line":"    for opt in opts:"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a6eadb0_831218b3","line":30,"updated":"2016-12-13 14:32:04.000000000","message":"The function name is very misleading\n\n\"get_incoming_storage_options()\" would be better and exactly what you meant.\n\nit could use _STORAGE_OPTS a global variable built from L39.","commit_id":"102195326e4c661a00b321f347d3bb8b8ff02a0b"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"b10f0818d907d94dd90734ad9fefd50ce75ca51d","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"def list_opts():"},{"line_number":39,"context_line":"    storage_opts \u003d list(itertools.chain(gnocchi.storage._carbonara.OPTS,"},{"line_number":40,"context_line":"                                        gnocchi.storage.ceph.OPTS,"},{"line_number":41,"context_line":"                                        gnocchi.storage.file.OPTS,"},{"line_number":42,"context_line":"                                        gnocchi.storage.swift.OPTS,"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a6eadb0_e3110cae","line":39,"updated":"2016-12-13 14:32:04.000000000","message":"make a global _STORAGE_OPTS?\n\n\nor just merge the 2 functions since they\u0027re used only once.","commit_id":"102195326e4c661a00b321f347d3bb8b8ff02a0b"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"b10f0818d907d94dd90734ad9fefd50ce75ca51d","unresolved":false,"context_lines":[{"line_number":43,"context_line":"                                        gnocchi.storage.s3.OPTS))"},{"line_number":44,"context_line":"    for opt in storage_opts:"},{"line_number":45,"context_line":"        opt.deprecated_opts.append(cfg.DeprecatedOpt("},{"line_number":46,"context_line":"            opt.name, group\u003d\"storage\"))"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    return ["},{"line_number":49,"context_line":"        (\"indexer\", gnocchi.indexer.OPTS),"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a6eadb0_036e082f","line":46,"updated":"2016-12-13 14:32:04.000000000","message":"I have trouble understanding what is that.","commit_id":"102195326e4c661a00b321f347d3bb8b8ff02a0b"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"b10f0818d907d94dd90734ad9fefd50ce75ca51d","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                             \u0027single response from a collection resource\u0027)),"},{"line_number":63,"context_line":"        )),"},{"line_number":64,"context_line":"        (\"storage\", storage_opts + gnocchi.storage.OPTS),"},{"line_number":65,"context_line":"        (\"incoming_storage\", set_storage_default(storage_opts)),"},{"line_number":66,"context_line":"        (\"statsd\", ("},{"line_number":67,"context_line":"            cfg.StrOpt(\u0027host\u0027,"},{"line_number":68,"context_line":"                       default\u003d\u00270.0.0.0\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a6eadb0_a3655446","line":65,"updated":"2016-12-13 14:32:04.000000000","message":"not a fan of the incoming_storage name but I don\u0027t have a better name.\n\nMaybe storage_incoming or incoming? Idea Gordon?","commit_id":"102195326e4c661a00b321f347d3bb8b8ff02a0b"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"7125a114e1ea1800cc3ee696fd5813251ff93f40","unresolved":false,"context_lines":[{"line_number":26,"context_line":"import gnocchi.storage.s3"},{"line_number":27,"context_line":"import gnocchi.storage.swift"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"_STORAGE_OPTS \u003d list(itertools.chain(gnocchi.storage._carbonara.OPTS,"},{"line_number":30,"context_line":"                                     gnocchi.storage.ceph.OPTS,"},{"line_number":31,"context_line":"                                     gnocchi.storage.file.OPTS,"},{"line_number":32,"context_line":"                                     gnocchi.storage.swift.OPTS,"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa48f94a_f8af2992","line":29,"range":{"start_line":29,"start_character":38,"end_line":29,"end_character":67},"updated":"2016-12-21 18:12:43.000000000","message":"i don\u0027t believe you need this. seems to be only used by aggregation storage parts","commit_id":"373b2acd1230e5caa654cf633f451d00611d2227"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"2a2c9c88dfe2dbacfc8bdac13a32b44fa8b5ee05","unresolved":false,"context_lines":[{"line_number":26,"context_line":"import gnocchi.storage.s3"},{"line_number":27,"context_line":"import gnocchi.storage.swift"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"_STORAGE_OPTS \u003d list(itertools.chain(gnocchi.storage._carbonara.OPTS,"},{"line_number":30,"context_line":"                                     gnocchi.storage.ceph.OPTS,"},{"line_number":31,"context_line":"                                     gnocchi.storage.file.OPTS,"},{"line_number":32,"context_line":"                                     gnocchi.storage.swift.OPTS,"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba5201f7_07faa142","line":29,"range":{"start_line":29,"start_character":38,"end_line":29,"end_character":67},"in_reply_to":"fa48f94a_f8af2992","updated":"2017-01-02 10:40:30.000000000","message":"Done","commit_id":"373b2acd1230e5caa654cf633f451d00611d2227"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"7125a114e1ea1800cc3ee696fd5813251ff93f40","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"_INCOMING_OPTS \u003d copy.deepcopy(_STORAGE_OPTS)"},{"line_number":37,"context_line":"for opt in _INCOMING_OPTS:"},{"line_number":38,"context_line":"    opt.default \u003d \u0027${storage.%s}\u0027 % opt.name"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"def list_opts():"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa48f94a_b893e14e","line":38,"range":{"start_line":37,"start_character":0,"end_line":38,"end_character":44},"updated":"2016-12-21 18:12:43.000000000","message":"what\u0027s this for?","commit_id":"373b2acd1230e5caa654cf633f451d00611d2227"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"80cc4e068cd3df12f57f17287174525ec2cf37e2","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"_INCOMING_OPTS \u003d copy.deepcopy(_STORAGE_OPTS)"},{"line_number":37,"context_line":"for opt in _INCOMING_OPTS:"},{"line_number":38,"context_line":"    opt.default \u003d \u0027${storage.%s}\u0027 % opt.name"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"def list_opts():"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa48f94a_58583557","line":38,"range":{"start_line":37,"start_character":0,"end_line":38,"end_character":44},"in_reply_to":"fa48f94a_b893e14e","updated":"2016-12-21 18:21:02.000000000","message":"This is to use the value set in [storage] for the same options in [incoming] by default. It\u0027s kinda handy IMHO.","commit_id":"373b2acd1230e5caa654cf633f451d00611d2227"}]}