)]}'
{"gnocchi/indexer/sqlalchemy_extension.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"fcdff91ddf97482b7559c1f9838936305e1fcb97","unresolved":false,"context_lines":[{"line_number":23,"context_line":"class SchemaMixin(object):"},{"line_number":24,"context_line":"    def for_filling(self, dialect):"},{"line_number":25,"context_line":"        # NOTE(sileht): This must be used only for patching resource type"},{"line_number":26,"context_line":"        # to fill all row with a default value and then siwtch back the"},{"line_number":27,"context_line":"        # server_default to None"},{"line_number":28,"context_line":"        if self.fill is None:"},{"line_number":29,"context_line":"            return None"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a3905b3_2176d6d8","line":26,"range":{"start_line":26,"start_character":56,"end_line":26,"end_character":62},"updated":"2017-01-24 18:59:29.000000000","message":"switch","commit_id":"3bee1545eeab72f6be1eabde319cd1ad64e1f184"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"6533fadded91dcaeb109faf69c81ec863472c0a5","unresolved":false,"context_lines":[{"line_number":23,"context_line":"class SchemaMixin(object):"},{"line_number":24,"context_line":"    def for_filling(self, dialect):"},{"line_number":25,"context_line":"        # NOTE(sileht): This must be used only for patching resource type"},{"line_number":26,"context_line":"        # to fill all row with a default value and then siwtch back the"},{"line_number":27,"context_line":"        # server_default to None"},{"line_number":28,"context_line":"        if self.fill is None:"},{"line_number":29,"context_line":"            return None"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a3905b3_c7b9a2cd","line":26,"range":{"start_line":26,"start_character":56,"end_line":26,"end_character":62},"in_reply_to":"5a3905b3_2176d6d8","updated":"2017-01-24 19:28:25.000000000","message":"Done","commit_id":"3bee1545eeab72f6be1eabde319cd1ad64e1f184"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"16e93ce54104c08db2f28c8b6d1ff28ff8e039c8","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    def for_filling(self, dialect):"},{"line_number":45,"context_line":"        if self.fill is None:"},{"line_number":46,"context_line":"            return False  # Don\u0027t set any server_default"},{"line_number":47,"context_line":"        return sqlalchemy.literal("},{"line_number":48,"context_line":"            self.satype.process_bind_param(self.fill, dialect))"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"5a3905b3_b62929f5","line":47,"updated":"2017-01-24 20:10:56.000000000","message":"I wonder if could/should not be always done anyway for all types?","commit_id":"bf941fd236cf5d683baeee616c37f57ceb073064"}],"gnocchi/tests/gabbi/gabbits/resource-type.yaml":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"fcdff91ddf97482b7559c1f9838936305e1fcb97","unresolved":false,"context_lines":[{"line_number":379,"context_line":"            type: uuid"},{"line_number":380,"context_line":"            required: True"},{"line_number":381,"context_line":"            options:"},{"line_number":382,"context_line":"              fill: \"00000000-0000-0000-0000-000000000000\""},{"line_number":383,"context_line":"        - op: remove"},{"line_number":384,"context_line":"          path: /attributes/foobar"},{"line_number":385,"context_line":"      status: 200"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"5a3905b3_fc71d5a9","line":382,"updated":"2017-01-24 18:59:29.000000000","message":"would be good to have a negative test to verify what happens when missing fill or given bad fill\n\nalso, a test for not required but fill given.","commit_id":"3bee1545eeab72f6be1eabde319cd1ad64e1f184"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"6533fadded91dcaeb109faf69c81ec863472c0a5","unresolved":false,"context_lines":[{"line_number":379,"context_line":"            type: uuid"},{"line_number":380,"context_line":"            required: True"},{"line_number":381,"context_line":"            options:"},{"line_number":382,"context_line":"              fill: \"00000000-0000-0000-0000-000000000000\""},{"line_number":383,"context_line":"        - op: remove"},{"line_number":384,"context_line":"          path: /attributes/foobar"},{"line_number":385,"context_line":"      status: 200"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"5a3905b3_c7d60227","line":382,"in_reply_to":"5a3905b3_fc71d5a9","updated":"2017-01-24 19:28:25.000000000","message":"I have added the 3 tests","commit_id":"3bee1545eeab72f6be1eabde319cd1ad64e1f184"}]}
