)]}'
{"gnocchi/carbonara.py":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"8b33574c7d3a285f1eb325ba58c51ed51a408ecf","unresolved":false,"context_lines":[{"line_number":613,"context_line":"        # Fill everything with zero"},{"line_number":614,"context_line":"        serial \u003d numpy.zeros(e_offset * 2, dtype\u003d\u0027float\u0027)"},{"line_number":615,"context_line":""},{"line_number":616,"context_line":"        # Get location of one"},{"line_number":617,"context_line":"        locs \u003d (numpy.diff(self.ts.index) // offset_div) * 2,"},{"line_number":618,"context_line":"        locs \u003d numpy.insert(locs, 0, 0)"},{"line_number":619,"context_line":"        locs \u003d numpy.array(locs, dtype\u003d\u0027int\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a3c09a3_85e354d8","line":616,"range":{"start_line":616,"start_character":26,"end_line":616,"end_character":29},"updated":"2017-01-17 21:42:42.000000000","message":"ones","commit_id":"2c5c58ff563b2e5b9d5abed67af5f858b7610779"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"42f99085ee42d759d9fa543a32930535f56b5052","unresolved":false,"context_lines":[{"line_number":613,"context_line":"        # Fill everything with zero"},{"line_number":614,"context_line":"        serial \u003d numpy.zeros(e_offset * 2, dtype\u003d\u0027float\u0027)"},{"line_number":615,"context_line":""},{"line_number":616,"context_line":"        # Get location of one"},{"line_number":617,"context_line":"        locs \u003d (numpy.diff(self.ts.index) // offset_div) * 2,"},{"line_number":618,"context_line":"        locs \u003d numpy.insert(locs, 0, 0)"},{"line_number":619,"context_line":"        locs \u003d numpy.array(locs, dtype\u003d\u0027int\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a3c09a3_50d68cf1","line":616,"range":{"start_line":616,"start_character":26,"end_line":616,"end_character":29},"in_reply_to":"7a3c09a3_85e354d8","updated":"2017-01-17 22:07:44.000000000","message":"Done","commit_id":"2c5c58ff563b2e5b9d5abed67af5f858b7610779"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"dab6eeb93f68c55564aced544540d2b5c7cc7046","unresolved":false,"context_lines":[{"line_number":615,"context_line":"        serial \u003d numpy.zeros(e_offset * 2, dtype\u003d\u0027float\u0027)"},{"line_number":616,"context_line":""},{"line_number":617,"context_line":"        # Get location of ones"},{"line_number":618,"context_line":"        locs \u003d (numpy.cumsum(numpy.diff(self.ts.index)) // offset_div) * 2"},{"line_number":619,"context_line":"        locs \u003d numpy.insert(locs, 0, 0)"},{"line_number":620,"context_line":"        locs \u003d numpy.array(locs, dtype\u003d\u0027int\u0027)"},{"line_number":621,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7a3c09a3_106c0434","line":618,"range":{"start_line":618,"start_character":16,"end_line":618,"end_character":28},"updated":"2017-01-17 22:09:50.000000000","message":"i was going to tell you to add this. :P","commit_id":"ff37fbaeda47083009be35ba4160bdd441168c50"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"14aa4b9580eb014075d9885a4d862c31d7fd6e35","unresolved":false,"context_lines":[{"line_number":619,"context_line":"        locs \u003d numpy.array(locs, dtype\u003d\u0027int\u0027)"},{"line_number":620,"context_line":""},{"line_number":621,"context_line":"        # extract values"},{"line_number":622,"context_line":"        serial[locs] \u003d numpy.ones(len(self.ts), dtype\u003d\u0027float\u0027)"},{"line_number":623,"context_line":"        serial[locs + 1] \u003d numpy.array(self.ts.values.tolist(), dtype\u003d\u0027float\u0027)"},{"line_number":624,"context_line":""},{"line_number":625,"context_line":"        offset \u003d int((first - start) // offset_div) * self.PADDED_SERIAL_LEN"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a3c09a3_5d186475","line":622,"range":{"start_line":622,"start_character":55,"end_line":622,"end_character":60},"updated":"2017-01-17 22:38:24.000000000","message":"this should be an int... we pack using \u0027?d\u0027 bool+double pairs.","commit_id":"be83cdf1ce9501c43c4973e87c821486023e181b"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"ec4eb93450e873613c7ff21cbcb18804321804b8","unresolved":false,"context_lines":[{"line_number":619,"context_line":"        locs \u003d numpy.array(locs, dtype\u003d\u0027int\u0027)"},{"line_number":620,"context_line":""},{"line_number":621,"context_line":"        # extract values"},{"line_number":622,"context_line":"        serial[locs] \u003d numpy.ones(len(self.ts), dtype\u003d\u0027float\u0027)"},{"line_number":623,"context_line":"        serial[locs + 1] \u003d numpy.array(self.ts.values.tolist(), dtype\u003d\u0027float\u0027)"},{"line_number":624,"context_line":""},{"line_number":625,"context_line":"        offset \u003d int((first - start) // offset_div) * self.PADDED_SERIAL_LEN"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a3c09a3_46222ba4","line":622,"range":{"start_line":622,"start_character":55,"end_line":622,"end_character":60},"in_reply_to":"7a3c09a3_0bbcaeb9","updated":"2017-01-18 14:25:40.000000000","message":"actually don\u0027t use bool... it\u0027s slower for some reason... i guess numpy really like floats.","commit_id":"be83cdf1ce9501c43c4973e87c821486023e181b"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"42e521dfb04fed90a374abc693ba87de2d4d3f34","unresolved":false,"context_lines":[{"line_number":619,"context_line":"        locs \u003d numpy.array(locs, dtype\u003d\u0027int\u0027)"},{"line_number":620,"context_line":""},{"line_number":621,"context_line":"        # extract values"},{"line_number":622,"context_line":"        serial[locs] \u003d numpy.ones(len(self.ts), dtype\u003d\u0027float\u0027)"},{"line_number":623,"context_line":"        serial[locs + 1] \u003d numpy.array(self.ts.values.tolist(), dtype\u003d\u0027float\u0027)"},{"line_number":624,"context_line":""},{"line_number":625,"context_line":"        offset \u003d int((first - start) // offset_div) * self.PADDED_SERIAL_LEN"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a3c09a3_3ed6234f","line":622,"range":{"start_line":622,"start_character":55,"end_line":622,"end_character":60},"in_reply_to":"7a3c09a3_36ad7588","updated":"2017-01-18 06:49:50.000000000","message":"I think I don\u0027t get your comment:\n\n\u003e\u003e\u003e numpy.ones(5, dtype\u003d\u0027float\u0027)\narray([ 1.,  1.,  1.,  1.,  1.])\n\nIt\u0027s a float (note that numpy removes useless 0 after the dot)\n\nAnd then struct.pack will call __bool__ for \u0027?\u0027 or __float__ for \u0027d\u0027 on each args. So the array of float become bool, double, boo\nl, double.\n\nI will change float to float64 to explicit the double precision.","commit_id":"be83cdf1ce9501c43c4973e87c821486023e181b"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"f295528b2fe83276b03fa21b5a549e4f482af3c1","unresolved":false,"context_lines":[{"line_number":619,"context_line":"        locs \u003d numpy.array(locs, dtype\u003d\u0027int\u0027)"},{"line_number":620,"context_line":""},{"line_number":621,"context_line":"        # extract values"},{"line_number":622,"context_line":"        serial[locs] \u003d numpy.ones(len(self.ts), dtype\u003d\u0027float\u0027)"},{"line_number":623,"context_line":"        serial[locs + 1] \u003d numpy.array(self.ts.values.tolist(), dtype\u003d\u0027float\u0027)"},{"line_number":624,"context_line":""},{"line_number":625,"context_line":"        offset \u003d int((first - start) // offset_div) * self.PADDED_SERIAL_LEN"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a3c09a3_f0067184","line":622,"range":{"start_line":622,"start_character":55,"end_line":622,"end_character":60},"in_reply_to":"7a3c09a3_3ed6234f","updated":"2017-01-18 14:05:11.000000000","message":"right, but i believe all you need is numpy.ones(5, dtype\u003d\u0027int\u0027) because \u0027?\u0027 doesn\u0027t care what type of data it is. it just checks if it\u0027s a zero or non-zero value and serialises it. a \u00271\u0027 as a float, int, etc... doesn\u0027t matter i think (unless you want to consider memory usage)","commit_id":"be83cdf1ce9501c43c4973e87c821486023e181b"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"3299eb688d71425443ac6392f6ece162a29645e6","unresolved":false,"context_lines":[{"line_number":619,"context_line":"        locs \u003d numpy.array(locs, dtype\u003d\u0027int\u0027)"},{"line_number":620,"context_line":""},{"line_number":621,"context_line":"        # extract values"},{"line_number":622,"context_line":"        serial[locs] \u003d numpy.ones(len(self.ts), dtype\u003d\u0027float\u0027)"},{"line_number":623,"context_line":"        serial[locs + 1] \u003d numpy.array(self.ts.values.tolist(), dtype\u003d\u0027float\u0027)"},{"line_number":624,"context_line":""},{"line_number":625,"context_line":"        offset \u003d int((first - start) // offset_div) * self.PADDED_SERIAL_LEN"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a3c09a3_36ad7588","line":622,"range":{"start_line":622,"start_character":55,"end_line":622,"end_character":60},"in_reply_to":"7a3c09a3_40c87774","updated":"2017-01-18 00:32:39.000000000","message":"but it will have all the same values. you are creating an array of 1\u0027s rather than array of 1.0\u0027s.\n\nalthough i guess it doesn\u0027t matter since \u0027?\u0027 just looks at first bit","commit_id":"be83cdf1ce9501c43c4973e87c821486023e181b"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"ce9a1bb85b4dd729b975dd907bea4b7bbebf0cfd","unresolved":false,"context_lines":[{"line_number":619,"context_line":"        locs \u003d numpy.array(locs, dtype\u003d\u0027int\u0027)"},{"line_number":620,"context_line":""},{"line_number":621,"context_line":"        # extract values"},{"line_number":622,"context_line":"        serial[locs] \u003d numpy.ones(len(self.ts), dtype\u003d\u0027float\u0027)"},{"line_number":623,"context_line":"        serial[locs + 1] \u003d numpy.array(self.ts.values.tolist(), dtype\u003d\u0027float\u0027)"},{"line_number":624,"context_line":""},{"line_number":625,"context_line":"        offset \u003d int((first - start) // offset_div) * self.PADDED_SERIAL_LEN"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a3c09a3_40c87774","line":622,"range":{"start_line":622,"start_character":55,"end_line":622,"end_character":60},"in_reply_to":"7a3c09a3_5d186475","updated":"2017-01-17 23:22:17.000000000","message":"numpy.array must have all values with the same dtype and struct make the convertion for us.","commit_id":"be83cdf1ce9501c43c4973e87c821486023e181b"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"78f026b1286caf0b53aa8a3ddd0a331c0a1df362","unresolved":false,"context_lines":[{"line_number":619,"context_line":"        locs \u003d numpy.array(locs, dtype\u003d\u0027int\u0027)"},{"line_number":620,"context_line":""},{"line_number":621,"context_line":"        # extract values"},{"line_number":622,"context_line":"        serial[locs] \u003d numpy.ones(len(self.ts), dtype\u003d\u0027float\u0027)"},{"line_number":623,"context_line":"        serial[locs + 1] \u003d numpy.array(self.ts.values.tolist(), dtype\u003d\u0027float\u0027)"},{"line_number":624,"context_line":""},{"line_number":625,"context_line":"        offset \u003d int((first - start) // offset_div) * self.PADDED_SERIAL_LEN"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a3c09a3_0bbcaeb9","line":622,"range":{"start_line":622,"start_character":55,"end_line":622,"end_character":60},"in_reply_to":"7a3c09a3_f0067184","updated":"2017-01-18 14:17:17.000000000","message":"i think in theory dtype\u003d\u0027bool\u0027 so instead of storing 8B, you just need 1B. you\u0027d have to change line614 as well... that said, i did quick test and it doesn\u0027t really change anything.","commit_id":"be83cdf1ce9501c43c4973e87c821486023e181b"}]}