)]}'
{"gnocchi/rest/auth_helper.py":[{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"53ce2ec3d0047e68fd61cff59da1c0e218366e2c","unresolved":false,"context_lines":[{"line_number":98,"context_line":"            return user_id"},{"line_number":99,"context_line":"        if project_id:"},{"line_number":100,"context_line":"            return project_id"},{"line_number":101,"context_line":"        rest.abort(400, \"Unable to determine current user\")"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"class BasicAuthHelper(object):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a3905b3_1afb0a7a","line":101,"range":{"start_line":101,"start_character":18,"end_line":101,"end_character":23},"updated":"2017-01-24 16:56:11.000000000","message":"Should be 401, no ?","commit_id":"4250560ac01d6aeb91503cfa81166daef1cdd882"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"7e8b9dbd1d034b4b7db39f671056ceda09fa375d","unresolved":false,"context_lines":[{"line_number":98,"context_line":"            return user_id"},{"line_number":99,"context_line":"        if project_id:"},{"line_number":100,"context_line":"            return project_id"},{"line_number":101,"context_line":"        rest.abort(400, \"Unable to determine current user\")"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"class BasicAuthHelper(object):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a3905b3_f3cd88b8","line":101,"range":{"start_line":101,"start_character":18,"end_line":101,"end_character":23},"in_reply_to":"5a3905b3_1afb0a7a","updated":"2017-01-24 17:55:51.000000000","message":"Hum yeah.","commit_id":"4250560ac01d6aeb91503cfa81166daef1cdd882"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"e5dc892d6c52b7e04330d249c0f870ad2068e040","unresolved":false,"context_lines":[{"line_number":98,"context_line":"            return user_id"},{"line_number":99,"context_line":"        if project_id:"},{"line_number":100,"context_line":"            return project_id"},{"line_number":101,"context_line":"        rest.abort(400, \"Unable to determine current user\")"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"class BasicAuthHelper(object):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a3905b3_fc5ab529","line":101,"range":{"start_line":101,"start_character":18,"end_line":101,"end_character":23},"in_reply_to":"5a3905b3_b3a4e0b9","updated":"2017-01-24 18:56:32.000000000","message":"It\u0027s not required by Gnocchi but by the auth middleware (badly named noauth)\n\nAlso keystone or any apache authXXX module also return 401 in such case.","commit_id":"4250560ac01d6aeb91503cfa81166daef1cdd882"},{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"387e1904921b418a1fe74a42868db896704f8b23","unresolved":false,"context_lines":[{"line_number":98,"context_line":"            return user_id"},{"line_number":99,"context_line":"        if project_id:"},{"line_number":100,"context_line":"            return project_id"},{"line_number":101,"context_line":"        rest.abort(400, \"Unable to determine current user\")"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"class BasicAuthHelper(object):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a3905b3_b3a4e0b9","line":101,"range":{"start_line":101,"start_character":18,"end_line":101,"end_character":23},"in_reply_to":"5a3905b3_f3cd88b8","updated":"2017-01-24 17:58:48.000000000","message":"I\u0027d disagree. This isn\u0027t auth, just required datum. 400 is correct.","commit_id":"4250560ac01d6aeb91503cfa81166daef1cdd882"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"d9a45da75d5523efde9df30ebbbaeae9b0a54132","unresolved":false,"context_lines":[{"line_number":98,"context_line":"            return user_id"},{"line_number":99,"context_line":"        if project_id:"},{"line_number":100,"context_line":"            return project_id"},{"line_number":101,"context_line":"        rest.abort(400, \"Unable to determine current user\")"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"class BasicAuthHelper(object):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a3905b3_9cd1b132","line":101,"range":{"start_line":101,"start_character":18,"end_line":101,"end_character":23},"in_reply_to":"5a3905b3_fc5ab529","updated":"2017-01-24 19:03:21.000000000","message":"It\u0027s definitely 4xx but I don\u0027t really know which one. 401 is meant for bad authentication and it is bad auth to not have those headers so…\n\nIn this case though Mehdi it is required by Gnocchi, there\u0027s no middleware for noauth.","commit_id":"4250560ac01d6aeb91503cfa81166daef1cdd882"}],"releasenotes/notes/noauth-force-headers-dda926ce83f810e8.yaml":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"794ee4bb2018de1992960a6ba1c008d07dd9afa7","unresolved":false,"context_lines":[{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":"  - \u003e-"},{"line_number":4,"context_line":"    The `noauth` authentication mode now requires that the `X-User-Id` and/or"},{"line_number":5,"context_line":"    `X-Project-Id` to be present for some operations."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3a461143_084d6a72","line":5,"range":{"start_line":5,"start_character":37,"end_line":5,"end_character":41},"updated":"2017-01-25 21:06:52.000000000","message":"this is really ambiguous. which operations require it and which dont?","commit_id":"9fbfba7521bd44d9d2bf42a06be56def0c280b18"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"b4ab36691f94a7c28f8c2348e707fd6b41662e5d","unresolved":false,"context_lines":[{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":"  - \u003e-"},{"line_number":4,"context_line":"    The `noauth` authentication mode now requires that the `X-User-Id` and/or"},{"line_number":5,"context_line":"    `X-Project-Id` to be present for some operations."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3a461143_cb37cae1","line":5,"range":{"start_line":5,"start_character":37,"end_line":5,"end_character":41},"in_reply_to":"3a461143_084d6a72","updated":"2017-01-26 08:29:56.000000000","message":"I don\u0027t think it\u0027s a good idea to list as it could change  so I\u0027ll just remove that :)","commit_id":"9fbfba7521bd44d9d2bf42a06be56def0c280b18"}]}