)]}'
{"gnocchi/cli.py":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"d133a82edea8de096ff07c3b0a7a71e3ec55232f","unresolved":false,"context_lines":[{"line_number":74,"context_line":"def change_sack_size():"},{"line_number":75,"context_line":"    conf \u003d cfg.ConfigOpts()"},{"line_number":76,"context_line":"    conf.register_cli_opts(["},{"line_number":77,"context_line":"        cfg.IntOpt(\"sack_size\", required\u003dTrue, min\u003d8,"},{"line_number":78,"context_line":"                   help\u003d\"Number of sacks.\"),"},{"line_number":79,"context_line":"    ])"},{"line_number":80,"context_line":"    conf \u003d service.prepare_service(conf\u003dconf)"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f044301_5f6d2bca","line":77,"range":{"start_line":77,"start_character":51,"end_line":77,"end_character":52},"updated":"2017-05-11 14:24:42.000000000","message":"1?","commit_id":"4405c566b130dd1c1edd1a6728e0d0c79d91da0f"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"d133a82edea8de096ff07c3b0a7a71e3ec55232f","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    report \u003d s.incoming.measures_report(details\u003dFalse)"},{"line_number":83,"context_line":"    remainder \u003d report[\u0027summary\u0027][\u0027measures\u0027]"},{"line_number":84,"context_line":"    if remainder:"},{"line_number":85,"context_line":"        LOG.error(\u0027Cannot change sack when non-empty backlog. Process \u0027"},{"line_number":86,"context_line":"                  \u0027remaining %s measures and try again\u0027, remainder)"},{"line_number":87,"context_line":"        return"},{"line_number":88,"context_line":"    LOG.info(\"Changing sack size to: %s\", conf.sack_size)"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f044301_ff6757e8","line":85,"updated":"2017-05-11 14:24:42.000000000","message":"i like that","commit_id":"4405c566b130dd1c1edd1a6728e0d0c79d91da0f"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"d133a82edea8de096ff07c3b0a7a71e3ec55232f","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    LOG.info(\"Changing sack size to: %s\", conf.sack_size)"},{"line_number":89,"context_line":"    old_num_sacks \u003d s.incoming.get_storage_sacks()"},{"line_number":90,"context_line":"    s.incoming.set_storage_settings(conf.sack_size)"},{"line_number":91,"context_line":"    s.incoming.clean_old_sacks(old_num_sacks)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"def statsd():"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f044301_9fea930c","line":91,"updated":"2017-05-11 14:24:42.000000000","message":"i would not call that \"old sacks\" just remove_sacks or something\n\nalso I don\u0027t get where you create the new ones?","commit_id":"4405c566b130dd1c1edd1a6728e0d0c79d91da0f"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"d422b05e5e6b119fbe558a84aa9b7ed653c32ac3","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    LOG.info(\"Changing sack size to: %s\", conf.sack_size)"},{"line_number":89,"context_line":"    old_num_sacks \u003d s.incoming.get_storage_sacks()"},{"line_number":90,"context_line":"    s.incoming.set_storage_settings(conf.sack_size)"},{"line_number":91,"context_line":"    s.incoming.clean_old_sacks(old_num_sacks)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"def statsd():"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f044301_cd74f2d1","line":91,"in_reply_to":"3f044301_9fea930c","updated":"2017-05-11 19:11:08.000000000","message":"they are all prefix\u0027d by sack size. so if you create 128 sacks, the sacks are incoming128-1, incoming128-2, etc... if it\u0027s 64 sacks, it\u0027s incoming64-1, incoming64-2, etc...","commit_id":"4405c566b130dd1c1edd1a6728e0d0c79d91da0f"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"9ad213635038d9923ab6291e4fe9d8876b50129f","unresolved":false,"context_lines":[{"line_number":79,"context_line":"def change_sack_size():"},{"line_number":80,"context_line":"    conf \u003d cfg.ConfigOpts()"},{"line_number":81,"context_line":"    conf.register_cli_opts(["},{"line_number":82,"context_line":"        cfg.IntOpt(\"sack_size\", required\u003dTrue, min\u003d8,"},{"line_number":83,"context_line":"                   help\u003d\"Number of sacks.\"),"},{"line_number":84,"context_line":"    ])"},{"line_number":85,"context_line":"    conf \u003d service.prepare_service(conf\u003dconf)"}],"source_content_type":"text/x-python","patch_set":10,"id":"1f013ff3_96044b7d","line":82,"range":{"start_line":82,"start_character":51,"end_line":82,"end_character":52},"updated":"2017-05-15 08:59:22.000000000","message":"again, any reason for it to be 8?\n\n1 seems to make sense to me.","commit_id":"cd50e53fcbe87edacd7cce65f5eb2b5d3651cd1f"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"4b961dde6d7665223c8b3e3d13ea739fa8f8d6ec","unresolved":false,"context_lines":[{"line_number":79,"context_line":"def change_sack_size():"},{"line_number":80,"context_line":"    conf \u003d cfg.ConfigOpts()"},{"line_number":81,"context_line":"    conf.register_cli_opts(["},{"line_number":82,"context_line":"        cfg.IntOpt(\"sack_size\", required\u003dTrue, min\u003d8,"},{"line_number":83,"context_line":"                   help\u003d\"Number of sacks.\"),"},{"line_number":84,"context_line":"    ])"},{"line_number":85,"context_line":"    conf \u003d service.prepare_service(conf\u003dconf)"}],"source_content_type":"text/x-python","patch_set":10,"id":"1f013ff3_2021a9fc","line":82,"range":{"start_line":82,"start_character":51,"end_line":82,"end_character":52},"in_reply_to":"1f013ff3_96044b7d","updated":"2017-05-15 12:57:59.000000000","message":"i\u0027m indifferent. 1 makes it more likely that someone can screw up distribution logic. ie you set 1 bucket and more than one metricd meaning you have a lot of idle metricd","commit_id":"cd50e53fcbe87edacd7cce65f5eb2b5d3651cd1f"}],"gnocchi/storage/incoming/redis.py":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"9ad213635038d9923ab6291e4fe9d8876b50129f","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    def set_storage_settings(self, num_sacks):"},{"line_number":35,"context_line":"        self._client.hset(self.CFG_PREFIX, self.CFG_SACKS, num_sacks)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def remove_sack_group(self, num_sacks):"},{"line_number":38,"context_line":"        # NOTE(gordc): redis doesn\u0027t maintain keys with empty values"},{"line_number":39,"context_line":"        pass"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"1f013ff3_563b6337","line":37,"updated":"2017-05-15 08:59:22.000000000","message":"@staticmethod :)","commit_id":"cd50e53fcbe87edacd7cce65f5eb2b5d3651cd1f"}],"gnocchi/storage/incoming/s3.py":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"9ad213635038d9923ab6291e4fe9d8876b50129f","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        # NOTE(gordc): override to follow s3 partitioning logic"},{"line_number":60,"context_line":"        return \u0027%s-\u0027 + (\u0027%s/\u0027 % (num_sacks if num_sacks else self.NUM_SACKS))"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def remove_sack_group(self, num_sacks):"},{"line_number":63,"context_line":"        # nothing to cleanup since sacks are part of path"},{"line_number":64,"context_line":"        pass"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"1f013ff3_f6138fb7","line":62,"updated":"2017-05-15 08:59:22.000000000","message":"@staticmethod :)","commit_id":"cd50e53fcbe87edacd7cce65f5eb2b5d3651cd1f"}]}