)]}'
{"gnocchi/indexer/sqlalchemy.py":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"7f1d5382bfb8c572c2fdc6334b7683d4fbc9fd44","unresolved":false,"context_lines":[{"line_number":677,"context_line":"            if ids is not None:"},{"line_number":678,"context_line":"                q \u003d q.filter(Metric.id.in_(ids))"},{"line_number":679,"context_line":"            if creator is not None:"},{"line_number":680,"context_line":"                escaped_creator \u003d creator.replace(\"%\", \"\\\\%\")"},{"line_number":681,"context_line":"                if creator[0] \u003d\u003d \":\":"},{"line_number":682,"context_line":"                    q \u003d q.filter(Metric.creator.like("},{"line_number":683,"context_line":"                        \"%%%s\" % escaped_creator, escape\u003d\"\\\\\"))"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_14f1b895","side":"PARENT","line":680,"updated":"2017-04-28 07:56:30.000000000","message":"u sure? does not look like we have a test","commit_id":"1ceae1f27d4c47f8d623617d924fc8e9c80c6c50"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"d53a5d094a8e9e62fc3cca6a44347f00574f39ad","unresolved":false,"context_lines":[{"line_number":677,"context_line":"            if ids is not None:"},{"line_number":678,"context_line":"                q \u003d q.filter(Metric.id.in_(ids))"},{"line_number":679,"context_line":"            if creator is not None:"},{"line_number":680,"context_line":"                escaped_creator \u003d creator.replace(\"%\", \"\\\\%\")"},{"line_number":681,"context_line":"                if creator[0] \u003d\u003d \":\":"},{"line_number":682,"context_line":"                    q \u003d q.filter(Metric.creator.like("},{"line_number":683,"context_line":"                        \"%%%s\" % escaped_creator, escape\u003d\"\\\\\"))"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_a82064ad","side":"PARENT","line":680,"in_reply_to":"5ff73747_14f1b895","updated":"2017-04-28 08:45:25.000000000","message":"I have removed this.","commit_id":"1ceae1f27d4c47f8d623617d924fc8e9c80c6c50"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"9c1ef93835b3b65c7882fcd00738955b31c6eb99","unresolved":false,"context_lines":[{"line_number":683,"context_line":"                    q \u003d q.filter(Metric.creator.like(\"%s%%\" % creator))"},{"line_number":684,"context_line":"                else:"},{"line_number":685,"context_line":"                    q \u003d q.filter(Metric.creator \u003d\u003d creator)"},{"line_number":686,"context_line":""},{"line_number":687,"context_line":"            for attr in kwargs:"},{"line_number":688,"context_line":"                q \u003d q.filter(getattr(Metric, attr) \u003d\u003d kwargs[attr])"},{"line_number":689,"context_line":"            if details:"}],"source_content_type":"text/x-python","patch_set":3,"id":"5ff73747_adde2e0e","line":686,"updated":"2017-04-28 12:12:40.000000000","message":"unrelated","commit_id":"6159841d0d9ffcf288a05ce68c9d49f20109692d"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"f002ae6c0d36d4eb7e14708bf138a4381bd0bbf4","unresolved":false,"context_lines":[{"line_number":683,"context_line":"                    q \u003d q.filter(Metric.creator.like(\"%s%%\" % creator))"},{"line_number":684,"context_line":"                else:"},{"line_number":685,"context_line":"                    q \u003d q.filter(Metric.creator \u003d\u003d creator)"},{"line_number":686,"context_line":""},{"line_number":687,"context_line":"            for attr in kwargs:"},{"line_number":688,"context_line":"                q \u003d q.filter(getattr(Metric, attr) \u003d\u003d kwargs[attr])"},{"line_number":689,"context_line":"            if details:"}],"source_content_type":"text/x-python","patch_set":3,"id":"5ff73747_dd2a3ed9","line":686,"in_reply_to":"5ff73747_adde2e0e","updated":"2017-04-28 18:54:26.000000000","message":"It\u0027s the essential central point of this change.","commit_id":"6159841d0d9ffcf288a05ce68c9d49f20109692d"}],"gnocchi/rest/__init__.py":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"7f1d5382bfb8c572c2fdc6334b7683d4fbc9fd44","unresolved":false,"context_lines":[{"line_number":537,"context_line":"        return m"},{"line_number":538,"context_line":""},{"line_number":539,"context_line":"    MetricListSchema \u003d voluptuous.Schema({"},{"line_number":540,"context_line":"        \"user_id\": six.text_type,"},{"line_number":541,"context_line":"        \"project_id\": six.text_type,"},{"line_number":542,"context_line":"        \"creator\": six.text_type,"},{"line_number":543,"context_line":"        \"limit\": six.text_type,"},{"line_number":544,"context_line":"        \"name\": six.text_type,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_b4e324d9","line":541,"range":{"start_line":540,"start_character":0,"end_line":541,"end_character":36},"updated":"2017-04-28 07:56:30.000000000","message":"nop","commit_id":"3844a156399be51fe8cb0e8acd88c96484403cd0"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"d53a5d094a8e9e62fc3cca6a44347f00574f39ad","unresolved":false,"context_lines":[{"line_number":537,"context_line":"        return m"},{"line_number":538,"context_line":""},{"line_number":539,"context_line":"    MetricListSchema \u003d voluptuous.Schema({"},{"line_number":540,"context_line":"        \"user_id\": six.text_type,"},{"line_number":541,"context_line":"        \"project_id\": six.text_type,"},{"line_number":542,"context_line":"        \"creator\": six.text_type,"},{"line_number":543,"context_line":"        \"limit\": six.text_type,"},{"line_number":544,"context_line":"        \"name\": six.text_type,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_cb296a8a","line":541,"range":{"start_line":540,"start_character":0,"end_line":541,"end_character":36},"in_reply_to":"5ff73747_b4e324d9","updated":"2017-04-28 08:45:25.000000000","message":"nop ? Should we drop backward compat ?","commit_id":"3844a156399be51fe8cb0e8acd88c96484403cd0"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"3fba580f92a8aaef571147a4107474ac69700367","unresolved":false,"context_lines":[{"line_number":537,"context_line":"        return m"},{"line_number":538,"context_line":""},{"line_number":539,"context_line":"    MetricListSchema \u003d voluptuous.Schema({"},{"line_number":540,"context_line":"        \"user_id\": six.text_type,"},{"line_number":541,"context_line":"        \"project_id\": six.text_type,"},{"line_number":542,"context_line":"        \"creator\": six.text_type,"},{"line_number":543,"context_line":"        \"limit\": six.text_type,"},{"line_number":544,"context_line":"        \"name\": six.text_type,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_bef1be6d","line":541,"range":{"start_line":540,"start_character":0,"end_line":541,"end_character":36},"in_reply_to":"5ff73747_cb296a8a","updated":"2017-04-28 09:57:58.000000000","message":"ah, my explanation before coffee are not so great\n\nno sorry I thought you were adding filtering that, I forgot it was used for creator compat. nevermind!","commit_id":"3844a156399be51fe8cb0e8acd88c96484403cd0"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"9c1ef93835b3b65c7882fcd00738955b31c6eb99","unresolved":false,"context_lines":[{"line_number":579,"context_line":"            attr_filter[\u0027creator\u0027] \u003d provided_creator"},{"line_number":580,"context_line":"        attr_filter.update(get_pagination_options("},{"line_number":581,"context_line":"            kwargs, METRIC_DEFAULT_PAGINATION))"},{"line_number":582,"context_line":"        attr_filter.update(kwargs)"},{"line_number":583,"context_line":"        try:"},{"line_number":584,"context_line":"            return pecan.request.indexer.list_metrics(**attr_filter)"},{"line_number":585,"context_line":"        except indexer.IndexerException as e:"}],"source_content_type":"text/x-python","patch_set":3,"id":"5ff73747_0d264216","line":582,"updated":"2017-04-28 12:12:40.000000000","message":"this will overwrite the pagination values from get_pagination_options i think? specifically the max_limit check?","commit_id":"6159841d0d9ffcf288a05ce68c9d49f20109692d"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"f002ae6c0d36d4eb7e14708bf138a4381bd0bbf4","unresolved":false,"context_lines":[{"line_number":579,"context_line":"            attr_filter[\u0027creator\u0027] \u003d provided_creator"},{"line_number":580,"context_line":"        attr_filter.update(get_pagination_options("},{"line_number":581,"context_line":"            kwargs, METRIC_DEFAULT_PAGINATION))"},{"line_number":582,"context_line":"        attr_filter.update(kwargs)"},{"line_number":583,"context_line":"        try:"},{"line_number":584,"context_line":"            return pecan.request.indexer.list_metrics(**attr_filter)"},{"line_number":585,"context_line":"        except indexer.IndexerException as e:"}],"source_content_type":"text/x-python","patch_set":3,"id":"5ff73747_3d1a42cb","line":582,"in_reply_to":"5ff73747_0d264216","updated":"2017-04-28 18:54:26.000000000","message":"I have changed get_pagination_options to drop consumed keys.\nAlso kwargs can have only keys present into the schema and max_limit is not in the schema.","commit_id":"6159841d0d9ffcf288a05ce68c9d49f20109692d"}]}