)]}'
{"reference/active-reviewers.rst":[{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"924eddc1b4bcd7b563f3403bedf57d2c2bfb5746","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"* Reviewed at least 30 reviews over the last 6 months"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"* Reviewed at least 5% of the proposed changes over the last 6 months"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"The 6 months period is evaluate from the moment the script is executed and it\u0027s"},{"line_number":30,"context_line":"not tight to a specific release cycle."}],"source_content_type":"text/x-rst","patch_set":1,"id":"1aa78d24_9b7245af","line":27,"range":{"start_line":27,"start_character":2,"end_line":27,"end_character":69},"updated":"2016-07-14 15:22:29.000000000","message":"Is that reviewed 5% of the changes, or has a number of reviews that is \u003e\u003d  5% of the number of proposed commits ?\n\n(aka - if a repo had 100 commits, would 4 reviews to one change, and 1 to another be enough? )","commit_id":"7025b3dc6d4fed6cb7071b9f975b2cf53eabc57c"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"924eddc1b4bcd7b563f3403bedf57d2c2bfb5746","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"The criteria used to evaluate active members activity is:"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"* Reviewed at least 30 reviews over the last 6 months"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"* Reviewed at least 5% of the proposed changes over the last 6 months"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"The 6 months period is evaluate from the moment the script is executed and it\u0027s"},{"line_number":30,"context_line":"not tight to a specific release cycle."}],"source_content_type":"text/x-rst","patch_set":1,"id":"1aa78d24_30a6d053","line":27,"range":{"start_line":25,"start_character":0,"end_line":27,"end_character":69},"updated":"2016-07-14 15:22:29.000000000","message":"is it both or one of them?\n\nAt what threshold? (aka 30 review, or 5% of changes, whichever is lower (or higher))?","commit_id":"7025b3dc6d4fed6cb7071b9f975b2cf53eabc57c"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"38c64a8d3386576de8c484672ec6e4beef373420","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"* Reviewed at least 30 reviews over the last 6 months"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"* Reviewed at least 5% of the proposed changes over the last 6 months"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"The 6 months period is evaluate from the moment the script is executed and it\u0027s"},{"line_number":30,"context_line":"not tight to a specific release cycle."}],"source_content_type":"text/x-rst","patch_set":1,"id":"1aa78d24_fb21c9fd","line":27,"range":{"start_line":27,"start_character":2,"end_line":27,"end_character":69},"in_reply_to":"1aa78d24_9b7245af","updated":"2016-07-14 15:32:53.000000000","message":"It\u0027s an OR. \n\nMind moving your other question here: https://review.openstack.org/#/c/337853/ ?\n\nThanks","commit_id":"7025b3dc6d4fed6cb7071b9f975b2cf53eabc57c"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"7c0dd4994ba7736d7c231fbba5890400aae26b08","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"* Reviewed at least 30 reviews over the last 6 months"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"* Reviewed at least 5% of the proposed changes over the last 6 months"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"The 6 months period is evaluate from the moment the script is executed and it\u0027s"},{"line_number":30,"context_line":"not tight to a specific release cycle."}],"source_content_type":"text/x-rst","patch_set":1,"id":"1aa78d24_db396df4","line":27,"range":{"start_line":27,"start_character":2,"end_line":27,"end_character":69},"in_reply_to":"1aa78d24_fb21c9fd","updated":"2016-07-14 15:37:01.000000000","message":"and (I am assuming) whichever is a lower number? - it would be good to call that out explicitly.\n\nI am assuming that asking me to move it is means that it should be one review per patchset? (i.e. in the hypothetical example above - it should be 1 review on 5 different patches? )","commit_id":"7025b3dc6d4fed6cb7071b9f975b2cf53eabc57c"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"99cc08e4f87ee2d0cba86ed182528f1ba4eddf37","unresolved":false,"context_lines":[{"line_number":6,"context_line":"common agreement on what metrics indicate activity in a project. The reference"},{"line_number":7,"context_line":"definition of an active reviewer is measured through metrics and parameters and"},{"line_number":8,"context_line":"defined in Python scripts stored in this repository. The scope of the definition"},{"line_number":9,"context_line":"is per project. Often core members are the most active reviewers of patch sets."},{"line_number":10,"context_line":"This document establishes the metrics and the parameters around them."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Goal"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fad55976_24924e58","line":9,"range":{"start_line":9,"start_character":16,"end_line":9,"end_character":78},"updated":"2016-07-15 16:01:17.000000000","message":"is this suppose to reference suppose to be linked to core members only? the name is seems to imply generic context but this seems to reference core members.","commit_id":"cfe30b185f0f9d1211f5f9a602b9a6dfb38669d7"},{"author":{"_account_id":964,"name":"Anne Gentle","email":"annegentle@justwriteclick.com","username":"annegentle"},"change_message_id":"21bcdae0770f0e0a1e17243beb4bead9fa567801","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"* Reviewed at least 5% of the proposed changes over the last 6 months"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"The 6 months period is evaluate from the moment the script is executed and it\u0027s"},{"line_number":30,"context_line":"not tight to a specific release cycle."}],"source_content_type":"text/x-rst","patch_set":4,"id":"dada55a8_5381e349","line":29,"updated":"2016-07-18 17:47:33.000000000","message":"I don\u0027t think vagarity in this threshold is what we want, though I suppose we\u0027ll need to be specific when this is run in relation to the age of the project itself. Perhaps not as important as relating it to the release cycles.\n\nMy suggestion:\n\nThe six-month period is evaluated at a point in time starting with when the script is run, to a date six month prior to the date the script is run. As we begin using this script for tagging purposes, we can get data in six-month windows related or not related to the release cycles, thinking about newer teams having time to establish the team as well as mature projects watching for patterns.","commit_id":"cfe30b185f0f9d1211f5f9a602b9a6dfb38669d7"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"99cc08e4f87ee2d0cba86ed182528f1ba4eddf37","unresolved":false,"context_lines":[{"line_number":27,"context_line":"* Reviewed at least 5% of the proposed changes over the last 6 months"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"The 6 months period is evaluate from the moment the script is executed and it\u0027s"},{"line_number":30,"context_line":"not tight to a specific release cycle."}],"source_content_type":"text/x-rst","patch_set":4,"id":"fad55976_24488e2d","line":30,"updated":"2016-07-15 16:01:17.000000000","message":"s/tight to/associated with/","commit_id":"cfe30b185f0f9d1211f5f9a602b9a6dfb38669d7"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"669745e981593789faecff16bc729010023bf6b1","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This metric is not used - and it should never be used - to evaluate reviewers"},{"line_number":16,"context_line":"performance or any other personal evaluation. This metric is meant to be used by"},{"line_number":17,"context_line":"the governance team and within the governance realm as a way to avoid false"},{"line_number":18,"context_line":"positive when evaluating a project\u0027s health."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Threshold"},{"line_number":21,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"dada55a8_c89bdec7","line":18,"range":{"start_line":17,"start_character":61,"end_line":18,"end_character":44},"updated":"2016-07-26 17:50:32.000000000","message":"Nit: a way to estimate which reviewers are the most \"active\".","commit_id":"6c81e6b0653d669d2d47295429cc1aec8e0c05d3"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"669745e981593789faecff16bc729010023bf6b1","unresolved":false,"context_lines":[{"line_number":20,"context_line":"Threshold"},{"line_number":21,"context_line":"---------"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Either of the following metrics are used to determine activity:"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"* Reviewed at least 30 reviews over the last 6 months"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"dada55a8_6debe4dc","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":6},"updated":"2016-07-26 17:50:32.000000000","message":"The higher of these two metrics, I guess?","commit_id":"6c81e6b0653d669d2d47295429cc1aec8e0c05d3"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"35754c009ef285b2a34321b79f9c2d60ad7b48f3","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"* Reviewed at least 30 reviews over the last 6 months"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"* Reviewed at least 5% of the proposed changes over the last 6 months"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"The 6 months period is evaluate from the moment the script is executed and it\u0027s"},{"line_number":30,"context_line":"not tight to a specific release cycle."}],"source_content_type":"text/x-rst","patch_set":5,"id":"dada55a8_c77d11b3","line":27,"updated":"2016-07-22 20:33:00.000000000","message":"Has a number of reviews equal or greater to x% of the proposed patches over the last 6 months.\n\nThat is what the parent patch is actually checking.","commit_id":"6c81e6b0653d669d2d47295429cc1aec8e0c05d3"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"669745e981593789faecff16bc729010023bf6b1","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"* Reviewed at least 30 reviews over the last 6 months"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"* Reviewed at least 5% of the proposed changes over the last 6 months"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"The 6 months period is evaluate from the moment the script is executed and it\u0027s"},{"line_number":30,"context_line":"not tight to a specific release cycle."}],"source_content_type":"text/x-rst","patch_set":5,"id":"dada55a8_e80a221f","line":27,"range":{"start_line":27,"start_character":20,"end_line":27,"end_character":21},"updated":"2016-07-26 17:50:32.000000000","message":"The other patch does 2% I think. I slightly prefer 5%, but lets be consistent.","commit_id":"6c81e6b0653d669d2d47295429cc1aec8e0c05d3"}],"reference/tags/team_diverse-affiliation.rst":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"99cc08e4f87ee2d0cba86ed182528f1ba4eddf37","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"This tag refers to the definition of active reviewers as described in the"},{"line_number":63,"context_line":":doc:`Active Reviewers \u003c../active-reviewers\u003e` reference . Inactive core"},{"line_number":64,"context_line":"reviewers won\u0027t be included in the core metrics."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"The timeline used for evaluation is based on the past 6 months, and should be"},{"line_number":67,"context_line":"updated around the same time as the 6 month release."}],"source_content_type":"text/x-rst","patch_set":4,"id":"fad55976_5f8d8f7a","line":64,"updated":"2016-07-15 16:01:17.000000000","message":"bringing it up again but it seems wrong to have review specific pre-conditions when commits are part of the metric criteria. it\u0027d be best to remove commits from metric if we want to add this pre-condition that certain reviews are required.\n\ni\u0027ll just add a disclaimer that i\u0027m against tags in general so feel to factor that in when reading my comment. :)","commit_id":"cfe30b185f0f9d1211f5f9a602b9a6dfb38669d7"},{"author":{"_account_id":22141,"name":"Rodrigo Caballero","email":"rodrigo.caballero.abraham@intel.com","username":"rcaballeromx"},"change_message_id":"d8e69c27f554a873d1f29e717b92741737053b18","unresolved":false,"context_lines":[{"line_number":59,"context_line":"* the union of the active memberships of the core review teams associated with"},{"line_number":60,"context_line":"  the git repositories managed by the team"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"This tag measures reviewer\u0027s activity based on the rules defined in the"},{"line_number":63,"context_line":"`tools/teamstats.py` script. According to this script, reviewers must have"},{"line_number":64,"context_line":"reviewed at least 30 patches or have reviewed at least 2% of the proposed"},{"line_number":65,"context_line":"patches over the last 6 months."}],"source_content_type":"text/x-rst","patch_set":7,"id":"9a89bdaa_9bca68a0","line":62,"range":{"start_line":62,"start_character":17,"end_line":62,"end_character":28},"updated":"2016-09-05 15:59:53.000000000","message":"the reviewer\u0027s","commit_id":"b6414ad1acae19c9d7245166596fb9a5a9a23d54"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"470e62ac9d4600bd57c5873a8a39ff2cda02358c","unresolved":false,"context_lines":[{"line_number":59,"context_line":"* the union of the active memberships of the core review teams associated with"},{"line_number":60,"context_line":"  the git repositories managed by the team"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"This tag measures reviewer\u0027s activity based on the rules defined in the"},{"line_number":63,"context_line":"`tools/teamstats.py` script. According to this script, reviewers must have"},{"line_number":64,"context_line":"reviewed at least 30 patches or have reviewed at least 2% of the proposed"},{"line_number":65,"context_line":"patches over the last 6 months."}],"source_content_type":"text/x-rst","patch_set":7,"id":"9a89bdaa_8e583534","line":62,"range":{"start_line":62,"start_character":17,"end_line":62,"end_character":28},"in_reply_to":"9a89bdaa_80210f50","updated":"2016-09-06 16:26:12.000000000","message":"The plural possessive form based on the rules I was always taught would be reviewers\u0027 (add the apostrophe to the end after the s that makes reviewers plural).\n\nThat said, the rewritten version is good, too.\n\nAdding \"a\" or \"the\" would make the subjects of first and second sentences disagree, since one would be singular and the other plural.","commit_id":"b6414ad1acae19c9d7245166596fb9a5a9a23d54"},{"author":{"_account_id":964,"name":"Anne Gentle","email":"annegentle@justwriteclick.com","username":"annegentle"},"change_message_id":"04462f11e8f659fb565bb14b562c4773899b957c","unresolved":false,"context_lines":[{"line_number":59,"context_line":"* the union of the active memberships of the core review teams associated with"},{"line_number":60,"context_line":"  the git repositories managed by the team"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"This tag measures reviewer\u0027s activity based on the rules defined in the"},{"line_number":63,"context_line":"`tools/teamstats.py` script. According to this script, reviewers must have"},{"line_number":64,"context_line":"reviewed at least 30 patches or have reviewed at least 2% of the proposed"},{"line_number":65,"context_line":"patches over the last 6 months."}],"source_content_type":"text/x-rst","patch_set":7,"id":"9a89bdaa_80210f50","line":62,"range":{"start_line":62,"start_character":17,"end_line":62,"end_character":28},"in_reply_to":"9a89bdaa_9bca68a0","updated":"2016-09-06 01:33:17.000000000","message":"Heh, I\u0027m not sure what is grammatically correct here. It\u0027s plural reviewers. Here\u0027s a revision avoiding the awkward possessive.\n\nThis tag is applied based on the `tools/teamstats.py` script. According to this script, reviewers must have reviewed at least 30 patches or have reviewed at least 2% of the total proposed patches over the last six months.","commit_id":"b6414ad1acae19c9d7245166596fb9a5a9a23d54"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"2358300e9733842b1bf3fd84847bfb61d7ad0efe","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"This tag measures reviewer\u0027s activity based on the rules defined in the"},{"line_number":63,"context_line":"`tools/teamstats.py` script. According to this script, reviewers must have"},{"line_number":64,"context_line":"reviewed at least 30 patches or have reviewed at least 2% of the proposed"},{"line_number":65,"context_line":"patches over the last 6 months."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"The timeline used for evaluation is based on the past 6 months, and should be"}],"source_content_type":"text/x-rst","patch_set":7,"id":"9a89bdaa_63b895e6","line":64,"range":{"start_line":64,"start_character":65,"end_line":64,"end_character":73},"updated":"2016-09-06 02:37:10.000000000","message":"proposed or merged. either is fine, I\u0027m just curious about the choice of proposed. Does this include abandoned, unmerged changes?","commit_id":"b6414ad1acae19c9d7245166596fb9a5a9a23d54"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"470e62ac9d4600bd57c5873a8a39ff2cda02358c","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"This tag measures reviewer\u0027s activity based on the rules defined in the"},{"line_number":63,"context_line":"`tools/teamstats.py` script. According to this script, reviewers must have"},{"line_number":64,"context_line":"reviewed at least 30 patches or have reviewed at least 2% of the proposed"},{"line_number":65,"context_line":"patches over the last 6 months."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"The timeline used for evaluation is based on the past 6 months, and should be"}],"source_content_type":"text/x-rst","patch_set":7,"id":"9a89bdaa_8be90783","line":64,"range":{"start_line":64,"start_character":65,"end_line":64,"end_character":73},"in_reply_to":"9a89bdaa_63b895e6","updated":"2016-09-06 16:26:12.000000000","message":"We\u0027re talking about reviewers, not contributors, so in this case I think it makes sense to cover all proposed patches and not just those that have merged. A review that leads to a patch being abandoned is still a legitimate review.","commit_id":"b6414ad1acae19c9d7245166596fb9a5a9a23d54"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"a46ff6148c2c100d81d8c8aa19297c5dbd5d7e36","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"This tag measures reviewer\u0027s activity based on the rules defined in the"},{"line_number":63,"context_line":"`tools/teamstats.py` script. According to this script, reviewers must have"},{"line_number":64,"context_line":"reviewed at least 30 patches or have reviewed at least 2% of the proposed"},{"line_number":65,"context_line":"patches over the last 6 months."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"The timeline used for evaluation is based on the past 6 months, and should be"}],"source_content_type":"text/x-rst","patch_set":7,"id":"9a89bdaa_fda6cc51","line":64,"range":{"start_line":64,"start_character":65,"end_line":64,"end_character":73},"in_reply_to":"9a89bdaa_8be90783","updated":"2016-09-06 20:12:44.000000000","message":"As doug clarified in IRC, we\u0027re saying the same thing. I\u0027ll revert my -1.","commit_id":"b6414ad1acae19c9d7245166596fb9a5a9a23d54"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"221854002cd0afb6bf9d1638cee50621cbb3c84c","unresolved":false,"context_lines":[{"line_number":59,"context_line":"* the union of the active memberships of the core review teams associated with"},{"line_number":60,"context_line":"  the git repositories managed by the team"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"This tag is applied based on the `tools/teamstats.py` script. According to this"},{"line_number":63,"context_line":"script, reviewers must have proposed review comments to at least 30 patches or"},{"line_number":64,"context_line":"to at least 2% of the total proposed patches over the last six months."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"The timeline used for evaluation is based on the past 6 months, and should be"},{"line_number":67,"context_line":"updated around the same time as the 6 month release."}],"source_content_type":"text/x-rst","patch_set":8,"id":"9a89bdaa_b8ca926c","line":64,"range":{"start_line":62,"start_character":0,"end_line":64,"end_character":70},"updated":"2016-09-06 20:31:35.000000000","message":"since we\u0027re going to talk about this in the \"open discussion\" part of the TC meeting today, I\u0027ve put some thoughts together in this etherpad.\n\nhttps://etherpad.openstack.org/p/gMPYW40Fmq","commit_id":"79ace8bad20c201d4b57cbf09dd023858cfc0e71"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"f38ff7f3002472413b0d1d3c7d07c508fb970c65","unresolved":false,"context_lines":[{"line_number":59,"context_line":"* the union of the active memberships of the core review teams associated with"},{"line_number":60,"context_line":"  the git repositories managed by the team"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"This tag is applied based on the `tools/teamstats.py` script. According to this"},{"line_number":63,"context_line":"script, reviewers must have proposed review comments to at least 30 patches or"},{"line_number":64,"context_line":"to at least 2% of the total proposed patches over the last six months."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"The timeline used for evaluation is based on the past 6 months, and should be"},{"line_number":67,"context_line":"updated around the same time as the 6 month release."}],"source_content_type":"text/x-rst","patch_set":8,"id":"9a89bdaa_ff969b3c","line":64,"range":{"start_line":62,"start_character":0,"end_line":64,"end_character":70},"in_reply_to":"9a89bdaa_32d77e4c","updated":"2016-09-07 12:48:34.000000000","message":"Reviewing what the tool does, (see teamstats.py), it computes (in _get_number_of_commits(), the total number of merged changes in a period of six months, for a given module (group).\n\nWe then compute 2% of that in get_team_size_stats and derive min_percent.\n\nmin_percent is a number that represents, in words, \"2% of the total number of merged changes in the project during the preceding six months\".\n\nWe then evaluate whether each engineer with a review in that same project has at least MIN_REVIEWS (30) or min_percent. In English, that is,\n\n\"A reviewer is an active reviewer if he or she has either 30 reviews, or 2% of the total number of merged changes in the project for the preceding six months, whichever is lower\".\n\nThis is NOT what is being said above. What is being said above is that the 2% is computed on the total \"proposed patches\".\n\nTwo distinctions, there from what the tool measures:\n\n- it is proposed, not merged\n- it is patches, not change sets (what\u0027s a patch, and what\u0027s a change set?)\n\nIn Gerrit terminology, a patch set is a revision of a change set. I assume therefore that a patch is analogous to a patch set.\n\nIf a proposed fix (change set) goes through 13 patch sets, that should be counted as 13 patch sets. The tool counts commits ( see _get_number_of_commits). So in the example change set with 13 patch sets, the verbiage above would have you count \"13\", the tool would count \"1\".\n\nThe verbiage above would indicate that if Bob posted three comments on a given patch set, that would be counted as \"1\". The tool would actually count the number of comments \"3\".\n\nIn my write-up https://etherpad.openstack.org/p/gMPYW40Fmq I said comments with a score of -2, -1, 0, 1, 2. It turns out that stackalytics only counts -2, -1, 1, and 2. 0\u0027s are not counted.\n\nFor all of these reasons, I submit to you that the verbiage above does not describe what the tool does.\n\nWhat the tool does is:\n\nThis tag is applied based on the `tools/teamstats.py` script. According to this script, an active reviewer is one who has proposed at least a certain minimum number of non-zero comments (the threshold) on proposed changes over the past six months. The threshold is computed as the lesser of 30, or 2% of the total number of changes merged in the project over the past six months. \n\nAccordingly, any reviewer who has posted a number of non-zero comments exceeding the lesser of 30, and 2% of the total number of changes merged in the project over the past six months is considered to be an active reviewer in the project.\n\nI believe that this is NOT what is intended. \n\nFor more on the issue of 0 comments in reviews, see my comment dated Jul 8 7:39 AM on https://review.openstack.org/#/c/337853/2\n\nOn the subject of whether we were after patch sets or commits, see my comments dated Jul 25 10:38 AM on https://review.openstack.org/#/c/337853/6 where I provided a list of projects with over the threshold of 600 merged changes (commits) in the past six months.\n\nI submit to you that this change proposed here is not consistent with the tool, or the spirit of the discussion in https://review.openstack.org/#/c/337853/","commit_id":"79ace8bad20c201d4b57cbf09dd023858cfc0e71"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"d4e1ccf28a1042bbade20315851571af5577075f","unresolved":false,"context_lines":[{"line_number":59,"context_line":"* the union of the active memberships of the core review teams associated with"},{"line_number":60,"context_line":"  the git repositories managed by the team"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"This tag is applied based on the `tools/teamstats.py` script. According to this"},{"line_number":63,"context_line":"script, reviewers must have proposed review comments to at least 30 patches or"},{"line_number":64,"context_line":"to at least 2% of the total proposed patches over the last six months."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"The timeline used for evaluation is based on the past 6 months, and should be"},{"line_number":67,"context_line":"updated around the same time as the 6 month release."}],"source_content_type":"text/x-rst","patch_set":8,"id":"9a89bdaa_32d77e4c","line":64,"range":{"start_line":62,"start_character":0,"end_line":64,"end_character":70},"in_reply_to":"9a89bdaa_b8ca926c","updated":"2016-09-06 21:57:57.000000000","message":"Based on the clarification from Doug in the etherpad referenced above, I\u0027m reverting my vote to -1.\n\nIn the terms of my example in that etherpad, this restriction is not clear about #2, and with respect to #1 it implies that the count would be that an active reviewer must have reviewed at least 2% of 5000 (2% of the total proposed patches).\n\nit makes no accommodation for a reviewer who reviews the same patch set multiple times (multiple reviews).\n\nDoug states, \" Every time someone registers a comment on a thing with a URL like https://review.openstack.org/#/c/342226/ that counts as 1 review. They need to perform whatever percent of those in order to be considered active.\"\n\nThat would be written as \"at least 2% of the reviews in the past six months\".","commit_id":"79ace8bad20c201d4b57cbf09dd023858cfc0e71"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"b4b3ce7d9e1b978feffe27ed02039649b60a25f7","unresolved":false,"context_lines":[{"line_number":59,"context_line":"* the union of the active memberships of the core review teams associated with"},{"line_number":60,"context_line":"  the git repositories managed by the team"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"This tag is applied based on the `tools/teamstats.py` script. According to this"},{"line_number":63,"context_line":"script, reviewers must have proposed review comments to at least 30 patches or"},{"line_number":64,"context_line":"to at least 2% of the total proposed patches over the last six months."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"The timeline used for evaluation is based on the past 6 months, and should be"},{"line_number":67,"context_line":"updated around the same time as the 6 month release."}],"source_content_type":"text/x-rst","patch_set":8,"id":"9a89bdaa_63ea55ae","line":64,"range":{"start_line":62,"start_character":0,"end_line":64,"end_character":70},"in_reply_to":"9a89bdaa_faeb6d10","updated":"2016-09-10 02:45:09.000000000","message":"I do not believe so but let me consider your response some more and get back to you.","commit_id":"79ace8bad20c201d4b57cbf09dd023858cfc0e71"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"17aed432bd83b28212cfb33403d788d814955d83","unresolved":false,"context_lines":[{"line_number":59,"context_line":"* the union of the active memberships of the core review teams associated with"},{"line_number":60,"context_line":"  the git repositories managed by the team"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"This tag is applied based on the `tools/teamstats.py` script. According to this"},{"line_number":63,"context_line":"script, reviewers must have proposed review comments to at least 30 patches or"},{"line_number":64,"context_line":"to at least 2% of the total proposed patches over the last six months."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"The timeline used for evaluation is based on the past 6 months, and should be"},{"line_number":67,"context_line":"updated around the same time as the 6 month release."}],"source_content_type":"text/x-rst","patch_set":8,"id":"9a89bdaa_faeb6d10","line":64,"range":{"start_line":62,"start_character":0,"end_line":64,"end_character":70},"in_reply_to":"9a89bdaa_ff969b3c","updated":"2016-09-09 20:12:46.000000000","message":"On second thought, my original comment on the etherpad may be too fine-grained.\n\nWe\u0027re actually counting reviewer participation in a thing with a URL like https://review.openstack.org/#/c/342225 (what Flavio calls a patch), and not each comment on that thing or each version of that thing (with URLs like https://review.openstack.org/#/c/342225/8 -- what I think Amrith is calling a patch as part of a patch set). That at least seems to match up closer to what stackalytics is actually collecting.\n\nThe intent of this patch was NOT to change what was being counted, just how the numbers are used. That is, we want to clarify that core reviewers don\u0027t count toward the diversity of a team if they are not actively reviewing things for that team. We fumbled a bit on explaining what active meant because of vague or overloaded meanings for \"patch\" and \"review\", but if we can clarify what those terms mean in the text here, that should resolve the issue, no?","commit_id":"79ace8bad20c201d4b57cbf09dd023858cfc0e71"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"f6299002b3ccbcdb0be0296982f9ae9612c272d1","unresolved":false,"context_lines":[{"line_number":60,"context_line":"  the git repositories managed by the team"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"This tag is applied based on the `tools/teamstats.py` script. The output of this"},{"line_number":63,"context_line":"script is then reviewed by the TC to verify it matches the reality."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"The timeline used for evaluation is based on the past 6 months, and should be"},{"line_number":66,"context_line":"updated around the same time as the 6 month release."}],"source_content_type":"text/x-rst","patch_set":9,"id":"7a8ec9b2_bd20df9c","line":63,"range":{"start_line":63,"start_character":47,"end_line":63,"end_character":66},"updated":"2016-09-20 20:46:16.000000000","message":"There is a little bikeshed right there, but I think thats good enough for now.","commit_id":"849801f381ff32f67b178b433ed4212506233f39"}],"reference/tags/team_single-vendor.rst":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"669745e981593789faecff16bc729010023bf6b1","unresolved":false,"context_lines":[{"line_number":63,"context_line":"This tag refers to the definition of active reviewers as described in the"},{"line_number":64,"context_line":":doc:`Active Reviewers \u003c../active-reviewers\u003e` reference . Inactive core"},{"line_number":65,"context_line":"reviewers won\u0027t be included in the core metrics."},{"line_number":66,"context_line":"     "},{"line_number":67,"context_line":"The application of this tag to new projects should be updated around the same"},{"line_number":68,"context_line":"time as the 6 month release. But the removal of this tag should happen shortly"},{"line_number":69,"context_line":"after it does not apply to a given project."}],"source_content_type":"text/x-rst","patch_set":5,"id":"dada55a8_081df661","line":66,"updated":"2016-07-26 17:50:32.000000000","message":"Nit: whitespace.","commit_id":"6c81e6b0653d669d2d47295429cc1aec8e0c05d3"},{"author":{"_account_id":22141,"name":"Rodrigo Caballero","email":"rodrigo.caballero.abraham@intel.com","username":"rcaballeromx"},"change_message_id":"d8e69c27f554a873d1f29e717b92741737053b18","unresolved":false,"context_lines":[{"line_number":60,"context_line":"* the union of the active members of the core review teams associated with the"},{"line_number":61,"context_line":"  git repositories managed by the team"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"This tag measures reviewer\u0027s activity based on the rules defined in the"},{"line_number":64,"context_line":"`tools/teamstats.py` script. According to this script, reviewers must have"},{"line_number":65,"context_line":"reviewed at least 30 patches or have reviewed at least 2% of the proposed"},{"line_number":66,"context_line":"patches over the last 6 months."}],"source_content_type":"text/x-rst","patch_set":7,"id":"9a89bdaa_db4b102a","line":63,"range":{"start_line":63,"start_character":17,"end_line":63,"end_character":29},"updated":"2016-09-05 15:59:53.000000000","message":"the reviewer\u0027s","commit_id":"b6414ad1acae19c9d7245166596fb9a5a9a23d54"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"f38ff7f3002472413b0d1d3c7d07c508fb970c65","unresolved":false,"context_lines":[{"line_number":60,"context_line":"* the union of the active members of the core review teams associated with the"},{"line_number":61,"context_line":"  git repositories managed by the team"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"This tag is applied based on the `tools/teamstats.py` script. According to this"},{"line_number":64,"context_line":"script, reviewers must have proposed review comments to at least 30 patches or"},{"line_number":65,"context_line":"to at least 2% of the total proposed patches over the last six months."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"The application of this tag to new projects should be updated around the same"},{"line_number":68,"context_line":"time as the 6 month release. But the removal of this tag should happen shortly"}],"source_content_type":"text/x-rst","patch_set":8,"id":"9a89bdaa_9fa82f79","line":65,"range":{"start_line":63,"start_character":0,"end_line":65,"end_character":70},"updated":"2016-09-07 12:48:34.000000000","message":"parallel comment to other file.","commit_id":"79ace8bad20c201d4b57cbf09dd023858cfc0e71"}]}
