)]}'
{"goals/queens/policy-in-code.rst":[{"author":{"_account_id":11589,"name":"Harry Rybacki","email":"hrybacki@redhat.com","username":"hrybacki"},"change_message_id":"20ec6b43f7f8125defdff2f8e5b96ff629849508","unresolved":false,"context_lines":[{"line_number":5,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"OpenStack services typically have a file that describes and enforces policy or"},{"line_number":8,"context_line":"Role Based Access Control for the APIs of that services. The file is usually"},{"line_number":9,"context_line":"maintained in the project source and documents the default policy values. The"},{"line_number":10,"context_line":"goal here would be to move default policy definitions from file-based"},{"line_number":11,"context_line":"maintenance to registering them in code. This is very similar to how we treat"}],"source_content_type":"text/x-rst","patch_set":1,"id":"df140735_e900e503","line":8,"updated":"2017-06-01 17:50:30.000000000","message":"/s/services/service/","commit_id":"f96ddfec9cdfe12228352480232c7a1e36768a32"},{"author":{"_account_id":11589,"name":"Harry Rybacki","email":"hrybacki@redhat.com","username":"hrybacki"},"change_message_id":"20ec6b43f7f8125defdff2f8e5b96ff629849508","unresolved":false,"context_lines":[{"line_number":17,"context_line":"#. The policy file can be removed for deployments that don\u0027t modify any default"},{"line_number":18,"context_line":"   policies."},{"line_number":19,"context_line":"#. Operators can remove default checks from policy files. The result is that"},{"line_number":20,"context_line":"   their policy file only contains the overridden policies they need for their"},{"line_number":21,"context_line":"   deployment. This makes policy maintenance easier."},{"line_number":22,"context_line":"#. Tooling can be used to generate sample policy files."},{"line_number":23,"context_line":"#. Tooling can be used to generate complete policy files that include overrides"}],"source_content_type":"text/x-rst","patch_set":1,"id":"df140735_c953e116","line":20,"updated":"2017-06-01 17:50:30.000000000","message":"I might emphasize this by adding it to the opening description -- put defaults in code, override (if needed) via file","commit_id":"f96ddfec9cdfe12228352480232c7a1e36768a32"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"36949c98d5bc65fb6ce20b094aa01a23dc525c3d","unresolved":false,"context_lines":[{"line_number":18,"context_line":"   policies."},{"line_number":19,"context_line":"#. Operators can remove default checks from policy files. The result is that"},{"line_number":20,"context_line":"   their policy file only contains the overridden policies they need for their"},{"line_number":21,"context_line":"   deployment. This makes policy maintenance easier."},{"line_number":22,"context_line":"#. Tooling can be used to generate sample policy files."},{"line_number":23,"context_line":"#. Tooling can be used to generate complete policy files that include overrides"},{"line_number":24,"context_line":"   from a specific policy file."}],"source_content_type":"text/x-rst","patch_set":3,"id":"df140735_b9c46492","line":21,"updated":"2017-06-02 11:16:49.000000000","message":"huge win","commit_id":"a873d52f1985ff1cb547e6a7ca2ef46136054367"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"36949c98d5bc65fb6ce20b094aa01a23dc525c3d","unresolved":false,"context_lines":[{"line_number":26,"context_line":"   operators."},{"line_number":27,"context_line":"#. Project developers have a way to communicate changing defaults to operators"},{"line_number":28,"context_line":"   through a library."},{"line_number":29,"context_line":"#. Project developers use the process of moving default into code and"},{"line_number":30,"context_line":"   documenting them as an exercise for understand the projects defaults and how"},{"line_number":31,"context_line":"   they might be improved."},{"line_number":32,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"df140735_f92adc29","line":29,"updated":"2017-06-02 11:16:49.000000000","message":"defaults","commit_id":"a873d52f1985ff1cb547e6a7ca2ef46136054367"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"f50534ee3b142d4f81d686d7ce38cac243310a52","unresolved":false,"context_lines":[{"line_number":26,"context_line":"   operators."},{"line_number":27,"context_line":"#. Project developers have a way to communicate changing defaults to operators"},{"line_number":28,"context_line":"   through a library."},{"line_number":29,"context_line":"#. Project developers use the process of moving default into code and"},{"line_number":30,"context_line":"   documenting them as an exercise for understand the projects defaults and how"},{"line_number":31,"context_line":"   they might be improved."},{"line_number":32,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"df140735_3f726bae","line":29,"in_reply_to":"df140735_f92adc29","updated":"2017-06-02 16:42:18.000000000","message":"Done","commit_id":"a873d52f1985ff1cb547e6a7ca2ef46136054367"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"36949c98d5bc65fb6ce20b094aa01a23dc525c3d","unresolved":false,"context_lines":[{"line_number":27,"context_line":"#. Project developers have a way to communicate changing defaults to operators"},{"line_number":28,"context_line":"   through a library."},{"line_number":29,"context_line":"#. Project developers use the process of moving default into code and"},{"line_number":30,"context_line":"   documenting them as an exercise for understand the projects defaults and how"},{"line_number":31,"context_line":"   they might be improved."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"By doing this, it becomes easier for developers and operators to move towards a"}],"source_content_type":"text/x-rst","patch_set":3,"id":"df140735_19db504f","line":30,"updated":"2017-06-02 11:16:49.000000000","message":"understanding the projects\u0027 (or project\u0027s, depending on which you mean)","commit_id":"a873d52f1985ff1cb547e6a7ca2ef46136054367"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"f50534ee3b142d4f81d686d7ce38cac243310a52","unresolved":false,"context_lines":[{"line_number":27,"context_line":"#. Project developers have a way to communicate changing defaults to operators"},{"line_number":28,"context_line":"   through a library."},{"line_number":29,"context_line":"#. Project developers use the process of moving default into code and"},{"line_number":30,"context_line":"   documenting them as an exercise for understand the projects defaults and how"},{"line_number":31,"context_line":"   they might be improved."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"By doing this, it becomes easier for developers and operators to move towards a"}],"source_content_type":"text/x-rst","patch_set":3,"id":"df140735_1f6b27b7","line":30,"in_reply_to":"df140735_19db504f","updated":"2017-06-02 16:42:18.000000000","message":"Oh - good catch. I reworded this to hopefully be a bit clearer. Let me know if it is!","commit_id":"a873d52f1985ff1cb547e6a7ca2ef46136054367"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"a094063a9c12302827de4e4eb3d93e27d273b186","unresolved":false,"context_lines":[{"line_number":39,"context_line":"Gerrit Topic"},{"line_number":40,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"To facilitate tracking, commits related to this goal should use the"},{"line_number":43,"context_line":"gerrit topic::"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"  \u003cpolicy-and-docs-in-code\u003e"}],"source_content_type":"text/x-rst","patch_set":3,"id":"df140735_087893c1","line":42,"range":{"start_line":42,"start_character":64,"end_line":42,"end_character":67},"updated":"2017-06-02 14:39:36.000000000","message":"in the","commit_id":"a873d52f1985ff1cb547e6a7ca2ef46136054367"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"f50534ee3b142d4f81d686d7ce38cac243310a52","unresolved":false,"context_lines":[{"line_number":39,"context_line":"Gerrit Topic"},{"line_number":40,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"To facilitate tracking, commits related to this goal should use the"},{"line_number":43,"context_line":"gerrit topic::"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"  \u003cpolicy-and-docs-in-code\u003e"}],"source_content_type":"text/x-rst","patch_set":3,"id":"df140735_ffacf3ed","line":42,"in_reply_to":"df140735_087893c1","updated":"2017-06-02 16:42:18.000000000","message":"I copy/pasted this from: \n\nhttps://github.com/openstack/governance/blob/master/goals/template.txt#gerrit-topic\n\nI can change folks think it will be easier to read though.","commit_id":"a873d52f1985ff1cb547e6a7ca2ef46136054367"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"36949c98d5bc65fb6ce20b094aa01a23dc525c3d","unresolved":false,"context_lines":[{"line_number":84,"context_line":"Note that this goal does not require the changing of default policies and only"},{"line_number":85,"context_line":"specifies moving the default into code and documenting them. If at a later"},{"line_number":86,"context_line":"time the community comes together and agrees upon a direction using specific"},{"line_number":87,"context_line":"default, we can leverage this work to make that transition easier."},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"As noted in the section above. The Compute and Identity projects have already"},{"line_number":90,"context_line":"completed these items as of the Pike release. The patterns used to implement"}],"source_content_type":"text/x-rst","patch_set":3,"id":"df140735_19b470f1","line":87,"updated":"2017-06-02 11:16:49.000000000","message":"defaults","commit_id":"a873d52f1985ff1cb547e6a7ca2ef46136054367"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"f50534ee3b142d4f81d686d7ce38cac243310a52","unresolved":false,"context_lines":[{"line_number":84,"context_line":"Note that this goal does not require the changing of default policies and only"},{"line_number":85,"context_line":"specifies moving the default into code and documenting them. If at a later"},{"line_number":86,"context_line":"time the community comes together and agrees upon a direction using specific"},{"line_number":87,"context_line":"default, we can leverage this work to make that transition easier."},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"As noted in the section above. The Compute and Identity projects have already"},{"line_number":90,"context_line":"completed these items as of the Pike release. The patterns used to implement"}],"source_content_type":"text/x-rst","patch_set":3,"id":"df140735_bfb2fb47","line":87,"in_reply_to":"df140735_19b470f1","updated":"2017-06-02 16:42:18.000000000","message":"Done","commit_id":"a873d52f1985ff1cb547e6a7ca2ef46136054367"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"36949c98d5bc65fb6ce20b094aa01a23dc525c3d","unresolved":false,"context_lines":[{"line_number":86,"context_line":"time the community comes together and agrees upon a direction using specific"},{"line_number":87,"context_line":"default, we can leverage this work to make that transition easier."},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"As noted in the section above. The Compute and Identity projects have already"},{"line_number":90,"context_line":"completed these items as of the Pike release. The patterns used to implement"},{"line_number":91,"context_line":"policy and policy documentation in code can serve as a reference for other"},{"line_number":92,"context_line":"projects looking to complete the goal."}],"source_content_type":"text/x-rst","patch_set":3,"id":"df140735_5991c846","line":89,"updated":"2017-06-02 11:16:49.000000000","message":"I tend to prefer to refer to the projects by their service type but since it is by project name below it should maybe be the same here? I dunno.","commit_id":"a873d52f1985ff1cb547e6a7ca2ef46136054367"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"f50534ee3b142d4f81d686d7ce38cac243310a52","unresolved":false,"context_lines":[{"line_number":86,"context_line":"time the community comes together and agrees upon a direction using specific"},{"line_number":87,"context_line":"default, we can leverage this work to make that transition easier."},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"As noted in the section above. The Compute and Identity projects have already"},{"line_number":90,"context_line":"completed these items as of the Pike release. The patterns used to implement"},{"line_number":91,"context_line":"policy and policy documentation in code can serve as a reference for other"},{"line_number":92,"context_line":"projects looking to complete the goal."}],"source_content_type":"text/x-rst","patch_set":3,"id":"df140735_9fea970c","line":89,"in_reply_to":"df140735_5991c846","updated":"2017-06-02 16:42:18.000000000","message":"Actually - that makes a lot more sense. Fixed here and above.","commit_id":"a873d52f1985ff1cb547e6a7ca2ef46136054367"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"36949c98d5bc65fb6ce20b094aa01a23dc525c3d","unresolved":false,"context_lines":[{"line_number":95,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":".. Use tools/build_team_section_for_goal.py to generate the rest of"},{"line_number":98,"context_line":"   the template and paste it into this section."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"barbican"}],"source_content_type":"text/x-rst","patch_set":3,"id":"df140735_b993445b","line":98,"updated":"2017-06-02 11:16:49.000000000","message":"you can probably delete this at some point\n\nAlso, do we know that all of these projects use policy as it\u0027s described here?\n\nI assume that if this goal is accepted, nova and keystone can immediately follow up with their completion artifacts?","commit_id":"a873d52f1985ff1cb547e6a7ca2ef46136054367"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"f50534ee3b142d4f81d686d7ce38cac243310a52","unresolved":false,"context_lines":[{"line_number":95,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":".. Use tools/build_team_section_for_goal.py to generate the rest of"},{"line_number":98,"context_line":"   the template and paste it into this section."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"barbican"}],"source_content_type":"text/x-rst","patch_set":3,"id":"df140735_5f3e3f8b","line":98,"in_reply_to":"df140735_b993445b","updated":"2017-06-02 16:42:18.000000000","message":"Oh - good call, I should have removed these bits before proposing the patch.\n\nI imagine there are going to be some projects that have either already done this work (e.g. nova and keystone) or don\u0027t fit within the requirements. I\u0027m not exactly sure which projects fall within the later though. I was hoping this proposal would start generating that discussion.\n\nIn the event the goal is accepted, I would assume it still makes sense to keep those projects listed so they can update their status with the reasons why they don\u0027t need to complete the goal, right?","commit_id":"a873d52f1985ff1cb547e6a7ca2ef46136054367"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"a094063a9c12302827de4e4eb3d93e27d273b186","unresolved":false,"context_lines":[{"line_number":273,"context_line":""},{"line_number":274,"context_line":"Completion Artifacts:"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"murano"},{"line_number":277,"context_line":"------"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"Planning Artifacts:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"df140735_2b80f145","line":276,"range":{"start_line":276,"start_character":0,"end_line":276,"end_character":6},"updated":"2017-06-02 14:39:36.000000000","message":"Work started on this here: https://blueprints.launchpad.net/murano/+spec/policy-in-code\n\n(Will have to tag it differently though as per this spec)","commit_id":"a873d52f1985ff1cb547e6a7ca2ef46136054367"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"f50534ee3b142d4f81d686d7ce38cac243310a52","unresolved":false,"context_lines":[{"line_number":273,"context_line":""},{"line_number":274,"context_line":"Completion Artifacts:"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"murano"},{"line_number":277,"context_line":"------"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"Planning Artifacts:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"df140735_5f575fcb","line":276,"in_reply_to":"df140735_2b80f145","updated":"2017-06-02 16:42:18.000000000","message":"Sweet! That\u0027s awesome to see!","commit_id":"a873d52f1985ff1cb547e6a7ca2ef46136054367"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"dbfcd014856cff6c281ccc29d1b4d0c078203652","unresolved":false,"context_lines":[{"line_number":5,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"OpenStack services typically have a file that describes and enforces policy or"},{"line_number":8,"context_line":"Role Based Access Control for the APIs of that services. The file is usually"},{"line_number":9,"context_line":"maintained in the project source and documents the default policy values. The"},{"line_number":10,"context_line":"goal here would be to move default policy definitions from file-based"},{"line_number":11,"context_line":"maintenance to registering them in code. This is very similar to how we treat"}],"source_content_type":"text/x-rst","patch_set":4,"id":"df140735_02faa7bb","line":8,"range":{"start_line":8,"start_character":47,"end_line":8,"end_character":55},"updated":"2017-06-02 20:31:08.000000000","message":"service","commit_id":"5d0b5d8b08e929b0150aab123c76e1a6f9b54dd2"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"be7bcdccae9b527406aafa30f8db2ea0067e57bc","unresolved":false,"context_lines":[{"line_number":5,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"OpenStack services typically have a file that describes and enforces policy or"},{"line_number":8,"context_line":"Role Based Access Control for the APIs of that services. The file is usually"},{"line_number":9,"context_line":"maintained in the project source and documents the default policy values. The"},{"line_number":10,"context_line":"goal here would be to move default policy definitions from file-based"},{"line_number":11,"context_line":"maintenance to registering them in code. This is very similar to how we treat"}],"source_content_type":"text/x-rst","patch_set":4,"id":"df140735_b60b3cd4","line":8,"in_reply_to":"df140735_02faa7bb","updated":"2017-06-02 23:47:31.000000000","message":"Done","commit_id":"5d0b5d8b08e929b0150aab123c76e1a6f9b54dd2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"dbfcd014856cff6c281ccc29d1b4d0c078203652","unresolved":false,"context_lines":[{"line_number":14,"context_line":"By registering and documenting default policy in code, we see the following"},{"line_number":15,"context_line":"benefits for operators and developers:"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"#. The policy file can be removed for deployments that don\u0027t modify any default"},{"line_number":18,"context_line":"   policies."},{"line_number":19,"context_line":"#. Operators can remove default checks from policy files. The result is that"},{"line_number":20,"context_line":"   their policy file only contains the overridden policies they need for their"},{"line_number":21,"context_line":"   deployment. This makes policy maintenance easier."}],"source_content_type":"text/x-rst","patch_set":4,"id":"df140735_8207d782","line":18,"range":{"start_line":17,"start_character":3,"end_line":18,"end_character":12},"updated":"2017-06-02 20:31:08.000000000","message":"The added benefit is you know longer need something in /etc which can mess with upgrades, i.e. new APIs with new policies won\u0027t automatically show up in old static policy.json files, but they will in new code.","commit_id":"5d0b5d8b08e929b0150aab123c76e1a6f9b54dd2"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"be7bcdccae9b527406aafa30f8db2ea0067e57bc","unresolved":false,"context_lines":[{"line_number":15,"context_line":"benefits for operators and developers:"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"#. The policy file can be removed for deployments that don\u0027t modify any default"},{"line_number":18,"context_line":"   policies."},{"line_number":19,"context_line":"#. Operators can remove default checks from policy files. The result is that"},{"line_number":20,"context_line":"   their policy file only contains the overridden policies they need for their"},{"line_number":21,"context_line":"   deployment. This makes policy maintenance easier."}],"source_content_type":"text/x-rst","patch_set":4,"id":"df140735_36ca8c4d","line":18,"in_reply_to":"df140735_8207d782","updated":"2017-06-02 23:47:31.000000000","message":"Attempted to add that in. Let me know what you think.","commit_id":"5d0b5d8b08e929b0150aab123c76e1a6f9b54dd2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"dbfcd014856cff6c281ccc29d1b4d0c078203652","unresolved":false,"context_lines":[{"line_number":18,"context_line":"   policies."},{"line_number":19,"context_line":"#. Operators can remove default checks from policy files. The result is that"},{"line_number":20,"context_line":"   their policy file only contains the overridden policies they need for their"},{"line_number":21,"context_line":"   deployment. This makes policy maintenance easier."},{"line_number":22,"context_line":"#. Tooling can be used to generate sample policy files."},{"line_number":23,"context_line":"#. Tooling can be used to generate complete policy files that include overrides"},{"line_number":24,"context_line":"   from a specific policy file."}],"source_content_type":"text/x-rst","patch_set":4,"id":"df140735_a2fc1bb5","line":21,"range":{"start_line":21,"start_character":33,"end_line":21,"end_character":44},"updated":"2017-06-02 20:31:08.000000000","message":"and auditing","commit_id":"5d0b5d8b08e929b0150aab123c76e1a6f9b54dd2"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"be7bcdccae9b527406aafa30f8db2ea0067e57bc","unresolved":false,"context_lines":[{"line_number":18,"context_line":"   policies."},{"line_number":19,"context_line":"#. Operators can remove default checks from policy files. The result is that"},{"line_number":20,"context_line":"   their policy file only contains the overridden policies they need for their"},{"line_number":21,"context_line":"   deployment. This makes policy maintenance easier."},{"line_number":22,"context_line":"#. Tooling can be used to generate sample policy files."},{"line_number":23,"context_line":"#. Tooling can be used to generate complete policy files that include overrides"},{"line_number":24,"context_line":"   from a specific policy file."}],"source_content_type":"text/x-rst","patch_set":4,"id":"df140735_b6345c94","line":21,"in_reply_to":"df140735_a2fc1bb5","updated":"2017-06-02 23:47:31.000000000","message":"Done","commit_id":"5d0b5d8b08e929b0150aab123c76e1a6f9b54dd2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"dbfcd014856cff6c281ccc29d1b4d0c078203652","unresolved":false,"context_lines":[{"line_number":22,"context_line":"#. Tooling can be used to generate sample policy files."},{"line_number":23,"context_line":"#. Tooling can be used to generate complete policy files that include overrides"},{"line_number":24,"context_line":"   from a specific policy file."},{"line_number":25,"context_line":"#. Documentation describing each policy is generated and available to assist"},{"line_number":26,"context_line":"   operators."},{"line_number":27,"context_line":"#. Project developers have a way to communicate changing defaults to operators"},{"line_number":28,"context_line":"   through a library."},{"line_number":29,"context_line":"#. Project developers use the process of moving defaults into code and"}],"source_content_type":"text/x-rst","patch_set":4,"id":"df140735_a2153be7","line":26,"range":{"start_line":25,"start_character":3,"end_line":26,"end_character":13},"updated":"2017-06-02 20:31:08.000000000","message":"Link to https://docs.openstack.org/developer/nova/sample_policy.html as an example?","commit_id":"5d0b5d8b08e929b0150aab123c76e1a6f9b54dd2"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"be7bcdccae9b527406aafa30f8db2ea0067e57bc","unresolved":false,"context_lines":[{"line_number":23,"context_line":"#. Tooling can be used to generate complete policy files that include overrides"},{"line_number":24,"context_line":"   from a specific policy file."},{"line_number":25,"context_line":"#. Documentation describing each policy is generated and available to assist"},{"line_number":26,"context_line":"   operators."},{"line_number":27,"context_line":"#. Project developers have a way to communicate changing defaults to operators"},{"line_number":28,"context_line":"   through a library."},{"line_number":29,"context_line":"#. Project developers use the process of moving defaults into code and"}],"source_content_type":"text/x-rst","patch_set":4,"id":"df140735_d62fd03c","line":26,"in_reply_to":"df140735_a2153be7","updated":"2017-06-02 23:47:31.000000000","message":"Done","commit_id":"5d0b5d8b08e929b0150aab123c76e1a6f9b54dd2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"dbfcd014856cff6c281ccc29d1b4d0c078203652","unresolved":false,"context_lines":[{"line_number":24,"context_line":"   from a specific policy file."},{"line_number":25,"context_line":"#. Documentation describing each policy is generated and available to assist"},{"line_number":26,"context_line":"   operators."},{"line_number":27,"context_line":"#. Project developers have a way to communicate changing defaults to operators"},{"line_number":28,"context_line":"   through a library."},{"line_number":29,"context_line":"#. Project developers use the process of moving defaults into code and"},{"line_number":30,"context_line":"   documenting them as an exercise for understanding the default policies"},{"line_number":31,"context_line":"   within the project and how they might be improved."}],"source_content_type":"text/x-rst","patch_set":4,"id":"df140735_e2e4530f","line":28,"range":{"start_line":27,"start_character":3,"end_line":28,"end_character":21},"updated":"2017-06-02 20:31:08.000000000","message":"I don\u0027t quite get this one - what library? The default policy is in code with the service. Communicating changes goes through reno either way, right? Or is there something in oslo.policy that allows marking a policy rule as deprecated and logs a warning if used without the default (i.e. it was overridden by the operator so they care about it going away).","commit_id":"5d0b5d8b08e929b0150aab123c76e1a6f9b54dd2"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"be7bcdccae9b527406aafa30f8db2ea0067e57bc","unresolved":false,"context_lines":[{"line_number":25,"context_line":"#. Documentation describing each policy is generated and available to assist"},{"line_number":26,"context_line":"   operators."},{"line_number":27,"context_line":"#. Project developers have a way to communicate changing defaults to operators"},{"line_number":28,"context_line":"   through a library."},{"line_number":29,"context_line":"#. Project developers use the process of moving defaults into code and"},{"line_number":30,"context_line":"   documenting them as an exercise for understanding the default policies"},{"line_number":31,"context_line":"   within the project and how they might be improved."}],"source_content_type":"text/x-rst","patch_set":4,"id":"df140735_f6ead4d5","line":28,"in_reply_to":"df140735_e2e4530f","updated":"2017-06-02 23:47:31.000000000","message":"Yes - I should have clarified that a bit more.\n\nI specifically meant that we have a way to signal to operators (outside of using reno) that something in their deployments configuration is changing. This is going to require some work to oslo.policy and the policy language itself, but I think it will be useful, especially if we ever get to the point of adding new roles as a group of services.\n\nWe should be able to signal to operators \"hey, this thing that you\u0027re relying on is going to change. If you still need it, then copy/paste it into your own policy file\".\n\nI\u0027ve added a bit to this one in hopes of clearing that up.","commit_id":"5d0b5d8b08e929b0150aab123c76e1a6f9b54dd2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"dbfcd014856cff6c281ccc29d1b4d0c078203652","unresolved":false,"context_lines":[{"line_number":58,"context_line":"   policy is intended to protect."},{"line_number":59,"context_line":"#. Ensure default policies that are registered in code can be overridden by"},{"line_number":60,"context_line":"   operators."},{"line_number":61,"context_line":"#. Ensure `oslo.policy` endpoints can be used to leverage tooling for"},{"line_number":62,"context_line":"   generating default policy files, or producing custom policy files that"},{"line_number":63,"context_line":"   consist of defaults in addition to overrides specified by operators in"},{"line_number":64,"context_line":"   existing policy files."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"References"},{"line_number":67,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"df140735_a2a65baa","line":64,"range":{"start_line":61,"start_character":3,"end_line":64,"end_character":25},"updated":"2017-06-02 20:31:08.000000000","message":"This sounds like a lot of work but I think it just means doing something like this:\n\nhttps://github.com/openstack/nova/blob/15.0.0/setup.cfg#L42","commit_id":"5d0b5d8b08e929b0150aab123c76e1a6f9b54dd2"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"be7bcdccae9b527406aafa30f8db2ea0067e57bc","unresolved":false,"context_lines":[{"line_number":61,"context_line":"#. Ensure `oslo.policy` endpoints can be used to leverage tooling for"},{"line_number":62,"context_line":"   generating default policy files, or producing custom policy files that"},{"line_number":63,"context_line":"   consist of defaults in addition to overrides specified by operators in"},{"line_number":64,"context_line":"   existing policy files."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"References"},{"line_number":67,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"df140735_16754832","line":64,"in_reply_to":"df140735_a2a65baa","updated":"2017-06-02 23:47:31.000000000","message":"Done","commit_id":"5d0b5d8b08e929b0150aab123c76e1a6f9b54dd2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"dbfcd014856cff6c281ccc29d1b4d0c078203652","unresolved":false,"context_lines":[{"line_number":86,"context_line":"time the community comes together and agrees upon a direction using specific"},{"line_number":87,"context_line":"defaults, we can leverage this work to make that transition easier."},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"As noted in the section above. The nova and keystone projects have already"},{"line_number":90,"context_line":"completed these items as of the Pike release. The patterns used to implement"},{"line_number":91,"context_line":"policy and policy documentation in code can serve as a reference for other"},{"line_number":92,"context_line":"projects looking to complete the goal."}],"source_content_type":"text/x-rst","patch_set":4,"id":"df140735_c2c26f34","line":89,"range":{"start_line":89,"start_character":29,"end_line":89,"end_character":34},"updated":"2017-06-02 20:31:08.000000000","message":", the","commit_id":"5d0b5d8b08e929b0150aab123c76e1a6f9b54dd2"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"be7bcdccae9b527406aafa30f8db2ea0067e57bc","unresolved":false,"context_lines":[{"line_number":86,"context_line":"time the community comes together and agrees upon a direction using specific"},{"line_number":87,"context_line":"defaults, we can leverage this work to make that transition easier."},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"As noted in the section above. The nova and keystone projects have already"},{"line_number":90,"context_line":"completed these items as of the Pike release. The patterns used to implement"},{"line_number":91,"context_line":"policy and policy documentation in code can serve as a reference for other"},{"line_number":92,"context_line":"projects looking to complete the goal."}],"source_content_type":"text/x-rst","patch_set":4,"id":"df140735_56a4e0a5","line":89,"in_reply_to":"df140735_c2c26f34","updated":"2017-06-02 23:47:31.000000000","message":"Done","commit_id":"5d0b5d8b08e929b0150aab123c76e1a6f9b54dd2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0bf2a3d0776e71b6fbc81890f23e21227b6f5378","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"#. The policy file can be removed for deployments that don\u0027t modify any default"},{"line_number":18,"context_line":"   policies. This continues to move configuration out of `/etc/$PROJECT/`"},{"line_number":19,"context_line":"   directories and into code, which natuarlly enables easier upgrades."},{"line_number":20,"context_line":"#. Operators can remove default checks from policy files. The result is that"},{"line_number":21,"context_line":"   their policy file only contains the overridden policies they need for their"},{"line_number":22,"context_line":"   deployment. This makes auditing and policy maintenance easier."}],"source_content_type":"text/x-rst","patch_set":5,"id":"df140735_b920cdad","line":19,"range":{"start_line":19,"start_character":36,"end_line":19,"end_character":45},"updated":"2017-06-03 01:37:54.000000000","message":"naturally","commit_id":"5130431390b62ce3c5600a5c18d96121b557407a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0bf2a3d0776e71b6fbc81890f23e21227b6f5378","unresolved":false,"context_lines":[{"line_number":28,"context_line":"   operators."},{"line_number":29,"context_line":"#. Project developers have a way to communicate changing defaults to operators"},{"line_number":30,"context_line":"   through a library. Think of this like marking configuration values for"},{"line_number":31,"context_line":"   deprecation or removal. The important bit is that we have a programatic way"},{"line_number":32,"context_line":"   to signal those changes for operators."},{"line_number":33,"context_line":"#. Project developers use the process of moving defaults into code and"},{"line_number":34,"context_line":"   documenting them as an exercise for understanding the default policies"}],"source_content_type":"text/x-rst","patch_set":5,"id":"df140735_590f7136","line":31,"range":{"start_line":31,"start_character":63,"end_line":31,"end_character":74},"updated":"2017-06-03 01:37:54.000000000","message":"programmatic","commit_id":"5130431390b62ce3c5600a5c18d96121b557407a"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"95939bdcb8a28113a9106eec9897d3933adf4373","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"#. Use `oslo.policy` to register default policies in code that map to the"},{"line_number":60,"context_line":"   defaults described in policy files."},{"line_number":61,"context_line":"#. Each policy must be contain a `description` that describes the API the"},{"line_number":62,"context_line":"   policy is intended to protect."},{"line_number":63,"context_line":"#. Ensure default policies that are registered in code can be overridden by"},{"line_number":64,"context_line":"   operators."}],"source_content_type":"text/x-rst","patch_set":6,"id":"df140735_b24d7f9b","line":61,"range":{"start_line":61,"start_character":15,"end_line":61,"end_character":30},"updated":"2017-06-04 03:23:33.000000000","message":"must contain","commit_id":"54cfa53576d0cc2f109742fdd1a88db690e925ac"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"6b7e9df2613b6a8e6bd95e0180fa8844f796702b","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"#. Use `oslo.policy` to register default policies in code that map to the"},{"line_number":60,"context_line":"   defaults described in policy files."},{"line_number":61,"context_line":"#. Each policy must be contain a `description` that describes the API the"},{"line_number":62,"context_line":"   policy is intended to protect."},{"line_number":63,"context_line":"#. Ensure default policies that are registered in code can be overridden by"},{"line_number":64,"context_line":"   operators."}],"source_content_type":"text/x-rst","patch_set":6,"id":"df140735_d3a69ec1","line":61,"in_reply_to":"df140735_b24d7f9b","updated":"2017-06-05 14:34:59.000000000","message":"Done","commit_id":"54cfa53576d0cc2f109742fdd1a88db690e925ac"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"95939bdcb8a28113a9106eec9897d3933adf4373","unresolved":false,"context_lines":[{"line_number":66,"context_line":"   generating default policy files, or producing custom policy files that"},{"line_number":67,"context_line":"   consist of defaults in addition to overrides specified by operators in"},{"line_number":68,"context_line":"   existing policy files. This mainly consists of exposing `oslo.policy`"},{"line_number":69,"context_line":"   endpoints in each projects `setup.cfg` file. An example can be found in some"},{"line_number":70,"context_line":"   of the existing `services"},{"line_number":71,"context_line":"   \u003chttps://github.com/openstack/nova/blob/15.0.0/setup.cfg#L42\u003e`_."},{"line_number":72,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"df140735_92527b3a","line":69,"range":{"start_line":69,"start_character":21,"end_line":69,"end_character":29},"updated":"2017-06-04 03:23:33.000000000","message":"project\u0027s","commit_id":"54cfa53576d0cc2f109742fdd1a88db690e925ac"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"6b7e9df2613b6a8e6bd95e0180fa8844f796702b","unresolved":false,"context_lines":[{"line_number":66,"context_line":"   generating default policy files, or producing custom policy files that"},{"line_number":67,"context_line":"   consist of defaults in addition to overrides specified by operators in"},{"line_number":68,"context_line":"   existing policy files. This mainly consists of exposing `oslo.policy`"},{"line_number":69,"context_line":"   endpoints in each projects `setup.cfg` file. An example can be found in some"},{"line_number":70,"context_line":"   of the existing `services"},{"line_number":71,"context_line":"   \u003chttps://github.com/openstack/nova/blob/15.0.0/setup.cfg#L42\u003e`_."},{"line_number":72,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"df140735_7397d249","line":69,"in_reply_to":"df140735_92527b3a","updated":"2017-06-05 14:34:59.000000000","message":"Done","commit_id":"54cfa53576d0cc2f109742fdd1a88db690e925ac"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"95939bdcb8a28113a9106eec9897d3933adf4373","unresolved":false,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":"As noted in the section above, the nova and keystone projects have already"},{"line_number":97,"context_line":"completed these items as of the Pike release. The patterns used to implement"},{"line_number":98,"context_line":"policy and policy documentation in code can serve as a reference for other"},{"line_number":99,"context_line":"projects looking to complete the goal."},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"Project Teams"}],"source_content_type":"text/x-rst","patch_set":6,"id":"df140735_32616f06","line":98,"range":{"start_line":98,"start_character":32,"end_line":98,"end_character":39},"updated":"2017-06-04 03:23:33.000000000","message":"in code by these projects","commit_id":"54cfa53576d0cc2f109742fdd1a88db690e925ac"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"6b7e9df2613b6a8e6bd95e0180fa8844f796702b","unresolved":false,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":"As noted in the section above, the nova and keystone projects have already"},{"line_number":97,"context_line":"completed these items as of the Pike release. The patterns used to implement"},{"line_number":98,"context_line":"policy and policy documentation in code can serve as a reference for other"},{"line_number":99,"context_line":"projects looking to complete the goal."},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"Project Teams"}],"source_content_type":"text/x-rst","patch_set":6,"id":"df140735_537bae26","line":98,"in_reply_to":"df140735_32616f06","updated":"2017-06-05 14:34:59.000000000","message":"Done","commit_id":"54cfa53576d0cc2f109742fdd1a88db690e925ac"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"95939bdcb8a28113a9106eec9897d3933adf4373","unresolved":false,"context_lines":[{"line_number":96,"context_line":"As noted in the section above, the nova and keystone projects have already"},{"line_number":97,"context_line":"completed these items as of the Pike release. The patterns used to implement"},{"line_number":98,"context_line":"policy and policy documentation in code can serve as a reference for other"},{"line_number":99,"context_line":"projects looking to complete the goal."},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"Project Teams"},{"line_number":102,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"df140735_723807ed","line":99,"range":{"start_line":99,"start_character":29,"end_line":99,"end_character":37},"updated":"2017-06-04 03:23:33.000000000","message":"the aforementioned goals","commit_id":"54cfa53576d0cc2f109742fdd1a88db690e925ac"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"6b7e9df2613b6a8e6bd95e0180fa8844f796702b","unresolved":false,"context_lines":[{"line_number":96,"context_line":"As noted in the section above, the nova and keystone projects have already"},{"line_number":97,"context_line":"completed these items as of the Pike release. The patterns used to implement"},{"line_number":98,"context_line":"policy and policy documentation in code can serve as a reference for other"},{"line_number":99,"context_line":"projects looking to complete the goal."},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"Project Teams"},{"line_number":102,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"df140735_3376fa3f","line":99,"in_reply_to":"df140735_723807ed","updated":"2017-06-05 14:34:59.000000000","message":"Done","commit_id":"54cfa53576d0cc2f109742fdd1a88db690e925ac"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"2ef57f51911e7eec4b565fa44e719a1ec28ad455","unresolved":false,"context_lines":[{"line_number":46,"context_line":"To facilitate tracking, commits related to this goal should use the"},{"line_number":47,"context_line":"gerrit topic::"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"  \u003cpolicy-and-docs-in-code\u003e"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Completion Criteria"},{"line_number":52,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":7,"id":"3f1d235d_e8c61b4a","line":49,"updated":"2017-07-07 14:12:19.000000000","message":"I think you don\u0027t want the \u003c and \u003e but we can fix that in another patch if this one is approved.","commit_id":"c040f5db574a24450d43f7d328fdb43cd29de58b"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"a7af2016733d99039197b002033221955de7faf9","unresolved":false,"context_lines":[{"line_number":46,"context_line":"To facilitate tracking, commits related to this goal should use the"},{"line_number":47,"context_line":"gerrit topic::"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"  \u003cpolicy-and-docs-in-code\u003e"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Completion Criteria"},{"line_number":52,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":7,"id":"3f1d235d_f865ad46","line":49,"in_reply_to":"3f1d235d_c390e0f0","updated":"2017-07-09 18:34:15.000000000","message":"Should we just get this patch updated instead of having the small follow on updates?","commit_id":"c040f5db574a24450d43f7d328fdb43cd29de58b"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"ff8b25345c2724b4fe69d26048516ea3423c2943","unresolved":false,"context_lines":[{"line_number":46,"context_line":"To facilitate tracking, commits related to this goal should use the"},{"line_number":47,"context_line":"gerrit topic::"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"  \u003cpolicy-and-docs-in-code\u003e"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Completion Criteria"},{"line_number":52,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":7,"id":"3f1d235d_c390e0f0","line":49,"in_reply_to":"3f1d235d_e8c61b4a","updated":"2017-07-07 14:47:36.000000000","message":"Fixed in https://review.openstack.org/#/c/481654/","commit_id":"c040f5db574a24450d43f7d328fdb43cd29de58b"},{"author":{"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},"change_message_id":"2b7251201b50a838f3739be70069e0d178061221","unresolved":false,"context_lines":[{"line_number":46,"context_line":"To facilitate tracking, commits related to this goal should use the"},{"line_number":47,"context_line":"gerrit topic::"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"  \u003cpolicy-and-docs-in-code\u003e"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Completion Criteria"},{"line_number":52,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":7,"id":"3f1d235d_ff122cb4","line":49,"in_reply_to":"3f1d235d_f865ad46","updated":"2017-07-10 08:02:49.000000000","message":"No, let\u0027s keep the current votes on this one, I\u0027ll merge the follow-up as a typo patch immediately after I merge this one (after the meeting tomorrow)","commit_id":"c040f5db574a24450d43f7d328fdb43cd29de58b"},{"author":{"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},"change_message_id":"57ada18539b9d971a3c675517f26709eececf341","unresolved":false,"context_lines":[{"line_number":52,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Enumerate the items that must be true in order to call the goal"},{"line_number":55,"context_line":"\"completed\" for a given project."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"For all projects:"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"7f231b9d_7a5ab82a","line":55,"updated":"2017-06-20 12:53:47.000000000","message":"boilerplate leftover","commit_id":"c040f5db574a24450d43f7d328fdb43cd29de58b"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"df5b8a6ee6b13b2b6c4a203003586a33ef225074","unresolved":false,"context_lines":[{"line_number":52,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Enumerate the items that must be true in order to call the goal"},{"line_number":55,"context_line":"\"completed\" for a given project."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"For all projects:"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"5f201791_34f7c9f8","line":55,"in_reply_to":"7f231b9d_7a5ab82a","updated":"2017-06-20 17:27:31.000000000","message":"Fixed this in a follow-on patch: https://review.openstack.org/475882","commit_id":"c040f5db574a24450d43f7d328fdb43cd29de58b"}]}
