)]}'
{"reference/principles.rst":[{"author":{"_account_id":23078,"name":"Jeremy Freudberg","email":"jeremyfreudberg@gmail.com","username":"jeremyfreudberg"},"change_message_id":"1ab3c40de01e12abbdd007b6adab5b15feac8e01","unresolved":false,"context_lines":[{"line_number":145,"context_line":"OpenStack processes and the documenting of our principles from within our"},{"line_number":146,"context_line":"community according to our rules of governance."},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"We do not nitpick"},{"line_number":149,"context_line":"-----------------"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"While participation is voluntary, we recognize that a preference for"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_2107aecc","line":148,"range":{"start_line":148,"start_character":0,"end_line":148,"end_character":17},"updated":"2018-05-30 16:54:28.000000000","message":"I agree with Ruby; \"we do not nitpick\" does not seem to accurately summarize what follows below. What I\u0027ve read, is that we DO nitpick, and will continue to nitpick, but ideally within the frames of some new standards for courtesy.","commit_id":"53d9ead7db585a529333f993bf74c5840b590108"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"2e6269b0538079a8f22fd024f109c670a53b448f","unresolved":false,"context_lines":[{"line_number":145,"context_line":"OpenStack processes and the documenting of our principles from within our"},{"line_number":146,"context_line":"community according to our rules of governance."},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"We do not nitpick"},{"line_number":149,"context_line":"-----------------"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"While participation is voluntary, we recognize that a preference for"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_5005da12","line":148,"updated":"2018-05-30 14:01:59.000000000","message":"nit: I am probably nitpicking here, so maybe I shouldn\u0027t comment, but ...\n\nWhat does this mean, \u0027we do not nitpick\u0027. Based on the email thread, my interpretation (which may be wrong), is that it is OK to add \u0027nit\u0027 comments in a review, but not -1 for *only* nits.\n\nWhen I read \u0027We do not nitpick\u0027, I interpret that as meaning \"we DO NOT nitpick\", which means to me, we do not add comments that refer to nits. Please clarify.","commit_id":"53d9ead7db585a529333f993bf74c5840b590108"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5b3e53f3866d6e2838754bacf68062eee654deff","unresolved":false,"context_lines":[{"line_number":145,"context_line":"OpenStack processes and the documenting of our principles from within our"},{"line_number":146,"context_line":"community according to our rules of governance."},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"We do not nitpick"},{"line_number":149,"context_line":"-----------------"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"While participation is voluntary, we recognize that a preference for"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_da09ee2a","line":148,"range":{"start_line":148,"start_character":0,"end_line":148,"end_character":17},"in_reply_to":"5f7c97a3_053f1587","updated":"2018-05-31 15:23:49.000000000","message":"I guess I don\u0027t understand. Maybe my definition is different/wrong. What do you mean by \u0027nitpick\u0027? I assume (or my actions) are that I am nitpicking the instant I put a review comment with \u0027nit\u0027 in it; eg \u0027nit: It might be better as ...\u0027 I don\u0027t always remember to prefix every comment with \u0027nit\u0027 but my assumption is that the person understands (if I think that this isn\u0027t a first-time contributor), e.g. to take Eric\u0027s comment below: \u0027s/-//\u0027. I\u0027m assuming that is a nit; so was he nit-picking?\n\nIs this saying that when we review, we do not (never) put such comments, with or without prefixing them with \u0027nit\u0027?","commit_id":"53d9ead7db585a529333f993bf74c5840b590108"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"36e68f3fc4ee6e576f8785e35d5af11b5455d510","unresolved":false,"context_lines":[{"line_number":145,"context_line":"OpenStack processes and the documenting of our principles from within our"},{"line_number":146,"context_line":"community according to our rules of governance."},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"We do not nitpick"},{"line_number":149,"context_line":"-----------------"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"While participation is voluntary, we recognize that a preference for"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_6ceef6ed","line":148,"range":{"start_line":148,"start_character":0,"end_line":148,"end_character":17},"in_reply_to":"5f7c97a3_2107aecc","updated":"2018-05-30 22:02:44.000000000","message":"If we look at the title line, and then compare with the other title lines in the file, We are fairly in-line with the other strong statements made by the principles. In my opinion, and clearly others by the review feedback, we are in need of a strong statement to move the community forward. To explicitly call out counterproductive behavior. Some may view it as productive and good in order to make \"it\" (code, docs, #whatever) perfect, but the reality also is that there is no such thing as perfect because we are solely relying upon our own perceptions. If multiple people are agreeing in a review that \"it would be much better if we did x instead of y\", then that is definitely not nitpicking. That is a dialog that has occurred. \n\nWe could change this to \"We do not nitpick with negative feedback\", and the overall statement text calls out providing positive feedback. Then again, I\u0027m sure someone could also take the position that it is culturally wrong for them to be unable to do so. Perhaps we should just explicitly state \"We don\u0027t make perfect software\" ? Except then everyone has to have the same concept of perfect.\n\nWhat do others suggest though? Because this is the time and place to make such suggestions. I know we likely want to avoid detailing every single negative and counter-productive behavior that occurs with nit-picking in projects. In part that is why I put a list at the bottom. What we want is to encourage contributors!\n\nAs for courtesy, I think that is going to be a difficult subject because we are all from different cultures. We are also dealing with people that are wired differently, who are in different situations. We have to give people the benefit of the doubt or consider that they may just be extremely direct, or could even be confusing context. I suspect that is a minefield of social issues, as compared to just addressing nitpicking.\n\nI do believe we\u0027re definitely nitpicking (or maybe we should just label this with #nitpick), but if we\u0027re going to nitpick anything, it might as well be this. The point of this is that we shouldn\u0027t be moving forward.","commit_id":"53d9ead7db585a529333f993bf74c5840b590108"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"956708f4881b5ea2bd3537b5c146b4046f480987","unresolved":false,"context_lines":[{"line_number":145,"context_line":"OpenStack processes and the documenting of our principles from within our"},{"line_number":146,"context_line":"community according to our rules of governance."},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"We do not nitpick"},{"line_number":149,"context_line":"-----------------"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"While participation is voluntary, we recognize that a preference for"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_053f1587","line":148,"range":{"start_line":148,"start_character":0,"end_line":148,"end_character":17},"in_reply_to":"5f7c97a3_6ceef6ed","updated":"2018-05-31 01:11:40.000000000","message":"Maybe something along the lines of \"We empower contributors to change the software\"?\n\n(This makes me slightly uncomfortable because it\u0027s not just software. Then again, one of the principles above is \"OpenStack Primarily Produces Software\".)\n\nIt feels like combating nitpicking is the most prominent facet of a larger goal we\u0027re trying to express here: that we should default to accepting contributions and only hold them up when there\u0027s a real problem, rather than default to deny/ignore and only accept when we can\u0027t find a reason to ask for one more patchset. If anyone can think of a pithy one-line summary of that then I think that would make a great Guiding Principle.","commit_id":"53d9ead7db585a529333f993bf74c5840b590108"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"a9883fe03de29b66132b6f3900030a50f32c00af","unresolved":false,"context_lines":[{"line_number":145,"context_line":"OpenStack processes and the documenting of our principles from within our"},{"line_number":146,"context_line":"community according to our rules of governance."},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"We do not nitpick"},{"line_number":149,"context_line":"-----------------"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"While participation is voluntary, we recognize that a preference for"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_bd32ec5c","line":148,"range":{"start_line":148,"start_character":0,"end_line":148,"end_character":17},"in_reply_to":"5f7c97a3_da09ee2a","updated":"2018-05-31 16:55:18.000000000","message":"\u003e I guess I don\u0027t understand. Maybe my definition is different/wrong.\n \u003e What do you mean by \u0027nitpick\u0027? I assume (or my actions) are that I\n \u003e am nitpicking the instant I put a review comment with \u0027nit\u0027 in it;\n \u003e eg \u0027nit: It might be better as ...\u0027 I don\u0027t always remember to\n \u003e prefix every comment with \u0027nit\u0027 but my assumption is that the\n \u003e person understands (if I think that this isn\u0027t a first-time\n \u003e contributor), e.g. to take Eric\u0027s comment below: \u0027s/-//\u0027. I\u0027m\n \u003e assuming that is a nit; so was he nit-picking?\n \u003e \n \u003e Is this saying that when we review, we do not (never) put such\n \u003e comments, with or without prefixing them with \u0027nit\u0027?\n\nNo, it\u0027s not about whether a comment actually says \"nit\". It means that we don\u0027t block changes from landing over minor issues when the code is otherwise correct and those issues can be fixed in a follow-up patch. Deciding what those \"minor issues\" are will require some judgement from reviewers. We are trying to ask folks to be more lenient when using their judgement than some contributors have perceived our community as a whole to be in the past.\n\nThis confusion is partly why I suggested we consider how to word the new section with a more positive phrasing, to emphasize the behaviors we do want rather than trying to make a list of the behaviors we don\u0027t want. If we talk about the types of reviews we find valuable, and why we find them valuable, then we can encourage people to review with those things in mind and to provide follow-up patches for things that they want to change but that aren\u0027t part of what we generally consider to be an important part of a review.","commit_id":"53d9ead7db585a529333f993bf74c5840b590108"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"3ae6a001d3cf7df40da3998514d8f43f9d04a56c","unresolved":false,"context_lines":[{"line_number":145,"context_line":"OpenStack processes and the documenting of our principles from within our"},{"line_number":146,"context_line":"community according to our rules of governance."},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"We do not nitpick"},{"line_number":149,"context_line":"-----------------"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"While participation is voluntary, we recognize that a preference for"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_3a6b4285","line":148,"range":{"start_line":148,"start_character":0,"end_line":148,"end_character":17},"in_reply_to":"5f7c97a3_da09ee2a","updated":"2018-05-31 16:05:02.000000000","message":"\u003e e.g. to take Eric\u0027s comment below: \u0027s/-//\u0027. I\u0027m\n \u003e assuming that is a nit; so was he nit-picking?\n\nTotally.  (I was doing it with full awareness of the irony; but note that I also +1ed at that time.)\n\nIf we\u0027re looking for a more precise/accurate header for this section, perhaps \"We do not hold up patches for nits\" and then define \"nits\" within.\n\n \u003e we should default to\n \u003e accepting contributions and only hold them up when there\u0027s a real\n \u003e problem, rather than default to deny/ignore and only accept when we\n \u003e can\u0027t find a reason to ask for one more patchset.\n\nIMO this is a perfect expression of the intent we want to convey.\n\n \u003e If anyone can\n \u003e think of a pithy one-line summary of that then I think that would\n \u003e make a great Guiding Principle.\n\nHow about:\n\nWe default to accepting contributions and only hold them up when there\u0027s a real problem, rather than default to deny/ignore and only accept when we can\u0027t find a reason to ask for one more patchset.\n\n:)","commit_id":"53d9ead7db585a529333f993bf74c5840b590108"},{"author":{"_account_id":25089,"name":"MarkMielke","email":"mark.mielke@gmail.com","username":"MarkMielke"},"change_message_id":"0c5732841c512379cf28b80c99506018ce4566b7","unresolved":false,"context_lines":[{"line_number":149,"context_line":"-----------------"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"While participation is voluntary, we recognize that a preference for"},{"line_number":152,"context_line":"exacting personal code styles or interpretation of language leads to"},{"line_number":153,"context_line":"discouraged contributors, especially those for which English is not their"},{"line_number":154,"context_line":"first language. We also recognize nitpicks are a mechanism"},{"line_number":155,"context_line":"to help teach and guide, but they should not force repeated revisions."}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_170a0b78","line":152,"updated":"2018-05-29 18:32:40.000000000","message":"I have a concern that \"nitpick\" and \"exacting personal code styles or interpretation of language\" are not necessarily synonymous.\n\nThis really comes down to:\n\n1. Does the change technically make a difference to the behaviour of the code? This is probably where some people think the line should be drawn for \"nitpick\" vs \"quality\".\n2. Does the change make a difference to the quality of the end product? This is where other people think the line should be drawn.\n\nTrue \"nitpicking\" in the sense of \"looking for small or unimportant errors or faults, especially in order to criticize unnecessarily\" is unhealthy, but asking for changes to ensure that the resulting product is of high quality and will not contain technical debt which *includes* code style and correct use of language, is not necessarily nitpicking.\n\nFor below where it says \"not force repeated revisions\" this is also concerning to me as this means that if a reviewer asks for a change, and the contributor doesn\u0027t do what they are told, there is now a limit on how many times the reviewer is allowed to challenge the contributor.\n\nAll of this seems to favour entry of new contributors, at the expense of quality and good habits. Is this really the right business call to make?\n\nIf this is really about nitpicking, and not about reducing quality, then I think the language should emphasize the definition of nitpicking which is \"looking for small or unimportant errors or faults, especially in order to criticize unnecessarily\" and not unnecessarily broaden this to include examples of things that probably do deserve to be reviewed and challenged?","commit_id":"53d9ead7db585a529333f993bf74c5840b590108"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"040912f249c241ef8ea1724b4284eed9c801c2ab","unresolved":false,"context_lines":[{"line_number":149,"context_line":"-----------------"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"While participation is voluntary, we recognize that a preference for"},{"line_number":152,"context_line":"exacting personal code styles or interpretation of language leads to"},{"line_number":153,"context_line":"discouraged contributors, especially those for which English is not their"},{"line_number":154,"context_line":"first language. We also recognize nitpicks are a mechanism"},{"line_number":155,"context_line":"to help teach and guide, but they should not force repeated revisions."}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_57716275","line":152,"in_reply_to":"5f7c97a3_170a0b78","updated":"2018-05-29 19:01:49.000000000","message":"\u003e 1. Does the change technically make a difference to the behaviour\n\n/readability/maintainability/...\n\n \u003e of the code?\n\nIf a code comment is laden with spelling or grammatical errors, but is totally comprehensible, no need to hold up the patch just for that.  If an algorithm is convoluted and hard to follow, but could be replaced with something simpler that does precisely the same thing logically, IMO that\u0027s worth a respin.  Neither is technically a \"behavior\" change.\n\n \u003e 2. Does the change make a difference to the quality of the end\n \u003e product? This is where other people think the line should be drawn.\n\nThis is where I would say it\u0027s reasonable to insist on perfect spelling/grammar in *docs* (including renos).  However, once again, it may be acceptable to defer to a followon, as long as the *meaning* is clear and correct.\n\n \u003e If this is really about nitpicking, and not about reducing quality,\n \u003e then I think the language should emphasize the definition of\n \u003e nitpicking which is \"looking for small or unimportant errors or\n \u003e faults, especially in order to criticize unnecessarily\" and not\n \u003e unnecessarily broaden this to include examples of things that\n \u003e probably do deserve to be reviewed and challenged?\n\n++\n\nUnfortunately, I anticipate one side effect of this to be reviews devolving into arguments over what\u0027s nitpicking and what\u0027s not.","commit_id":"53d9ead7db585a529333f993bf74c5840b590108"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"36e68f3fc4ee6e576f8785e35d5af11b5455d510","unresolved":false,"context_lines":[{"line_number":149,"context_line":"-----------------"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"While participation is voluntary, we recognize that a preference for"},{"line_number":152,"context_line":"exacting personal code styles or interpretation of language leads to"},{"line_number":153,"context_line":"discouraged contributors, especially those for which English is not their"},{"line_number":154,"context_line":"first language. We also recognize nitpicks are a mechanism"},{"line_number":155,"context_line":"to help teach and guide, but they should not force repeated revisions."}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_6cf11695","line":152,"in_reply_to":"5f7c97a3_57716275","updated":"2018-05-30 22:02:44.000000000","message":"\u003e Unfortunately, I anticipate one side effect of this to be reviews\n \u003e devolving into arguments over what\u0027s nitpicking and what\u0027s not.\n\n\u003c3\n\nThe conundrum I see is that one person\u0027s fault is another person\u0027s nitpick. A third person is sitting wondering if any of what the first two people are talking about is important because they have gone down a rabbit hole starting around patch set 85. The forth person curled up in the corner crying because they have to revise the patch set again... and the next revision will be 125. Each project is different, and each situation is different, and all people can do is look at that context and content objectively at the time they review it.\n\nPeople do tend to be forward looking, and looking back we can see the pain, frustration, catharsis that is tied in with this... but only when we stop to look at it. I think we need to foster an encouraging community to not just help newcomers and occasional committers, but to keep the contributors we already have in the community.","commit_id":"53d9ead7db585a529333f993bf74c5840b590108"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"1b2b4a0417b07848892bba1e21a04532ca3349ae","unresolved":false,"context_lines":[{"line_number":150,"context_line":""},{"line_number":151,"context_line":"While participation is voluntary, we recognize that a preference for"},{"line_number":152,"context_line":"exacting personal code styles or interpretation of language leads to"},{"line_number":153,"context_line":"discouraged contributors, especially those for which English is not their"},{"line_number":154,"context_line":"first language. We also recognize nitpicks are a mechanism"},{"line_number":155,"context_line":"to help teach and guide, but they should not force repeated revisions."},{"line_number":156,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_0b0bc8d4","line":153,"range":{"start_line":153,"start_character":47,"end_line":153,"end_character":52},"updated":"2018-05-29 14:32:15.000000000","message":"whom","commit_id":"53d9ead7db585a529333f993bf74c5840b590108"},{"author":{"_account_id":25089,"name":"MarkMielke","email":"mark.mielke@gmail.com","username":"MarkMielke"},"change_message_id":"0c5732841c512379cf28b80c99506018ce4566b7","unresolved":false,"context_lines":[{"line_number":150,"context_line":""},{"line_number":151,"context_line":"While participation is voluntary, we recognize that a preference for"},{"line_number":152,"context_line":"exacting personal code styles or interpretation of language leads to"},{"line_number":153,"context_line":"discouraged contributors, especially those for which English is not their"},{"line_number":154,"context_line":"first language. We also recognize nitpicks are a mechanism"},{"line_number":155,"context_line":"to help teach and guide, but they should not force repeated revisions."},{"line_number":156,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_974b7baf","line":153,"range":{"start_line":153,"start_character":47,"end_line":153,"end_character":52},"in_reply_to":"5f7c97a3_0b0bc8d4","updated":"2018-05-29 18:32:40.000000000","message":"Not sure if Eric was trying to be funny here... but an excellent example of where the feedback improves the quality of the product, but some might prematurely conclude this was nitpicking.","commit_id":"53d9ead7db585a529333f993bf74c5840b590108"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"040912f249c241ef8ea1724b4284eed9c801c2ab","unresolved":false,"context_lines":[{"line_number":150,"context_line":""},{"line_number":151,"context_line":"While participation is voluntary, we recognize that a preference for"},{"line_number":152,"context_line":"exacting personal code styles or interpretation of language leads to"},{"line_number":153,"context_line":"discouraged contributors, especially those for which English is not their"},{"line_number":154,"context_line":"first language. We also recognize nitpicks are a mechanism"},{"line_number":155,"context_line":"to help teach and guide, but they should not force repeated revisions."},{"line_number":156,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_d72493c8","line":153,"range":{"start_line":153,"start_character":47,"end_line":153,"end_character":52},"in_reply_to":"5f7c97a3_974b7baf","updated":"2018-05-29 19:01:49.000000000","message":"Yes, totally trying to be funny (though this is also a correct correction :)  Note that I +1ed at the same time.","commit_id":"53d9ead7db585a529333f993bf74c5840b590108"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"36e68f3fc4ee6e576f8785e35d5af11b5455d510","unresolved":false,"context_lines":[{"line_number":150,"context_line":""},{"line_number":151,"context_line":"While participation is voluntary, we recognize that a preference for"},{"line_number":152,"context_line":"exacting personal code styles or interpretation of language leads to"},{"line_number":153,"context_line":"discouraged contributors, especially those for which English is not their"},{"line_number":154,"context_line":"first language. We also recognize nitpicks are a mechanism"},{"line_number":155,"context_line":"to help teach and guide, but they should not force repeated revisions."},{"line_number":156,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_0c366252","line":153,"range":{"start_line":153,"start_character":47,"end_line":153,"end_character":52},"in_reply_to":"5f7c97a3_d72493c8","updated":"2018-05-30 22:02:44.000000000","message":"Thanks Eric! I\u0027ll incorporate that into my next revision or a follow-up patch.","commit_id":"53d9ead7db585a529333f993bf74c5840b590108"},{"author":{"_account_id":23078,"name":"Jeremy Freudberg","email":"jeremyfreudberg@gmail.com","username":"jeremyfreudberg"},"change_message_id":"1ab3c40de01e12abbdd007b6adab5b15feac8e01","unresolved":false,"context_lines":[{"line_number":152,"context_line":"exacting personal code styles or interpretation of language leads to"},{"line_number":153,"context_line":"discouraged contributors, especially those for which English is not their"},{"line_number":154,"context_line":"first language. We also recognize nitpicks are a mechanism"},{"line_number":155,"context_line":"to help teach and guide, but they should not force repeated revisions."},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"Reviewing contributors should provide encouraging feedback and be"},{"line_number":158,"context_line":"willing to follow-up on their nitpicks themselves using follow-up patches,"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_61192620","line":155,"range":{"start_line":155,"start_character":45,"end_line":155,"end_character":70},"updated":"2018-05-30 16:54:28.000000000","message":"It seems to me like the meat of the actual proposal is in these three words, albeit somewhat obscured. \"Forced repeated revisions\" happen when either 1) the reviewer doesn\u0027t unload all of his nits at once 2) the reviewer saves his nits for when the patch is already otherwise merge-ready. So many expand this part to mention this (assuming that my claim is correct)?","commit_id":"53d9ead7db585a529333f993bf74c5840b590108"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"36e68f3fc4ee6e576f8785e35d5af11b5455d510","unresolved":false,"context_lines":[{"line_number":152,"context_line":"exacting personal code styles or interpretation of language leads to"},{"line_number":153,"context_line":"discouraged contributors, especially those for which English is not their"},{"line_number":154,"context_line":"first language. We also recognize nitpicks are a mechanism"},{"line_number":155,"context_line":"to help teach and guide, but they should not force repeated revisions."},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"Reviewing contributors should provide encouraging feedback and be"},{"line_number":158,"context_line":"willing to follow-up on their nitpicks themselves using follow-up patches,"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_ecce862b","line":155,"range":{"start_line":155,"start_character":45,"end_line":155,"end_character":70},"in_reply_to":"5f7c97a3_61192620","updated":"2018-05-30 22:02:44.000000000","message":"And you\u0027ve found the key point, in that this process can take months if not years because of the evolution of the code during the review process alone can result in changes that have to be accounted for which forces evolution in the patch set its self. People also don\u0027t see every possible thing on their first pass, but that is also why we have multiple reviewers, because no reviewer has to catch everything. The thing that is frustrating though is the endless revisions with no sight in end. A business can\u0027t plan if they can\u0027t even plan on a cycle for a new feature that may even have community consensus... because of this review churn that results.\n\nI guess I\u0027m unsure of a good way to convey what I just rambled off above in a few words, but suggestions welcome!","commit_id":"53d9ead7db585a529333f993bf74c5840b590108"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"3ae6a001d3cf7df40da3998514d8f43f9d04a56c","unresolved":false,"context_lines":[{"line_number":152,"context_line":"exacting personal code styles or interpretation of language leads to"},{"line_number":153,"context_line":"discouraged contributors, especially those for which English is not their"},{"line_number":154,"context_line":"first language. We also recognize nitpicks are a mechanism"},{"line_number":155,"context_line":"to help teach and guide, but they should not force repeated revisions."},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"Reviewing contributors should provide encouraging feedback and be"},{"line_number":158,"context_line":"willing to follow-up on their nitpicks themselves using follow-up patches,"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_9accd689","line":155,"range":{"start_line":155,"start_character":45,"end_line":155,"end_character":70},"in_reply_to":"5f7c97a3_ecce862b","updated":"2018-05-31 16:05:02.000000000","message":"To put it another way, reviewers should have the awareness and discipline to stop -1ing when all that\u0027s left is nits.\n\n(When I do a review with multiple comments, some of which are nits and some of which are substantive, I\u0027ll usually leave a top-level comment explaining which issue(s) the -1 is for.)\n\nWe still need consensus on what constitutes a nit.  For reasons stated, this consensus is unlikely ever to reach 100%, but I think this review and the ML thread have gotten pretty close at this point.  If we use the label \"guidelines\" it makes it clear that there aren\u0027t hard rules; reviewers are still free to use common sense and judgment on a case-by-case basis.","commit_id":"53d9ead7db585a529333f993bf74c5840b590108"},{"author":{"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},"change_message_id":"7d4239886ad557a7e5e56a0a784796c1c86bd072","unresolved":false,"context_lines":[{"line_number":155,"context_line":"to help teach and guide, but they should not force repeated revisions."},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"Reviewing contributors should provide encouraging feedback and be"},{"line_number":158,"context_line":"willing to follow-up on their nitpicks themselves using follow-up patches,"},{"line_number":159,"context_line":"such as those generated via `git-nit"},{"line_number":160,"context_line":"\u003chttp://git.openstack.org/cgit/openstack/git-nit/\u003e`__."},{"line_number":161,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_8a8fc021","line":158,"range":{"start_line":158,"start_character":66,"end_line":158,"end_character":73},"updated":"2018-05-30 10:29:37.000000000","message":"I\u0027d say something like \"follow-up changes\" here since people seem to be confused whether this encourages the posting of a new patchset over the existing change, or a new separate follow-up change.","commit_id":"53d9ead7db585a529333f993bf74c5840b590108"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"1b2b4a0417b07848892bba1e21a04532ca3349ae","unresolved":false,"context_lines":[{"line_number":155,"context_line":"to help teach and guide, but they should not force repeated revisions."},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"Reviewing contributors should provide encouraging feedback and be"},{"line_number":158,"context_line":"willing to follow-up on their nitpicks themselves using follow-up patches,"},{"line_number":159,"context_line":"such as those generated via `git-nit"},{"line_number":160,"context_line":"\u003chttp://git.openstack.org/cgit/openstack/git-nit/\u003e`__."},{"line_number":161,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_ebf52ccc","line":158,"range":{"start_line":158,"start_character":17,"end_line":158,"end_character":18},"updated":"2018-05-29 14:32:15.000000000","message":"s/-/ /","commit_id":"53d9ead7db585a529333f993bf74c5840b590108"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"36e68f3fc4ee6e576f8785e35d5af11b5455d510","unresolved":false,"context_lines":[{"line_number":155,"context_line":"to help teach and guide, but they should not force repeated revisions."},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"Reviewing contributors should provide encouraging feedback and be"},{"line_number":158,"context_line":"willing to follow-up on their nitpicks themselves using follow-up patches,"},{"line_number":159,"context_line":"such as those generated via `git-nit"},{"line_number":160,"context_line":"\u003chttp://git.openstack.org/cgit/openstack/git-nit/\u003e`__."},{"line_number":161,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_ec9c460f","line":158,"range":{"start_line":158,"start_character":66,"end_line":158,"end_character":73},"in_reply_to":"5f7c97a3_8a8fc021","updated":"2018-05-30 22:02:44.000000000","message":"I concur, stating changes is much better. Just raw google index counts seem to suggest \"follow-up\" is the preferred style.","commit_id":"53d9ead7db585a529333f993bf74c5840b590108"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"3ae6a001d3cf7df40da3998514d8f43f9d04a56c","unresolved":false,"context_lines":[{"line_number":155,"context_line":"to help teach and guide, but they should not force repeated revisions."},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"Reviewing contributors should provide encouraging feedback and be"},{"line_number":158,"context_line":"willing to follow-up on their nitpicks themselves using follow-up patches,"},{"line_number":159,"context_line":"such as those generated via `git-nit"},{"line_number":160,"context_line":"\u003chttp://git.openstack.org/cgit/openstack/git-nit/\u003e`__."},{"line_number":161,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_daab2e85","line":158,"range":{"start_line":158,"start_character":66,"end_line":158,"end_character":73},"in_reply_to":"5f7c97a3_ec9c460f","updated":"2018-05-31 16:05:02.000000000","message":"\"follow-up\" or \"followup\" when used as a noun or adjective; \"follow up\" when used as a verb, as here.  So commonly misused that I wouldn\u0027t trust any google index.\n\nIt\u0027s a nit; I\u0027m not going to -1 for this :P","commit_id":"53d9ead7db585a529333f993bf74c5840b590108"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"0888de196bc8dc98c558c4ced17859ce17ee6246","unresolved":false,"context_lines":[{"line_number":162,"context_line":"Examples of nitpicks"},{"line_number":163,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"* Style preferences"},{"line_number":166,"context_line":"* Missing punctuation (periods on the end of line...)"},{"line_number":167,"context_line":"* Typos that do not hinder the understanding of the message"},{"line_number":168,"context_line":"* Grammatical preferences (double negatives, passive voice usage...)"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_8d9919c5","line":165,"updated":"2018-05-30 12:18:57.000000000","message":"The wording at the beginning of this section talks about \"personal code style\", while this is about more general \"style preferences\". Does it mean that pointing out that a patch does not follow the general style of the rest of the code (written by different people but consistent) is considered nitpicking?","commit_id":"53d9ead7db585a529333f993bf74c5840b590108"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"36e68f3fc4ee6e576f8785e35d5af11b5455d510","unresolved":false,"context_lines":[{"line_number":162,"context_line":"Examples of nitpicks"},{"line_number":163,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"* Style preferences"},{"line_number":166,"context_line":"* Missing punctuation (periods on the end of line...)"},{"line_number":167,"context_line":"* Typos that do not hinder the understanding of the message"},{"line_number":168,"context_line":"* Grammatical preferences (double negatives, passive voice usage...)"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_8c003204","line":165,"in_reply_to":"5f7c97a3_61ee06ee","updated":"2018-05-30 22:02:44.000000000","message":"I\u0027ve received plenty of -1s that have just hanged around where reviewers have refused or ignored requests to reconsider that the patch was performed in the style of the existing code. I think it is that vicious cycle of seeking perfection.\n\nAt the same time, if someone submits code that passes pep8, that can be understood and followed with ease... are we not then subjecting them to our personal preference to have the code a particular way?\n\nAt the same time, if we have a particular style preference as a project, we should codify that in our testing. Thus I think preference based negative feedback is still a nitpick. \n\nWhat are others thoughts here? I could agree with \"Personal style preferences\" but at the same time nitpicking valid readable code that passes tests would be counter productive and also a style based preference.","commit_id":"53d9ead7db585a529333f993bf74c5840b590108"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"3ae6a001d3cf7df40da3998514d8f43f9d04a56c","unresolved":false,"context_lines":[{"line_number":162,"context_line":"Examples of nitpicks"},{"line_number":163,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"* Style preferences"},{"line_number":166,"context_line":"* Missing punctuation (periods on the end of line...)"},{"line_number":167,"context_line":"* Typos that do not hinder the understanding of the message"},{"line_number":168,"context_line":"* Grammatical preferences (double negatives, passive voice usage...)"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_3af10296","line":165,"in_reply_to":"5f7c97a3_8c003204","updated":"2018-05-31 16:05:02.000000000","message":"IMO this one is almost impossible to codify.  It really needs to be case by case.  Does the style deviate from that of the surrounding code, or from some guideline (which may have been put into place after the surrounding code was written)?  Is the guideline written or is it tribal knowledge?  How egregious is the deviation?  Is it in production code, test code, comments, or docs?\n\nI don\u0027t have a good suggestion other than removing this bullet.  I agree with statements elsewhere that we don\u0027t want to attempt to be exhaustive in our definitions here.","commit_id":"53d9ead7db585a529333f993bf74c5840b590108"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"2e6269b0538079a8f22fd024f109c670a53b448f","unresolved":false,"context_lines":[{"line_number":162,"context_line":"Examples of nitpicks"},{"line_number":163,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"* Style preferences"},{"line_number":166,"context_line":"* Missing punctuation (periods on the end of line...)"},{"line_number":167,"context_line":"* Typos that do not hinder the understanding of the message"},{"line_number":168,"context_line":"* Grammatical preferences (double negatives, passive voice usage...)"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_d3549400","line":165,"in_reply_to":"5f7c97a3_8d9919c5","updated":"2018-05-30 14:01:59.000000000","message":"+1. If \u0027consistency\u0027 is considered a style preference, then I strongly disagree to it being ok for folks to not be consistent (unless there is a good reason to diverge). Depending on how inconsistent the code is, I have -1\u0027d in the past.","commit_id":"53d9ead7db585a529333f993bf74c5840b590108"},{"author":{"_account_id":23078,"name":"Jeremy Freudberg","email":"jeremyfreudberg@gmail.com","username":"jeremyfreudberg"},"change_message_id":"1ab3c40de01e12abbdd007b6adab5b15feac8e01","unresolved":false,"context_lines":[{"line_number":162,"context_line":"Examples of nitpicks"},{"line_number":163,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"* Style preferences"},{"line_number":166,"context_line":"* Missing punctuation (periods on the end of line...)"},{"line_number":167,"context_line":"* Typos that do not hinder the understanding of the message"},{"line_number":168,"context_line":"* Grammatical preferences (double negatives, passive voice usage...)"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_61ee06ee","line":165,"in_reply_to":"5f7c97a3_d3549400","updated":"2018-05-30 16:54:28.000000000","message":"I strongly agree with Luigi\u0027s/Ruby\u0027s thoughts here.","commit_id":"53d9ead7db585a529333f993bf74c5840b590108"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b006b6cb3c435f10e27105decbbb1e7dd3070b5b","unresolved":false,"context_lines":[{"line_number":159,"context_line":"such as those generated via `git-nit"},{"line_number":160,"context_line":"\u003chttp://git.openstack.org/cgit/openstack/git-nit/\u003e`__."},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"Examples of nitpicks"},{"line_number":163,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"* Style preferences"},{"line_number":166,"context_line":"* Missing punctuation (periods on the end of line...)"},{"line_number":167,"context_line":"* Typos that do not hinder the understanding of the message"},{"line_number":168,"context_line":"* Grammatical preferences (double negatives, passive voice usage...)"},{"line_number":169,"context_line":"* Un-necessary refactoring"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_c6361e04","line":169,"range":{"start_line":162,"start_character":0,"end_line":169,"end_character":26},"updated":"2018-05-30 01:39:28.000000000","message":"I think we should be explicit here that these nitpick are applicable for code not doc/reno patches. Because few of above nitpick should be fixed in same PS instead of follow-up as it is doc/reno and proper base structure is needed to merge instead of fixing in in new PS.","commit_id":"53d9ead7db585a529333f993bf74c5840b590108"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"1b2b4a0417b07848892bba1e21a04532ca3349ae","unresolved":false,"context_lines":[{"line_number":166,"context_line":"* Missing punctuation (periods on the end of line...)"},{"line_number":167,"context_line":"* Typos that do not hinder the understanding of the message"},{"line_number":168,"context_line":"* Grammatical preferences (double negatives, passive voice usage...)"},{"line_number":169,"context_line":"* Un-necessary refactoring"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_8bfef8ac","line":169,"range":{"start_line":169,"start_character":4,"end_line":169,"end_character":5},"updated":"2018-05-29 14:32:15.000000000","message":"s/-//","commit_id":"53d9ead7db585a529333f993bf74c5840b590108"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"36e68f3fc4ee6e576f8785e35d5af11b5455d510","unresolved":false,"context_lines":[{"line_number":166,"context_line":"* Missing punctuation (periods on the end of line...)"},{"line_number":167,"context_line":"* Typos that do not hinder the understanding of the message"},{"line_number":168,"context_line":"* Grammatical preferences (double negatives, passive voice usage...)"},{"line_number":169,"context_line":"* Un-necessary refactoring"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_8f5ca419","line":169,"range":{"start_line":169,"start_character":4,"end_line":169,"end_character":5},"in_reply_to":"5f7c97a3_8bfef8ac","updated":"2018-05-30 22:02:44.000000000","message":"Ed, Great catch for polishing. The googleplex index agrees.","commit_id":"53d9ead7db585a529333f993bf74c5840b590108"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"36e68f3fc4ee6e576f8785e35d5af11b5455d510","unresolved":false,"context_lines":[{"line_number":159,"context_line":"such as those generated via `git-nit"},{"line_number":160,"context_line":"\u003chttp://git.openstack.org/cgit/openstack/git-nit/\u003e`__."},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"Examples of nitpicks"},{"line_number":163,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"* Style preferences"},{"line_number":166,"context_line":"* Missing punctuation (periods on the end of line...)"},{"line_number":167,"context_line":"* Typos that do not hinder the understanding of the message"},{"line_number":168,"context_line":"* Grammatical preferences (double negatives, passive voice usage...)"},{"line_number":169,"context_line":"* Un-necessary refactoring"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_6f6108d3","line":169,"range":{"start_line":162,"start_character":0,"end_line":169,"end_character":26},"in_reply_to":"5f7c97a3_c6361e04","updated":"2018-05-30 22:02:44.000000000","message":"I feel like this was pointed out on the mailing list, and we are then still holding an un-necessary high bar by stating that stating that this only applies to code and not doc/reno changes.\n\nAlso, project practices vary, sometimes the needs may vary where these thins may need to be split up to a degree, or are included in the same change.\n\nAn interesting question to ponder, what if someone only knew Latin...","commit_id":"53d9ead7db585a529333f993bf74c5840b590108"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"9e2c69558fd88c5a9f7466b20b2939ee837a8fa3","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Peer review is a fundamental part of our culture. Reviewing submissions of"},{"line_number":54,"context_line":"code and documentation helps us find mistakes and become better programmers"},{"line_number":55,"context_line":"or writers. Peer review helps us build trust between team members and gives"},{"line_number":56,"context_line":"us an opportunity to teach each other about different parts of our software,"},{"line_number":57,"context_line":"CI system, and processes."},{"line_number":58,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f7c97a3_937a8121","line":55,"range":{"start_line":55,"start_character":45,"end_line":55,"end_character":52},"updated":"2018-05-31 18:53:33.000000000","message":"or \"among\"","commit_id":"4fef5707b2de43d32d823e02f3a96a36edd5e881"},{"author":{"_account_id":3217,"name":"Ian Wells","username":"ijw-ubuntu"},"change_message_id":"0fd57c1ee20e7ae3f7fe419220a4471a2ebf94d3","unresolved":false,"context_lines":[{"line_number":54,"context_line":"code and documentation helps us find mistakes and become better programmers"},{"line_number":55,"context_line":"or writers. Peer review helps us build trust between team members and gives"},{"line_number":56,"context_line":"us an opportunity to teach each other about different parts of our software,"},{"line_number":57,"context_line":"CI system, and processes."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"We want review comments to be constructive so that the review process fulfills"},{"line_number":60,"context_line":"its purpose. We do not want reviews to be used to block contributions based on"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f7c97a3_1292bd59","line":57,"updated":"2018-06-04 12:08:13.000000000","message":"I admit it\u0027s the first time that I\u0027ve read this document, but while all of the above are both true and valuable points, peer review\u0027s primary purpose in a quality system is to ensure that unmeasurable aspects of code quality (things that e.g. testing and static analysis can\u0027t pick up) are validated.  I\u0027m surprised this isn\u0027t mentioned.\n\nThat is to say, this is secondarily a tool of education but primarily a means for ensuring the program does what it is supposed to do and will be maintainable in the future by whoever happens to be a project member at that point, which may be neither coder nor reviewer.\n\nPerhaps a topic for a separate patch, though.","commit_id":"4fef5707b2de43d32d823e02f3a96a36edd5e881"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"8e3fe87b26c10cc6d74d93781a400d54a3760194","unresolved":false,"context_lines":[{"line_number":54,"context_line":"code and documentation helps us find mistakes and become better programmers"},{"line_number":55,"context_line":"or writers. Peer review helps us build trust between team members and gives"},{"line_number":56,"context_line":"us an opportunity to teach each other about different parts of our software,"},{"line_number":57,"context_line":"CI system, and processes."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"We want review comments to be constructive so that the review process fulfills"},{"line_number":60,"context_line":"its purpose. We do not want reviews to be used to block contributions based on"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f7c97a3_23d529b8","line":57,"in_reply_to":"5f7c97a3_1292bd59","updated":"2018-06-04 14:17:33.000000000","message":"How would you rephrase \"Reviewing submissions of code and documentation helps us find mistakes\" to make that more clear?","commit_id":"4fef5707b2de43d32d823e02f3a96a36edd5e881"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"04b1b6efb5f1db1b98fec7b57d85554bd04c9191","unresolved":false,"context_lines":[{"line_number":54,"context_line":"code and documentation helps us find mistakes and become better programmers"},{"line_number":55,"context_line":"or writers. Peer review helps us build trust between team members and gives"},{"line_number":56,"context_line":"us an opportunity to teach each other about different parts of our software,"},{"line_number":57,"context_line":"CI system, and processes."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"We want review comments to be constructive so that the review process fulfills"},{"line_number":60,"context_line":"its purpose. We do not want reviews to be used to block contributions based on"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f7c97a3_a0fd7c09","line":57,"in_reply_to":"5f7c97a3_23d529b8","updated":"2018-06-06 09:48:02.000000000","message":"For the sake of completeness: besides spotting mistakes, we sometimes can deduce the overlooked edge cases or offer some optimisation ideas.","commit_id":"4fef5707b2de43d32d823e02f3a96a36edd5e881"},{"author":{"_account_id":3217,"name":"Ian Wells","username":"ijw-ubuntu"},"change_message_id":"691a5e5df9855fd1a8e24354b4c8d379efceabfb","unresolved":false,"context_lines":[{"line_number":54,"context_line":"code and documentation helps us find mistakes and become better programmers"},{"line_number":55,"context_line":"or writers. Peer review helps us build trust between team members and gives"},{"line_number":56,"context_line":"us an opportunity to teach each other about different parts of our software,"},{"line_number":57,"context_line":"CI system, and processes."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"We want review comments to be constructive so that the review process fulfills"},{"line_number":60,"context_line":"its purpose. We do not want reviews to be used to block contributions based on"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f7c97a3_c639b93f","line":57,"in_reply_to":"5f7c97a3_23d529b8","updated":"2018-06-06 02:48:44.000000000","message":"OK, apparently I have selective blindness.","commit_id":"4fef5707b2de43d32d823e02f3a96a36edd5e881"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"9e2c69558fd88c5a9f7466b20b2939ee837a8fa3","unresolved":false,"context_lines":[{"line_number":63,"context_line":"patch is perfect."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"We encourage reviewers who find minor aspects of a patch that they wish to"},{"line_number":66,"context_line":"see changed to engage in discussion with patch authors instead of downvoting,"},{"line_number":67,"context_line":"and to use follow-up patches to make them rather than asking for a new"},{"line_number":68,"context_line":"revision."},{"line_number":69,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f7c97a3_b380ddc0","line":66,"range":{"start_line":66,"start_character":15,"end_line":66,"end_character":62},"updated":"2018-05-31 18:53:33.000000000","message":"To me, this implies that the discussion should happen outside of the review, which is usually not a good thing (because no trackability/history).\n\nPerhaps:\n\n\"We encourage reviewers to work with authors to submit follow-up change sets for minor issues rather than downvoting the original change set.\"","commit_id":"4fef5707b2de43d32d823e02f3a96a36edd5e881"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3b7cc33a9ba0cdc749c127a88778e16a1ced8d6a","unresolved":false,"context_lines":[{"line_number":63,"context_line":"patch is perfect."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"We encourage reviewers who find minor aspects of a patch that they wish to"},{"line_number":66,"context_line":"see changed to engage in discussion with patch authors instead of downvoting,"},{"line_number":67,"context_line":"and to use follow-up patches to make them rather than asking for a new"},{"line_number":68,"context_line":"revision."},{"line_number":69,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f7c97a3_f89ccd5c","line":66,"range":{"start_line":66,"start_character":15,"end_line":66,"end_character":62},"in_reply_to":"5f7c97a3_0e8f242a","updated":"2018-06-03 16:40:21.000000000","message":"I think Amy\u0027s suggestion works, although I also suspect we may need to tune that at a later point... which I also think is totally cool.","commit_id":"4fef5707b2de43d32d823e02f3a96a36edd5e881"},{"author":{"_account_id":15993,"name":"Amy Marrich","display_name":"Amy Marrich (spotz)","email":"amy@demarco.com","username":"amarrich"},"change_message_id":"d173169e74ded93b7c50e597034a6b9168bd1692","unresolved":false,"context_lines":[{"line_number":63,"context_line":"patch is perfect."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"We encourage reviewers who find minor aspects of a patch that they wish to"},{"line_number":66,"context_line":"see changed to engage in discussion with patch authors instead of downvoting,"},{"line_number":67,"context_line":"and to use follow-up patches to make them rather than asking for a new"},{"line_number":68,"context_line":"revision."},{"line_number":69,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f7c97a3_0e8f242a","line":66,"range":{"start_line":66,"start_character":15,"end_line":66,"end_character":62},"in_reply_to":"5f7c97a3_8e94948c","updated":"2018-05-31 19:53:59.000000000","message":"What about - We encourage reviewers who find minor aspects of a patch they feel need to be changed, to engage the author in discussion versus downvoting,.....","commit_id":"4fef5707b2de43d32d823e02f3a96a36edd5e881"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"f74adb89271b2eb61d256ab1ed51ea73722f513e","unresolved":false,"context_lines":[{"line_number":63,"context_line":"patch is perfect."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"We encourage reviewers who find minor aspects of a patch that they wish to"},{"line_number":66,"context_line":"see changed to engage in discussion with patch authors instead of downvoting,"},{"line_number":67,"context_line":"and to use follow-up patches to make them rather than asking for a new"},{"line_number":68,"context_line":"revision."},{"line_number":69,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f7c97a3_8e94948c","line":66,"range":{"start_line":66,"start_character":15,"end_line":66,"end_character":62},"in_reply_to":"5f7c97a3_937361e7","updated":"2018-05-31 19:28:09.000000000","message":"Yeah, I know, tough to do without exploding the number of words we have to use.\n\n\"We encourage reviewers and/or authors to submit follow-up change sets for minor issues rather than downvoting the original change set.\"\n\n?","commit_id":"4fef5707b2de43d32d823e02f3a96a36edd5e881"},{"author":{"_account_id":3217,"name":"Ian Wells","username":"ijw-ubuntu"},"change_message_id":"ddb07ef845ff2be68c781b22520556980970193f","unresolved":false,"context_lines":[{"line_number":63,"context_line":"patch is perfect."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"We encourage reviewers who find minor aspects of a patch that they wish to"},{"line_number":66,"context_line":"see changed to engage in discussion with patch authors instead of downvoting,"},{"line_number":67,"context_line":"and to use follow-up patches to make them rather than asking for a new"},{"line_number":68,"context_line":"revision."},{"line_number":69,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f7c97a3_a66a7d18","line":66,"range":{"start_line":66,"start_character":15,"end_line":66,"end_character":62},"in_reply_to":"5f7c97a3_99c6df49","updated":"2018-06-06 02:54:14.000000000","message":"The question is not \u0027is -1 a bad vote\u0027; the question is \u0027what is the most productive thing to do in a given circumstance\u0027.  -1 is usually enough to block a patch from being accepted short of an appeal personally to a core reviewer.  In truth do you mean \u0027I would not accept this patch short of personal attention from a higher authority to confirm it\u0027s adequate\u0027 or do you mean \u0027I think it could be slightly better\u0027?\n\nI think this is really coming to a common understanding of what a -1 actually does to a patch, versus what we believe it to mean.","commit_id":"4fef5707b2de43d32d823e02f3a96a36edd5e881"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"3779cff43cab5efdf42b342044ceeb239fb6b08d","unresolved":false,"context_lines":[{"line_number":63,"context_line":"patch is perfect."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"We encourage reviewers who find minor aspects of a patch that they wish to"},{"line_number":66,"context_line":"see changed to engage in discussion with patch authors instead of downvoting,"},{"line_number":67,"context_line":"and to use follow-up patches to make them rather than asking for a new"},{"line_number":68,"context_line":"revision."},{"line_number":69,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f7c97a3_937361e7","line":66,"range":{"start_line":66,"start_character":15,"end_line":66,"end_character":62},"in_reply_to":"5f7c97a3_b380ddc0","updated":"2018-05-31 19:09:20.000000000","message":"I\u0027m not sure I see that implication but we can work on the wording. Your proposal makes it sounds like we expect the authors to submit those updates, and that\u0027s not the point. We want reviewers to be willing to do it, too. How can we include that in the update?","commit_id":"4fef5707b2de43d32d823e02f3a96a36edd5e881"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"661cf47fed0d8703245cee81468f045f4324825d","unresolved":false,"context_lines":[{"line_number":63,"context_line":"patch is perfect."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"We encourage reviewers who find minor aspects of a patch that they wish to"},{"line_number":66,"context_line":"see changed to engage in discussion with patch authors instead of downvoting,"},{"line_number":67,"context_line":"and to use follow-up patches to make them rather than asking for a new"},{"line_number":68,"context_line":"revision."},{"line_number":69,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f7c97a3_99c6df49","line":66,"range":{"start_line":66,"start_character":15,"end_line":66,"end_character":62},"in_reply_to":"5f7c97a3_f89ccd5c","updated":"2018-06-05 07:51:28.000000000","message":"Maybe I am weird but I don\u0027t think a -1 is a bad vote.\nAnd, when I read this text, it means the downvote sounds negative.\n\nI like this part of the text of Amy: \"We encourage reviewers who find minor aspects of a patch they feel need to be changed to engage with the patch author\". I\u0027d just continue with \"on how to collaboratively improve the current state. This can be done, for example, by updating the current patch, or by proposing another patch later.\"\n\nWhich IMO, sounds better, but Ian Wells here below made an even far better text :)","commit_id":"4fef5707b2de43d32d823e02f3a96a36edd5e881"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"9e2c69558fd88c5a9f7466b20b2939ee837a8fa3","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"We encourage reviewers who find minor aspects of a patch that they wish to"},{"line_number":66,"context_line":"see changed to engage in discussion with patch authors instead of downvoting,"},{"line_number":67,"context_line":"and to use follow-up patches to make them rather than asking for a new"},{"line_number":68,"context_line":"revision."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"One Contributor, One Vote"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f7c97a3_d399d96c","line":67,"range":{"start_line":67,"start_character":21,"end_line":67,"end_character":28},"updated":"2018-05-31 18:53:33.000000000","message":"change sets","commit_id":"4fef5707b2de43d32d823e02f3a96a36edd5e881"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"a024ef35f5f2e817198a6561db7129e05afa36f5","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"We encourage reviewers who find minor aspects of a patch that they wish to"},{"line_number":66,"context_line":"see changed to engage in discussion with patch authors instead of downvoting,"},{"line_number":67,"context_line":"and to use follow-up patches to make them rather than asking for a new"},{"line_number":68,"context_line":"revision."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"One Contributor, One Vote"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f7c97a3_6c9c6d0e","line":67,"range":{"start_line":67,"start_character":21,"end_line":67,"end_character":28},"in_reply_to":"5f7c97a3_1222bdbb","updated":"2018-06-04 16:50:00.000000000","message":"I think this is very nicely stated.","commit_id":"4fef5707b2de43d32d823e02f3a96a36edd5e881"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"dbe52397ce5ddaf3c7a8d50b3ac5ebddbc755591","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"We encourage reviewers who find minor aspects of a patch that they wish to"},{"line_number":66,"context_line":"see changed to engage in discussion with patch authors instead of downvoting,"},{"line_number":67,"context_line":"and to use follow-up patches to make them rather than asking for a new"},{"line_number":68,"context_line":"revision."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"One Contributor, One Vote"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f7c97a3_902852e2","line":67,"range":{"start_line":67,"start_character":21,"end_line":67,"end_character":28},"in_reply_to":"5f7c97a3_39f1cb96","updated":"2018-06-12 15:36:32.000000000","message":"We are trying to avoid being too verbose, and with the review guide updates I\u0027m unsure if we really need to dive into the level of detail, where as we should be focusing on principles for context sharing. You do have a great item which is pointing out that without good will we would not have a community. I\u0027m adding that to the first paragraph because it feels important to state upfront to provide greater context.","commit_id":"4fef5707b2de43d32d823e02f3a96a36edd5e881"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"661cf47fed0d8703245cee81468f045f4324825d","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"We encourage reviewers who find minor aspects of a patch that they wish to"},{"line_number":66,"context_line":"see changed to engage in discussion with patch authors instead of downvoting,"},{"line_number":67,"context_line":"and to use follow-up patches to make them rather than asking for a new"},{"line_number":68,"context_line":"revision."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"One Contributor, One Vote"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f7c97a3_39f1cb96","line":67,"range":{"start_line":67,"start_character":21,"end_line":67,"end_character":28},"in_reply_to":"5f7c97a3_6c9c6d0e","updated":"2018-06-05 07:51:28.000000000","message":"I agree. I\u0027d remove \"fundamental\" in the last sentence, though.\n\nFor me, a nit is a comment or even a +1, a problem is -1, a fundamental problem is -2, but again, that might be me.","commit_id":"4fef5707b2de43d32d823e02f3a96a36edd5e881"},{"author":{"_account_id":3217,"name":"Ian Wells","username":"ijw-ubuntu"},"change_message_id":"0fd57c1ee20e7ae3f7fe419220a4471a2ebf94d3","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"We encourage reviewers who find minor aspects of a patch that they wish to"},{"line_number":66,"context_line":"see changed to engage in discussion with patch authors instead of downvoting,"},{"line_number":67,"context_line":"and to use follow-up patches to make them rather than asking for a new"},{"line_number":68,"context_line":"revision."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"One Contributor, One Vote"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f7c97a3_1222bdbb","line":67,"range":{"start_line":67,"start_character":21,"end_line":67,"end_character":28},"in_reply_to":"5f7c97a3_d399d96c","updated":"2018-06-04 12:08:13.000000000","message":"I\u0027m going to propose an alternative wording for the sake of discussion, though from I can see here that we\u0027re trying to keep changes to a minimum so it may not be an option on the table.\n\n\"Review is a balancing act between getting things in the hands of the users and making things perfect.  Work needs to be good enough, not perfect.\n\nWe encourage reviewers to find ways to improve contributions, but we ask reviewers to consider how best to use that information. Options include:\n- making a comment asking the author to consider incorporating the information\n- updating the patch directly (for minor changes with a specific skillset - for instance, if the reviewer is a native speaker and the author is not)\n- propose another patch on top (for instance, if code will work just fine, get it into the hands of users now, and take additional time to consider how to make it more elegant)\n\nReviewers should considerate and encouraging; we would have no project but for the goodwill of our contributors.  We all write code that could be better, and no code is perfect.  Communicate; do not downvote patches unless there is a fundamental problem, and do not criticise without offering help to overcome the obstacle.\"","commit_id":"4fef5707b2de43d32d823e02f3a96a36edd5e881"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"9e2c69558fd88c5a9f7466b20b2939ee837a8fa3","unresolved":false,"context_lines":[{"line_number":65,"context_line":"We encourage reviewers who find minor aspects of a patch that they wish to"},{"line_number":66,"context_line":"see changed to engage in discussion with patch authors instead of downvoting,"},{"line_number":67,"context_line":"and to use follow-up patches to make them rather than asking for a new"},{"line_number":68,"context_line":"revision."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"One Contributor, One Vote"},{"line_number":71,"context_line":"-------------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f7c97a3_f3de550f","line":68,"range":{"start_line":68,"start_character":0,"end_line":68,"end_character":8},"updated":"2018-05-31 18:53:33.000000000","message":"or \"patch set\"\n\nI know we colloquially use \"patch\" to refer to what gerrit calls a \"change set\", but noobs won\u0027t necessarily know that.  Using gerrit\u0027s terminology (\"change set\" and \"patch set\") is unambiguous.","commit_id":"4fef5707b2de43d32d823e02f3a96a36edd5e881"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"21ca6f0a741e203b8341800ee7a222eadb9e942c","unresolved":false,"context_lines":[{"line_number":65,"context_line":"We encourage reviewers who find minor aspects of a patch that they wish to"},{"line_number":66,"context_line":"see changed to engage in discussion with patch authors instead of downvoting,"},{"line_number":67,"context_line":"and to use follow-up patches to make them rather than asking for a new"},{"line_number":68,"context_line":"revision."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"One Contributor, One Vote"},{"line_number":71,"context_line":"-------------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f7c97a3_ee4e686d","line":68,"range":{"start_line":68,"start_character":0,"end_line":68,"end_character":8},"in_reply_to":"5f7c97a3_537949c2","updated":"2018-05-31 19:33:27.000000000","message":"From my perspective the current wording (\"follow-up patches\" vs. \"new revision\") is extremely clear, and your alternative (\"follow-up change sets\" vs. \"new patch set\") could easily mean the opposite.\n\nI don\u0027t know how this translates to new contributors, but I would point out that:\n\n* New contributors are actually *less* likely to be familiar with Gerrit terminology than anyone.\n* The main audience for this (although it\u0027s for all reviewers) is core reviewers, whom we can expect to understand the terminology as written.\n\nAlso since this is a review about nitpicking, Gerrit uses the term \"Change\" (and there\u0027s a corresponding \"Change-Id\" in the commit message) but not \"change set\" anywhere in the UI that I can see. You might be thinking of Mercurial ;)","commit_id":"4fef5707b2de43d32d823e02f3a96a36edd5e881"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"c6007b973fcd8aae498b692a4cab0c6ad8ce386c","unresolved":false,"context_lines":[{"line_number":65,"context_line":"We encourage reviewers who find minor aspects of a patch that they wish to"},{"line_number":66,"context_line":"see changed to engage in discussion with patch authors instead of downvoting,"},{"line_number":67,"context_line":"and to use follow-up patches to make them rather than asking for a new"},{"line_number":68,"context_line":"revision."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"One Contributor, One Vote"},{"line_number":71,"context_line":"-------------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f7c97a3_8e47b41d","line":68,"range":{"start_line":68,"start_character":0,"end_line":68,"end_character":8},"in_reply_to":"5f7c97a3_537949c2","updated":"2018-05-31 19:40:57.000000000","message":"The misuse/confusion of this terminology has created problems in the past too. I\u0027ve been asked to push a new patchset, so I did and updated an existing change with a new patchset. The requester wanted a followup change instead. Long story short ++ to being specific with the terminology here.\n\nChanges are the top level review \"objects\" they are composed of one or more patchsets. Asking for a new patch(set) could imply updating the original change rather than pushing a new change.","commit_id":"4fef5707b2de43d32d823e02f3a96a36edd5e881"},{"author":{"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},"change_message_id":"6bca5ac970a7d062f59fc2073e9366b25098c2b8","unresolved":false,"context_lines":[{"line_number":65,"context_line":"We encourage reviewers who find minor aspects of a patch that they wish to"},{"line_number":66,"context_line":"see changed to engage in discussion with patch authors instead of downvoting,"},{"line_number":67,"context_line":"and to use follow-up patches to make them rather than asking for a new"},{"line_number":68,"context_line":"revision."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"One Contributor, One Vote"},{"line_number":71,"context_line":"-------------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f7c97a3_9ac84822","line":68,"range":{"start_line":68,"start_character":0,"end_line":68,"end_character":8},"in_reply_to":"5f7c97a3_8e47b41d","updated":"2018-06-01 09:03:29.000000000","message":"Right, we need to be clear here... I suggest \"and to post a follow-up change rather than ask for a new revision on the current change\".","commit_id":"4fef5707b2de43d32d823e02f3a96a36edd5e881"},{"author":{"_account_id":3217,"name":"Ian Wells","username":"ijw-ubuntu"},"change_message_id":"691a5e5df9855fd1a8e24354b4c8d379efceabfb","unresolved":false,"context_lines":[{"line_number":65,"context_line":"We encourage reviewers who find minor aspects of a patch that they wish to"},{"line_number":66,"context_line":"see changed to engage in discussion with patch authors instead of downvoting,"},{"line_number":67,"context_line":"and to use follow-up patches to make them rather than asking for a new"},{"line_number":68,"context_line":"revision."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"One Contributor, One Vote"},{"line_number":71,"context_line":"-------------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f7c97a3_0638113b","line":68,"range":{"start_line":68,"start_character":0,"end_line":68,"end_character":8},"in_reply_to":"5f7c97a3_9ac84822","updated":"2018-06-06 02:48:44.000000000","message":"\u0027...revising the change under review\u0027.","commit_id":"4fef5707b2de43d32d823e02f3a96a36edd5e881"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"3779cff43cab5efdf42b342044ceeb239fb6b08d","unresolved":false,"context_lines":[{"line_number":65,"context_line":"We encourage reviewers who find minor aspects of a patch that they wish to"},{"line_number":66,"context_line":"see changed to engage in discussion with patch authors instead of downvoting,"},{"line_number":67,"context_line":"and to use follow-up patches to make them rather than asking for a new"},{"line_number":68,"context_line":"revision."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"One Contributor, One Vote"},{"line_number":71,"context_line":"-------------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f7c97a3_537949c2","line":68,"range":{"start_line":68,"start_character":0,"end_line":68,"end_character":8},"in_reply_to":"5f7c97a3_f3de550f","updated":"2018-05-31 19:09:20.000000000","message":"That\u0027s a good point.","commit_id":"4fef5707b2de43d32d823e02f3a96a36edd5e881"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"2e54603c914e17f465c6a741356256c3499be0b4","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"We want review comments to be constructive so that the review process fulfills"},{"line_number":61,"context_line":"its purpose. We do not want reviews to be used to block contributions based on"},{"line_number":62,"context_line":"minor issues, often called \"nits\". The focus should always be on incremental"},{"line_number":63,"context_line":"improvement of the system as a whole, rather than ensuring each individual"},{"line_number":64,"context_line":"change is perfect."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"We encourage reviewers who find minor aspects of a change they feel need to"},{"line_number":67,"context_line":"be changed, to engage the author in discussion versus downvoting, and"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5f7c97a3_90ea1bd6","line":64,"range":{"start_line":62,"start_character":35,"end_line":64,"end_character":18},"updated":"2018-06-18 12:45:48.000000000","message":"yay!","commit_id":"a1c444beed87ffd2ca8d646987acf9a3b828205a"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"abca16dc61715b828a6e5020c50006e1734747ab","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"We encourage reviewers who find minor aspects of a change they feel need to"},{"line_number":67,"context_line":"be changed, to engage the author in discussion versus downvoting, and"},{"line_number":68,"context_line":"collaborate on how best to move the change forward. Often this may result"},{"line_number":69,"context_line":"in a follow-up change, or revising the change under review."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"One Contributor, One Vote"},{"line_number":72,"context_line":"-------------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5f7c97a3_165c357b","line":69,"range":{"start_line":68,"start_character":52,"end_line":69,"end_character":59},"updated":"2018-06-12 16:50:32.000000000","message":"You haven\u0027t said who\u0027s responsible for this.\n\nAnd that\u0027s exactly as it should be.\n\nWill depend on the situation.","commit_id":"a1c444beed87ffd2ca8d646987acf9a3b828205a"}]}
