)]}'
{"tools/check_review_status.py":[{"author":{"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},"change_message_id":"29079f7187c339bd10666edec343282b4dfa1918","unresolved":false,"context_lines":[{"line_number":170,"context_line":"        elif votes[1] \u003c 7:"},{"line_number":171,"context_line":"            can_approve \u003d \u0027not majority\u0027"},{"line_number":172,"context_line":"        elif votes[1] \u003c 5:"},{"line_number":173,"context_line":"            can_approve \u003d \u0027not enough votes\u0027"},{"line_number":174,"context_line":"        else:"},{"line_number":175,"context_line":"            can_approve \u003d \u0027YES\u0027"},{"line_number":176,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_8c2a9b7b","line":173,"updated":"2018-07-05 10:28:37.000000000","message":"This is short-circuited by the previous elif, so will never happen","commit_id":"92bd20d7240e1250a023e71791123da55c20ce6f"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"c3ae33af55edd349ecbb35d51c3dbe50916fe3cf","unresolved":false,"context_lines":[{"line_number":170,"context_line":"        elif votes[1] \u003c 7:"},{"line_number":171,"context_line":"            can_approve \u003d \u0027not majority\u0027"},{"line_number":172,"context_line":"        elif votes[1] \u003c 5:"},{"line_number":173,"context_line":"            can_approve \u003d \u0027not enough votes\u0027"},{"line_number":174,"context_line":"        else:"},{"line_number":175,"context_line":"            can_approve \u003d \u0027YES\u0027"},{"line_number":176,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_8bfb58bd","line":173,"in_reply_to":"5f7c97a3_8c2a9b7b","updated":"2018-07-05 18:09:55.000000000","message":"Done","commit_id":"92bd20d7240e1250a023e71791123da55c20ce6f"},{"author":{"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},"change_message_id":"29079f7187c339bd10666edec343282b4dfa1918","unresolved":false,"context_lines":[{"line_number":172,"context_line":"        elif votes[1] \u003c 5:"},{"line_number":173,"context_line":"            can_approve \u003d \u0027not enough votes\u0027"},{"line_number":174,"context_line":"        else:"},{"line_number":175,"context_line":"            can_approve \u003d \u0027YES\u0027"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"        if can_approve !\u003d \u0027no\u0027 and age \u003c datetime.timedelta(3):"},{"line_number":178,"context_line":"            can_approve \u003d can_approve + \u0027, too soon\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_4c5563f8","line":175,"updated":"2018-07-05 10:28:37.000000000","message":"Majority is just a shortcut. The real rule is at least 5 positive votes and more positive votes than negative votes. \n\nWith the current code, 6 yes and 1 nay would result in a \"no\" while it should result in a \"yes if final vote was called\".","commit_id":"92bd20d7240e1250a023e71791123da55c20ce6f"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"c3ae33af55edd349ecbb35d51c3dbe50916fe3cf","unresolved":false,"context_lines":[{"line_number":172,"context_line":"        elif votes[1] \u003c 5:"},{"line_number":173,"context_line":"            can_approve \u003d \u0027not enough votes\u0027"},{"line_number":174,"context_line":"        else:"},{"line_number":175,"context_line":"            can_approve \u003d \u0027YES\u0027"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"        if can_approve !\u003d \u0027no\u0027 and age \u003c datetime.timedelta(3):"},{"line_number":178,"context_line":"            can_approve \u003d can_approve + \u0027, too soon\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_abf894c0","line":175,"in_reply_to":"5f7c97a3_4c5563f8","updated":"2018-07-05 18:09:55.000000000","message":"Done","commit_id":"92bd20d7240e1250a023e71791123da55c20ce6f"},{"author":{"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},"change_message_id":"29079f7187c339bd10666edec343282b4dfa1918","unresolved":false,"context_lines":[{"line_number":232,"context_line":"    votes \u003d \u0027\\n\u0027.join(["},{"line_number":233,"context_line":"        \u0027CR:\u0027 + format_votes(code_reviews),"},{"line_number":234,"context_line":"        \u0027 V:\u0027 + format_votes(votes),"},{"line_number":235,"context_line":"        \u0027 W:\u0027 + format_votes(workflow),"},{"line_number":236,"context_line":"        \u0027\u0027,"},{"line_number":237,"context_line":"    ])"},{"line_number":238,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_a900a904","line":235,"updated":"2018-07-05 10:28:37.000000000","message":"The W line looks a bit like noise to me, but if it\u0027s useful to others...","commit_id":"92bd20d7240e1250a023e71791123da55c20ce6f"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"c3ae33af55edd349ecbb35d51c3dbe50916fe3cf","unresolved":false,"context_lines":[{"line_number":232,"context_line":"    votes \u003d \u0027\\n\u0027.join(["},{"line_number":233,"context_line":"        \u0027CR:\u0027 + format_votes(code_reviews),"},{"line_number":234,"context_line":"        \u0027 V:\u0027 + format_votes(votes),"},{"line_number":235,"context_line":"        \u0027 W:\u0027 + format_votes(workflow),"},{"line_number":236,"context_line":"        \u0027\u0027,"},{"line_number":237,"context_line":"    ])"},{"line_number":238,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_ebf20ce3","line":235,"in_reply_to":"5f7c97a3_a900a904","updated":"2018-07-05 18:09:55.000000000","message":"Done","commit_id":"92bd20d7240e1250a023e71791123da55c20ce6f"}]}