)]}'
{"reference/project-testing-interface.rst":[{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"e8a8fe70bba267b3b1e1b442c94cb0181ef6295b","unresolved":false,"context_lines":[{"line_number":58,"context_line":"* Have a ``docs`` environment set up in a ``tox.ini`` file within the"},{"line_number":59,"context_line":"  repository."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"Assuming requirements have been properly installed as indicated by"},{"line_number":62,"context_line":"``bindep.txt``, the following command should work with no additional"},{"line_number":63,"context_line":"setup and should result in the documentation being emitted into"},{"line_number":64,"context_line":"``doc/build/html``."}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f7c97a3_8ee014fa","line":61,"range":{"start_line":61,"start_character":0,"end_line":61,"end_character":21},"updated":"2018-07-09 16:58:06.000000000","message":"Maybe change this to \"Assuming any non-Python requirements\" to avoid confusion?","commit_id":"128c9213a793c79129cfa2e03bf4687ee8fbe0ea"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"1e1501ef4f89266dd09e8e97599a880e8782d7fa","unresolved":false,"context_lines":[{"line_number":58,"context_line":"* Have a ``docs`` environment set up in a ``tox.ini`` file within the"},{"line_number":59,"context_line":"  repository."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"Assuming requirements have been properly installed as indicated by"},{"line_number":62,"context_line":"``bindep.txt``, the following command should work with no additional"},{"line_number":63,"context_line":"setup and should result in the documentation being emitted into"},{"line_number":64,"context_line":"``doc/build/html``."}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f7c97a3_8e1ed471","line":61,"range":{"start_line":61,"start_character":0,"end_line":61,"end_character":21},"in_reply_to":"5f7c97a3_8ee014fa","updated":"2018-07-09 17:23:37.000000000","message":"Done","commit_id":"128c9213a793c79129cfa2e03bf4687ee8fbe0ea"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"ae59105a4242b93f24767e07b257bde45075af2c","unresolved":false,"context_lines":[{"line_number":59,"context_line":"  repository."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"Assuming requirements have been properly installed as indicated by"},{"line_number":62,"context_line":"``bindep.txt``, the following command should work with no additional"},{"line_number":63,"context_line":"setup and should result in the documentation being emitted into"},{"line_number":64,"context_line":"``doc/build/html``."},{"line_number":65,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f7c97a3_5cb988e9","line":62,"updated":"2018-07-05 21:08:52.000000000","message":"Why bindep.txt and not doc/requirements.txt? Many projects already have the docs environment defined but they use doc/requirements.txt and this works locally. If the main change here is to go back to use the tox environment on the gates, I don\u0027t see the reason to also switch to bindep.txt at the same time.\nI suggest to discuss again this specific change or at least postpone it.\n\nAlso, if bindep.txt must be used, should doc dependency use a specific environment? [doc]?","commit_id":"128c9213a793c79129cfa2e03bf4687ee8fbe0ea"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"7c0cbb4d6cae8c61037b79480a2bd311b1dc12b2","unresolved":false,"context_lines":[{"line_number":59,"context_line":"  repository."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"Assuming requirements have been properly installed as indicated by"},{"line_number":62,"context_line":"``bindep.txt``, the following command should work with no additional"},{"line_number":63,"context_line":"setup and should result in the documentation being emitted into"},{"line_number":64,"context_line":"``doc/build/html``."},{"line_number":65,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f7c97a3_dccd985e","line":62,"in_reply_to":"5f7c97a3_5c8c282d","updated":"2018-07-05 21:22:28.000000000","message":"I see, thanks for clarifying.","commit_id":"128c9213a793c79129cfa2e03bf4687ee8fbe0ea"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"d112802a3e0b45246556e2411ab664b602a35844","unresolved":false,"context_lines":[{"line_number":59,"context_line":"  repository."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"Assuming requirements have been properly installed as indicated by"},{"line_number":62,"context_line":"``bindep.txt``, the following command should work with no additional"},{"line_number":63,"context_line":"setup and should result in the documentation being emitted into"},{"line_number":64,"context_line":"``doc/build/html``."},{"line_number":65,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f7c97a3_5c8c282d","line":62,"in_reply_to":"5f7c97a3_5cb988e9","updated":"2018-07-05 21:15:06.000000000","message":"The use of doc/requirements.txt is still present, see line 53. The change here is that we do not need someone to install those dependencies *before* running tox, because tox should install them.","commit_id":"128c9213a793c79129cfa2e03bf4687ee8fbe0ea"},{"author":{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},"change_message_id":"81a6e2274180dc8e5b9875c81c6ec16c3f4d2b98","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":".. note::"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"   We strongly discourage project teams from adding commands to the"},{"line_number":73,"context_line":"   ``docs`` environment beyond:"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"   .. code-block:: bash"},{"line_number":76,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f7c97a3_f82632ba","line":73,"range":{"start_line":72,"start_character":0,"end_line":73,"end_character":31},"updated":"2018-07-09 15:22:49.000000000","message":"I know long ago this was an issue, projects adding commands. However, even if we strongly discourage projects from adding things, I don\u0027t believe that will stop it.  Not saying projects will go out and start adding command, but think either except it is going to happen or maybe write some automate to validate tox.ini files.","commit_id":"128c9213a793c79129cfa2e03bf4687ee8fbe0ea"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"534a5f2e16423e8a3c02c211cfe8eb3cf8e054a8","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":".. note::"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"   We strongly discourage project teams from adding commands to the"},{"line_number":73,"context_line":"   ``docs`` environment beyond:"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"   .. code-block:: bash"},{"line_number":76,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f7c97a3_33ba8d0a","line":73,"range":{"start_line":72,"start_character":0,"end_line":73,"end_character":31},"in_reply_to":"5f7c97a3_f82632ba","updated":"2018-07-09 16:07:20.000000000","message":"Yes, that\u0027s a risk. We could do some validation, but I\u0027m less concerned about lots of extra steps for doc builds than I am for package builds, and the package builds are staying the same (i.e., no tox).","commit_id":"128c9213a793c79129cfa2e03bf4687ee8fbe0ea"}],"reference/pti/python.rst":[{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"e8a8fe70bba267b3b1e1b442c94cb0181ef6295b","unresolved":false,"context_lines":[{"line_number":161,"context_line":""},{"line_number":162,"context_line":"The project infrastructure will not use ``tox -e docs`` to build the"},{"line_number":163,"context_line":"documentation. Therefore it is **STRONGLY** discouraged for people to put"},{"line_number":164,"context_line":"additional logic into the command section of that tox environment. Additional"},{"line_number":165,"context_line":"logic needed around Sphinx generation should go into Sphinx plugins."},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"Release Notes"},{"line_number":168,"context_line":"-------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f7c97a3_8e8ed42f","side":"PARENT","line":165,"range":{"start_line":164,"start_character":67,"end_line":165,"end_character":68},"updated":"2018-07-09 16:58:06.000000000","message":"Is it maybe worth copying over this sentence too?","commit_id":"d2fb9b804b554965c63d7ad597020a55b49355a1"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"1e1501ef4f89266dd09e8e97599a880e8782d7fa","unresolved":false,"context_lines":[{"line_number":161,"context_line":""},{"line_number":162,"context_line":"The project infrastructure will not use ``tox -e docs`` to build the"},{"line_number":163,"context_line":"documentation. Therefore it is **STRONGLY** discouraged for people to put"},{"line_number":164,"context_line":"additional logic into the command section of that tox environment. Additional"},{"line_number":165,"context_line":"logic needed around Sphinx generation should go into Sphinx plugins."},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"Release Notes"},{"line_number":168,"context_line":"-------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f7c97a3_ce384cee","side":"PARENT","line":165,"range":{"start_line":164,"start_character":67,"end_line":165,"end_character":68},"in_reply_to":"5f7c97a3_8e8ed42f","updated":"2018-07-09 17:23:37.000000000","message":"Done","commit_id":"d2fb9b804b554965c63d7ad597020a55b49355a1"}]}
