)]}'
{"id":"openstack%2Fgovernance~669549","triplet_id":"openstack%2Fgovernance~master~Ib5a5c48131603effeed4e967f4ff6057b73bc712","project":"openstack/governance","branch":"master","topic":"code-change","hashtags":[],"change_id":"Ib5a5c48131603effeed4e967f4ff6057b73bc712","subject":"ci: check for proper retirement","status":"ABANDONED","created":"2019-07-06 17:36:03.000000000","updated":"2019-12-04 12:08:10.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"d9a70a01245c6c026124bbfd7152fc7e493ab212","_number":669549,"virtual_id_number":669549,"owner":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},{"date":"2019-07-06 18:21:05.000000000","_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},{"date":"2019-12-04 12:08:07.000000000","_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},{"date":"2019-07-08 16:36:15.000000000","_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},{"value":-1,"date":"2019-07-06 17:43:07.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"rejected":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"all":[{"value":-1,"date":"2019-07-08 05:43:39.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Rollcall-Vote":{"all":[{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"No"," 0":"Abstain","+1":"Yes"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-07-06 17:43:07.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-07-06 18:21:05.000000000","updated_by":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"reviewer":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"state":"REVIEWER"},{"updated":"2019-07-08 05:43:39.000000000","updated_by":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"reviewer":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"state":"REVIEWER"},{"updated":"2019-12-04 12:08:07.000000000","updated_by":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"reviewer":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"state":"REVIEWER"}],"messages":[{"id":"75468ef24261911b26196b2d45b9ae1bc1a91ada","author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"date":"2019-07-06 17:36:03.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ae8ddb9764d044f23c4e9699f88ae781b9fe546b","author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"date":"2019-07-06 17:36:51.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"a29ba719f1a2a52c49a757d09a941349d64b9977","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-06 17:43:07.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-docs http://logs.openstack.org/49/669549/2/check/openstack-tox-docs/7d23db1/html/ : SUCCESS in 4m 01s\n- openstack-tox-py36 http://logs.openstack.org/49/669549/2/check/openstack-tox-py36/28ac98f/ : SUCCESS in 3m 32s\n- openstack-tox-linters http://logs.openstack.org/49/669549/2/check/openstack-tox-linters/4084f9c/ : FAILURE in 3m 45s","accounts_in_message":[],"_revision_number":2},{"id":"5b9cc6c13f1d691f8e94c66787015f00fa9e4357","author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"date":"2019-07-06 18:19:12.000000000","message":"Patch Set 2:\n\nDoes removing a repo from governance always imply that it is being fully retired? Does that mean I couldn\u0027t, for example, take stevedore out of the Oslo team repo list and maintain it myself on GitHub? (Not that I want to, that\u0027s just an example.)","accounts_in_message":[],"_revision_number":2},{"id":"9dec2034497a24e825dfab10edc8a41b4a4f330b","author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"date":"2019-07-06 18:21:05.000000000","message":"Patch Set 2:\n\n\u003e Does removing a repo from governance always imply that it is being\n \u003e fully retired? Does that mean I couldn\u0027t, for example, take\n \u003e stevedore out of the Oslo team repo list and maintain it myself on\n \u003e GitHub? (Not that I want to, that\u0027s just an example.)\n\nI suppose I should have actually asked if I could maintain it on opendev.org just not under the Oslo program. Moving to GitHub would make deleting the content here more obviously desirable.","accounts_in_message":[],"_revision_number":2},{"id":"fed0aa6118675a5401733ffaf6c30f725b3a00f4","author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"date":"2019-07-06 18:33:40.000000000","message":"Patch Set 2:\n\nI thought a little bit about that in advance, in this case, we\u0027re actually specifically checking for openstack/\u003cfoo\u003e\n\nIf you move openstack/stevedore to dhellmann/stevedore on opendev, the entry for retirement will still be there, and ideally openstack/stevedore would include a commit with a README saying it\u0027s no longer maintained there?\n\nAs an example: https://opendev.org/openstack/gnocchi","accounts_in_message":[],"_revision_number":2},{"id":"f47245a2b5df1e9e9d7eb227a1235fff56695358","author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"date":"2019-07-08 05:43:39.000000000","message":"Patch Set 2: Code-Review-1\n\nThis check is too aggressive, it catches the cases that Doug mentions: A repo is moved out of governance but still maintained in OpenDev infrastructure. Some examples are fuel repos, networking repos, or api-site. Moving them out of governance is *not* retiring. The way the governance repo is set up, it handles both the same.\n\nSo, -1 on this change.\n\nYou could differentiate the two cases in legacy.yaml and add another flag and test for that one...","accounts_in_message":[],"_revision_number":2},{"id":"951a3caed111d00dd504dfcd3530427c344be20c","author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"date":"2019-07-08 16:36:15.000000000","message":"Patch Set 2:\n\nThis is pretty confusing, I always thought a retired project is a retired project, not one that left OpenStack.\n\nShould retired projects be renamed out of openstack/ ?","accounts_in_message":[],"_revision_number":2},{"id":"38636a4b9ead6dc54d0f780a19bbae506be65a6d","author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"date":"2019-07-08 16:37:57.000000000","message":"Patch Set 2:\n\nA retired project is retired ;) \n\nBut legacy.yaml lists not only retired repos but also repos that are moved out of governance.","accounts_in_message":[],"_revision_number":2},{"id":"f974b72ff5d2728578ff577422e0db876a3f9896","author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"date":"2019-07-08 16:38:49.000000000","message":"Patch Set 2:\n\nFirst lines of legacy.yaml:\n\n# List of projects that were previously official, and have been dropped from\n# the official list.  We track these temporarily to manage voter rolls.  When a\n# no-longer-official project has been delisted long enough that its\n# contributors are no longer eligible to vote, the associated entry should be\n# removed from this file.","accounts_in_message":[],"_revision_number":2},{"id":"2b4628e50cd7188b8130a9f68b603b0b59e2cb4c","author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"date":"2019-07-08 16:41:32.000000000","message":"Topic changed from ci/check-retired to code-change","accounts_in_message":[],"_revision_number":2},{"id":"829587a8f285fe8d8fabc50b1d13ce65bdab5aa7","author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"date":"2019-12-04 12:06:17.000000000","message":"Patch Set 2:\n\nI will leave this open, as I understand the context, and I like the concept.","accounts_in_message":[],"_revision_number":2},{"id":"7e8db0921bd88cb8e9ea401d3c3ac98952e1dc1f","author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"date":"2019-12-04 12:08:07.000000000","message":"Patch Set 2:\n\n\u003e I will leave this open, as I understand the context, and I like the\n \u003e concept.\n\nPosted too early... Here is what is missing:\n\n\"Howver, as I don\u0027t have time right now, I suggest to temporarily abandon it, and anyone with the time could re-open it.\"","accounts_in_message":[],"_revision_number":2},{"id":"d9a70a01245c6c026124bbfd7152fc7e493ab212","author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"date":"2019-12-04 12:08:10.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"33913d86c57e04a601ee92057b396ba954644eb3","revisions":{"727a6bd39009cc13861f4088a7d928068ab6ad2e":{"kind":"REWORK","_number":1,"created":"2019-07-06 17:36:03.000000000","uploader":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"ref":"refs/changes/49/669549/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/governance","ref":"refs/changes/49/669549/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/governance refs/changes/49/669549/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/governance refs/changes/49/669549/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/governance refs/changes/49/669549/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/governance refs/changes/49/669549/1"}}},"commit":{"parents":[{"commit":"8959064b711f670831929317057e7443098210ad","subject":"Merge \"Display table of TC Liasons and projects\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/governance/commit/8959064b711f670831929317057e7443098210ad"}]}],"author":{"name":"Mohammed Naser","email":"mnaser@vexxhost.com","date":"2019-07-06 17:35:08.000000000","tz":-240},"committer":{"name":"Mohammed Naser","email":"mnaser@vexxhost.com","date":"2019-07-06 17:36:02.000000000","tz":-240},"subject":"ci: check for proper retirement","message":"ci: check for proper retirement\n\nThis will check that a repository is properly retired by making\nsure that it only contains a README (and optionally a .gitreview\nfile).\n\nThis will make sure that we enforce the process we agreed to that\nwe won\u0027t retire a project until the code is officially gone.\n\nChange-Id: Ib5a5c48131603effeed4e967f4ff6057b73bc712\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/governance/commit/727a6bd39009cc13861f4088a7d928068ab6ad2e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/governance/commit/727a6bd39009cc13861f4088a7d928068ab6ad2e"}]},"branch":"refs/heads/master"},"33913d86c57e04a601ee92057b396ba954644eb3":{"kind":"REWORK","_number":2,"created":"2019-07-06 17:36:51.000000000","uploader":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"ref":"refs/changes/49/669549/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/governance","ref":"refs/changes/49/669549/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/governance refs/changes/49/669549/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/governance refs/changes/49/669549/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/governance refs/changes/49/669549/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/governance refs/changes/49/669549/2"}}},"commit":{"parents":[{"commit":"8959064b711f670831929317057e7443098210ad","subject":"Merge \"Display table of TC Liasons and projects\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/governance/commit/8959064b711f670831929317057e7443098210ad"}]}],"author":{"name":"Mohammed Naser","email":"mnaser@vexxhost.com","date":"2019-07-06 17:35:08.000000000","tz":-240},"committer":{"name":"Mohammed Naser","email":"mnaser@vexxhost.com","date":"2019-07-06 17:36:45.000000000","tz":-240},"subject":"ci: check for proper retirement","message":"ci: check for proper retirement\n\nThis will check that a repository is properly retired by making\nsure that it only contains a README (and optionally a .gitreview\nfile).\n\nThis will make sure that we enforce the process we agreed to that\nwe won\u0027t retire a project until the code is officially gone.\n\nChange-Id: Ib5a5c48131603effeed4e967f4ff6057b73bc712\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/governance/commit/33913d86c57e04a601ee92057b396ba954644eb3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/governance/commit/33913d86c57e04a601ee92057b396ba954644eb3"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}