)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"247093efc41cb2f87b7dc979d7ea4181fb6df3d7","unresolved":false,"context_lines":[{"line_number":13,"context_line":"ensure complete backwards compatibility [1]."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"As a provisioning and a lifecycle management"},{"line_number":16,"context_line":"service for file shares, manila does not place"},{"line_number":17,"context_line":"it self in the data path, thereby, any service"},{"line_number":18,"context_line":"plane changes occurring as a result of upgrade"},{"line_number":19,"context_line":"do not affect resources that it manages."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Manila already has the \"assert:supports-upgrade\""},{"line_number":22,"context_line":"tag. A grenade gate job runs on every change"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f560f44_c82ca449","line":19,"range":{"start_line":16,"start_character":25,"end_line":19,"end_character":40},"updated":"2020-07-27 15:27:57.000000000","message":"we should update this now as manila is testing the data path while upgrading now.","commit_id":"df45371dac629778e802296166309ef182be69fe"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"4eb27bb394bb0b3188e75b4bda96d574967d746a","unresolved":false,"context_lines":[{"line_number":13,"context_line":"ensure complete backwards compatibility [1]."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"As a provisioning and a lifecycle management"},{"line_number":16,"context_line":"service for file shares, manila does not place"},{"line_number":17,"context_line":"it self in the data path, thereby, any service"},{"line_number":18,"context_line":"plane changes occurring as a result of upgrade"},{"line_number":19,"context_line":"do not affect resources that it manages."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Manila already has the \"assert:supports-upgrade\""},{"line_number":22,"context_line":"tag. A grenade gate job runs on every change"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f560f44_a1134bb8","line":19,"range":{"start_line":16,"start_character":25,"end_line":19,"end_character":40},"in_reply_to":"9f560f44_06c20d86","updated":"2020-07-27 18:28:55.000000000","message":"yeah after re-reading I think 2nd paragraph clarifies the testing of this tag more clearly. I am good now. Thanks for covering the tests.","commit_id":"df45371dac629778e802296166309ef182be69fe"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3b73dba0d8d5b8879eb4a427477c9796aa75f95d","unresolved":false,"context_lines":[{"line_number":13,"context_line":"ensure complete backwards compatibility [1]."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"As a provisioning and a lifecycle management"},{"line_number":16,"context_line":"service for file shares, manila does not place"},{"line_number":17,"context_line":"it self in the data path, thereby, any service"},{"line_number":18,"context_line":"plane changes occurring as a result of upgrade"},{"line_number":19,"context_line":"do not affect resources that it manages."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Manila already has the \"assert:supports-upgrade\""},{"line_number":22,"context_line":"tag. A grenade gate job runs on every change"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f560f44_06c20d86","line":19,"range":{"start_line":16,"start_character":25,"end_line":19,"end_character":40},"in_reply_to":"9f560f44_c82ca449","updated":"2020-07-27 17:04:45.000000000","message":"The statement below covers that, \n\n\"A grenade gate job runs on every change\nsubmitted to the project and validates that\ncontrolled resources are not impacted by the\nupgrade process [2].\"\n\nPrior to https://review.opendev.org/742585/, this wasn\u0027t completely true, but now it is? WDYT?","commit_id":"df45371dac629778e802296166309ef182be69fe"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b412a68d2a90b49bad5d21f4061de90b8a74a41d","unresolved":false,"context_lines":[{"line_number":21,"context_line":"Manila already has the \"assert:supports-upgrade\""},{"line_number":22,"context_line":"tag. A grenade gate job runs on every change"},{"line_number":23,"context_line":"submitted to the project and validates that"},{"line_number":24,"context_line":"controlled resources are not impacted by the"},{"line_number":25,"context_line":"upgrade process [2]. The upgrade process is"},{"line_number":26,"context_line":"documented in the project\u0027s administration"},{"line_number":27,"context_line":"guide [3]"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bf51134e_680396bf","line":25,"range":{"start_line":24,"start_character":0,"end_line":25,"end_character":15},"updated":"2020-07-22 22:49:54.000000000","message":"manila grenade job does verify the resources in pre and post upgrade phase using verify() method[1] But I cannot see it verify the resources during the upgrade, verify_noapi() method does not verify anything[2]. verify_noapi is the phase when grenade stops all the services and checks if controlled resources are still accessible or not which is what tag \u0027 assert:supports-accessible-upgrade\u0027 is.\n\nFor example, nova ping the server during verify_noapi[3] and cinder checks if LVM volume exists and right file content[4].\n\n[1] https://github.com/openstack/manila/blob/c94e1deff1bde93d4167ceeb9dafc494d12cd60c/devstack/upgrade/resources.sh#L447\n\n[2] https://github.com/openstack/manila/blob/c94e1deff1bde93d4167ceeb9dafc494d12cd60c/devstack/upgrade/resources.sh#L465\n\n[3] https://github.com/openstack/grenade/blob/edb6ddc2db1cf93211bd43a68097a47c5b455582/projects/60_nova/resources.sh#L194\n\n[4] https://github.com/openstack/grenade/blob/edb6ddc2db1cf93211bd43a68097a47c5b455582/projects/70_cinder/resources.sh#L237","commit_id":"df45371dac629778e802296166309ef182be69fe"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"889b70952a6d83fda5e264abca3e8a107560d041","unresolved":false,"context_lines":[{"line_number":21,"context_line":"Manila already has the \"assert:supports-upgrade\""},{"line_number":22,"context_line":"tag. A grenade gate job runs on every change"},{"line_number":23,"context_line":"submitted to the project and validates that"},{"line_number":24,"context_line":"controlled resources are not impacted by the"},{"line_number":25,"context_line":"upgrade process [2]. The upgrade process is"},{"line_number":26,"context_line":"documented in the project\u0027s administration"},{"line_number":27,"context_line":"guide [3]"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bf51134e_e28dec2a","line":25,"range":{"start_line":24,"start_character":0,"end_line":25,"end_character":15},"in_reply_to":"bf51134e_680396bf","updated":"2020-07-23 21:43:24.000000000","message":"Thanks for noticing and for adding the helpful links, Ghanshyam. I added a data path test now: https://review.opendev.org/742585/","commit_id":"df45371dac629778e802296166309ef182be69fe"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"247093efc41cb2f87b7dc979d7ea4181fb6df3d7","unresolved":false,"context_lines":[{"line_number":21,"context_line":"Manila already has the \"assert:supports-upgrade\""},{"line_number":22,"context_line":"tag. A grenade gate job runs on every change"},{"line_number":23,"context_line":"submitted to the project and validates that"},{"line_number":24,"context_line":"controlled resources are not impacted by the"},{"line_number":25,"context_line":"upgrade process [2]. The upgrade process is"},{"line_number":26,"context_line":"documented in the project\u0027s administration"},{"line_number":27,"context_line":"guide [3]"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f560f44_a82df047","line":25,"range":{"start_line":24,"start_character":0,"end_line":25,"end_character":15},"in_reply_to":"bf51134e_e28dec2a","updated":"2020-07-27 15:27:57.000000000","message":"thanks Goutham.","commit_id":"df45371dac629778e802296166309ef182be69fe"}]}