)]}'
{"tools/check_review_status.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"027340982e28564962d75f561811b1ff081a1d9b","unresolved":false,"context_lines":[{"line_number":145,"context_line":"    for label in [\u0027Code-Review\u0027, \u0027Rollcall-Vote\u0027]:"},{"line_number":146,"context_line":"        for vote in review[\u0027labels\u0027].get(label, {}).get(\u0027all\u0027, []):"},{"line_number":147,"context_line":"            voter \u003d vote.get(\u0027name\u0027, \u0027\u0027)"},{"line_number":148,"context_line":"            if voter.startswith(name):"},{"line_number":149,"context_line":"                yield vote"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_4b723c7e","line":148,"range":{"start_line":148,"start_character":32,"end_line":148,"end_character":36},"updated":"2020-08-13 23:24:05.000000000","message":"I did not get what cases it solve and can this give false info? For example if \u0027name\u0027 in hard-coded (or lease PTL in project.yaml) list is \u0027Tony\u0027 then anyone with first name \u0027Tony\u0027 in gerrit vote matches.","commit_id":"6b2e491df60cf6f5f86e17a7d7c550e767ef2dbe"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"d066057ba1da5ab0b59cbc504e75fd69c02df3f7","unresolved":false,"context_lines":[{"line_number":145,"context_line":"    for label in [\u0027Code-Review\u0027, \u0027Rollcall-Vote\u0027]:"},{"line_number":146,"context_line":"        for vote in review[\u0027labels\u0027].get(label, {}).get(\u0027all\u0027, []):"},{"line_number":147,"context_line":"            voter \u003d vote.get(\u0027name\u0027, \u0027\u0027)"},{"line_number":148,"context_line":"            if voter.startswith(name):"},{"line_number":149,"context_line":"                yield vote"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_66bbf70d","line":148,"updated":"2020-08-14 01:05:00.000000000","message":"If I\u0027m listed as \"Jeremy Stanley\" but set my Gerrit display name to \"Jeremy Stanley (fungi)\" it will still match. I have to assume we wouldn\u0027t list people as just \"Tony\" but you\u0027re right there\u0027s the slight chance that one person\u0027s display name could be an initial subset of someone else\u0027s. It would also be possible for one person to intentionally set their name to a superset of another and then trigger this with a vote, but the odds of that going unnoticed are relatively slim and also there\u0027s nothing stopping someone from triggering this today by simply having the same display name as the person recorded in the list. Gerrit doesn\u0027t require these to be unique. If we want that, we should match on E-mail address or Gerrit account number.","commit_id":"6b2e491df60cf6f5f86e17a7d7c550e767ef2dbe"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"86693763506ce2d6d30c757380b4c1fd4d4afb34","unresolved":false,"context_lines":[{"line_number":145,"context_line":"    for label in [\u0027Code-Review\u0027, \u0027Rollcall-Vote\u0027]:"},{"line_number":146,"context_line":"        for vote in review[\u0027labels\u0027].get(label, {}).get(\u0027all\u0027, []):"},{"line_number":147,"context_line":"            voter \u003d vote.get(\u0027name\u0027, \u0027\u0027)"},{"line_number":148,"context_line":"            if voter.startswith(name):"},{"line_number":149,"context_line":"                yield vote"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_c64ac381","line":148,"in_reply_to":"9f560f44_66bbf70d","updated":"2020-08-14 02:09:54.000000000","message":"Yeah, now the chance is little more for false matching. \nI think email matching is a good way and we do not have only 3 delegates tag so it is not a huge list.","commit_id":"6b2e491df60cf6f5f86e17a7d7c550e767ef2dbe"}]}