)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"0e8ab0b7913c554a6dc39be1755576ab1f78eade","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"69e3bd8f_8e564afd","updated":"2023-03-17 14:03:06.000000000","message":"Response inline.","commit_id":"e44ce1f3a93b65a06f8883149a27871f556d393a"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"f78f1cbb5b9978ededc06b92cbcec454b7dc9a28","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2b6e84bb_ddb17b33","updated":"2023-03-15 21:07:42.000000000","message":"See comment inline.","commit_id":"e44ce1f3a93b65a06f8883149a27871f556d393a"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"aad19811a2404ffa3bdbd12ba5ebf9ee4755a428","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6439cd9f_b5937df8","updated":"2023-03-15 21:08:32.000000000","message":"Sorry about that ... hit the wrong button.","commit_id":"e44ce1f3a93b65a06f8883149a27871f556d393a"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"72ff86f30a86c6de6b4ca25f64f794000febf676","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"43dfde8e_d97c0b53","updated":"2023-04-18 20:56:56.000000000","message":"Thanks, Ghanshyam.  LGTM.","commit_id":"77c310c024823a77862c1771937c2f24514d0567"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"44b8d4c3d40e0ec06a51ffca74143a7e974290cd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d5c405d8_8b953c79","updated":"2023-04-18 21:39:17.000000000","message":"holding it as it will cause PTL appointment in progress changes to be updated which are more important to merge ASAP.","commit_id":"77c310c024823a77862c1771937c2f24514d0567"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"53df23b4d9630ae3cbb0027b65d65af72299c4bf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e254b5cb_953e0e82","in_reply_to":"d5c405d8_8b953c79","updated":"2023-04-20 19:13:12.000000000","message":"current PTL appointment patch for swift was merged and remaining two anyways need to add release version so it can be merged and will not cause them any mergable patch to fail.","commit_id":"77c310c024823a77862c1771937c2f24514d0567"},{"author":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"change_message_id":"ba935b78c606bf1e8fbdbb78511a44bd3038585a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"df52465c_71550ec7","updated":"2023-04-22 11:51:53.000000000","message":"Approving as code change, 2 +2s. Thank Ghanshyam.","commit_id":"417267d550a875fa3c2f7726b916c05458afb756"}],"openstack_governance/projects_schema.yaml":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"f78f1cbb5b9978ededc06b92cbcec454b7dc9a28","unresolved":true,"context_lines":[{"line_number":111,"context_line":"              - deprecated"},{"line_number":112,"context_line":"              - external"},{"line_number":113,"context_line":"          deprecated:"},{"line_number":114,"context_line":"            type: [\"string\", \"number\"]"},{"line_number":115,"context_line":"    extra-atcs:"},{"line_number":116,"context_line":"      type: \"array\""},{"line_number":117,"context_line":"      items:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"8168e021_30431eb3","line":114,"range":{"start_line":114,"start_character":29,"end_line":114,"end_character":37},"updated":"2023-03-15 21:07:42.000000000","message":"I\u0027m not convinced this is correct semantically.  \u00272023.1\u0027 is not a number, it\u0027s a name (a string) all of whose non-period characters are numeric.  The \u00271\u0027 after the period refers to the first development cycle in 2023, not one-tenth.  I think we should be enforcing a string type here.","commit_id":"e44ce1f3a93b65a06f8883149a27871f556d393a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d1eb10c5fd7eb4c6ee977019267789e3c5b7a7f8","unresolved":true,"context_lines":[{"line_number":111,"context_line":"              - deprecated"},{"line_number":112,"context_line":"              - external"},{"line_number":113,"context_line":"          deprecated:"},{"line_number":114,"context_line":"            type: [\"string\", \"number\"]"},{"line_number":115,"context_line":"    extra-atcs:"},{"line_number":116,"context_line":"      type: \"array\""},{"line_number":117,"context_line":"      items:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"c937adbf_0d634252","line":114,"range":{"start_line":114,"start_character":29,"end_line":114,"end_character":37},"in_reply_to":"0f4ef42c_4b8e7d5c","updated":"2023-04-03 21:47:51.000000000","message":"As PEP440  stats (what Dmitriy mentioned in earlier review), https://peps.python.org/pep-0440/#public-version-identifiers these needs to be treated as number and if we see our release schema it is \u003cyear\u003e.1 and \u003cyear\u003e.2 so we can compare them also.\n\nI do not agree that we need to treat it as string.\n\nI find it treated as numeric in release tooling also, exaple https://github.com/openstack/releases/blob/00deff90c0c0fda03101853753d314b07d5229da/openstack_releases/series_status_schema.yaml#L19","commit_id":"e44ce1f3a93b65a06f8883149a27871f556d393a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"fab467a8c635aae8c50f80eb0b40857c11bb5f72","unresolved":true,"context_lines":[{"line_number":111,"context_line":"              - deprecated"},{"line_number":112,"context_line":"              - external"},{"line_number":113,"context_line":"          deprecated:"},{"line_number":114,"context_line":"            type: [\"string\", \"number\"]"},{"line_number":115,"context_line":"    extra-atcs:"},{"line_number":116,"context_line":"      type: \"array\""},{"line_number":117,"context_line":"      items:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"a40ba5b8_21fa9847","line":114,"range":{"start_line":114,"start_character":29,"end_line":114,"end_character":37},"in_reply_to":"26b27c19_4310c15f","updated":"2023-04-18 20:04:18.000000000","message":"as discussed in IRC meeting, I agree to add it as string, done\n\nhttps://meetings.opendev.org/meetings/tc/2023/tc.2023-04-18-18.00.log.html#l-99","commit_id":"e44ce1f3a93b65a06f8883149a27871f556d393a"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"c67248c2241d4165d0d6230ff018a69a59e7ee40","unresolved":true,"context_lines":[{"line_number":111,"context_line":"              - deprecated"},{"line_number":112,"context_line":"              - external"},{"line_number":113,"context_line":"          deprecated:"},{"line_number":114,"context_line":"            type: [\"string\", \"number\"]"},{"line_number":115,"context_line":"    extra-atcs:"},{"line_number":116,"context_line":"      type: \"array\""},{"line_number":117,"context_line":"      items:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"26b27c19_4310c15f","line":114,"range":{"start_line":114,"start_character":29,"end_line":114,"end_character":37},"in_reply_to":"28b9c60b_4038f3c6","updated":"2023-04-18 18:37:28.000000000","message":"Agree, this should only be a string.\n```\n\u003e\u003e\u003e int(\u002724.0.1\u0027)\nTraceback (most recent call last):\n  File \"\u003cstdin\u003e\", line 1, in \u003cmodule\u003e\nValueError: invalid literal for int() with base 10: \u002724.0.1\u0027\n\n\u003e\u003e\u003e float(\u002724.0.1\u0027)\nTraceback (most recent call last):\n  File \"\u003cstdin\u003e\", line 1, in \u003cmodule\u003e\nValueError: could not convert string to float: \u002724.0.1\u0027\n```","commit_id":"e44ce1f3a93b65a06f8883149a27871f556d393a"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"0e8ab0b7913c554a6dc39be1755576ab1f78eade","unresolved":true,"context_lines":[{"line_number":111,"context_line":"              - deprecated"},{"line_number":112,"context_line":"              - external"},{"line_number":113,"context_line":"          deprecated:"},{"line_number":114,"context_line":"            type: [\"string\", \"number\"]"},{"line_number":115,"context_line":"    extra-atcs:"},{"line_number":116,"context_line":"      type: \"array\""},{"line_number":117,"context_line":"      items:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"0f4ef42c_4b8e7d5c","line":114,"range":{"start_line":114,"start_character":29,"end_line":114,"end_character":37},"in_reply_to":"7bd07db5_3fa043cf","updated":"2023-03-17 14:03:06.000000000","message":"You remind me that I objected to this when the \u0027appointed\u0027 field was changed!\nhttps://review.opendev.org/c/openstack/governance/+/858967/2/openstack_governance/projects_schema.yaml#63\n\nBut I let it slide because that patch also concerned appointing the Adjutant PTL.\n\nMy opinion is that this is incorrect, and it only works because we\u0027re lucky.  If you really treat this like a number, and we were doing \u003cyear\u003e.\u003cmonth\u003e (which is allowed by PEP 440), 2023.3 \u003e 2023.10 when they\u0027re treated as JSON numbers, even though March is before October.  But the \"version number\" is not a number!","commit_id":"e44ce1f3a93b65a06f8883149a27871f556d393a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9459eb279108173630477d5bdbf1e561d17ab1ef","unresolved":true,"context_lines":[{"line_number":111,"context_line":"              - deprecated"},{"line_number":112,"context_line":"              - external"},{"line_number":113,"context_line":"          deprecated:"},{"line_number":114,"context_line":"            type: [\"string\", \"number\"]"},{"line_number":115,"context_line":"    extra-atcs:"},{"line_number":116,"context_line":"      type: \"array\""},{"line_number":117,"context_line":"      items:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7bd07db5_3fa043cf","line":114,"range":{"start_line":114,"start_character":29,"end_line":114,"end_character":37},"in_reply_to":"8168e021_30431eb3","updated":"2023-03-16 23:36:33.000000000","message":"Well, I am using it like\n      deprecated: 2023.1\n- https://review.opendev.org/c/openstack/governance/+/877132/2/reference/projects.yaml#2767\n\nso 2023.1 is vesion number, we should not use it as string \u00272023.1\u0027. it is same like we have/use in \n\n\u0027appointed\u0027 field - L60 schema\n- https://review.opendev.org/c/openstack/governance/+/877132/2/reference/projects.yaml#2505","commit_id":"e44ce1f3a93b65a06f8883149a27871f556d393a"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"da4fefdaff041ed732bf45261eaccb6ae21b5dd2","unresolved":true,"context_lines":[{"line_number":111,"context_line":"              - deprecated"},{"line_number":112,"context_line":"              - external"},{"line_number":113,"context_line":"          deprecated:"},{"line_number":114,"context_line":"            type: [\"string\", \"number\"]"},{"line_number":115,"context_line":"    extra-atcs:"},{"line_number":116,"context_line":"      type: \"array\""},{"line_number":117,"context_line":"      items:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"28b9c60b_4038f3c6","line":114,"range":{"start_line":114,"start_character":29,"end_line":114,"end_character":37},"in_reply_to":"c937adbf_0d634252","updated":"2023-04-18 18:30:18.000000000","message":"Version numbers are not decimal.\n\n2023.1 is not \"2023 plus one tenth\"\n2023.1.2 isn\u0027t a python-number at all.\n\nTreating these as numbers will potentially be painful.\n\nThis all being said; I don\u0027t see this as an extremely valuable thing to spend much time arguing about.","commit_id":"e44ce1f3a93b65a06f8883149a27871f556d393a"}]}