)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"410c2ddcc74606549a73409958efe424bf39e7f3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4503a650_5244c137","updated":"2025-05-21 00:55:23.000000000","message":"-1 because of the tiem line\n\ni was aware of the  old resoltion https://review.opendev.org/c/openstack/governance/+/120260\n\nbtu rasing this now and proposing ti implement it in such a short time seam overly rushed.","commit_id":"8a510a29ac386ca900ba249f19024137c69f361d"},{"author":{"_account_id":113,"name":"Jonathan Bryce","email":"jbryce@jbryce.com","username":"jbryce"},"change_message_id":"d51006da63f2ac3d479a80dd6d47b2a85c7c9826","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"09c3f10e_16c91045","updated":"2025-05-21 16:17:00.000000000","message":"After getting some initial feedback from legal and a further chat in IRC, I\u0027m going to check on the viability from a legal standpoint of doing the cutover July 1. This would mean that the last contributions accepted under the CLA checks would be on 2025-06-30 and all contributions after 2025-07-01 00:00:00UTC would require a DCO check.\n\nAs mentioned in the TC chat, this aligns well with the end of the M-2 milestone on 2025-07-03.","commit_id":"8a510a29ac386ca900ba249f19024137c69f361d"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"19fb76427d8164712516d67d7808c9f8d92f3f23","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5a3f1143_e6b2d2ab","updated":"2025-05-21 07:52:03.000000000","message":"Very strong concerns by the very aggressive deadline we have. I\u0027d rather prefer if we could have an interim period that would allow some smoother transition post June 1 (ideally the existing CLA to be carrying over the contributions to the new entity).","commit_id":"8a510a29ac386ca900ba249f19024137c69f361d"},{"author":{"_account_id":113,"name":"Jonathan Bryce","email":"jbryce@jbryce.com","username":"jbryce"},"change_message_id":"a4617d3455a3118afcf16cdcec59040f4dd742c1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3e9b039c_1ec704d6","in_reply_to":"09c3f10e_16c91045","updated":"2025-05-22 00:42:24.000000000","message":"I have gotten positive feedback from the legal team on this approach.","commit_id":"8a510a29ac386ca900ba249f19024137c69f361d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fca1309e834f21b4e1f24adc1ace69a24387c666","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8b5433fd_546ee829","in_reply_to":"09c3f10e_16c91045","updated":"2025-05-21 18:02:44.000000000","message":"Thanks; i\u0027ll update the resolution with this information. Please let us know if any changes are necessary.","commit_id":"8a510a29ac386ca900ba249f19024137c69f361d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"373f0d010cb98e170903f5459f69421bab6a39ea","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e4946521_2208808d","in_reply_to":"3e9b039c_1ec704d6","updated":"2025-05-22 06:18:48.000000000","message":"i guess if we cant wait till after rc1 then doing thsi at m2 is better then m3.","commit_id":"8a510a29ac386ca900ba249f19024137c69f361d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bc538b4cbc7f14823ddf06de5c0b3f9bfcb62acc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a90a7419_9bda452a","in_reply_to":"8b5433fd_546ee829","updated":"2025-05-21 18:37:15.000000000","message":"Done","commit_id":"8a510a29ac386ca900ba249f19024137c69f361d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bc538b4cbc7f14823ddf06de5c0b3f9bfcb62acc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e60a2fb8_e2145313","updated":"2025-05-21 18:37:15.000000000","message":"Enforcement date has been updated; please re-review.. but be aware that the date and the plan could change if the Foundation legal team seeks changes to this plan. We\u0027ll merge this proposal only after we get the requisite TC majority for formal-votes, and with the legal sign off from the Foundation Legal team.","commit_id":"40fb2ae81cfd946aaad2932c637a13d22389ea4c"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"eb5295ecac3622b901c55ea6d865f55f1024fe4e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6055c992_49770856","updated":"2025-05-22 09:01:57.000000000","message":"I\u0027m maybe pedantic (as I already said) but I think we still need to explain what our contributors need to do quickly by this resolution.\n\nFor sure, we\u0027ll have more examples and more explanations in other docs (at least the contributors guide) but I want it clear now (also given people will *need* to set manually the labels if they use the Gerrit UI)","commit_id":"40fb2ae81cfd946aaad2932c637a13d22389ea4c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"224c618c376664e4a876b90fb8cd389026c6c0d6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"54974a0a_d46c7fd8","updated":"2025-06-04 05:46:33.000000000","message":"Merging this since it has picked up sufficient votes from the TC and community members.","commit_id":"40fb2ae81cfd946aaad2932c637a13d22389ea4c"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"537c4c23321a32257ee707c56a6be8a185fa6598","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"22be9859_6ed3202b","updated":"2025-06-04 07:22:50.000000000","message":"Very late r-v approval but I wanted to tell I\u0027m eventually fine :-) \n\nThanks Goutham for the summary.","commit_id":"40fb2ae81cfd946aaad2932c637a13d22389ea4c"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"06c4cc6ce078f455ade3838981e40373fe88c0ce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"15c95616_f3eb2069","updated":"2025-06-03 17:37:33.000000000","message":"removing my -1 given the consensus now seems to be about the document we need, so I no longer have concerns AFAICS, but I need a summary given we have a lot of discussions here before +1. \n\nThanks.","commit_id":"40fb2ae81cfd946aaad2932c637a13d22389ea4c"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"319b2c180002219d9ca2bd2f7e177c27eb9f82fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"afb71010_d82532cd","updated":"2025-05-22 01:29:01.000000000","message":"this version lgtm, thanks Goutham for being proactive on this, you deserve a beer :)","commit_id":"40fb2ae81cfd946aaad2932c637a13d22389ea4c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8248bd45a3da27de10451ada70e817d97b989bd6","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d6028cd7_5b0a9044","in_reply_to":"15c95616_f3eb2069","updated":"2025-06-03 21:42:38.000000000","message":"Thanks for asking for this Sylvain... \n\nOIF\u0027s move under the LF is now complete: https://openinfra.org/blog/openinfra-joins-linux-foundation\n\nHere\u0027s the plan of record:\n\n1) This TC resolution acts as a precursor for community-wide effort to enforce the DCO. \n2) We\u0027ve informally begun asking contributors to include the DCO sign off. We\u0027ve asked PTLs/liaisons/cores to gently nudge people to do this.. over code reviews and IRC meetings etc\n3) Changes to the OpenStack Contributor Guide have been proposed, all other documentation mentions of the CLA have to similarly be updated - we\u0027ll get to this over the next few weeks\n4) Changes to bot tooling are underway - i.e., all bot proposed changes will begin including a \"signed-off-by\" line. We\u0027re having a productive discussion on this in the respective changes: https://review.opendev.org/q/hashtag:dco-signed-off-by\n4) We\u0027ll need to hash out the plan for translation contributors; per today\u0027s meeting, that will be done in a separate resolution\n5) We are expecting problems on the enforcement date, and will adjust to these concerns slowly as a community","commit_id":"40fb2ae81cfd946aaad2932c637a13d22389ea4c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bbf99bdf5eb88b4a214b4e6cb86ea5247905e860","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e288de3e_07130e95","in_reply_to":"6055c992_49770856","updated":"2025-05-27 23:06:02.000000000","message":"I am unsure what part is unclear, or deficient? Do you want to take a stab at suggesting edits?","commit_id":"40fb2ae81cfd946aaad2932c637a13d22389ea4c"}],"resolutions/20250520-replace-the-cla-with-dco-for-all-contributions.rst":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"da6bec08c8b4ce6a849bea01278885abbdb6ed9b","unresolved":true,"context_lines":[{"line_number":28,"context_line":"- Replace the Contributor License Agreement (CLA) with the Developer"},{"line_number":29,"context_line":"  Certificate of Origin (DCO) as the core legal framework for contributions to"},{"line_number":30,"context_line":"  OpenStack projects."},{"line_number":31,"context_line":"- Set the transition effective date to **June 1, 2025**. From that"},{"line_number":32,"context_line":"  date, all commits to OpenStack repositories must include a valid"},{"line_number":33,"context_line":"  `Signed-off-by` line in the commit message as stated in the DCO."},{"line_number":34,"context_line":"- Direct the OpenDev Infrastructure team to enforce DCO compliance on the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"643eb9e6_2699125f","line":31,"updated":"2025-05-20 22:03:13.000000000","message":"During TC meeting and after we talked this to death, so not trying to rehash the discussion, just want to document it for Gerrit.\n\nThis is at best a 10 day notice; at time of merge it will be a 3 day notice. I believe this may pose a barrier to contributors who might need to work with legal or ospo teams inside their organization to revise contribution policies internally. Ideally we\u0027d give a month notice, minimum, or have an overlap period.","commit_id":"8a510a29ac386ca900ba249f19024137c69f361d"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"a87751579cfb6f7a5d1fd7be6c68730610146642","unresolved":true,"context_lines":[{"line_number":28,"context_line":"- Replace the Contributor License Agreement (CLA) with the Developer"},{"line_number":29,"context_line":"  Certificate of Origin (DCO) as the core legal framework for contributions to"},{"line_number":30,"context_line":"  OpenStack projects."},{"line_number":31,"context_line":"- Set the transition effective date to **June 1, 2025**. From that"},{"line_number":32,"context_line":"  date, all commits to OpenStack repositories must include a valid"},{"line_number":33,"context_line":"  `Signed-off-by` line in the commit message as stated in the DCO."},{"line_number":34,"context_line":"- Direct the OpenDev Infrastructure team to enforce DCO compliance on the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7f755bd3_a734a19e","line":31,"in_reply_to":"07526ab0_b9de8b1e","updated":"2025-05-21 14:50:56.000000000","message":"\u003e by the way wether the icla or ccla is corrently configureabl per repo.\n\u003e and we will have to update that for all the relevent repos in the project-config repo. and update the project creation guide ectra.\n\nWhile it *can* be configured per-repo, we presently do it in one ACL which is inherited by all other OpenStack projects ACLs, so would only need to update that: \nhttps://opendev.org/openstack/project-config/src/commit/3677117/gerrit/acls/openstack/meta-config.config#L22\n\n\u003e i dont have any objection to startign to accpt patches based on DCO from june 1st but i dont think we shoudl start rejecting them during 2025.2\n\nWe already do accept packages with a Signed-Off-By footer in their commit messages (except insofar as Jay mentioned having seen reviewers vote -1 in the past on some changes for it, but that probably hasn\u0027t happened in quite a while now). Therefore the transition can start any time with no changes needed in Gerrit, just be aware that it can\u0027t be configured to accept *either* DCO *or* CLA simultaneously, if you have both enforcement options turned on then both will be required to accept any future git push.","commit_id":"8a510a29ac386ca900ba249f19024137c69f361d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9342d766dc1dbc63f817e56ebb17d289326f6740","unresolved":true,"context_lines":[{"line_number":28,"context_line":"- Replace the Contributor License Agreement (CLA) with the Developer"},{"line_number":29,"context_line":"  Certificate of Origin (DCO) as the core legal framework for contributions to"},{"line_number":30,"context_line":"  OpenStack projects."},{"line_number":31,"context_line":"- Set the transition effective date to **June 1, 2025**. From that"},{"line_number":32,"context_line":"  date, all commits to OpenStack repositories must include a valid"},{"line_number":33,"context_line":"  `Signed-off-by` line in the commit message as stated in the DCO."},{"line_number":34,"context_line":"- Direct the OpenDev Infrastructure team to enforce DCO compliance on the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"c3781417_eb13d3c1","line":31,"in_reply_to":"643eb9e6_2699125f","updated":"2025-05-20 22:46:27.000000000","message":"+1 thanks for sharing that note here.. this proposal is a starting point for us to discuss and converge on a date","commit_id":"8a510a29ac386ca900ba249f19024137c69f361d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9abdb186c2dbb0ae51140620469702af56f1a132","unresolved":true,"context_lines":[{"line_number":28,"context_line":"- Replace the Contributor License Agreement (CLA) with the Developer"},{"line_number":29,"context_line":"  Certificate of Origin (DCO) as the core legal framework for contributions to"},{"line_number":30,"context_line":"  OpenStack projects."},{"line_number":31,"context_line":"- Set the transition effective date to **June 1, 2025**. From that"},{"line_number":32,"context_line":"  date, all commits to OpenStack repositories must include a valid"},{"line_number":33,"context_line":"  `Signed-off-by` line in the commit message as stated in the DCO."},{"line_number":34,"context_line":"- Direct the OpenDev Infrastructure team to enforce DCO compliance on the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"74fcc2be_c5b7edfa","line":31,"in_reply_to":"6c36d97e_596e4222","updated":"2025-05-21 01:00:15.000000000","message":"by the way wether the icla or ccla is corrently configureabl per repo.\n\nand we will have to update that for all the relevent repos in the project-config repo. and update the project creation guide ectra.\n\n\ni dont have any objection to startign to accpt patches based on DCO from june 1st but i dont think we shoudl start rejecting them during 2025.2\n\nwe shoudl use that tiem as a transtion period and allow both.","commit_id":"8a510a29ac386ca900ba249f19024137c69f361d"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"19fb76427d8164712516d67d7808c9f8d92f3f23","unresolved":true,"context_lines":[{"line_number":28,"context_line":"- Replace the Contributor License Agreement (CLA) with the Developer"},{"line_number":29,"context_line":"  Certificate of Origin (DCO) as the core legal framework for contributions to"},{"line_number":30,"context_line":"  OpenStack projects."},{"line_number":31,"context_line":"- Set the transition effective date to **June 1, 2025**. From that"},{"line_number":32,"context_line":"  date, all commits to OpenStack repositories must include a valid"},{"line_number":33,"context_line":"  `Signed-off-by` line in the commit message as stated in the DCO."},{"line_number":34,"context_line":"- Direct the OpenDev Infrastructure team to enforce DCO compliance on the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"07526ab0_b9de8b1e","line":31,"in_reply_to":"74fcc2be_c5b7edfa","updated":"2025-05-21 07:52:03.000000000","message":"As stated, we have two concerns, let me summarize it as only one is mentioned : \n* we have an technical onboarding concern about contributors unable to upload patches post June 1 if they don\u0027t sign-off the DCO. This requires a substantial amount of communication thru different mediums (necessarly not only the ML) and ideally kept visible for a long time to prevent on-off contributors who rarely upload patches to be blocked quite later after the switch.\n* we also have a legal concern about the employers of our contributors that would require a substantial amount of time for ensuring that the OpenStack DCO is basically as acceptable as the Linux Kernel DCO is (even if we all know that the DCO is the same)","commit_id":"8a510a29ac386ca900ba249f19024137c69f361d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c8fabafda70f2b286ed8c935c64f87f663621697","unresolved":false,"context_lines":[{"line_number":28,"context_line":"- Replace the Contributor License Agreement (CLA) with the Developer"},{"line_number":29,"context_line":"  Certificate of Origin (DCO) as the core legal framework for contributions to"},{"line_number":30,"context_line":"  OpenStack projects."},{"line_number":31,"context_line":"- Set the transition effective date to **June 1, 2025**. From that"},{"line_number":32,"context_line":"  date, all commits to OpenStack repositories must include a valid"},{"line_number":33,"context_line":"  `Signed-off-by` line in the commit message as stated in the DCO."},{"line_number":34,"context_line":"- Direct the OpenDev Infrastructure team to enforce DCO compliance on the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"c242f957_c0160bb4","line":31,"in_reply_to":"7f755bd3_a734a19e","updated":"2025-05-21 18:35:44.000000000","message":"I\u0027m resolving this thread as having been discussed here, and on the #openstack-tc channel on 05-20-2025: https://meetings.opendev.org/irclogs/%23openstack-tc/%23openstack-tc.2025-05-21.log.html#openstack-tc.2025-05-21.log.html#t2025-05-21T16:01:20\n\nWill be updating this to July 1st 2025, in the week of Flamingo M-2; we\u0027ll need the Foundation legal team to sign off on the date or suggest a different date or plan in case we can\u0027t keep that date.\n\n\n\u003e Therefore the transition can start any time with no changes needed in Gerrit, just be aware that it can\u0027t be configured to accept either DCO or CLA simultaneously, if you have both enforcement options turned on then both will be required to accept any future git push.\n\n\nThe resolution requires gerrit enforcement because we can\u0027t be in soft-compliance of the stated goal. We could encourage folks to begin DCO compliance right away though, and not wait until the enforcement date","commit_id":"8a510a29ac386ca900ba249f19024137c69f361d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"410c2ddcc74606549a73409958efe424bf39e7f3","unresolved":true,"context_lines":[{"line_number":28,"context_line":"- Replace the Contributor License Agreement (CLA) with the Developer"},{"line_number":29,"context_line":"  Certificate of Origin (DCO) as the core legal framework for contributions to"},{"line_number":30,"context_line":"  OpenStack projects."},{"line_number":31,"context_line":"- Set the transition effective date to **June 1, 2025**. From that"},{"line_number":32,"context_line":"  date, all commits to OpenStack repositories must include a valid"},{"line_number":33,"context_line":"  `Signed-off-by` line in the commit message as stated in the DCO."},{"line_number":34,"context_line":"- Direct the OpenDev Infrastructure team to enforce DCO compliance on the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"6c36d97e_596e4222","line":31,"in_reply_to":"c3781417_eb13d3c1","updated":"2025-05-21 00:55:23.000000000","message":"honestly i dotn think we shoudl make a hard swich during the current cycle\n\nwe shoudl aim to do it at the start of the 2026.1 cycle to give everyone time to update tooling and comunicate this to new and old contibutors alike.","commit_id":"8a510a29ac386ca900ba249f19024137c69f361d"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"19fb76427d8164712516d67d7808c9f8d92f3f23","unresolved":true,"context_lines":[{"line_number":30,"context_line":"  OpenStack projects."},{"line_number":31,"context_line":"- Set the transition effective date to **June 1, 2025**. From that"},{"line_number":32,"context_line":"  date, all commits to OpenStack repositories must include a valid"},{"line_number":33,"context_line":"  `Signed-off-by` line in the commit message as stated in the DCO."},{"line_number":34,"context_line":"- Direct the OpenDev Infrastructure team to enforce DCO compliance on the"},{"line_number":35,"context_line":"  OpenStack `code review system`_, i.e., require a valid DCO sign-off for"},{"line_number":36,"context_line":"  all new commits."}],"source_content_type":"text/x-rst","patch_set":1,"id":"78f262f4_cb3b3167","line":33,"range":{"start_line":33,"start_character":2,"end_line":33,"end_character":66},"updated":"2025-05-21 07:52:03.000000000","message":"`Signed-Off-by: Name (email)` to be pedantic here (I guess the resolution would be the first document we would provide for our contributors) so let\u0027s be explicit here.","commit_id":"8a510a29ac386ca900ba249f19024137c69f361d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7657589b86d8d5d594aefbddc6ad8c641ac6c272","unresolved":false,"context_lines":[{"line_number":30,"context_line":"  OpenStack projects."},{"line_number":31,"context_line":"- Set the transition effective date to **June 1, 2025**. From that"},{"line_number":32,"context_line":"  date, all commits to OpenStack repositories must include a valid"},{"line_number":33,"context_line":"  `Signed-off-by` line in the commit message as stated in the DCO."},{"line_number":34,"context_line":"- Direct the OpenDev Infrastructure team to enforce DCO compliance on the"},{"line_number":35,"context_line":"  OpenStack `code review system`_, i.e., require a valid DCO sign-off for"},{"line_number":36,"context_line":"  all new commits."}],"source_content_type":"text/x-rst","patch_set":1,"id":"65512665_a3e32f89","line":33,"range":{"start_line":33,"start_character":2,"end_line":33,"end_character":66},"in_reply_to":"0591df4c_f72523a5","updated":"2025-05-21 15:55:36.000000000","message":"+1 I\u0027d leave these details to the Contributors\u0027 Guide","commit_id":"8a510a29ac386ca900ba249f19024137c69f361d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a8db883905bb6cdb469cb34497194018e216e3bf","unresolved":true,"context_lines":[{"line_number":30,"context_line":"  OpenStack projects."},{"line_number":31,"context_line":"- Set the transition effective date to **June 1, 2025**. From that"},{"line_number":32,"context_line":"  date, all commits to OpenStack repositories must include a valid"},{"line_number":33,"context_line":"  `Signed-off-by` line in the commit message as stated in the DCO."},{"line_number":34,"context_line":"- Direct the OpenDev Infrastructure team to enforce DCO compliance on the"},{"line_number":35,"context_line":"  OpenStack `code review system`_, i.e., require a valid DCO sign-off for"},{"line_number":36,"context_line":"  all new commits."}],"source_content_type":"text/x-rst","patch_set":1,"id":"abb4f307_4d0d4a38","line":33,"range":{"start_line":33,"start_character":2,"end_line":33,"end_character":66},"in_reply_to":"0add4afe_1be88c5f","updated":"2025-05-22 06:40:02.000000000","message":"wait when was git config --global format.signoff true updated\n\ni tought the same too orgianly hten i found \n\nhttps://stackoverflow.com/questions/15015894/git-add-signed-off-by-line-using-format-signoff-not-working\n\n\nso that only take effect when exportign a commit as a prtch i think i.e in an emial ro file not when you do git commit.\n\n\nhttps://git-scm.com/docs/git-config#Documentation/git-config.txt-formatsignOff\n\n     \nformat.signOff\n\n    A boolean value which lets you enable the -s/--signoff option of format-patch by default. Note: Adding the Signed-off-by trailer to a patch should be a conscious act and means that you certify you have the rights to submit this work under the same open source license. Please see the SubmittingPatches document for further discussion.\n\nyouc an autmaticly sign  with \nhttps://git-scm.com/docs/git-config#Documentation/git-config.txt-codecommitgpgSigncode\n\nor \n\nuse a non defautl git commit template with \n\nhttps://git-scm.com/docs/git-config#Documentation/git-config.txt-codecommittemplatecode\n\nand you can add the Signed-off-by line in yoru local template\n\nbut you cant just have git commit automaticlly add it today as far as im aware without a commit-message hook.\n\nthat why i was suggestign writing one to do just aht and addign it to the set we ship with hacking so that we can share the singel hook across all our repos.","commit_id":"8a510a29ac386ca900ba249f19024137c69f361d"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"51ed84afc78dbe79509497a4023ca043f8c05aff","unresolved":false,"context_lines":[{"line_number":30,"context_line":"  OpenStack projects."},{"line_number":31,"context_line":"- Set the transition effective date to **June 1, 2025**. From that"},{"line_number":32,"context_line":"  date, all commits to OpenStack repositories must include a valid"},{"line_number":33,"context_line":"  `Signed-off-by` line in the commit message as stated in the DCO."},{"line_number":34,"context_line":"- Direct the OpenDev Infrastructure team to enforce DCO compliance on the"},{"line_number":35,"context_line":"  OpenStack `code review system`_, i.e., require a valid DCO sign-off for"},{"line_number":36,"context_line":"  all new commits."}],"source_content_type":"text/x-rst","patch_set":1,"id":"9109d9b7_0af74a9c","line":33,"range":{"start_line":33,"start_character":2,"end_line":33,"end_character":66},"in_reply_to":"65512665_a3e32f89","updated":"2025-05-21 22:27:33.000000000","message":"Whoever does update the contributor guide:\n\ngit config --global format.signoff true\n\nCan be used in lieu of the command line switch.","commit_id":"8a510a29ac386ca900ba249f19024137c69f361d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"7034cad65d6b74733af0163b2e7d4749c27b4574","unresolved":true,"context_lines":[{"line_number":30,"context_line":"  OpenStack projects."},{"line_number":31,"context_line":"- Set the transition effective date to **June 1, 2025**. From that"},{"line_number":32,"context_line":"  date, all commits to OpenStack repositories must include a valid"},{"line_number":33,"context_line":"  `Signed-off-by` line in the commit message as stated in the DCO."},{"line_number":34,"context_line":"- Direct the OpenDev Infrastructure team to enforce DCO compliance on the"},{"line_number":35,"context_line":"  OpenStack `code review system`_, i.e., require a valid DCO sign-off for"},{"line_number":36,"context_line":"  all new commits."}],"source_content_type":"text/x-rst","patch_set":1,"id":"0591df4c_f72523a5","line":33,"range":{"start_line":33,"start_character":2,"end_line":33,"end_character":66},"in_reply_to":"78f262f4_cb3b3167","updated":"2025-05-21 09:13:38.000000000","message":"well its the thing that is generated when you do `git commit -s`\n\n```\n-s, --signoff, --no-signoff\n           Add a Signed-off-by trailer by the committer at the end of the commit log message. The meaning of a signoff depends on the project to which you’re committing. For example, it may certify that the committer has the rights to\n           submit the work under the project’s license or agrees to some contributor representation, such as a Developer Certificate of Origin. (See https://developercertificate.org for the one used by the Linux kernel and Git\n           projects.) Consult the documentation or leadership of the project to which you’re contributing to understand how the signoffs are used in that project.\n\n           The --no-signoff option can be used to countermand an earlier --signoff option on the command line.\n\n```\n\ni would not expect anyone to actully type it out.\n\n\nfor most i would expect that we will jsut update oru git configs to add that automaticlly.\n\nin the pass i have gone out of my way to never to use that.\n\nand to be extra pedantic its actully \n\n```\ncommit ad5ee6fd7cde631b93d61907fcca79bbf276a1f5 (HEAD -\u003e master)\nAuthor: Sean Mooney \u003cwork@seanmooney.info\u003e\nDate:   Wed May 21 10:04:31 2025 +0100\n\n    test\n    \n    Signed-off-by: Sean Mooney \u003cwork@seanmooney.info\u003e\n\n\n```\n\nthe current proposal has the correct casing `Signed-off-by`\nso its `Signed-off-by: name \u003cemail\u003e`\nthe name and email are in the same format as the author and committer fields.","commit_id":"8a510a29ac386ca900ba249f19024137c69f361d"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"a84d0894d5b573ea5f0c3d983ed08f9ddff99931","unresolved":false,"context_lines":[{"line_number":30,"context_line":"  OpenStack projects."},{"line_number":31,"context_line":"- Set the transition effective date to **June 1, 2025**. From that"},{"line_number":32,"context_line":"  date, all commits to OpenStack repositories must include a valid"},{"line_number":33,"context_line":"  `Signed-off-by` line in the commit message as stated in the DCO."},{"line_number":34,"context_line":"- Direct the OpenDev Infrastructure team to enforce DCO compliance on the"},{"line_number":35,"context_line":"  OpenStack `code review system`_, i.e., require a valid DCO sign-off for"},{"line_number":36,"context_line":"  all new commits."}],"source_content_type":"text/x-rst","patch_set":1,"id":"0add4afe_1be88c5f","line":33,"range":{"start_line":33,"start_character":2,"end_line":33,"end_character":66},"in_reply_to":"9109d9b7_0af74a9c","updated":"2025-05-22 04:57:29.000000000","message":"I would prefer slightly more infos Here. what disturbed me most is when there are different requirements from different projects a person is contributing. It requires quite specific and flexible git config full of macros. Imho this will be often not as easy as setting global config option, same as using different email for contributing in different projects.","commit_id":"8a510a29ac386ca900ba249f19024137c69f361d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bbf99bdf5eb88b4a214b4e6cb86ea5247905e860","unresolved":false,"context_lines":[{"line_number":30,"context_line":"  OpenStack projects."},{"line_number":31,"context_line":"- Set the transition effective date to **June 1, 2025**. From that"},{"line_number":32,"context_line":"  date, all commits to OpenStack repositories must include a valid"},{"line_number":33,"context_line":"  `Signed-off-by` line in the commit message as stated in the DCO."},{"line_number":34,"context_line":"- Direct the OpenDev Infrastructure team to enforce DCO compliance on the"},{"line_number":35,"context_line":"  OpenStack `code review system`_, i.e., require a valid DCO sign-off for"},{"line_number":36,"context_line":"  all new commits."}],"source_content_type":"text/x-rst","patch_set":1,"id":"bca73067_da61ffd4","line":33,"range":{"start_line":33,"start_character":2,"end_line":33,"end_character":66},"in_reply_to":"a42d55be_a638cb9d","updated":"2025-05-27 23:06:02.000000000","message":"a contributor doc update is being pursued here: https://review.opendev.org/c/openstack/contributor-guide/+/950839\n\nI agree with the pre-commit suggestion; however, we won\u0027t force it down projects.. Would be glad to see all these ideas make it to the contributor guide, and organically into any project tooling, like pre-commit","commit_id":"8a510a29ac386ca900ba249f19024137c69f361d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ecfd64578ab8ac35c1df7bbe2a3f969cfa39b416","unresolved":true,"context_lines":[{"line_number":30,"context_line":"  OpenStack projects."},{"line_number":31,"context_line":"- Set the transition effective date to **June 1, 2025**. From that"},{"line_number":32,"context_line":"  date, all commits to OpenStack repositories must include a valid"},{"line_number":33,"context_line":"  `Signed-off-by` line in the commit message as stated in the DCO."},{"line_number":34,"context_line":"- Direct the OpenDev Infrastructure team to enforce DCO compliance on the"},{"line_number":35,"context_line":"  OpenStack `code review system`_, i.e., require a valid DCO sign-off for"},{"line_number":36,"context_line":"  all new commits."}],"source_content_type":"text/x-rst","patch_set":1,"id":"f7656181_3214e951","line":33,"range":{"start_line":33,"start_character":2,"end_line":33,"end_character":66},"in_reply_to":"abb4f307_4d0d4a38","updated":"2025-05-22 07:19:40.000000000","message":"not signign a commit does not add signed off by so \ncommit.gpgSign  does nto actuly help here either.","commit_id":"8a510a29ac386ca900ba249f19024137c69f361d"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"eb5295ecac3622b901c55ea6d865f55f1024fe4e","unresolved":true,"context_lines":[{"line_number":30,"context_line":"  OpenStack projects."},{"line_number":31,"context_line":"- Set the transition effective date to **June 1, 2025**. From that"},{"line_number":32,"context_line":"  date, all commits to OpenStack repositories must include a valid"},{"line_number":33,"context_line":"  `Signed-off-by` line in the commit message as stated in the DCO."},{"line_number":34,"context_line":"- Direct the OpenDev Infrastructure team to enforce DCO compliance on the"},{"line_number":35,"context_line":"  OpenStack `code review system`_, i.e., require a valid DCO sign-off for"},{"line_number":36,"context_line":"  all new commits."}],"source_content_type":"text/x-rst","patch_set":1,"id":"a42d55be_a638cb9d","line":33,"range":{"start_line":33,"start_character":2,"end_line":33,"end_character":66},"in_reply_to":"f7656181_3214e951","updated":"2025-05-22 09:01:57.000000000","message":"Again, I\u0027m OK with documenting in the contrib guide, but given we will merge this governance patch closely, it will be the first document we provide to our contributors so I think they should know what they need to do.\n\n@smooney@redhat.com yup, I knew that we just need to `git -s` but when using the Gerrit UI when eg. backporting a change, you can\u0027t do this, right ? 😊","commit_id":"8a510a29ac386ca900ba249f19024137c69f361d"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"19fb76427d8164712516d67d7808c9f8d92f3f23","unresolved":true,"context_lines":[{"line_number":33,"context_line":"  `Signed-off-by` line in the commit message as stated in the DCO."},{"line_number":34,"context_line":"- Direct the OpenDev Infrastructure team to enforce DCO compliance on the"},{"line_number":35,"context_line":"  OpenStack `code review system`_, i.e., require a valid DCO sign-off for"},{"line_number":36,"context_line":"  all new commits."},{"line_number":37,"context_line":"- Ensure that the OpenStack Contributor Documentation features the Developer"},{"line_number":38,"context_line":"  Certificate of Origin and includes clear and practical guidance for"},{"line_number":39,"context_line":"  contributors on how to sign their commits and what the sign-off represents."}],"source_content_type":"text/x-rst","patch_set":1,"id":"aa3d5deb_4639324c","line":36,"updated":"2025-05-21 07:52:03.000000000","message":"That necessarly has to be done before the above step, tbc.","commit_id":"8a510a29ac386ca900ba249f19024137c69f361d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c8fabafda70f2b286ed8c935c64f87f663621697","unresolved":false,"context_lines":[{"line_number":33,"context_line":"  `Signed-off-by` line in the commit message as stated in the DCO."},{"line_number":34,"context_line":"- Direct the OpenDev Infrastructure team to enforce DCO compliance on the"},{"line_number":35,"context_line":"  OpenStack `code review system`_, i.e., require a valid DCO sign-off for"},{"line_number":36,"context_line":"  all new commits."},{"line_number":37,"context_line":"- Ensure that the OpenStack Contributor Documentation features the Developer"},{"line_number":38,"context_line":"  Certificate of Origin and includes clear and practical guidance for"},{"line_number":39,"context_line":"  contributors on how to sign their commits and what the sign-off represents."}],"source_content_type":"text/x-rst","patch_set":1,"id":"913d8f59_7f794c08","line":36,"in_reply_to":"aa3d5deb_4639324c","updated":"2025-05-21 18:35:44.000000000","message":"unless specified, there\u0027s no order here. All of this has to be done.","commit_id":"8a510a29ac386ca900ba249f19024137c69f361d"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"19fb76427d8164712516d67d7808c9f8d92f3f23","unresolved":true,"context_lines":[{"line_number":37,"context_line":"- Ensure that the OpenStack Contributor Documentation features the Developer"},{"line_number":38,"context_line":"  Certificate of Origin and includes clear and practical guidance for"},{"line_number":39,"context_line":"  contributors on how to sign their commits and what the sign-off represents."},{"line_number":40,"context_line":"- Encourage OpenStack project maintainers to update their own contributor"},{"line_number":41,"context_line":"  documentation to point to the OpenStack Contributor Documentation regarding"},{"line_number":42,"context_line":"  the DCO. We don\u0027t need to reproduce the DCO within project documentation"},{"line_number":43,"context_line":"  or the source code."},{"line_number":44,"context_line":"- Clarify that existing contributors **will not** be required to retroactively"},{"line_number":45,"context_line":"  sign or re-submit anything. However, all new commits made on or after"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5becb966_b3880e92","line":42,"range":{"start_line":40,"start_character":2,"end_line":42,"end_character":10},"updated":"2025-05-21 07:52:03.000000000","message":"I tend to disagree : we should rather ask our project maintainers to check whether they mention current CLA in their repositories and remove that reference then by the time we stop requiring ICLAs (and take the opportunity to refer in their repo to the contributor guide)","commit_id":"8a510a29ac386ca900ba249f19024137c69f361d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7657589b86d8d5d594aefbddc6ad8c641ac6c272","unresolved":true,"context_lines":[{"line_number":37,"context_line":"- Ensure that the OpenStack Contributor Documentation features the Developer"},{"line_number":38,"context_line":"  Certificate of Origin and includes clear and practical guidance for"},{"line_number":39,"context_line":"  contributors on how to sign their commits and what the sign-off represents."},{"line_number":40,"context_line":"- Encourage OpenStack project maintainers to update their own contributor"},{"line_number":41,"context_line":"  documentation to point to the OpenStack Contributor Documentation regarding"},{"line_number":42,"context_line":"  the DCO. We don\u0027t need to reproduce the DCO within project documentation"},{"line_number":43,"context_line":"  or the source code."},{"line_number":44,"context_line":"- Clarify that existing contributors **will not** be required to retroactively"},{"line_number":45,"context_line":"  sign or re-submit anything. However, all new commits made on or after"}],"source_content_type":"text/x-rst","patch_set":1,"id":"6e18b745_d2e7ef77","line":42,"range":{"start_line":40,"start_character":2,"end_line":42,"end_character":10},"in_reply_to":"5becb966_b3880e92","updated":"2025-05-21 15:55:36.000000000","message":"Yeah, there are some references to the ICLA elsewhere: https://codesearch.opendev.org/?q\u003dAgreement\u0026i\u003dnope\u0026literal\u003dnope\u0026files\u003drst\u0026excludeFiles\u003d\u0026repos\u003d","commit_id":"8a510a29ac386ca900ba249f19024137c69f361d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c8fabafda70f2b286ed8c935c64f87f663621697","unresolved":false,"context_lines":[{"line_number":37,"context_line":"- Ensure that the OpenStack Contributor Documentation features the Developer"},{"line_number":38,"context_line":"  Certificate of Origin and includes clear and practical guidance for"},{"line_number":39,"context_line":"  contributors on how to sign their commits and what the sign-off represents."},{"line_number":40,"context_line":"- Encourage OpenStack project maintainers to update their own contributor"},{"line_number":41,"context_line":"  documentation to point to the OpenStack Contributor Documentation regarding"},{"line_number":42,"context_line":"  the DCO. We don\u0027t need to reproduce the DCO within project documentation"},{"line_number":43,"context_line":"  or the source code."},{"line_number":44,"context_line":"- Clarify that existing contributors **will not** be required to retroactively"},{"line_number":45,"context_line":"  sign or re-submit anything. However, all new commits made on or after"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ed8005b8_3b120078","line":42,"range":{"start_line":40,"start_character":2,"end_line":42,"end_character":10},"in_reply_to":"6e18b745_d2e7ef77","updated":"2025-05-21 18:35:44.000000000","message":"Done","commit_id":"8a510a29ac386ca900ba249f19024137c69f361d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9abdb186c2dbb0ae51140620469702af56f1a132","unresolved":true,"context_lines":[{"line_number":43,"context_line":"  or the source code."},{"line_number":44,"context_line":"- Clarify that existing contributors **will not** be required to retroactively"},{"line_number":45,"context_line":"  sign or re-submit anything. However, all new commits made on or after"},{"line_number":46,"context_line":"  June 1, 2025 must adhere to the DCO requirements."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"This adoption of the DCO will lower the barrier to contribution, reduce"},{"line_number":49,"context_line":"administrative burden, and bring OpenStack in line with best practices across"}],"source_content_type":"text/x-rst","patch_set":1,"id":"f3b007f3_d529ee64","line":46,"updated":"2025-05-21 01:00:15.000000000","message":"so this is ambigous\n\nis it a new commit if i rebase a change for review feedback.\n\nwhat about the 10s if not hundered fo commits in the openapi schema seriese \nor the event lete remvoal ones..\n\nthso are alreayd long and complex.\n\nhavign to amend them or add it when rebaseing while do able woudl be annorying.","commit_id":"8a510a29ac386ca900ba249f19024137c69f361d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"7034cad65d6b74733af0163b2e7d4749c27b4574","unresolved":true,"context_lines":[{"line_number":43,"context_line":"  or the source code."},{"line_number":44,"context_line":"- Clarify that existing contributors **will not** be required to retroactively"},{"line_number":45,"context_line":"  sign or re-submit anything. However, all new commits made on or after"},{"line_number":46,"context_line":"  June 1, 2025 must adhere to the DCO requirements."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"This adoption of the DCO will lower the barrier to contribution, reduce"},{"line_number":49,"context_line":"administrative burden, and bring OpenStack in line with best practices across"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fed094fd_77fd04ff","line":46,"in_reply_to":"425390a3_3d0d5706","updated":"2025-05-21 09:13:38.000000000","message":"its not really that there is a diffent between new vs old.\n\nits more we have a lot of open patches in gerrit and we shoudl not ahve to rebase/update the commit message in all of them after june 1st\n\nwe will also need ot update how gerrit does cherrypicks via the ui to add the Signed-off-by or lose the ablity to do cherry picks form the ui on older patches.\n\nyou can edit the commit message when using the ui to cherry pick but geting the caseign correct is going to be error-prone.\n\n\nso really we need to make sure Gerrit has the option to add signed off by when doing actions liek that in the web ui or it will break some existing workflows or cause pain for those doing backport.\n\nif im backporting more then 2 patches, i will alwasy do that form teh cli because its simpler to do but its a non trivial workflow change for existing open reviews.\n\nnew reviews are trival because you can update your git config to add Signed-off-by\nby default.","commit_id":"8a510a29ac386ca900ba249f19024137c69f361d"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"19fb76427d8164712516d67d7808c9f8d92f3f23","unresolved":true,"context_lines":[{"line_number":43,"context_line":"  or the source code."},{"line_number":44,"context_line":"- Clarify that existing contributors **will not** be required to retroactively"},{"line_number":45,"context_line":"  sign or re-submit anything. However, all new commits made on or after"},{"line_number":46,"context_line":"  June 1, 2025 must adhere to the DCO requirements."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"This adoption of the DCO will lower the barrier to contribution, reduce"},{"line_number":49,"context_line":"administrative burden, and bring OpenStack in line with best practices across"}],"source_content_type":"text/x-rst","patch_set":1,"id":"425390a3_3d0d5706","line":46,"in_reply_to":"f3b007f3_d529ee64","updated":"2025-05-21 07:52:03.000000000","message":"I know we discussed that to death yesterday (to quote Jay) but I don\u0027t see a difference here between net new contributors and old existing contributors if we just require any of them to sign-off the DCO before June 1, whether they want to push a gerrit revision or patch.","commit_id":"8a510a29ac386ca900ba249f19024137c69f361d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c8fabafda70f2b286ed8c935c64f87f663621697","unresolved":false,"context_lines":[{"line_number":43,"context_line":"  or the source code."},{"line_number":44,"context_line":"- Clarify that existing contributors **will not** be required to retroactively"},{"line_number":45,"context_line":"  sign or re-submit anything. However, all new commits made on or after"},{"line_number":46,"context_line":"  June 1, 2025 must adhere to the DCO requirements."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"This adoption of the DCO will lower the barrier to contribution, reduce"},{"line_number":49,"context_line":"administrative burden, and bring OpenStack in line with best practices across"}],"source_content_type":"text/x-rst","patch_set":1,"id":"07623102_3d7d27f7","line":46,"in_reply_to":"fed094fd_77fd04ff","updated":"2025-05-21 18:35:44.000000000","message":"I don\u0027t know how the UI will enforce these updates for rebases; but, hopefully it provides the necessary enforcement for web-ui edits and cherry-picks.. \n\n@cboylan@sapwetik.org and @fungi@yuggoth.org were brainstorming a way to test this. In any case, i don\u0027t expect to add a ton of implementation/enforcement detail in this resolution unless there are legal grey areas to clarify.. I would offload all of this into a working document and ofcourse the Contributor guide as referenced","commit_id":"8a510a29ac386ca900ba249f19024137c69f361d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4a9c69df586af9c4a26eb578f71e179636c579ff","unresolved":true,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"The OpenStack Technical Committee therefore resolves to:"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"- Replace the Contributor License Agreement (CLA) with the Developer"},{"line_number":29,"context_line":"  Certificate of Origin (DCO) as the core legal framework for contributions to"},{"line_number":30,"context_line":"  OpenStack projects."},{"line_number":31,"context_line":"- Set the transition effective date to **July 1, 2025**. From that"},{"line_number":32,"context_line":"  date, all commits to OpenStack repositories must include a valid"},{"line_number":33,"context_line":"  `Signed-off-by` line in the commit message as stated in the DCO."}],"source_content_type":"text/x-rst","patch_set":2,"id":"4badd9bf_fa572724","line":30,"range":{"start_line":28,"start_character":0,"end_line":30,"end_character":21},"updated":"2025-05-23 18:47:07.000000000","message":"before ratifying this resolution i think this propsoal overlooks the fact that we have other soucs of contribution that dont initally start in git/gerrit\n\nhttps://lists.openstack.org/archives/list/openstack-discuss@lists.openstack.org/message/H3KXJTHWUY3SNTEOSDDACIZKSCOZ3UXD/\n\nnamely translation submitted via the Zanata server and\nsecurtiy bug patchs submited in launchpad.\n\nthe latter will generaly be submited on teh orgianl author behalf by a core develop who weill have reced the patch under an opensouce license adn proably modifed them to actully work\n\nso that is coverd by clause b.\n\n```\n(b) The contribution is based upon previous work that, to the best\n    of my knowledge, is covered under an appropriate open source\n    license and I have the right under that license to submit that\n    work with modifications, whether created in whole or in part\n    by me, under the same open source license (unless I am\n    permitted to submit under a different license), as indicated\n    in the file; or\n```\n\nbut what about the translations.\n\ncan Zanata also enfoce the DCO in some way or enfoce that the translation are \n\"under an appropriate open source license\" in place of the the cla in teh same way?","commit_id":"40fb2ae81cfd946aaad2932c637a13d22389ea4c"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"5fb2dee883355b5ab4e089554ec36ef15ca8c887","unresolved":true,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"The OpenStack Technical Committee therefore resolves to:"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"- Replace the Contributor License Agreement (CLA) with the Developer"},{"line_number":29,"context_line":"  Certificate of Origin (DCO) as the core legal framework for contributions to"},{"line_number":30,"context_line":"  OpenStack projects."},{"line_number":31,"context_line":"- Set the transition effective date to **July 1, 2025**. From that"},{"line_number":32,"context_line":"  date, all commits to OpenStack repositories must include a valid"},{"line_number":33,"context_line":"  `Signed-off-by` line in the commit message as stated in the DCO."}],"source_content_type":"text/x-rst","patch_set":2,"id":"a8282606_c63ce5f6","line":30,"range":{"start_line":28,"start_character":0,"end_line":30,"end_character":21},"in_reply_to":"02f1df0c_f304938c","updated":"2025-05-29 17:39:31.000000000","message":"\u003e Regarding security patches on launchpad... I think this is covered by c) of DCO, which is about posting code for another person without changing it. But again, we need an agreement from the person placing the patch for that.\n\nYou can have the contribution process use something like `git show HEAD` or `git format-patch` so that a commit message with signed-of-by is present and can be carried forward.","commit_id":"40fb2ae81cfd946aaad2932c637a13d22389ea4c"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"bb0705cf681e703ad864633f35fd9bcbd02ec9b5","unresolved":true,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"The OpenStack Technical Committee therefore resolves to:"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"- Replace the Contributor License Agreement (CLA) with the Developer"},{"line_number":29,"context_line":"  Certificate of Origin (DCO) as the core legal framework for contributions to"},{"line_number":30,"context_line":"  OpenStack projects."},{"line_number":31,"context_line":"- Set the transition effective date to **July 1, 2025**. From that"},{"line_number":32,"context_line":"  date, all commits to OpenStack repositories must include a valid"},{"line_number":33,"context_line":"  `Signed-off-by` line in the commit message as stated in the DCO."}],"source_content_type":"text/x-rst","patch_set":2,"id":"02f1df0c_f304938c","line":30,"range":{"start_line":28,"start_character":0,"end_line":30,"end_character":21},"in_reply_to":"4885ca7e_7a3b738a","updated":"2025-05-29 17:36:57.000000000","message":"\u003e Well, Weblate does have an option for contributor agreement: https://docs.weblate.org/en/latest/admin/projects.html#component-agreement\n\u003e\n\u003e But I\u0027m really no idea if DCO is a suitable one there.\n\nA different version of the docs contains: https://docs.weblate.org/es/weblate-3.6.1/admin/licensing.html#signed-off-by which indicates that DCO is a valid contributor aggreement type/option. I suspect that this would work fine if someone with weblate admin perms is able to check that it is still an option with the current version of weblate.\n\nIt also looks like weblate may have gerrit integration using git-review with templated commit message formats that can be configured to support signed off by if we want to go that route (I think the current plan is to make it more like zanata though which may require us to update this integration ourselves in the zuul jobs).","commit_id":"40fb2ae81cfd946aaad2932c637a13d22389ea4c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bbf99bdf5eb88b4a214b4e6cb86ea5247905e860","unresolved":true,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"The OpenStack Technical Committee therefore resolves to:"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"- Replace the Contributor License Agreement (CLA) with the Developer"},{"line_number":29,"context_line":"  Certificate of Origin (DCO) as the core legal framework for contributions to"},{"line_number":30,"context_line":"  OpenStack projects."},{"line_number":31,"context_line":"- Set the transition effective date to **July 1, 2025**. From that"},{"line_number":32,"context_line":"  date, all commits to OpenStack repositories must include a valid"},{"line_number":33,"context_line":"  `Signed-off-by` line in the commit message as stated in the DCO."}],"source_content_type":"text/x-rst","patch_set":2,"id":"93b3b70a_31b8f591","line":30,"range":{"start_line":28,"start_character":0,"end_line":30,"end_character":21},"in_reply_to":"4badd9bf_fa572724","updated":"2025-05-27 23:06:02.000000000","message":"that\u0027s a good question; we currently need the ICLA.. unsure how that is enforced.. \n\nhttps://docs.openstack.org/i18n/latest/official_translator.html#steps-to-become-a-openstack-translator\n\n\n@ianyrchoi@gmail.com do you know?","commit_id":"40fb2ae81cfd946aaad2932c637a13d22389ea4c"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"423583a29f65d15457a38dfd3cec0977e57fb31d","unresolved":true,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"The OpenStack Technical Committee therefore resolves to:"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"- Replace the Contributor License Agreement (CLA) with the Developer"},{"line_number":29,"context_line":"  Certificate of Origin (DCO) as the core legal framework for contributions to"},{"line_number":30,"context_line":"  OpenStack projects."},{"line_number":31,"context_line":"- Set the transition effective date to **July 1, 2025**. From that"},{"line_number":32,"context_line":"  date, all commits to OpenStack repositories must include a valid"},{"line_number":33,"context_line":"  `Signed-off-by` line in the commit message as stated in the DCO."}],"source_content_type":"text/x-rst","patch_set":2,"id":"4885ca7e_7a3b738a","line":30,"range":{"start_line":28,"start_character":0,"end_line":30,"end_character":21},"in_reply_to":"58280254_a285c4dc","updated":"2025-05-29 14:05:21.000000000","message":"It would be good to get input from the I18n team on this point as to how it\u0027s been handled so far. Is there any CLA enforcement configured in Zanata today? If not, then this is already a separate issue worth bringing up with foundation legal. Looking at how other DCO-using projects apply it to the work of translators would also be a good idea, but I don\u0027t think any of these should hold up the current resolution unless translations are currently covered by CLA functionality in the platform being used.","commit_id":"40fb2ae81cfd946aaad2932c637a13d22389ea4c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d890ac5a9f678ad5f9d47953322715b44352d27f","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"The OpenStack Technical Committee therefore resolves to:"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"- Replace the Contributor License Agreement (CLA) with the Developer"},{"line_number":29,"context_line":"  Certificate of Origin (DCO) as the core legal framework for contributions to"},{"line_number":30,"context_line":"  OpenStack projects."},{"line_number":31,"context_line":"- Set the transition effective date to **July 1, 2025**. From that"},{"line_number":32,"context_line":"  date, all commits to OpenStack repositories must include a valid"},{"line_number":33,"context_line":"  `Signed-off-by` line in the commit message as stated in the DCO."}],"source_content_type":"text/x-rst","patch_set":2,"id":"bfc48193_a39f0ecc","line":30,"range":{"start_line":28,"start_character":0,"end_line":30,"end_character":21},"in_reply_to":"8245bad5_01891825","updated":"2025-06-04 05:42:58.000000000","message":"Thanks for the great discussion here wrt translators needing a ICLA/DCO. In the TC meeting on 06-03-2025 it was agreed upon that we\u0027ll treat this as a follow up. Our weblate transition is an ongoing project. We\u0027d like to enable DCO within weblate as earlier comments indicated, we\u0027ll gather some more opinions in a separate proposal.","commit_id":"40fb2ae81cfd946aaad2932c637a13d22389ea4c"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"bfe8320d1a3921f0e4688687871d6d9bf97a4e9f","unresolved":true,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"The OpenStack Technical Committee therefore resolves to:"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"- Replace the Contributor License Agreement (CLA) with the Developer"},{"line_number":29,"context_line":"  Certificate of Origin (DCO) as the core legal framework for contributions to"},{"line_number":30,"context_line":"  OpenStack projects."},{"line_number":31,"context_line":"- Set the transition effective date to **July 1, 2025**. From that"},{"line_number":32,"context_line":"  date, all commits to OpenStack repositories must include a valid"},{"line_number":33,"context_line":"  `Signed-off-by` line in the commit message as stated in the DCO."}],"source_content_type":"text/x-rst","patch_set":2,"id":"58280254_a285c4dc","line":30,"range":{"start_line":28,"start_character":0,"end_line":30,"end_character":21},"in_reply_to":"93b3b70a_31b8f591","updated":"2025-05-29 13:40:32.000000000","message":"Well, Weblate does have an option for contributor agreement: https://docs.weblate.org/en/latest/admin/projects.html#component-agreement\n\nBut I\u0027m really no idea if DCO is a suitable one there.\n\nRegarding security patches on launchpad... I think this is covered by c) of DCO, which is about posting code for another person without changing it. But again, we need an agreement from the person placing the patch for that.","commit_id":"40fb2ae81cfd946aaad2932c637a13d22389ea4c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"128fcd57b87d601c8e448b54186e862e1e48cf76","unresolved":true,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"The OpenStack Technical Committee therefore resolves to:"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"- Replace the Contributor License Agreement (CLA) with the Developer"},{"line_number":29,"context_line":"  Certificate of Origin (DCO) as the core legal framework for contributions to"},{"line_number":30,"context_line":"  OpenStack projects."},{"line_number":31,"context_line":"- Set the transition effective date to **July 1, 2025**. From that"},{"line_number":32,"context_line":"  date, all commits to OpenStack repositories must include a valid"},{"line_number":33,"context_line":"  `Signed-off-by` line in the commit message as stated in the DCO."}],"source_content_type":"text/x-rst","patch_set":2,"id":"8245bad5_01891825","line":30,"range":{"start_line":28,"start_character":0,"end_line":30,"end_character":21},"in_reply_to":"a799aec8_fe67ec44","updated":"2025-05-31 13:19:43.000000000","message":"the documentation artifact and all translations are governed by the same license as the python code \"apchae2\" in almost all cases and contribute to those for the most part require that the icla has been sigiend for all contiubutes to the code repsoitory.\n\nin this context, translators are developers as they are author of a change to the content of a repo. technical writers are also developers in the context of th DCO.\n\nit is not referring to a specific job title or role. our existing ICLA uses the term contributor, which is more generic but it does not materially change the fact that to contribute to the repos, you must do so under the terms of the project\u0027s open-source license.\n\n\nif that is problematic for the translator community that volunteers to do the translations, then perhaps we shoudl revisit how translation is done in a separate document and move all the translations out of tree into sibling repos.\nie, from nova to nova-i18n and that can be managed separately.\n\nThat\u0027s out os the scope of this discussion, however.","commit_id":"40fb2ae81cfd946aaad2932c637a13d22389ea4c"},{"author":{"_account_id":14482,"name":"Ian Y. Choi","email":"ianyrchoi@gmail.com","username":"ianychoi"},"change_message_id":"dcac8b9716a82a8fb23426443af6b3dcedc5caae","unresolved":true,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"The OpenStack Technical Committee therefore resolves to:"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"- Replace the Contributor License Agreement (CLA) with the Developer"},{"line_number":29,"context_line":"  Certificate of Origin (DCO) as the core legal framework for contributions to"},{"line_number":30,"context_line":"  OpenStack projects."},{"line_number":31,"context_line":"- Set the transition effective date to **July 1, 2025**. From that"},{"line_number":32,"context_line":"  date, all commits to OpenStack repositories must include a valid"},{"line_number":33,"context_line":"  `Signed-off-by` line in the commit message as stated in the DCO."}],"source_content_type":"text/x-rst","patch_set":2,"id":"a799aec8_fe67ec44","line":30,"range":{"start_line":28,"start_character":0,"end_line":30,"end_character":21},"in_reply_to":"a8282606_c63ce5f6","updated":"2025-05-30 19:00:18.000000000","message":"From me as I18n hat, my understanding is that the current process for translation contributions was defined back in 2015, when the translation working group became an official team as I18n and we migrated from Transifex to Zanata. This predates when I started as PTL in the fall of 2016. As far as I know, Zanata itself did not enforce ICLA for translators, and I double-checked Foundation membership regarding extra AC proposals. It would certainly be beneficial if Weblate could support contributor agreements or DCO enforcement directly. In my personal opinion, I am not still currently sure on DCO with translators since DCO itself is \"Developer\" Certificate of Origin. We generally say \u0027docs as code\u0027, which would imply that documentation artifacts can be dealt like how source codes are dealt. On the other hand, I have never heard a term like \u0027translation as code\u0027. Q: Can the commits from \"OpenStack Proposal Bot\" be signed off? Note that I am trying to better understand how DCO would impact on I18n.","commit_id":"40fb2ae81cfd946aaad2932c637a13d22389ea4c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b83a851d4204b1c71ea186ecbca8eaf8a3eb49dd","unresolved":true,"context_lines":[{"line_number":48,"context_line":"  the code review system need not be modified just to include the"},{"line_number":49,"context_line":"  `Signed-off-by` line in the commit message. However, when changes need to be"},{"line_number":50,"context_line":"  modified for other reasons, the commit message must be amended to include the"},{"line_number":51,"context_line":"  `Signed-off-by` line."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"This adoption of the DCO will lower the barrier to contribution, reduce"},{"line_number":54,"context_line":"administrative burden, and bring OpenStack in line with best practices across"}],"source_content_type":"text/x-rst","patch_set":2,"id":"25a5d31e_74cac6f3","line":51,"updated":"2025-05-22 06:16:37.000000000","message":"so i was talking to @mikal@stillhq.com about this on irc just now and they had a good idea.\n\nwe have been usign pre-commit in many repos now for quite a while\n\npre-commit supprot commit-msg hooks ot validate the content of the msssage.\nhttps://pre-commit.com/index.html#commit-msg\n\nwe already use hackign via pre-commit in many repos to run our hackign and  or pep8 checks \n\nhttps://github.com/openstack/hacking/blob/master/.pre-commit-hooks.yaml\n\none thing we can do to make this similar for folks is to provide a hook in the hackign repo to auto ammend the commit message with the Signed-off-by line if it is not present. \n\nproject can opt into that hook in there pre-commit config\nand contibutors can opt in by choosing to use the pre-commit tool.\n\nnote in moth project that use pre-commit we also supprot runign things via tox.\nso in generally whle pre-commit is recomemnd its not required to be used\n\nthis will make this just work for most folks that want that.\n\nfor every one else the can just do `git commit -s`\n\nthe ohter option i see ot make this seamless woudl eb to update the commit-hook we whave to generate the change-id to also add teh Sgined-off-by\n\nthe info for it is in the users git config its there git user and email\nso  this can be fully automated.\n\nthe disadvantage or the gerrit server appcoh is obvilsy anyoen with an existin repo would need ot update the hook they already have locally with the new one.\nhttps://review.opendev.org/Documentation/cmd-hook-commit-msg.html#_obtaining\n\n\nwe can simple enforce the requiremetn by enabling https://review.opendev.org/Documentation/config-project-config.html#receive.requireSignedOffBy\n\n\nthe other thing that mikal asked about was recording who reviewd the commit  in teh git history\n\nhttps://review.opendev.org/Documentation/user-signedoffby.html#Reviewed-by\n\nso downtream i configured our downstream nova repo to have the rebase_always merge stategy\n\nhttps://review.opendev.org/Documentation/config-project-config.html#rebase_always\n\nthe side effect fo that are 1 no merge commtis so your git history is linear\nthat is awsome\n\nbut the relevent one is it add the following too the commit message automaticlly\n```\n\n Change-Id: \u003cchange-id\u003e (only if this footer is not already present, see Change-Id)\n* Reviewed-on: \u003cchange-url\u003e (links to the change in Gerrit where this commit was reviewed)\n* Reviewed-by: \u003creviewer\u003e (once for every reviewer with a positive Code-Review vote)\n* Tested-by: \u003creviewer\u003e (once for every reviewer with a positive Verified vote)\n* \u003clabel-name\u003e: \u003creviewer\u003e (once for every reviewer with a positive vote on any other label)\n```\n\nthe only downside to adopting it is because that requrie the commit message to be updated when its merged it will also cause the git sha to change.\n\nthat will im pact oru cherry pick workflow and maybe how the gate pipelien works as pending changews would have to be restarted after each commti merges.\n\nproject can alrady opt into this on a pre repo basis by setting there submit type vai a chagne to the project config repo\n\nby default we use the `merge if necessary` stragey today and i don tthink anyone overrieds that.\n\n\nwetaher or not we want to take thsi opertuntity to swap to the rebase_alwasy stargey is kind fo out of scope but if we are going to make this change to DCO it would likely be a good time to adopt that too if we are going to do it.\n\nim not sure if i will have time to wrtie a commit message hook and propose it to the hackign repo but i just wanted to raise that as a path to making this just work since there is no native way to configre git to automaticly add it and a lot of peopel expiclty have leanrd not to add -s when commiting because we have not used this for so long.","commit_id":"40fb2ae81cfd946aaad2932c637a13d22389ea4c"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"eb5295ecac3622b901c55ea6d865f55f1024fe4e","unresolved":true,"context_lines":[{"line_number":48,"context_line":"  the code review system need not be modified just to include the"},{"line_number":49,"context_line":"  `Signed-off-by` line in the commit message. However, when changes need to be"},{"line_number":50,"context_line":"  modified for other reasons, the commit message must be amended to include the"},{"line_number":51,"context_line":"  `Signed-off-by` line."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"This adoption of the DCO will lower the barrier to contribution, reduce"},{"line_number":54,"context_line":"administrative burden, and bring OpenStack in line with best practices across"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7deef351_23525225","line":51,"in_reply_to":"25a5d31e_74cac6f3","updated":"2025-05-22 09:01:57.000000000","message":"pre-commit is and should be optional for our contributors.\nI also don\u0027t want to ask all our projects to modify their repositories for DCO so maybe Nova or other projects could modify their pre-commit usage but again, it would be optional.","commit_id":"40fb2ae81cfd946aaad2932c637a13d22389ea4c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8a0ffb42f96df383b1d75f3932c47cb4d7bf6f46","unresolved":true,"context_lines":[{"line_number":48,"context_line":"  the code review system need not be modified just to include the"},{"line_number":49,"context_line":"  `Signed-off-by` line in the commit message. However, when changes need to be"},{"line_number":50,"context_line":"  modified for other reasons, the commit message must be amended to include the"},{"line_number":51,"context_line":"  `Signed-off-by` line."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"This adoption of the DCO will lower the barrier to contribution, reduce"},{"line_number":54,"context_line":"administrative burden, and bring OpenStack in line with best practices across"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9f94b77a_4c6f74b9","line":51,"in_reply_to":"2b196814_15e7bb93","updated":"2025-05-27 17:50:46.000000000","message":"becasue that config option does not alter the beviro fo git commit.\n\nits for git formatpatch\n\n```\nformat.signOff\n\n    A boolean value which lets you enable the -s/--signoff option of format-patch by default. Note: Adding the Signed-off-by trailer to a patch should be a conscious act and means that you certify you have the rights to submit this work under the same open source license. Please see the SubmittingPatches document for further discussion.\n```\n\n\n```\n18:46:20]\u003e git config --edit\n~/temp on master [?] took 20s \n[18:46:58]\u003e touch test\n~/temp on master [?] \n[18:47:02]\u003e git add test\n~/temp on master [+?] \n[18:47:09]\u003e git commit\n[master 44718f5] test with\n 1 file changed, 0 insertions(+), 0 deletions(-)\n create mode 100644 test\n~/temp on master [?] took 7s \n[18:47:21]\u003e git show\ncommit 44718f5bf1ff2b8f0fc7f1d3ebcc8753fda89d0d (HEAD -\u003e master)\nAuthor: Sean Mooney \u003cwork@seanmooney.info\u003e\nDate:   Tue May 27 18:47:13 2025 +0100\n\n    test with\n    \n    [format]\n    signOff \u003d true\n\ndiff --git a/test b/test\nnew file mode 100644\nindex 0000000..e69de29\n~/temp on master [?] \n[18:48:06]\u003e git format-patch --stdout HEAD^1\nFrom 44718f5bf1ff2b8f0fc7f1d3ebcc8753fda89d0d Mon Sep 17 00:00:00 2001\nFrom: Sean Mooney \u003cwork@seanmooney.info\u003e\nDate: Tue, 27 May 2025 18:47:13 +0100\nSubject: [PATCH] test with\n\n[format]\nsignOff \u003d true\n\nSigned-off-by: Sean Mooney \u003cwork@seanmooney.info\u003e\n---\n test | 0\n 1 file changed, 0 insertions(+), 0 deletions(-)\n create mode 100644 test\n\ndiff --git a/test b/test\nnew file mode 100644\nindex 0000000..e69de29\n-- \n2.49.0\n\n~/temp on master [?] \n```\n\nit will only add signed off by if you format a commit to send as an email.\n\nit does not work for our gerrit workflow at all.\n\nthat is why you would need a CommitMSG hook to update the commit message when you commit to make it work","commit_id":"40fb2ae81cfd946aaad2932c637a13d22389ea4c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ad70ff2b4842a764d34e3463328573e37318551b","unresolved":true,"context_lines":[{"line_number":48,"context_line":"  the code review system need not be modified just to include the"},{"line_number":49,"context_line":"  `Signed-off-by` line in the commit message. However, when changes need to be"},{"line_number":50,"context_line":"  modified for other reasons, the commit message must be amended to include the"},{"line_number":51,"context_line":"  `Signed-off-by` line."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"This adoption of the DCO will lower the barrier to contribution, reduce"},{"line_number":54,"context_line":"administrative burden, and bring OpenStack in line with best practices across"}],"source_content_type":"text/x-rst","patch_set":2,"id":"f7d01b2c_5bcac172","line":51,"in_reply_to":"7deef351_23525225","updated":"2025-05-23 07:38:02.000000000","message":"yep i said that above.\nwe can provide the hook and people can use it or not.\n\nwith that said since the whole point fo this resolution is apparently easing the abltiy of new contibtors to get invovled choosing to opt out of pre-commit or similar tooling that can make it \"just work\" would be counter productive.","commit_id":"40fb2ae81cfd946aaad2932c637a13d22389ea4c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"91028d2d022e1f54b541d9fcfc332bbd4e9e4db7","unresolved":true,"context_lines":[{"line_number":48,"context_line":"  the code review system need not be modified just to include the"},{"line_number":49,"context_line":"  `Signed-off-by` line in the commit message. However, when changes need to be"},{"line_number":50,"context_line":"  modified for other reasons, the commit message must be amended to include the"},{"line_number":51,"context_line":"  `Signed-off-by` line."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"This adoption of the DCO will lower the barrier to contribution, reduce"},{"line_number":54,"context_line":"administrative burden, and bring OpenStack in line with best practices across"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ca268114_762145cd","line":51,"in_reply_to":"9f94b77a_4c6f74b9","updated":"2025-05-27 18:58:51.000000000","message":"to be clear requiring people to use an ide to do commits is a massive impediment to\nfolks that have worked on openstack for a long time.\n\ni have VS Code but i never would commit form it\nvia its gui. i even have the gerrit pluging configured with api access so if i want to review in it i can but i still gernelly choose not too.\n\nSuggesting we develop a pre-commit hook is just to prevent the muscel memory of those who never use -s because we don\u0027t do it as a community.\n\nHaving Gerrit reject it when i create a review is ok, but any later than that and it will be a significant regression in workflow.","commit_id":"40fb2ae81cfd946aaad2932c637a13d22389ea4c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bbf99bdf5eb88b4a214b4e6cb86ea5247905e860","unresolved":false,"context_lines":[{"line_number":48,"context_line":"  the code review system need not be modified just to include the"},{"line_number":49,"context_line":"  `Signed-off-by` line in the commit message. However, when changes need to be"},{"line_number":50,"context_line":"  modified for other reasons, the commit message must be amended to include the"},{"line_number":51,"context_line":"  `Signed-off-by` line."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"This adoption of the DCO will lower the barrier to contribution, reduce"},{"line_number":54,"context_line":"administrative burden, and bring OpenStack in line with best practices across"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5ea3febf_dbedbfc6","line":51,"in_reply_to":"ca268114_762145cd","updated":"2025-05-27 23:06:02.000000000","message":"We can expand this in the contributor guide.","commit_id":"40fb2ae81cfd946aaad2932c637a13d22389ea4c"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"6a2656064b1d487f0a613beb48dd94463399ffac","unresolved":true,"context_lines":[{"line_number":48,"context_line":"  the code review system need not be modified just to include the"},{"line_number":49,"context_line":"  `Signed-off-by` line in the commit message. However, when changes need to be"},{"line_number":50,"context_line":"  modified for other reasons, the commit message must be amended to include the"},{"line_number":51,"context_line":"  `Signed-off-by` line."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"This adoption of the DCO will lower the barrier to contribution, reduce"},{"line_number":54,"context_line":"administrative burden, and bring OpenStack in line with best practices across"}],"source_content_type":"text/x-rst","patch_set":2,"id":"2b196814_15e7bb93","line":51,"in_reply_to":"f7d01b2c_5bcac172","updated":"2025-05-27 17:16:46.000000000","message":"\u003e one thing we can do to make this similar for folks is to provide a hook in the hackign repo to auto ammend the commit message with the Signed-off-by line if it is not present.\n\nI\u0027m not sure why to use pre-commit, when this is literally is a configuration option in Git:\nhttps://git-scm.com/docs/git-config#Documentation/git-config.txt-formatsignOff\n\nSo you pretty much can add to ~/.gitconfig (or .git/config):\n```\n[format]\nsignOff \u003d true\n```\nOr offload to IDE, ie vscode has `git.alwaysSignOff` in settings.\n\nSo I\u0027m not sure that pre-commit hook is a good idea, given that this is already solved in many different ways.","commit_id":"40fb2ae81cfd946aaad2932c637a13d22389ea4c"}]}