)]}'
{"check-sanity":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"e90019af43dfca0360372ce9b18479daaabc9f6e","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    if [ \"$name\" \u003d\u003d \"q-fwaas\" ]; then"},{"line_number":49,"context_line":"        echo \"$name is a Neutron service plugin and doesn\u0027t run in its own process, skipping check\""},{"line_number":50,"context_line":"        return 1"},{"line_number":51,"context_line":"    fi"},{"line_number":52,"context_line":"    if [ \"$name\" \u003d\u003d \"q-l3\" ] \u0026\u0026 [[ \"$ENABLED_SERVICES\" \u003d~ \"q-vpn\" ]]; then"},{"line_number":53,"context_line":"        echo \"$name is running as a part of q-vpn service, skipping check\""},{"line_number":54,"context_line":"        return 1"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"baada198_4bace5a0","line":51,"updated":"2014-07-10 16:22:54.000000000","message":"Looking at it, there could be \u0027elif\u0027","commit_id":"49883a0270ede3dfdfe15bde2930c9df9bdc8c7f"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"afe1a795ae1597e1cf78889b3ee9cb9fc6097e4c","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    if [ \"$name\" \u003d\u003d \"q-fwaas\" ]; then"},{"line_number":49,"context_line":"        echo \"$name is a Neutron service plugin and doesn\u0027t run in its own process, skipping check\""},{"line_number":50,"context_line":"        return 1"},{"line_number":51,"context_line":"    fi"},{"line_number":52,"context_line":"    if [ \"$name\" \u003d\u003d \"q-l3\" ] \u0026\u0026 [[ \"$ENABLED_SERVICES\" \u003d~ \"q-vpn\" ]]; then"},{"line_number":53,"context_line":"        echo \"$name is running as a part of q-vpn service, skipping check\""},{"line_number":54,"context_line":"        return 1"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"baada198_91d1cafd","line":51,"in_reply_to":"baada198_4bace5a0","updated":"2014-07-10 17:08:44.000000000","message":"yeah but q-fwaas just like q-l3 needs q-vpn in $ENABLED_SERVICES, as it currently the firewalll runs within the router.\n\nIf that\u0027s correct maybe you could either use a single if with name \u003d\u003d q-fwaas or name \u003d\u003d q-l3 or maybe use regex pattern matching.","commit_id":"49883a0270ede3dfdfe15bde2930c9df9bdc8c7f"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"561f3a7865957455c3d0f721c32554449368aed3","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    if [ \"$name\" \u003d\u003d \"q-fwaas\" ]; then"},{"line_number":49,"context_line":"        echo \"$name is a Neutron service plugin and doesn\u0027t run in its own process, skipping check\""},{"line_number":50,"context_line":"        return 1"},{"line_number":51,"context_line":"    fi"},{"line_number":52,"context_line":"    if [ \"$name\" \u003d\u003d \"q-l3\" ] \u0026\u0026 [[ \"$ENABLED_SERVICES\" \u003d~ \"q-vpn\" ]]; then"},{"line_number":53,"context_line":"        echo \"$name is running as a part of q-vpn service, skipping check\""},{"line_number":54,"context_line":"        return 1"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"baada198_23def53f","line":51,"in_reply_to":"baada198_6372ad7d","updated":"2014-07-10 17:26:43.000000000","message":"Oh, you were replying to my self-review :)\n\nWell, I think the $name var could be either q-l3 or q-fwaas so there is no point to have two conditions on different values.","commit_id":"49883a0270ede3dfdfe15bde2930c9df9bdc8c7f"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"cac829a79be485bf17b2701a921b1be70d30ea26","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    if [ \"$name\" \u003d\u003d \"q-fwaas\" ]; then"},{"line_number":49,"context_line":"        echo \"$name is a Neutron service plugin and doesn\u0027t run in its own process, skipping check\""},{"line_number":50,"context_line":"        return 1"},{"line_number":51,"context_line":"    fi"},{"line_number":52,"context_line":"    if [ \"$name\" \u003d\u003d \"q-l3\" ] \u0026\u0026 [[ \"$ENABLED_SERVICES\" \u003d~ \"q-vpn\" ]]; then"},{"line_number":53,"context_line":"        echo \"$name is running as a part of q-vpn service, skipping check\""},{"line_number":54,"context_line":"        return 1"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"baada198_6372ad7d","line":51,"in_reply_to":"baada198_91d1cafd","updated":"2014-07-10 17:24:16.000000000","message":"It\u0027s not about checking that if q-fwaas is present then also q-l3 should be enabled. Check above excludes q-fwaas because it doesn\u0027t have its own dedicated agent. The check below is because when q-vpn is defined, there shouldn\u0027t be explicit check that q-l3 has its process (screen) because q-vpn runs l3-agent process.\n\nDoes it answer your concerns or I\u0027m completely missed your point?","commit_id":"49883a0270ede3dfdfe15bde2930c9df9bdc8c7f"}]}